Require it explicitly. Makes it easier to understand and matches the style of other values
Questionable YAML changes (either broken before or now broken):
secureplatform: haStatCode
ptp600: receiveModulationMode
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* bug-fix and new features
Fixed incorrect OID for rate, renamed rate to TX-Rate as per update from mikrotik.
Added support for link distance
* Fixed indent issue
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
WIP - @papatango71 please test.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* New os Eltek WebPower - files + test files
* OS eltek-webpower - minor fix to mib query.
* OS eltek-webpower - sensor and state data improvements.
* OS Eltek Webpower - Created battery symmetry test and battery bank delta voltage support.
* OS Eltek Webpower - symmetry code fix.
* OS Eltek Webpower - symmetry code fix.
* OS Eltek Webpower - symmetry code fix.
* new os eltek - rectifier state fix
* Updated json test data
* Update eltek-webpower.json
* Update eltek-webpower.yaml
* Update eltek-webpower.yaml
* Adjustment in #9301: Eaton Galaxy HW seems to be the exception here with divisor 10 for voltage
* fix for APC Galaxy UPS (and not Eaton anymore)
* remove Galaxy test data from eaton-mgeups files
* tests: APC Galaxy 7000 test data
* update os polling for ray
I changed hardware detection, because in old format i got a hostname instead of hardware. I added features tab also.
* Added wireless rate sensors
I added sensors for Netbitrate and Maxbirate
* deleted old ray.png
* added better resolution logo for ray
* Update Ray.php
* Delete ray.png
* Add files via upload
* Delete ray.svg
* added ray.svg logo
* update ray.snmprec
* Update Ray.php
* Updated json test data
* added state support for RAy Radios
* Update ray.snmprec
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Fixes: #8933
* syntax issues.
I will probably resubmit after another travis run to pick up what's still wrong
* Add files via upload
* Add files via upload
* Update includes/definitions/discovery/cyberpower.yaml
* Add files via upload
* Add files via upload
* Updated json file
* netagent2 - 3Phase UPS support
* Revert "netagent2 - 3Phase UPS support"
This reverts commit 7900bc5bc0.
* OS netagent feature update - 3 phase support
* OS netagent2 update - 3phase support code cleanup
* OS netagent2 update - 3phase support code cleanup 2
* Netagent2 - Add status unknown to smoke and water states.
* NetAgent2 - changed detection method like murrant suggested.
* netagent2 - XPPC-MIB - 3 phase states support
* Added json test data
* remove_apc-ats
* add test data
* delete apc-ats.snmprec
* add apc_ats variant test file
* fix os in json
* Updated json test files
* Updated json test data
* Update to add support for environment sensor
Adding support for RM203 card environment sensor, temp and humidity.
* Update cyberpower.yaml
* Add files via upload
* Added json test data
* MGE: Improve support for Galaxy devices
* MGE: Improve support for Galaxy devices
* MGE: Improve support for Galaxy devices
* rfc1628 adaptations for Eaton MGE Galaxy 7000
* eaton-mge: test data on a Galaxy 7000
* rfc1628 adaptations for Eaton MGE Galaxy 7000
* rfc1628 adaptations for Eaton MGE Galaxy 7000
* eaton-mgeups: test data on a Galaxy 7000
* Add upsmgUtilityFailure and upsmgUtilityRestored trap support for eaton-mgeups
* dev: eaton-mgeups: OID in the dynamic definition for discovery
* dev: eaton-mgeups: cleaning
* add contributor
* add contributor
* Updated DataDomain MIB, Added DataDomain Storage poller and discovery
* Fixed issues pre-commit issues
* Removed extra blank lines
* Make polling less redudant
* Remove blank line
* Remove device os detection since it's not needed. Add test data for DataDomain
* Added json test file
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
NOTE: Those devices come all with same `sysName` so `$config['allow_duplicate_sysName'] = true;` is needed to have more than 1 working.
* added PBI MIB
I finally found a MIB for PBI device
* added PBI-MAIN-MIB
* added another PBI MIB
* added PBI MGSYSTEM-MIB
* added ird.yaml to definition
* added senors discovery for PBI devices
* added ird.inc.php for polling
* added logo for PBI
* added ird.json
* Rename PB-MAIN-MIB to PBI-MAIN-MIB
* Update ird.json
* Update PBI-4000P-5000P-MIB
* Update PBI-MAIN-MIB
* Update PBI-MGSIGNALCHARACTERISTICS-MIB
* Update PBI-MGSYSTEM-MIB
* Create ird.snmprec
* Updated json test file
* deleted frequency from yaml
I think that better will be see values from frequency in wirelles frequency, where it is in MHz
* Create Ird.php
* Update Ird.php
* Update Ird.php
* Update ird.json
* Update Ird.php
https://phpunit.de/manual/6.5/en/textui.html#textui.examples.filter-patterns
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* fixing sentry3 temperature sensor issues: read all sensors not just first two, fix reading limit and current values, fixing snmp get options
* fixing sentry4 temperature sensor issues: read all sensors not just first two, fix reading limit and current values, fixing snmp get options
* fixing code style issues
* addressing review items from murrant, removing individual snmp_gets, fixing fahrenheit to celcius code back
* addressing review items, putting back the celcius fahrenheit conversion logic back
* using snmpwalk_cache_oid instead of reinventing in sentry3 code
* using pre-cache for sentry4 temp sensors, addressing review items
* checking all sentry3 humidity sensors instead of first two, bulk reading instead of individual gets
* addressing style issues
* pre-caching sentry4 humidity warning table removing duplicate temp sensor event config table
* adding two more sentry snmprec files after temperature and humidity sensor updates
* making sensor index values for sentry3/4 unique
* adding sentry3 and 4 test data files after temperature and humidity sensors update
* VRP: improving extraction of HW and Version
* VRP: Improving extraction of HW and Version - CodeClimate update
* VRP: Improving extraction of HW and Version - Review and debug code cleaning
* VRP: Improving extraction of HW and Version - resolve OIDs and swap order of poll
* VRP: Improving extraction of HW and Version - resolve OIDs and swap order of poll
* Device: VRP: Update test data
* Device: VRP: Travis code clean
* Device: VRP: Update test data for variants
* Device: VRP: Update test data for variants
* Allow trusted proxy via APP_TRUSTED_PROXIES
Set to '*' by default to emulate legacy behavior.
Set up doc describing environment variables
* Create helper to parse environment variables into arrays properly.
* Update doc blocks
* Use Laravel for authentication
Support legacy auth methods
Always create DB entry for users (segregate by auth method)
Port api auth to Laravel
restrict poller errors to devices the user has access to
Run checks on every page load. But set a 5 minute (configurable) timer.
Only run some checks if the user is an admin
Move toastr down a few pixels so it isn't as annoying.
Fix menu not loaded on laravel pages when twofactor is enabled for the system, but disabled for the user.
Add two missing menu entries in the laravel menu
Rewrite 2FA code
Simplify some and verify code before applying
Get http-auth working
Handle legacy $_SESSION differently. Allows Auth::once(), etc to work.
* Fix tests and mysqli extension check
* remove duplicate Toastr messages
* Fix new items
* Rename 266.sql to 267.sql
* Feature: Collect VRP Entity details in the Huawei MIB
* Feature: Collect VRP Entity details in the Huawei MIB - Add Test Data
* Renaming of the test file vrp_5720_vrf.snmprec
* Added json test files
* Update vrp_5720_vrf.snmprec
* Update vrp_5720_vrf.snmprec
* Update vrp_5720_vrf.json
* Updated processor and mempool discovery to limit descr field
* Updated test
* Updated tests again
* Updated json test data
* Update vrp_ce12804-entity.json
* Update vrp_ce12804-entity.json
* Update vrp_5720_vrf.json
* Added BGP Peer Descriptions
* Fixed formatting
* Added to device routing tab too
* Some text formatting
* Test files
* Added default null to bgpPeerDescr
* Added db_schema.yaml
* Fix default value for bgpPeerDescr
* Fixed Order and Search box
* Added glyphicon for success/error
* Switch to toastr notification
* Removed unused bootstrap code
* device: Initial support for CXR-Networks Terminal Server
* device: Support for CXR-Networks Terminal Server - CodeClimate + cleaning
* device: renamed cxr-networks-ts and code improvement
* device: cxr-networks-ts test data
* device: renamed os as cxr-ts
* device: renamed os as cxr-ts, test data
* fix fan state
fix fan duty instead of rpm
* changed check to os definition bad_fanspeed
* revert back fan rpm
* Fix other state generics
* Update fanspeed.inc.php
* Update edgeswitch.json
* snmpsim tests data
* Update tests
* target db_schema
* Database schema cleanup
Remove several inconsistencies (mostly with data types and lengths)
Make things a bit nicer to implement with Laravel database migrations.
poller* tables had f'd up indexes
* Update tests, extra noise because db returns numeric types now.
* Update test data again.
* fix 253 migration for mysql 5.3
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
convert the junos call to translate too.
Not 100% sure what was wrong with arris-c4, but removing this data fixed it and tests still pass.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
