Commit Graph

43 Commits

Author SHA1 Message Date
Tony Murray
d8c372bbf4 Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-06 07:34:14 -05:00
Tony Murray
be24993cbb Remove snmp functions that are barely used (#15377)
* Remove snmp functions that are barely used
Replace them with SnmpQuery calls

* Apply fixes from StyleCI

* Fix missing namespace

* Import Oid

* No more variables left may be repeated multiple times at the end with snmpsim, remove them all

* update data fixed by SnmpResponse bugfix

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 01:29:22 -05:00
Jellyfrog
b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
Jellyfrog
2fc3a21211 Apply fixes from StyleCI (#12121) 2020-09-21 15:43:38 +02:00
Jozef Pivarník
2dc05ee501 Fixed Cisco MAC accounting discovery, polling and HTML templates. (#10158)
* Fix Cisco MAC acounting discovery, polling and HTML templates.

* Remove empty code.

* Provide test data for cisco-mac-accounting module.

* Added module test dependency.
2019-05-20 20:56:19 -05:00
Tony Murray
b9dc7773d7 refactor: Don't do unneeded snmp queries (#7841)
* Don't do uneeded snmp queries
sensors discovery 26 -> 16
wrapped some poller modules in db checks.  The same could be done for some others, but more work is needed.

* travis fix
2017-12-02 23:18:45 +00:00
Neil Lathwood
fad5aca1b7 feature: Allow customisation of rrd step/heartbeat when creating new rrd files (#5947)
* feature: Allow customisation of rrd step/heartbeat when creating new rrd files

* revert defaults

* added docs + webui config option

* Move RrdDefinition to an Object to make them easier to create and remove the possibility of typos.

* Fix style/lint issues and missing use statements

* 3 more missing use statements

* updated doc + moved schema file
2017-02-23 22:45:50 +00:00
Neil Lathwood
21898a3c29 Disco / Poller tidy up + Added display of module mem usage (#5778)
* tidyup + added mem usage for poller modules

* tidied up discovery modules

* fix sensors
2017-02-07 22:54:30 -06:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
Tony Murray
57650e4ffc Remove nfs requirement for distributed poller (with rrdtool 1.5+)
Use data_update instead of rrd_update/rrd_create and influx_update
Centralize rrd file check so we can check against a remote rrdcached server too
Use rrd_name() to generate rrd file names
2016-07-07 21:10:06 -05:00
laf
a194009917 Pretty up the polling process output 2016-06-21 01:41:45 +01:00
laf
7b14aada4e Rebased 2015-10-26 11:08:19 +00:00
f0o
7d95e94954 Fix rrd creation parameters 2015-09-28 08:24:57 +00:00
Daniel Preussker
ba7bf5f60b Merge pull request #1715 from laf/rrdoptions
Updated rrdtool_update() to use new array format
2015-09-22 12:15:59 +00:00
Mark Schouten
55a2e0423d Remove all unneeded if($debug)-statements and replace them with d_echo 2015-08-21 16:10:00 +02:00
laf
433562d351 More updates for influx 2015-08-19 20:58:02 +00:00
laf
987634e463 Updated rrdtool_update() to use new array format 2015-08-18 16:26:55 +00:00
Job Snijders
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
Alexander Sosna
5a7988e2e4 chmod 0644 to php files not directly executed 2015-04-28 22:58:03 +02:00
Adam Amstrong
1de9e32d90 fix mac accounting
git-svn-id: http://www.observium.org/svn/observer/trunk@3249 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-29 11:25:25 +00:00
Adam Amstrong
b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong
cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Adam Amstrong
4db1454e92 move from port_id to interface_id. make ports discovery only discover. add some cleaner functions. add a tiny bit of alerting infrastructure.
git-svn-id: http://www.observium.org/svn/observer/trunk@3195 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-16 13:25:50 +00:00
Adam Amstrong
29c70aaefa fix some rrdtool_graph calls to use arrays. add NRG printer support.
git-svn-id: http://www.observium.org/svn/observer/trunk@3187 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-15 16:50:36 +00:00
Adam Amstrong
2b8178bb5b move all RRA decisions to config. switch mempool/storage to new rrds (sorry, data lost, the old rrds sucked). added some more apps pages.
git-svn-id: http://www.observium.org/svn/observer/trunk@3068 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-20 17:37:58 +00:00
Tom Laermans
a10d3f75ea syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@3008 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-09 15:30:45 +00:00
Tom Laermans
502f207291 only poll cisco CEF and cisco mac accounting on cisco devices + some small fixes
git-svn-id: http://www.observium.org/svn/observer/trunk@2999 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-09 10:53:55 +00:00
Adam Amstrong
799f54ba06 fixes
git-svn-id: http://www.observium.org/svn/observer/trunk@2387 61d68cd4-352d-0410-923a-c4978735b2b8
2011-06-01 10:25:22 +00:00
Adam Amstrong
402c170b0b fix db update for mac accounting (and enable spitting out sql query on error)
git-svn-id: http://www.observium.org/svn/observer/trunk@2386 61d68cd4-352d-0410-923a-c4978735b2b8
2011-06-01 10:21:09 +00:00
Adam Amstrong
99937c4d3b fix?
git-svn-id: http://www.observium.org/svn/observer/trunk@2385 61d68cd4-352d-0410-923a-c4978735b2b8
2011-06-01 10:17:22 +00:00
Adam Amstrong
96c71cbf91 fix?
git-svn-id: http://www.observium.org/svn/observer/trunk@2384 61d68cd4-352d-0410-923a-c4978735b2b8
2011-06-01 10:09:52 +00:00
Adam Amstrong
66b34b8999 more db* (and add on-the-fly discovery of ports and removal of OSPF areas)
git-svn-id: http://www.observium.org/svn/observer/trunk@2338 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-16 21:56:01 +00:00
Tom Laermans
f0ed749a26 all trailing spaces must die, this concludes the polling part
git-svn-id: http://www.observium.org/svn/observer/trunk@1881 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-16 17:57:40 +00:00
Tom Laermans
ecbcd1db43 clean up polling source files, remove dead code
git-svn-id: http://www.observium.org/svn/observer/trunk@1865 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-16 01:11:27 +00:00
Tom Laermans
3c10ede092 Get rid of some more execs
git-svn-id: http://www.observium.org/svn/observer/trunk@1814 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-10 15:51:56 +00:00
Tom Laermans
22620145eb clean up MAC change reporting, graph error size
git-svn-id: http://www.observium.org/svn/observer/trunk@1734 61d68cd4-352d-0410-923a-c4978735b2b8
2010-11-23 14:32:37 +00:00
Adam Amstrong
0db6ad08ff vastly improved entity-sensors and cisco-entity-sensors speed. improved entity-mib inventory. removed device_id element from oid caches. add min/max ranges to sensor graphs.
git-svn-id: http://www.observium.org/svn/observer/trunk@1669 61d68cd4-352d-0410-923a-c4978735b2b8
2010-08-11 17:08:56 +00:00
Adam Amstrong
e220114f4c add some mibs, update snmp functions
git-svn-id: http://www.observium.org/svn/observer/trunk@1458 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-22 21:58:49 +00:00
Adam Amstrong
3eba59c8ab cleanup some mac accounting stuff
git-svn-id: http://www.observium.org/svn/observer/trunk@1085 61d68cd4-352d-0410-923a-c4978735b2b8
2010-05-02 20:32:34 +00:00
Adam Amstrong
0bee34b6ad change interfaces table to ports (to match GUI conventions)
git-svn-id: http://www.observium.org/svn/observer/trunk@889 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-20 17:22:22 +00:00
Tom Laermans
e77c976670 use rrdtool_update() everywhere instead of single rrdtool update lines, remove some dead code, and a bunch of coding style cleanups..
git-svn-id: http://www.observium.org/svn/observer/trunk@780 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-07 22:39:02 +00:00
Tom Laermans
57a9689ddd correctly escape : for temperatures so FPC temperature works on junos + add safename() function to strip unwanted characters from filenames - should not break anything existing afaik
git-svn-id: http://www.observium.org/svn/observer/trunk@765 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-05 22:10:06 +00:00
Adam Amstrong
1f1eda9764 Major updates on the road to 0.7
git-svn-id: http://www.observium.org/svn/observer/trunk@492 61d68cd4-352d-0410-923a-c4978735b2b8
2009-10-28 13:49:37 +00:00