Commit Graph

448 Commits

Author SHA1 Message Date
Tony Murray
59d6857bb4 lnms dev:simulate Snmpsim debug output on failure (#12880) 2021-05-14 12:39:38 -05:00
Tony Murray
77a17dac88 Fix installer when DB is empty (#12873)
(which is every time)
2021-05-13 13:02:43 -05:00
Tony Murray
df5096e449 Install: Validate database before migrating (#12867)
* Validate database during install
Needed to remove usages of legacy functions in the validation

* Fix output, restore real versions
2021-05-13 07:18:54 -05:00
Tony Murray
3b0c2c090a Fix top devices widget storage graphs (#12849)
referenced the wrong graph, caused it to not work because device was not set.
2021-05-11 16:58:05 +02:00
Tony Murray
2d752925b0 Oxidized improvements (#12773)
* Oxidized API cleanup
Import more settings to the UI
use lnms config:set

* validate os and type exist

* map settings WIP

* oops

* editing working.  Needed to add new property to pass update state to child

* implement deleting and handle text overflow a little better.

* Update app/Models/Device.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* Update app/Models/Device.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

* revert change

* fix style

* add return

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2021-05-11 08:08:59 -05:00
PipoCanaja
fff8b8e832 Collect OUI Database and do OUI lookups (#12842)
* first draft

refresh time

refresh time

* return codes

style

style

* presentation

* Exception details

more

fix

fix

* add tooltips

fixes for dns display

* create WebUI config option

languages

* refresh data every 7 to 11 days, keep it 15 days max

* 'Ports' and 'Port' ARP table

* Stp page support

style

style

* fix dnsname column finding when vendor is added/removed

fix dnsname column finding when vendor is added/removed

* nac vendor column

nac

* filter fields to reduce size of AJAX reply

filter fields to reduce size of AJAX reply

* fix typo on dns column detection

* default enabled
2021-05-10 14:56:48 -05:00
Tony Murray
21b0e20343 Show OS definition in lnms config:get (#12819)
* Fix lint and style issues

* remove special definition_loaded key
2021-05-02 19:25:35 +02:00
Jellyfrog
ec949d9a34 Widgets: Include variables in default view (#12818)
This causes an error with the default view since it uses $id
2021-05-01 16:03:30 -05:00
Tony Murray
61c89794e4 Remove debug globals (#12811)
* Remove $debug global
and $vdebug global
makes these variables more accessible and protects from collisions.

* the on boot set sends application as the first parameter, just handle that

* Relocate other debug related functions

* Log debug to stdout

* Wrong output

* remove stupid constants

* Fix lint and style issues
2021-04-29 22:42:18 -05:00
Tony Murray
ebadcbc8af Enable config:set to set variables inside a nested array of settings (#12772)
* Enable config:set to set variables inside a nested array of settings
Re-index arrays when forgetting a value from a sequential numerically indexed array

* cleanup
2021-04-26 21:03:03 -05:00
Jellyfrog
3e3aa9077e Revert "Fix StringBlade errors with a stub file" (#12776)
This reverts parts of commit 165c4fd53c.
2021-04-21 23:22:15 +02:00
Jellyfrog
165c4fd53c Enable PHPStan linter (#12678)
* Enable PHPStan linter

* Add PHPStan baseline

* Switch to Level 5

* Fix StringBlade errors with a stub file
2021-04-21 07:41:34 -05:00
Jellyfrog
a8c8a9a4a2 Misc cleanup (#12758)
* Fix Docblock

* Misc

* Parameter #2 $callback of function array_filter expects (callable(mixed, mixed): bool)|null, 'strlen' given

* Parameter #2 $data of function hash_hmac expects string, int given

* Unreachable statement - code above always terminates.

* Update Device.php
2021-04-20 12:47:22 +02:00
Jellyfrog
e86b4662b3 Fix globe controller up/down partition bug (#12757) 2021-04-17 16:46:54 -05:00
Jellyfrog
2ce294618f Fix scopeIsArchived query (#12756)
Method Illuminate\Database\Eloquent\Builder<App\Models\Notification>::limit() invoked with 0 parameters, 1 required.
2021-04-17 17:47:28 +02:00
Tony Murray
6241df2d74 StateTranslation model (#12751) 2021-04-14 07:33:41 -05:00
Tony Murray
0f1c4734d4 Load device relationship from device cache (#12712)
* Load device relationship from device cache

* unrelated should be null, not a null object
2021-04-12 02:55:39 +02:00
Tony Murray
c36fe928e4 Fix mini graphs (#12738)
Remove the polyfill, if the noscript tag isn't removed it breaks graphs
Ajax tables should not use lazy loading anyway...
2021-04-12 02:40:47 +02:00
Jellyfrog
edb36fd69d More cleanups (#12715)
* PHPDoc

* Replace Auth > Illuminate\Support\Facades\Auth

* Return inside when()

* use str_replace correct

* Misc

* dead code

* use int $port

* styleci
2021-04-08 08:14:49 -05:00
SourceDoctor
4b9e480118 Define Port Groups (#12402)
* Define Port Groups

* .

* .

* .

* API Calls

* .

* .

* .

* minor changes

* .

* update forms

* remove link

* .

* change column settings

* change migration

* change update position

* db migration fix

* .

* .

* .

* add missing doc reference

* update test data

* update test data

* update test data

* .

* .

* .

* .

* .

* .

* .

* .

* port group association in seperate table

* .

* .

* show all found groups on port

* select multiple Portgroups per Port

* change on migration file

* change query to eloquent

* Code changes

* move port group menu to ports main menu

* port group update to eloquent

* .

* .

* update to new setting way

* add missing merge parameter

* Use select2 and port some things to Laravel
some fixes, hopefully no new added bugs

* schema

* don't use on update restrict unfortunately

* remove unused import and revert changes

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-04-06 17:25:08 -05:00
Jellyfrog
a0a3a1c8d8 PHPDoc fixes (#12693) 2021-04-01 00:35:19 +02:00
Jellyfrog
24c8513029 Replace Auth > Illuminate\Support\Facades\Auth (#12664)
Helps phpstan
2021-03-31 21:30:04 +02:00
Jellyfrog
58af994c6b Linting (#12677)
* Fix Canopsis Transport

* Lint Hipchat

* Lint IRCBot.php

* Misc

* Update Hipchat.php

* Update Notification.php
2021-03-31 17:29:22 +02:00
Jellyfrog
4b6efba040 Type hint all device model relations (#12686) 2021-03-31 17:28:47 +02:00
Jellyfrog
dc160c6813 PHPDoc fixes (#12687) 2021-03-31 17:18:43 +02:00
Jellyfrog
10cf97e581 More PHPDoc changes (#12674)
* PHPDoc

* Override type hint
2021-03-30 11:16:44 +02:00
Jellyfrog
64e50e4d85 Type hint model relations (#12673) 2021-03-30 11:14:34 +02:00
Jellyfrog
6c59f368b0 Linting: Fix misc problems (#12675) 2021-03-29 17:43:05 -05:00
Jellyfrog
4e5849272f Make moduleobserver type hinting overridable (#12670) 2021-03-29 10:30:36 +02:00
Jellyfrog
4ada8a418d Typo (#12671) 2021-03-29 03:22:47 +02:00
Tony Murray
1c379dcd05 Remove legacy function calls (#12651)
* massive inlines

* fix style and wtf

* remove rrdtool.inc.php include

* fix CommonFunctions namespace issues

* looking for missing class space, fix undefined class issues

* style fixes
2021-03-29 00:25:30 +02:00
Jellyfrog
efb157f5fb Fix more PHPDoc (#12665)
* Fix PHPDoc

* Fix PHPDoc
2021-03-28 12:18:47 -05:00
Jellyfrog
e00eba327d Re-implement Printer as a class based module (#12605)
* Re-implement Printer as a class based module

* Rename toner table

* wip

* wip

* Rename to printersupplies

* Fixes

* Rename

* wip

* wip
2021-03-27 10:09:14 -05:00
Jellyfrog
ede486ea95 Fix regression from 3cfffb9912 (#12661) 2021-03-27 15:39:24 +01:00
Jellyfrog
3cfffb9912 Cleanups (#12642)
Should only be cosmetic
2021-03-24 09:13:43 -05:00
Cupid@zul
c05cf4b2fc Add ID to Device Table List and to Device Dependencies Table List + Shorten ifname in Device: Recent Events. (#12397)
* Add ID to Device Table List and to Device Dependencies Table List

* wrap interface text to max-width: 100px

* ok, fixed as requested. all tests ok! gui working well... filtering and sort tests ok.
2021-03-23 09:07:27 -05:00
Jellyfrog
800ae95b90 Cleanup (#12641) 2021-03-23 08:47:38 -05:00
Tony Murray
ac7b4539ce Fix Service Templates Dynamic (#12626)
* Fix Service Templates Dynamic
Remove dynamic groups type, it did not work.
Rename and simplify field names.  (fixing an issue with the builder where the rules field should be named rules)

* update schema def

* wrong method name in migration

* fix rules builder

* corerct call to apply

* sqlite can't drop columns

* correct column rename order on down.

* fix sqlite again

* fix whitespace
2021-03-18 08:14:45 -05:00
Tony Murray
61316ce2cc PHP 8 fixes (#12528)
* port related errors

* more fixes

* fix storage count

* add tests for php8

* style

* only need not empty

* aix fixes....

* storage WIP

* fix aix discovering hrstorage
fix db test adding .gitkeep
fix os modules when discovery only

* fix aos processors wrong oid

* fix mempool number casting

* fix aos7 cpu

* use + 0 cast instead of floatval()

* more verbose error on invalid json

* remove invalid data in json

* actually fix the json

* correct json error fix

* cast_number() function
fix aruba-instant and aos6 bugs exposed by new function, probably more...

* fix a-f
fix inadequate sort for component data

* fix global port poll time

* fix mempools precent 0, route count, ntp const

* fix schleifenbauer liberal current usage

* further number casting refinement

* vrp

* fix tests

* fix arbos

* warn cleanups adjust to :: change

* fix ciena-sds

* fix drac

* fix dell-rpdu anddlink

* fix and improve arubaos
better error when getting an array in Processor

* fix atenpdu, add missing arubaos files

* aruba-instant to yaml
apparently I didn't need to do this, the diff just looks really odd
It did add ranged sub-index replacements

* docker app, was completely wrong... fixed

* fix sentry4 divide by 0...

* fixed root issue, remove check

* nicer cidr in ipv6 code

* remove bogus enuxus battery bank skip_values

* Fix InfluxDB tests

* remove extra import

* fix other style issues.

* influx "style" fixes
2021-03-12 18:10:14 -06:00
SourceDoctor
1e3cc4788a Sort Type List in Eventlog Pages (#12572)
* Sort Type List in Eventlog Pages

* update code
2021-03-12 10:29:19 +01:00
Anthony F. McInerney
9cd963e3a4 Service templates - fix rules (#12587)
* Service Templates - Submit Error

* Service Templates - Rules Error

* Service Templates - Rules Error

* Service Templates - Rules Error

* Service Templates - Rules Error
2021-03-11 14:28:53 +01:00
Tony Murray
9e10b757fa Fix dev:simulate (#12596) 2021-03-08 18:33:42 -06:00
Tony Murray
e4e2113585 Developer device simulation (#12577)
* Developer device simulation
lnms dev:simulate
handy helper to start snmpsim with test data and optionally add and remove a device to LibreNMS

* doc update
2021-03-03 21:42:49 -06:00
SourceDoctor
4ae452640a WebUI - Spanning Tree Link in Eventlog (#12571) 2021-02-28 00:04:42 +01:00
SourceDoctor
75a0a5e374 Use DNS Location Record for Location (#12409)
* Use DNS Location Record for Location

* .

* .

* .

* grammar fix

* dns class

* code changes

* composer update

* add missing composer.lock update

* reposition Location record parsing

* composer update

* default yes ; change lookup order

* merge master

* .

* move Location Record Parser to Model Level

* .

* fix location record code

* Location precedence with tests
Setting from UI disables all lookups

* update composer.lock and mix-manifest.json

* Style fixes

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-02-22 11:17:40 +01:00
Tony Murray
28d69c5230 Update php packages and fix composer warnings (#12526)
composer/ca-bundle (1.2.8 => 1.2.9)
composer/composer (2.0.8 => 2.0.9)
facade/ignition (2.5.8 => 2.5.11)
filp/whoops (2.9.1 => 2.9.2)
friendsofphp/php-cs-fixer (v2.17.3 => v2.18.2)
laravel/dusk (v6.11.0 => v6.11.3)
laravel/framework (v8.24.0 => v8.27.0)
laravel/tinker (v2.5.0 => v2.6.0)
maximebf/debugbar (v1.16.4 => v1.16.5)
nesbot/carbon (2.44.0 => 2.45.1)
nunomaduro/collision (v5.1.0 => v5.3.0)
phpunit/phpunit (9.5.1 => 9.5.2)
psy/psysh (v0.10.5 => v0.10.6)
symfony/console (v5.2.2 => v5.2.3)
symfony/css-selector (v5.2.2 => v5.2.3)
symfony/error-handler (v5.2.2 => v5.2.3)
symfony/event-dispatcher (v5.2.2 => v5.2.3)
symfony/filesystem (v5.2.1 => v5.2.3)
symfony/finder (v5.2.2 => v5.2.3)
symfony/http-foundation (v5.2.2 => v5.2.3)
symfony/http-kernel (v5.2.2 => v5.2.3)
symfony/mime (v5.2.2 => v5.2.3)
symfony/options-resolver (v5.2.1 => v5.2.3)
symfony/process (v5.2.2 => v5.2.3)
symfony/routing (v5.2.2 => v5.2.3)
symfony/stopwatch (v5.2.1 => v5.2.3)
symfony/string (v5.2.2 => v5.2.3)
symfony/translation (v5.2.2 => v5.2.3)
symfony/var-dumper (v5.2.2 => v5.2.3)
symfony/yaml (v4.4.18 => v4.4.19)
2021-02-14 21:50:32 -06:00
Tony Murray
8b105ba162 GPS coordinates from device (#12521)
* GPS coords from device
in yaml or php
define for epmp, airos, and airos-af-ltu
quirk for airos bug with - in the middle of the number

* style fixes

* revert airos-af-ltu mempool change

* fix imports

* add epmp test data... more improvements to come there.

* don't stagger geocoding now that this is moved to discovery
also, no need to check OSDiscovery since the base implements it.

* fix json data

* fixed
2021-02-14 20:36:55 -06:00
SourceDoctor
4efb71e679 Show Alert Count on Widget (#12503)
* Show Alert Count on Widget

* update query
2021-02-11 19:28:59 -06:00
Tony Murray
4f66427cef Fix Fast Ping alerts always running (#12510)
Alerts should only be ran if the status changes.  This should restore some speed.
Was broken by another fix.
2021-02-11 09:05:13 -06:00
Jellyfrog
4126663b3a Speedup device list (#12514)
* Speedup device list

* Update DeviceController.php
2021-02-08 23:07:49 -06:00