Commit Graph

2 Commits

Author SHA1 Message Date
Tony Murray
3e35ee0e7d Refactored and update Location Geocoding (#9359)
- Fix location so it is a regular database relation (this allows multiple devices to be accurately linked to one location and saves api calls)
- Parse coordinates from the location more consistently
- Add settings to webui
- ~~Used [PHP Geocoder](http://geocoder-php.org/), which has lots of backends and is well tested. (also includes reverse and geoip)~~
- Google Maps, Bing, Mapquest, and OpenStreetMap supported initially.
- Default to OpenStreetMap, which doesn't require a key.  They will liberally hand out bans if you exceed 1 query per second though.
- All other Geocoding APIs require an API key. (Google requires a credit card on file, but seems to be the most accurate)
- Update all (I think) sql queries to handle the new structure
- Remove final vestiges of override_sysLocation as a device attribute
- Update existing device groups and rules in DB
- Tested all APIs with good/bad location, no/bad/good key, and no connection.
- Cannot fix advanced queries that use location

This blocks #8868

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-11-28 22:49:18 +00:00
Dag Bakke
af39200c41 Borderless fullscreen geographical map, with just the nodes. (#8337)
* Added a variant of map.php which allows for a borderless fullscreen geographical map, with just the nodes.

* Signed my work.

* Removed a space.

* delete whitespace

* remove whitespace

* hack to fix some tiles not loading

found the fix here:
https://stackoverflow.com/questions/36246815/data-toggle-tab-does-not-download-leaflet-map/36257493#36257493
https://gis.stackexchange.com/questions/224932/problem-with-map-tiles-loading-with-leaflet-and-bootstrap

You might be able to do something more elegant.

* added menu entry

This removes the need for setting it as a front-page. Now it can be accessed from the menu and LibreNMS can be accessed by navigating back.

* Create fullscreenmap.inc.php

Notice the line:
$pagetitle[] = 'Fullscreen Map';

* REmoved the original fullscreenmap.php

* Revert "REmoved the original fullscreenmap.php"

This reverts commit 570953c5f5.

* addded the resize event to html/pages/fullscreenmap.inc.php for proper leaflet rendering

* Removed old file

* Adjusted CSS and javascript.

* Reverting to original javascript.

* change Leaflet container CSS to white background

* Made the Geographical Map not hide the menu when not in fullscreen mode.

* Cleaned up the CSS-file a bit.

* Added a variant of map.php which allows for a borderless fullscreen geographical map, with just the nodes.

* Signed my work.

* Removed a space.

* delete whitespace

* remove whitespace

* hack to fix some tiles not loading

found the fix here:
https://stackoverflow.com/questions/36246815/data-toggle-tab-does-not-download-leaflet-map/36257493#36257493
https://gis.stackexchange.com/questions/224932/problem-with-map-tiles-loading-with-leaflet-and-bootstrap

You might be able to do something more elegant.

* added menu entry

This removes the need for setting it as a front-page. Now it can be accessed from the menu and LibreNMS can be accessed by navigating back.

* Create fullscreenmap.inc.php

Notice the line:
$pagetitle[] = 'Fullscreen Map';

* REmoved the original fullscreenmap.php

* Revert "REmoved the original fullscreenmap.php"

This reverts commit 570953c5f5.

* addded the resize event to html/pages/fullscreenmap.inc.php for proper leaflet rendering

* Removed old file

* Adjusted CSS and javascript.

* Reverting to original javascript.

* change Leaflet container CSS to white background

* Made the Geographical Map not hide the menu when not in fullscreen mode.

* Cleaned up the CSS-file a bit.
2018-03-18 22:47:06 -05:00