* Create a case for routeros.
RouterOS doesn't support the bgpPeerInUpdateElapsedTime object, so when
LibreNMS does to insert a peer update into the database from a MikroTik
router, you see the following error:
SQLSTATE[22007]: Invalid datetime format: 1366 Incorrect integer value: '' for column `librenms`.`bgpPeers`.`bgpPeerInUpdateElapsedTime` at row 2 (Connection: mysql, SQL: UPDATE `bgpPeers` set `bgpPeerAdminStatus`=start,`bgpPeerInUpdateElapsedTime`=...
To fix this, special-case routeros and note that the object is not yet
supported.
* Use spaces, not tabs.
* Use set_numeric() to ensure bgpPeerInUpdateElapsedTime is a number.
---------
Co-authored-by: Joe Clarke <jclarke@cisco.com>
* Fixes#14957 missing IPv6 BGP peers
* Limit to NX-OS and IOS-XR
* Check for actual VRF since count(getVrfContexts) always > 0
* argh, fix last minute nervous finger superfluous space
* removed redundant count()
* Add Cumulus-BGPUN-MIB
* Add bgpPeerIface column into bgpPeers table
* update mysql database for BGP unnumbered support
* Rename BGP unumbered MIB for Cumulus
* remove duplicate Cumulus BGPUM mib
* Use custom BGPUN minb for Cumulus while polling bgp peers
* Update BGP peers discovery for Cumulus with unumbered support
* Update BGP peers polling for Cumulus with unumbered support
* Correct typing error
* Add BGP unumbered Cumulus tests units
* Remove unused SQL file
* Update migrations databse by adding bgpPeerIface into bgpPeers table
* Correct spacing error for continous integration
* Update DB column bgpPeerIface to point to ifIndex
* fix: bgpPeerIface column exist
* fix: use Eloquent instead of dbFetch deprecated
* fix: delete unused namespace
* fix: type bgpPeerIface
* fix: add root cumulus mib lacking
* move root cumulus mib into mibs/
* fix: missing root cumulus MIB
* fix: bgpPeerIface not expected for other OS
* fix: add bgpPeerIface into json tests for other OS
* fix: add bgpPeerIface for poller tests OS
* add relathionship between bgpPeers and Ports tables
* Revert "fix: bgpPeerIface not expected for other OS"
This reverts commit f979482106.
* fix: HasOne not imported
* fix: CI php placement of use line
* fix: bgpPeerIface has not default value
* updates way to fill bgpPeerIface
* remove relationship between BgpPeer and Ipv4Address/Ipv6Address
* fix: CI php syntax
fix: CI php syntax
fix: CI php syntax
fix: CI php syntax
* updates cumulus tests
* updates bgpPeerIface already filled
* fix : bgpPeerIface wrong ifIndex
* fix: update cumulus test for polling bgpPeerIface
* fix: CI PHP syntax
* fix: update cumulus test for polling bgpPeerIface
* fix: update cumulus test for polling bgpPeerIface
* Fix Fortigate Test
* Tests
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Add EntityVoltage Sensors
* Add BoardPower Sensors
* Add Fanspeed Percent sensor
* Add Voltage_Status and Temperature_Status Normal|Minor|Major|Critical indicators, and internal Voltage and Temperature sensors
* set Minor alarm violations to warning status
* remove inconsistently applied empty lines between sections, and trailing newline that caused errors
* fetch thresholds for temperature.sensors and optical.RxPower from SNMP
* Added snmp testfiles for ne8000-m8 variant of VRP platform
* group sensors by card-identifier
* Regenerate testfiles for 5720-32x-ei
* Regenerate testfiles for the whole VRP family
* Optical Bias is reported as miliamps-mA, and not microamps-uA
* Implement divisor detection, VRP or NE8 prepended on sensor for debug-testing
* remove VRP or NE8 prependeds on sensors(put there for debug/testing only)
* use parent OIDs for walking and naming
* ignore per-slot power if unsupported
* regenerated snmp json testfiles
* sanitize bgp-peers value
* restore vrp.json test
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Add Firebrick MIBs, temperatures and voltages.
* Add missing $sysOid checks.
* Add fan speed for FB6000 series.
* Add sane limits.
* Update Firebrick MIBs.
* Make BGP peers work.
* Better support for Firebricks.
* Add more firebrick support.
* Add BGP Peer States.
* Fix fan speed divisor now that Cliff has fixed the code.
* Fixes for BGP and sensors.
* Add Firebrick IPSec module.
* Add IPSec Tunnels (Base).
* Sort out the IPSec states (although they're still green for no real reason).
* Code style fixes.
* Add missing config definition.
* Fix code style issues.
* Move bgp-peers to its own file.
* Do fan speeds with yaml, not PHP.
* Add Firebrick 6000 snmprec.
* Move Firebrick tests to be FB6000 tests.
* Revert "Move Firebrick tests to be FB6000 tests."
This reverts commit 426c1db980.
* Add tests for specific firebrick variants (2900, 6000) rather than generic.
* Add the firebrick-ipsec-tunnels poller config option.
* Switch to cipsec-tunnels for Firebrick.
* Unnecessary as it's now in cipsec-tunnels.
* Add extra MIB fields for Firebrick BGP MIB.
* Minor fix for AS text.
* Fix the tests.
* Exclude build timestamp from the version.
* Fix a couple of careless errors.
* Code style fix.
* Better version strings.
* Fixes for BGP, and add "Routing Table" support (VRF).
* Add more test data for BGP peers.
* Fix test data for BGP.
* Remove processors for now - as we can't get the data sensibly.
* Fix code style.
* Update firebrick.inc.php
Force tests re-run
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
* Add BGP discovery and polling for Dell OS10 devices
* Add BGP testing data for Dell OS10
* Add BGP testing data for Dell OS10 (fix)
* Add DB info for unit testing
DB_TEST_HOST must be changed when running mysql in a separate docker container or unit tests fail
* Set bgpLocalAs in discovery (fixes unit test fail)
Ideally the main `bgp-peers.inc.php` should be fixed so it does not
depend on finding bgpLocalAs from BGP4-MIB
* Change comment style
* Remove link to code in documentation
* Discover BGP counters
* Use IPv6 addresses in compressed format
* vrp-improve
* add bgp4 data, and get errors
* Fix WRONG Type error on bgpPeerRemoteAs + handle ErrorSubCode in a generic way
* fixing tests
* clean
* improve state backup to BGP4-MIB
* tests with corrected data
* tests
* restore original tests/data/vrp_5720.json
* BGP Polling: Add error code polling
* Rework describe_bgp_error_code and fix bgp error fields migration
* Add real test data for IOS-XR and Arista EOS
* ipv6 support for BGP routes in VRP devices
* reverse bgpPeers array to allow VRF aware BGP
* codeclimate
* codeclimate
* codeclimate, finally
* Split VRP out of bgp-peers for readabilty
* Split VRP out of bgp-peers for readabilty
* tests
* CodeClimate
* improve function description
* improve function description
* v6data
* rebase
* space
* ipv6 support for BGP routes in VRP devices
* reverse bgpPeers array to allow VRF aware BGP
* codeclimate
* codeclimate
* codeclimate, finally
* Split VRP out of bgp-peers for readabilty
* Split VRP out of bgp-peers for readabilty
* tests
* CodeClimate
* improve function description
* improve function description
* v6data
* rebase
* space
* fixed corner case
* Migrate ironware sensor discovery from php to yaml.
* More sensors, add grouping.
* dynamic_discovery_get_value() becomes getValueFromData()
* Target a specific index with skip_values.
* Improve Brocade BGP session discovery/polling
This commit allows for the correct discovery of BGP sessions
with 32-bit ASNs, IPv6 neighbors using the BGP4V2-MIB which is
based on draft-ietf-idr-bgp4-mibv2-11 and also polls for IPv4
unicast received routes through the FOUNDRY-SN-BGP4-GROUP-MIB.
Copied most of the code from PR#8877 by @Mikeburke14, cleaned
up the code a little bit to match the normal LibreNMS style,
and fixed bgpPeers_cbgp discovery as well as polling for the
ipv4.unicast neighbors.
Note that older Brocade IronWare firmware versions are known
to have multiple defects relating to the BGP4V2-MIB which
might result in certain missing non-established neighbors.
Related vendor defect numbers:
- DEFECT000633962
-- Symptom: The OID bgp4V2PeerAdminStatus does not return the
correct value
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00g
- DEFECT000583319
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
does not display all the BGP entries
-- Reported: NI 05.6.00
-- Resolved: NI 05.8.00e
- DEFECT000550309
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
does not display the full information
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00c
* Add ironware CER & ICX platform test data.
* Re-add ironware.json compatible with current master branch.
The values in the $peer['c_update'][$oid] array are set only if they have
changed. If the value has not changed, then zero is substituted for real
values, which leads to incorrect calculation of delta values and records
in the database:
SELECT AcceptedPrefixes,AcceptedPrefixes_prev,AcceptedPrefixes_delta
FROM bgpPeers_cbgp
WHERE device_id=115;
| AcceptedPrefixes | AcceptedPrefixes_prev | AcceptedPrefixes_delta |
|------------------|-----------------------|------------------------|
| 21 | 21 | -21 |
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Use Log facility when Laravel is booted.
Update init.php so we can easily boot Laravel for CLI scripts. (and just Eloquent, but that may go away)
Move all debug setup into set_debug() function and use that across all scripts.
Log Laravel database queries.
Send debug output to librenms log file when enabling debug in the webui.
Allow for colorized Log CLI output. (currently will leave % tags in log file output)
** Needs testing and perhaps tweaking still.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
* bgp-peers update
Use IP parsing library more effectively.
Fix update issue
Include comware bgp-peers test data
deeper refactoring
Allow JunOS fallback to BGP4-MIB, some models only use that.
Add junos bgp4 data
Actually update all bpg data in the poller
* fix arista data. refactor some to prevent missing data from mucking things up
* refactor to use $oid_map for BGP4-MIB too
* A few comments to break up teh file a bit
* Junos bgp data an a quick revert for now.
* small cleanup
* fix ios bgp polling, add test data
* check the correct variable
* Test Data
* fix bugs in bgp-peers poller
peer data in wrong format
array_diff doesn't work right, change to array_diff_assoc
astext is too short for some
