mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
6394c35ce6f31a57ea70c3b09ec64f67a3f69b44
26 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
rsys-dev
|
6394c35ce6 |
Graylog entry matching device if source is not hostname or primary ip (#10458)
* Added findByHostnameOrIp($hostnameOrIp) for devices.
Returns Device or null
Fixed Graylog device links, "device" parameter in URL was IP or Hostname instead of device id before
Added Severity number to name conversion. Can be activated by setting $config['graylog']['severity-names'] = "true" in config
Added Facility number to name conversion. Can be activated by setting $config['graylog']['facility-names'] = "true" in config
* Added $config['graylog']['match-any-address']. To enable matching Graylog entries by any interface address set to "true"
Added code to match Graylog entries by any interface address instead of only hostname or primary address
* Fixed missing quotation marks in <script> block in includes/html/common/graylog.inc.php:46, causing graylog page only load header with empty table. Introduced in https://github.com/librenms/librenms/pull/10447
* Modified code to reduce complexity as mentioned by codeclimate
* Changed findByHostnameOrIp($hostnameOrIp) as mentioned by https://github.com/murrant
* Added Language File "syslog.php" for Syslog Severity and Facility
Merged functions "levelName($level)" and "facilityName($facility)" to "syslogPrioParser($type, $value)" where $type should be "facility" or "severity" and $value the numeric or text facility or severity. Returns "NUMBER (NAME)" if possible, otherwhise returns $value
* Shortened findByHostnameOrIp($hostnameOrIp) as mentioned by https://github.com/murrant
* Add shortcut ipv4 and ipv6 device relationships
Better code for adding source addresses
Only translate level and facility if they are numeric
Allow level and facility to be sortable
No need for device link if we know it won't work. Before the code was punting to save sql queries.
* Cache devices
Took queries from 69 to 6 in my quick test.
* Added Documentation for $config['graylog']['match-any-address']
* Fixed missing quotation marks in app/ApiClients/GraylogApi.php:125
|
||
CirnoT
|
86740a76c0 |
Replaced color indicator near uptime counter with colored text and change color of status indicator to black on disabled devices instead of gray(#10372)
(matches availablity map with show ignored/disabled enabled) |
||
|
CirnoT
|
241b07756f |
Don't show warning when ignored device is online (pingable) (#10286)
* Don't show warning when ignored device is online (pingable) * Update logic for header on device page too * Make codeclimate happy |
||
Tony Murray
|
e9ae08d5db |
Use Laravel url helpers to improve functionality without dns name (#10227)
* Use Laravel url helpers to improve functionality without dns name Not exhaustive... * Fix Url generated urls * Bump js version |
||
|
Tony Murray
|
bc24d39bf1 |
Fix device list down devices that have never been polled (#9994)
* Fix device list down devices that have never been polled * Suggestion with 'Never' in case last_polled empty and down * Improve handling of all cases * fix doc comment |
||
PipoCanaja
|
a2d378e0be |
Display Up/Down time in Device List (#9951)
* First attempt of Up/Down time * First attempt of Up/Down time * Moved to Time::formatInterval() * cleaning * last polled in casts * Cleaning the variants of formatUptime() * Cleaning in ./html/includes/dev-overview-data.inc.php * Cleaning in ./html/includes/dev-overview-data.inc.php * Cleaning in ./html/includes/dev-overview-data.inc.php * updated includes/polling/core.inc.php * updated includes/alerts.inc.php * clean accessors |
||
|
Tony Murray
|
b65205b983 | Graylog: Handle missing fields a little more gracefully (#9919) | ||
|
PipoCanaja
|
e2f835ad9d |
FDB table with history capabilities (#9804)
* Migration script and data feeding * Adding the columns in the GUI * build schema * update FDB test data * Use of timestamps() * ignore created_at and updated_at in tests, and regenerate test impacted * daily.sh does the cleaning * space cleaning codeclimate * Use carbon instead of str-val * handle when $fdb_entry->updated_at and created at are null * handle when $fdb_entry->updated_at and created at are null (force travis rerun) * Doc update * Doc update |
||
CoMMyz
|
2b4d8fc541 |
Port exists check in eventlog (#9778)
Check if port exists before getting the label as some ports may have events but then removed and this can break eventlog page. |
||
|
Tony Murray
|
eb59287d34 |
Fix devices page search & OS loading (#9752)
* Fix devices page search * add a definition_loaded flag to prevent false positives for already loaded OS * Fix copy paste error * and another |
||
|
Tony Murray
|
590c488d74 |
Rewrite devices page backend (and a little frontend) (#9726)
* Implement devices table data output * initial filter * Add select2 filters improve table header layout improve init_select2 * bump versions to be safe * add group filtering fix location sorting * allow filter value morphing * add missing state filter * remove the old devices endpoint |
||
|
Tony Murray
|
ef41c9fd7d |
Refactor FDB Tables to Laravel (#9669)
* Refactor FDB Tables to Laravel Hopefully much better performance with large tables. Better dns resolution (limit to 4 IPs tried per MAC) * update style * de-duplicate IPs * fixed column width for mac and vlan * Make DNS column visibility control whether or not we send the dns query. Hide that column by default. |
||
|
Tony Murray
|
394c40e541 |
Implement filter helpers for ajax table controllers (#9660)
Reduces boiler plate code. |
||
|
Tony Murray
|
97a94f3449 | Fix customers page to only show customer type ports (#9598) | ||
Jose Augusto Cardoso
|
aa25b2b47a |
NAC Polling (Network Access Control) (#9227)
* RouterOS wireless sensors update (#9401)
* bug-fix and new features
Fixed incorrect OID for rate, renamed rate to TX-Rate as per update from mikrotik.
Added support for link distance
* Fixed indent issue
* Added support for using Transport name in templates (#9411)
* Added ability to sort alert schedules by status (#9257)
Signed-off-by: Rémy Jacquin <remy@remyj.fr>
* Converted Polling From Ports to New Module (cisco-nac)
* Converted Polling From Ports to New Module (cisco-nac)
* Fixed alert util (#9428)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixed AlertUtil - again (#9429)
* Update BEGEMOT-HAST-MIB (#9427)
FIX:
Due to a missing import and the uppercase after some SYNTAX this mib is not bein compiled correctly everywhere.
For example the one from Horizon OpenNMS fails with some errors
ERROR: Cannot find symbol UNSIGNED32, Source: BEGEMOT-HAST-MIB.txt, Row: 321, Col: 17
The proposed change prevent the errors.
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fixing Travis CI and Code Climate Issues
* Fixing Travis CI and Code Climate Issues
* Fixing Travis CI and Code Climate More Issues
* Fixing Travis CI and Code Climate More Issues
* Fixes delta calculation for bgpPeers_cbgp metrics (#9431)
The values in the $peer['c_update'][$oid] array are set only if they have
changed. If the value has not changed, then zero is substituted for real
values, which leads to incorrect calculation of delta values and records
in the database:
SELECT AcceptedPrefixes,AcceptedPrefixes_prev,AcceptedPrefixes_delta
FROM bgpPeers_cbgp
WHERE device_id=115;
| AcceptedPrefixes | AcceptedPrefixes_prev | AcceptedPrefixes_delta |
|------------------|-----------------------|------------------------|
| 21 | 21 | -21 |
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Improve Junos state sensor discovery (#9426)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
Tested on MX and EX series, works fine.
Skip slots that are empty and pull all sensors in jnxFruTable, data from old code is preserved.
* Added alerts schedule notes into device notes (#9258)
* Add alerts schedule notes into device notes
Signed-off-by: Rémy Jacquin <remy@remyj.fr>
* Update preferences.inc.php
* Show port description and dns name in FDB table (#9370)
- Added Port Description field to FDB Table
- Added DNS Name field to FDB Table
- Fixed sorting by port in FDB Table
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update draytek.inc.php (#9432)
* Removed unnecessary model checks in HiveOS Wireless (#9409)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added format field to Telegram Messages (#9404)
* Add format field to Telegram Messages
Added Telegram field to send formatted messages as Mardown or HTML
* Update Telegram.php
* Correct Mistypo.
* Correct mistypo
* Correct Mistypo
* Correct mistypo
* Update Transports.md
* Add Format field on Telegram Examples
* Change Telegram Format field to type select
* Add "blank" option to Format field
* Update Telegram.php
* Update Telegram.php
* Update Telegram.php
* Disable page refresh on health sensors pages, autorefresh most tables (#9386)
* Disable page refresh on health sensors pages
Refresh all bootgrid tables every 5 minutes
* Update legacy_index.php
* Update librenmsv1.blade.php
* Style cleanup in hiveos file (#9440)
Fix code style check for https://github.com/librenms/librenms/pull/9438
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Ensure the checks for ASA context devices are strict (#9441)
* Show visually in webui + cli when using deprecated templates or transports (#9413)
* Show visually in webui + cli when using deprecated templates or transports
* Fixed query
* Added Bing geocode lookup support (#9434)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added ScreenOS Syslog Hook (#9438)
* Add ScreenOS Syslog Hook
Adds Syslog Hook for ScreenOS
https://community.librenms.org/t/juniper-screenos-syslog-hook/6146
* Update Syslog.md
* Update syslog-notify-oxidized.php
* Discovery YAML. Do not implicitly append $index (#9315)
Require it explicitly. Makes it easier to understand and matches the style of other values
Questionable YAML changes (either broken before or now broken):
secureplatform: haStatCode
ptp600: receiveModulationMode
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update Syslog.md (#9443)
Fixed the screenOS output added in #9438 which was confusing mkdocs output. Refer to the docs currently https://docs.librenms.org/Extensions/Syslog/ - It's all mashed up at the bottom
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Fix ping.php poller groups setting
confusion between dispatch(new PingCheck($groups)) and PingCheck::dispatch($groups)
* Replaced Other to Disabled on Metod Column
* Replaced Other to Disabled on Metod Column
* Removed Extra Character < on Authz Icon
* Removed Extra Character < on Authz Icon
* Created sql-schema (261)
* Created sql-schema (261)
* Update docs for virtual images (#9456)
* Added Traffic to the Windows OS overlib graph (#9445)
WebUI: added Traffic to the Windows OS overlib graph
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Update World-Map.md to include pros/cons (#9442)
DO NOT DELETE THIS TEXT
#### Please note
> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.
- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)
#### Testers
If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
* Added allow ipv6 address localhost nginx-status docs (#9458)
Following the modification of the SNMP Nginx agent (
|
||
|
Tony Murray
|
74882e3950 |
Dashboard widget update (#9515)
Implemented in Laravel Doesn't use legacy PHP session Several widgets have new features and settings, for example: - Multiple ports in one graph - Maps settings are configurable and override system settings but default to system settings - Graylog stream and/or device selection - Much improved graph widget selection - Many more DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926` After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert. |
||
|
Tony Murray
|
93f44d67f8 |
Fixed customers page (#9521)
move customers table backend to Laravel DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926` After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert. |
||
|
Tony Murray
|
c5c8654e0e | Fix locations page search (#9501) | ||
|
Tony Murray
|
957ecc2441 |
Locations UI and editing (#9480)
* Better handling of errors Mapquest seems to return the center of the US on error....... * Editable locations WIP * Change to bootgrid ajax table WIP * Graphs working, using handlebars update js libs add current location button * remove sql query, change icon * Add the map to the device view, only when gps is expanded. Allow edit on device page, share js code * fix chevron rotation, improve click area * extra warning * fix overview layout (remove containers) * fix style * fix html divs, change collapse ui a bit move css, update css/js versions * start zoomed out on new locations * don't double load scripts, zoom to 17 * fix php-md errors, remove unused use statement * improve non-admin experience * Move locations page to Laravel More functions in Url and Html util classes reduce code duplication * translation buttons too * fix whitespace * move formatters to the frontend * small changes * disable traffic for locations with no devices * change down 0 to green from gray * missing " * Fix paginate all * working fix for paginate all * allow sort by counts * fix down sort * a little safety * Don't call the function twice * btn-xs |
||
TheGreatDoc
|
f603ec204f | Change to use searchFields() like syslog controller (#9337) | ||
|
TheGreatDoc
|
4a23f8dddd |
Fixed search & device eventlog (#9329)
DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926` After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert. In #9252 search box and inside device eventlog where broken. Noticed in https://community.librenms.org/t/bug-set-filter-in-device-eventlog-shows-filtered-events-from-all-devices/5633 I hope my fix does the job :) |
||
|
Tony Murray
|
ac677a99ee | Fix eventlog when the device has been deleted. (#9276) | ||
|
Tony Murray
|
6242f941f6 |
Update Eventlog WebUI/backend to use ajax (#9252)
* WIP Eventlog table * Initial Eventlog rework * fromdevice is not a request parameter * updates * remove unneeded field * Cleanups |
||
|
Tony Murray
|
5bf4ca2b6c |
Fix syslog select2 theme (#9248)
Wrong one :/ htmlentities the rest... |
||
|
Tony Murray
|
f81552e1c1 | Syslog fixes (#9246) | ||
|
Tony Murray
|
21ca8bf0b0 |
Update syslog display and backend (#9228)
* Update syslog display backend select boxes now dynamically load instead of loading all on pageload select and table ajax backends completely redone with Laravel (just syslog for now) duplicate url creation to Url utility class for now (uses Device model instead of array) build short hostname functionality into Device->displayName() helper * Fix whitespace * Some tidying up. Split out displayName() and shortDisplayName() * Enable auto-sizing. Fix small error in Url * Eager load device Use bootstrap theme for select2 |