Commit Graph
470 Commits
Author SHA1 Message Date
Patrik Forsberg e40e1069d5 Fixes to Export CSV (#12830)
* fixes to port CSV Export

Signed-off-by: Patrik Forsberg <[email protected]>

* fix code-style issues

Signed-off-by: Patrik Forsberg <[email protected]>

Co-authored-by: Tony Murray <[email protected]>
2021-05-04 21:51:19 -05:00
Denny Friebe 1734e3af04 Fix allow_unauth_graphs (#12829) 2021-05-04 07:49:16 -05:00
Tony Murray bb39b4ad83 Rrd graph optimizations (#12806)
* RRD Graph optimization
Do not use temporary files to generate graphs
Don't start up a process to pipe commands to, just run the command
Error image improvements

* fix style issues

* run the rrdgraph command in the rrd directory
2021-05-03 09:48:15 -05:00
Jellyfrog 4821c2b377 Prevent error when no alert rules (#12815) 2021-04-29 22:45:06 -05:00
Jellyfrog 49ec6aabd6 Bump tecnickcom/tcpdf dependency to support php 8 (#12816)
Also fix undefined variable error
2021-04-29 22:43:47 -05:00
Tony Murray 61c89794e4 Remove debug globals (#12811)
* Remove $debug global
and $vdebug global
makes these variables more accessible and protects from collisions.

* the on boot set sends application as the first parameter, just handle that

* Relocate other debug related functions

* Log debug to stdout

* Wrong output

* remove stupid constants

* Fix lint and style issues
2021-04-29 22:42:18 -05:00
Jellyfrog 76803c2acc Make applications work with rrdcached (#12807) 2021-04-28 22:00:32 -05:00
Tony Murray 7de808a4e8 Revert "RRD Graph optimization (#12735)" (#12805)
This reverts commit 2833d935e0.
2021-04-28 09:07:31 -05:00
Tony Murray 2833d935e0 RRD Graph optimization (#12735)
* RRD Graph optimization
Do not use temporary files to generate graphs
Don't start up a process to pipe commands to, just run the command
Error image improvements

* fix style issues
2021-04-28 05:28:07 -05:00
martinberg 33c7151763 Additional data collection for GAIA (#12713)
* Added support for GAIA logserver/firewall lograte, raid state and type, logserver state and testdata, firewall packet stats and connections stats

* Fixed typo

* Added testdata

* Fixed typo

* Changed some faulty strings to integers

* Added more sensors. License, HA states and Updates checks

* Added testdata

* Using snmp_get_multi. Cleaner code

* Fix rrd function usage

Co-authored-by: Tony Murray <[email protected]>
2021-04-28 05:19:17 -05:00
Bennet Gallein 5576847c26 fix: fixing consistency accross api endpoints (#12795) 2021-04-26 21:30:30 +02:00
Simon Smith 5453163331 change printer-supplies rrd name to include the supply_type (#12792)
* Update PrinterSupplies.php

* Update toner.inc.php

* Update auth.inc.php
2021-04-25 09:16:21 -05:00
PipoCanaja eab63ea220 webui - Services bootstrap enable + status (#12736)
* Services bootstrap enable + status

* style

* copyright

* generic create-service.inc.php to allow updates of some fields only

* generic create-service.inc.php to allow updates of some fields only
2021-04-22 19:13:39 +02:00
djamp42 97d20dd09a Make docker app work with rrdcached (#12746)
* docker app rrdcached

* offset fix and formatting fix

* more fixes

* Update Rrd.php

* Update Rrd.php

Co-authored-by: Jellyfrog <[email protected]>
2021-04-21 07:40:48 -05:00
Rob Schultz 7c157c1577 Fix auth and crypto select options (#12769)
* Fix auth and crypto select options

Output no string vs the value of $snmpv3_sha2 and $snmpv3_aes256 as this would result in <option selected1> resulting in the proper option not being selected.

* Fix style issue
2021-04-20 23:26:01 +02:00
Tony Murray 3a29198238 Fix mempool tags (#12745)
Does not affect rrd, only external tsdb
2021-04-13 21:33:07 +02:00
Tony Murray 0b617db7f5 Fix alert rules display when creating new alert template (#12731)
Doesn't clear rules from default template...
2021-04-12 02:47:08 +02:00
Tony Murray c36fe928e4 Fix mini graphs (#12738)
Remove the polyfill, if the noscript tag isn't removed it breaks graphs
Ajax tables should not use lazy loading anyway...
2021-04-12 02:40:47 +02:00
Tony Murray 0e79413a5b escape user editable field (#12739) 2021-04-11 15:08:41 +02:00
Tony Murray 6d40871395 Fix mempools divide by 0 (#12734) 2021-04-09 11:10:02 +02:00
Tony Murray 78dd6f305c Fix bug in component table (#12730)
* Fix bug in component table

* use !empty
2021-04-08 10:27:20 -05:00
Jellyfrog edb36fd69d More cleanups (#12715)
* PHPDoc

* Replace Auth > Illuminate\Support\Facades\Auth

* Return inside when()

* use str_replace correct

* Misc

* dead code

* use int $port

* styleci
2021-04-08 08:14:49 -05:00
Tony Murray d34cd0a1b8 Fix ports table when unpolled ports exist (#12722)
* Fix ports table when unpolled ports exist

* fix another divide by 0
2021-04-08 11:17:53 +02:00
Rob Schultz 40517f695a Cisco AES256 support (#12717)
* Add support for net-snmp AES-256-C option

* Add AES-256-C to tests and config definition
2021-04-06 22:07:41 -05:00
Jellyfrog dedc46b548 Fix SQL injection in rediscover-device (#12716)
Closes #12697
2021-04-06 21:57:50 -05:00
SourceDoctor 4b9e480118 Define Port Groups (#12402)
* Define Port Groups

* .

* .

* .

* API Calls

* .

* .

* .

* minor changes

* .

* update forms

* remove link

* .

* change column settings

* change migration

* change update position

* db migration fix

* .

* .

* .

* add missing doc reference

* update test data

* update test data

* update test data

* .

* .

* .

* .

* .

* .

* .

* .

* port group association in seperate table

* .

* .

* show all found groups on port

* select multiple Portgroups per Port

* change on migration file

* change query to eloquent

* Code changes

* move port group menu to ports main menu

* port group update to eloquent

* .

* .

* update to new setting way

* add missing merge parameter

* Use select2 and port some things to Laravel
some fixes, hopefully no new added bugs

* schema

* don't use on update restrict unfortunately

* remove unused import and revert changes

Co-authored-by: Tony Murray <[email protected]>
2021-04-06 17:25:08 -05:00
Antonio Almeida d80c19d0dd WebUI - Display interface errors per second instead of accumulated (#12613)
* Display delta errors instead of accumulated
* Interface errors rate based on polling time and with units
* After some googling changed Eps to EPS to represent errors per second

Co-authored-by: PipoCanaja <[email protected]>
2021-04-06 20:40:23 +02:00
PipoCanaja 422d1195c6 fix BGP tab Exception (#12672) 2021-03-29 17:44:12 -05:00
Tony Murray 1c379dcd05 Remove legacy function calls (#12651)
* massive inlines

* fix style and wtf

* remove rrdtool.inc.php include

* fix CommonFunctions namespace issues

* looking for missing class space, fix undefined class issues

* style fixes
2021-03-29 00:25:30 +02:00
Jellyfrog e00eba327d Re-implement Printer as a class based module (#12605)
* Re-implement Printer as a class based module

* Rename toner table

* wip

* wip

* Rename to printersupplies

* Fixes

* Rename

* wip

* wip
2021-03-27 10:09:14 -05:00
Tony Murray 5e7c58aa1a Fix double escaping sysContact on device overview (#12653) 2021-03-26 16:11:29 -05:00
djamp42 9465e0d305 Hide disabled components from overview page CIMC (#12650)
* Hide Disabled Components from Overview Page

If $component is disabled, hide it from the overview page.

* Update cimc.inc.php

continue instead of break
2021-03-26 14:46:38 +01:00
Yif Swery de0fc2125c Add ability to set a custom port on IPMI agents (#12634)
* Add ability to set a csutom port on IPMI agents

* Casting the port value to int
2021-03-23 10:11:05 -05:00
Cupid@zul c05cf4b2fc Add ID to Device Table List and to Device Dependencies Table List + Shorten ifname in Device: Recent Events. (#12397)
* Add ID to Device Table List and to Device Dependencies Table List

* wrap interface text to max-width: 100px

* ok, fixed as requested. all tests ok! gui working well... filtering and sort tests ok.
2021-03-23 09:07:27 -05:00
Jellyfrog 800ae95b90 Cleanup (#12641) 2021-03-23 08:47:38 -05:00
Simon Smith 0712b5299e Update availability-map.inc.php (#12632)
fix services url in availability maps as currently generates a 404
2021-03-18 16:27:49 -05:00
Serphentas c88ef64169 Chrony support (#12488)
* initial chrony implementation

* remove unused import

* add testing data

* fix test data

* fix tests

Co-authored-by: Jellyfrog <[email protected]>
2021-03-18 20:11:25 +01:00
Tony Murray 61316ce2cc PHP 8 fixes (#12528)
* port related errors

* more fixes

* fix storage count

* add tests for php8

* style

* only need not empty

* aix fixes....

* storage WIP

* fix aix discovering hrstorage
fix db test adding .gitkeep
fix os modules when discovery only

* fix aos processors wrong oid

* fix mempool number casting

* fix aos7 cpu

* use + 0 cast instead of floatval()

* more verbose error on invalid json

* remove invalid data in json

* actually fix the json

* correct json error fix

* cast_number() function
fix aruba-instant and aos6 bugs exposed by new function, probably more...

* fix a-f
fix inadequate sort for component data

* fix global port poll time

* fix mempools precent 0, route count, ntp const

* fix schleifenbauer liberal current usage

* further number casting refinement

* vrp

* fix tests

* fix arbos

* warn cleanups adjust to :: change

* fix ciena-sds

* fix drac

* fix dell-rpdu anddlink

* fix and improve arubaos
better error when getting an array in Processor

* fix atenpdu, add missing arubaos files

* aruba-instant to yaml
apparently I didn't need to do this, the diff just looks really odd
It did add ranged sub-index replacements

* docker app, was completely wrong... fixed

* fix sentry4 divide by 0...

* fixed root issue, remove check

* nicer cidr in ipv6 code

* remove bogus enuxus battery bank skip_values

* Fix InfluxDB tests

* remove extra import

* fix other style issues.

* influx "style" fixes
2021-03-12 18:10:14 -06:00
Tony Murray 74c3d714a5 Oxidized support airfiber (#12597)
map airos-af and airos-af-ltu to the correct model
2021-03-08 21:19:00 +01:00
yrebrac 7d65cf1f05 Add application powermon (#12500)
* adding powermon application

* working consumption graph

* updating powermon application

* powermon app style fixes

* added powermon app test data

* debug code

* revert

* fix tests

* fix tests

Co-authored-by: Tony Murray <[email protected]>
Co-authored-by: Jellyfrog <[email protected]>
2021-03-07 20:28:09 +01:00
Lucas Dousse 49868ee1a6 docker stats app (#12358)
* docker stat app support

* Add missing doc and app

* stylci

* styleci

* styleci

* Add test data

* add snmpsim

* Update docker.inc.php

test with use Number::Bi

* typo

* Add tests

* Add tests

Co-authored-by: Jellyfrog <[email protected]>
2021-03-07 20:26:44 +01:00
theochita c5178cf550 webui: Add button to show verbose alert details in the alert, alert-log webui (#12484)
* Show verbose alert details in the alert, alert-log webui

update file permissions

* Make global admin permission required to use alert details ui

* StyleCI patch

Co-authored-by: root <[email protected]>
2021-03-06 21:57:06 +01:00
Tony Murray 6e19805bcb remove legacy json format function (#12583)
* remove legacy json format function

* remove silly use
2021-03-04 14:55:41 +01:00
Janno Schouwenburg 0a8f24c5b1 Cisco enhanced cellular (#12463)
* Cisco enhanced cellular support

* Extra sensors, camelcasing and bugfixes

* Doc update

* German translation

* French translation

* Style fixes

* Style changes

* Style changes

* Style changes

* Style changes

* Style changes

* Added test data

* New test data --variant

* New test data --variant ir1101

* Made the new wireless sensors generic

* Added test data for ios variant ir809

* Fix includes/discovery/sensors/count/cisco.inc.php, thanks PipoCanaja

* Moved cellular operating band from Wireless sensors to count sensor

* test data

* test data

* test data

* test data

* Moved ICCID/IMSI/IMEI to inventory

* test data and style fix

* Cellular state sensors now have a group

Co-authored-by: Maikel de Boer <[email protected]>
2021-03-02 06:37:30 -06:00
PipoCanaja 839ccec9ad F5 realservers (node_name) display (#12553)
* Use the actual server name instead of pool name where needed

* Add a new attribute with nodename to avoid breaking RRD filenames

* tests

* tests improved

* force refresh tests
2021-02-26 16:15:43 +01:00
PipoCanaja 1c3303d8ae Notifications : display sensor state textual value (#12554)
* display sensor state textual value
* style
* if then else
2021-02-25 19:00:47 +01:00
SourceDoctor 75a0a5e374 Use DNS Location Record for Location (#12409)
* Use DNS Location Record for Location

* .

* .

* .

* grammar fix

* dns class

* code changes

* composer update

* add missing composer.lock update

* reposition Location record parsing

* composer update

* default yes ; change lookup order

* merge master

* .

* move Location Record Parser to Model Level

* .

* fix location record code

* Location precedence with tests
Setting from UI disables all lookups

* update composer.lock and mix-manifest.json

* Style fixes

Co-authored-by: Tony Murray <[email protected]>
2021-02-22 11:17:40 +01:00
PipoCanaja d20e1bdf5d GUI - Fix the detailed access point view (#12543)
* Fix the detailed access point view
* Removing unused old tab file
2021-02-18 15:10:32 +01:00
Jellyfrog 38de49ca30 Correct check for SNMPv3 SHA-192/256 compability (#12494)
* Correct check for SNMPv3 SHA-192/256 compability

* fixup

* fixup
2021-02-10 07:57:12 -06:00
Jellyfrog 20b4215204 Swich links to https (#12511)
* Switch librenms links to https

* Convert librenms links in comments

* Switch gnu.org url to https

* switch php urls to https
2021-02-09 00:29:04 +01:00