Commit Graph

1042 Commits

Author SHA1 Message Date
Tony Murray
635d39a86f fix asterisk test data (#11378)
* fix test data
oops

* fix order

* one too many
2020-04-03 12:27:38 -05:00
Kevin Zink
b03c3bb996 Changed USV bypass state from alert to warning (#11356)
* Changed USV bypass state from alert to warning

* add /opt/librenms/tests/data/dell-ups_tower1000w.json

* add deltaups.json

* orvaldi-ups

* add generex-ups.json

* include two more generex-ups variants

* add eaton-mgeups_5px.json

* add tree more

* add istars.json

* restart hanging CI
2020-03-30 11:37:08 +02:00
Kevin Zink
ae4dae533f Cisco-Remote-Access-Monitor (#11355)
* Cisco-Remote-Access-Monitor

* add asa
2020-03-29 14:32:52 +02:00
cjwbath
a70313f3ee Sonus became Ribbon Communications - update logos (#11339)
* Sonus became Ribbon Communications - update logos

* minify

* Update ribbon.svg

* Create ribbon.svg

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 11:00:33 -05:00
Wheel
3e0e359f5b Ubiquiti Edgepower OS definition (#11315)
* Initial adding Ubiquiti EdgePower sensors

* Initial adding Ubiquiti EdgePower sensors

* Create airos-ep OS

* Added sensors

* Travis

* Added test / snmprec data

* Codeclimate

* minors

* Update ubnt.inc.php

* Update UBNT-EdgeMAX-MIB

* Update ubnt.inc.php

* Change Airos to EdgeOS

* Add forgotten files

* Test data

* Change os yaml

* Travis

* Update edgeos-ep.inc.php

* Create edgeos-ep.json

* Update edgeos-ep.yaml

* Update ubnt.inc.php

* Update airos.yaml

* Battery and PSU quantity not beeing displayed

* Rerun OS tests to generate json file

* Add high low temp values recommended by factory

* Add high low temp values recommended by factory

* Travis

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-03-24 09:13:04 -05:00
Tony Murray
df16de9d2f Refactor Datastores to allow future improvements. OpenTSDB Tags. (#11283)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues

* Make sure port data is stored the same way as before for Graphite and OpenTSDB
Add ifIndex tag to all to be compatible

* Missed rrdtool_tune() call

* Test update WIP

* OpenTSDB now includes tags

* fix style
2020-03-16 09:17:58 -05:00
crcro
2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
Tony Murray
746112acc4 Update Sophos detection (#11275) 2020-03-11 15:50:27 +01:00
PipoCanaja
0c1985b8b2 fix route tests (#11274) 2020-03-11 09:11:37 -05:00
Tony Murray
7fe895bd08 Revert "Refactor datastores to classes (#9179)" (#11273)
This reverts commit e5dad7a64e.
2020-03-11 07:52:52 -05:00
Tony Murray
e5dad7a64e Refactor datastores to classes (#9179)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues
2020-03-10 19:08:00 -05:00
Jay Shepherd
34924f6ad3 Add device support for SilverPeak (#11270)
* Add Silver Peak VXOA Device

Rename MIB Files
Update to use snmp_get_multi

* Add test data for Silverpeak
2020-03-10 22:48:20 +01:00
FingerlessGlov3s
dcc6b9ac0b Update OPNsense definition due to incorrect OID on second detection method (#11265)
* Update OPNsense snmprec, with real data

Update OPNsense snmprec, with real data.

Data from OPNsense 20.1.2 (Latest release at time of commit)

* Update OPNsense definition due to incorrect OID

sysObjectID is incorrect for OPNsense should be .1.3.6.1.4.1.8072.3.2.8.  for this snmpget detection to work.
This has been tested in my environment with 2 OPNsense Firewalls.
2020-03-09 20:45:47 +01:00
PipoCanaja
c4eb412e2e Collect average server CPU usage on Huawei RH servers (IBMC) (#11236)
* add average server main CPU(s) usage

* tests
2020-03-08 17:30:14 +01:00
Kevin Zink
3567386c48 Add Device: Innovaphone (#11225)
* Add Device: Innovaphone

* fix typo

* Move mib to subdir and Refresh testdata

* Fix typo

* Fix discovery index

* force test re-run

* Cleanup

* image

* Update innovaphone.yaml

* Update innovaphone.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-03-06 23:33:31 +01:00
PipoCanaja
5628b60f2c Extra VLAN mapping in bridge FDB module to fix HP ProCurve (#11230)
* Extra mapping for dot1qVlanFdbId to allow FDB VLANs to work on ProCurve
* Test data from joseUPV for ProCurve FDB VLANs
2020-03-05 17:52:01 +01:00
Dan Langille
c69b4a5898 Fix includes/defaults.inc.php references (#11249)
Now that includes/defaults.inc.php has gone away, refer to
misc/config_definitions.json instead.
2020-03-04 09:18:56 +01:00
PipoCanaja
6a3f321b69 Added support for Inteno devices (#11229)
* MIB

* fixMib

* sensors

* sensors

* cleaning

* tests
2020-03-03 09:45:22 +01:00
Kevin Zink
7254f13b26 Aruba cluster userfriendly read (#11217)
* Aruba-Instant: Include hostnames as a better identifier for mesh members sensors

* Refresh testdata
2020-02-27 15:35:28 -06:00
Neil Lathwood
e8f252de95 Added support for VLANs and FDB in AOS (#11145)
* Draft of Aos Script

* Changing to independant script

* Adding Aos6 vlan_dict and port_dict

* Adding Aos7 vlans module

* Adding Aos7 vlans module script

* Added Test data
2020-02-27 10:31:11 +00:00
Heath Barnhart
e83583f6f4 Adva FSP150cc Health Sensors (#11168)
* initial commit adding sensors

* changed dbm logic for port exclusions

* update mib, added xg116 support, update disc logic

* sfp health appears on ports page

* added sfp temps

* updated mib file names

* updated mib file names

* removed .mib extension

* replace ADVA-MIB

* Add test data

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-02-26 12:00:48 -06:00
FingerlessGlov3s
fe9deb9b9c Additional Open Sense detection (#11196)
* Update opnsense.yaml - too add discovery method

Update opnsense.yaml for new OPNsense OID called version.
This will help with detection after the user turns on "Display Verion in OID" within OPNsense

* Re-order to reduce snmp-scan.py time

First, check sysDescr for OPNsense.  Then if sysObjectID is 1.3.6.1.4.1.12325.1.1.2.1.1, run an snmpget

* Create opnsense_1.snmprec

Make up test file since data was not supplied

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-02-25 20:28:22 -06:00
Kevin Zink
3ce8ae5bad Aruba-Instant: Add the serial to aruba-instant devices (#11184)
* Add the serial to aruba-instant devices

* add test data

* add test for 105
2020-02-25 19:35:49 -06:00
PipoCanaja
3742e4f7ac Add basic support for PICA8 devices (#11185)
* mib

* os_support

* polling

* tests

* codeclimate
2020-02-26 01:28:56 +01:00
PipoCanaja
13e6a38ee4 Added Cambium PTP670 (#11186)
* cambium PTP670

* Wireless data

* space

* space
2020-02-26 01:28:40 +01:00
Tony Murray
b78084f1ba Fix invalid dnos test data (#11158)
It encoded non-ascii data in the test string
2020-02-16 17:49:06 -06:00
Tony Murray
dc9db06dff Fix SSO Auth test (#11155)
Because $dbuser is null here it causes PHP errors when using more strict modes.
So, just test that it is null.
2020-02-16 16:07:51 -06:00
JosÃe UPV
0f7bfb18ea Added Test data 2020-02-14 13:20:52 +01:00
joseUPV
dfd6f2d3b6 Aruba Controller ->Correct AP Power value (#11122)
* Correct AP Power value

* Added test data

* Added json test data
2020-02-12 18:24:33 +01:00
PipoCanaja
95820bf5d4 Improve Huawei VRP bgp discovery (#11054)
* vrp bgp rewrite

VRP BGP code isolated and VRF aware

Ipv6 peer and afi typo

* mib-update

* avoid malformed OIDs in discovery

* Restore BGP4 MIB calls for some Campus devices

* CodeClimate
2020-02-11 20:54:12 +01:00
Kevin Zink
083afd1422 device: Add serial number to Epson printer (#11111)
* Add serial to Epson printer
* add Testdata
2020-02-09 18:28:44 +01:00
PipoCanaja
385f5e0bc1 device: Support for Teldat routers (#11118)
* teldat base

* HW and version

* tests

* typo

* typo
2020-02-09 15:28:15 +01:00
Kevin Zink
f8ce4df0f8 Add Janitza Power Sensors (#11110)
* Add Janitza Power Sensors

* Fix testdata from previos bug
2020-02-07 09:11:46 +01:00
Jellyfrog
c380921d4b Speed up canAccessDevice/devicesForUser (#10992)
Relying on filtering on user_id/device_id with laravel/arrays is slow.
By splitting the cache on user_id, we can utilize faster array functions
2020-02-05 18:00:08 -06:00
Pluppo
b2d660efd8 Adding support for Cisco SB SX550X-24F switch (#11098)
* Adding support for Cisco SB SX550X-24F switch

This pull request adds support for Cisco Small Business SX550X-24F switch by adding sysObjectID .1.3.6.1.4.1.9.6.1.1001 in the ciscosb discovery module.

* Added ciscosb_sx550x-24f.snmprec file

* Added ciscosb_sx550x-24f.json

* Updated ciscosb_sx550x-24f.json

* update ciscosb_sx550x-24f.snmprec

* Collected new ciscosb_sx550x-24f.snmprec file

* updated test data
2020-02-06 00:35:21 +01:00
Kevin Zink
4e18e8b5c1 Added rittal-cmc (LCP Plus) (#11091)
* Added rittal-cmc (LCP Plus)

skip_values opperand 'not_in_array' returns an error in pre-commit but in principal it's running. Can someone help?

1) LibreNMS\Tests\YamlTest::testDiscoveryDefinitionSchema
rittal-cmc.yaml does not validate. Violations:
[modules.sensors.fanspeed.data[0].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[0].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[1].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[2].skip_values[0].value] Array value found, but an integer or a string is required
[modules.sensors.temperature.data[3].skip_values[0].value] Array value found, but an integer or a string is required

* fix  Scrutinizer Inspection

* fix  codeclimate

* fix typo

* Update discovery_schema.json

To allow arrays in comparisons

* Control structures

* fix the pre-fix issues

* Typo in copy/paste

* Update rittal-cmc.json

* Unit1,2,3,4 and new snmprec, json have not changed

* Update rittal-cmc.json

Correct JSON data

* typo copy paste

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-02-05 13:23:54 +01:00
Joseph Tingiris
02bc15c206 Asterisk app: add IAX2 peer graphs (#11078)
* Asterisk app: add IAX2 peer graphs

* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274

* code climate, round 1

* clarified unit text

* code climate, round 2

* changes needed to properly generate test data

* linux_asterisk-v1 test data
2020-02-03 18:47:27 +01:00
Martijn Schmidt
07f3c91e6c Revert ironware BGP-peers changes from PR #10941 (#11096)
* Revert ironware BGP-peers changes from PR #10941.

* Regenerate test data without BGP4V2-MIB support.

* Initialise $local_ip

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-02-03 14:32:45 +01:00
Kevin Zink
ee72fa4d3c Added WUT Humidity and Temperature Sensors (#11053)
* Added WUT 57606,57613,57720

* Added os wut-*

* fixed MIB Names and try to generalize wut

* more general sysObjectID mapping, and mib directory

* Delete WUT-57606-MIB

* Delete WUT-57613-MIB

* Delete WUT-57720-MIB

* Rename wut-57613.snmprec to wut_57613.snmprec

* Rename wut-57720.snmprec to wut_57720.snmprec

* Rename wut-57606.snmprec to wut_57606.snmprec

* Delete wut-57606.yaml

* Delete wut-57720.yaml

* Delete wut-57613.yaml

* Delete wut-57606.yaml

* Delete wut-57720.yaml

* Delete wut-57613.yaml

* Update wut.yaml

* Try to correct the Temperature part

This should work for temperature, according to MIB. Pressure and Humidity are not described in this mibfile, so we cannot poll them.

* change wut.yaml

* Add and fix wut_57720

* after ./scripts/save-test-data.php ?

* Add test data

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-02-01 23:29:05 +01:00
Martijn Schmidt
a64bd45dbc Update IronWare sensors & bgp-peers discovery, allow skip_values to target a specific index appended to the OID (#10941)
* Migrate ironware sensor discovery from php to yaml.

* More sensors, add grouping.

* dynamic_discovery_get_value() becomes getValueFromData()

* Target a specific index with skip_values.

* Improve Brocade BGP session discovery/polling

This commit allows for the correct discovery of BGP sessions
with 32-bit ASNs, IPv6 neighbors using the BGP4V2-MIB which is
based on draft-ietf-idr-bgp4-mibv2-11 and also polls for IPv4
unicast received routes through the FOUNDRY-SN-BGP4-GROUP-MIB.

Copied most of the code from PR#8877 by @Mikeburke14, cleaned
up the code a little bit to match the normal LibreNMS style,
and fixed bgpPeers_cbgp discovery as well as polling for the
ipv4.unicast neighbors.

Note that older Brocade IronWare firmware versions are known
to have multiple defects relating to the BGP4V2-MIB which
might result in certain missing non-established neighbors.

Related vendor defect numbers:

- DEFECT000633962
-- Symptom: The OID bgp4V2PeerAdminStatus does not return the
            correct value
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00g

- DEFECT000583319
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
            does not display all the BGP entries
-- Reported: NI 05.6.00
-- Resolved: NI 05.8.00e

- DEFECT000550309
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
            does not display the full information
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00c

* Add ironware CER & ICX platform test data.

* Re-add ironware.json compatible with current master branch.
2020-02-01 23:28:03 +01:00
Joseph Tingiris
1535d6589d mock.snmp.inc.php: Fix snmptranslate exception (#11085)
* Running ./scripts/pre-commit.php -p -u [-m applications] fails all tests that have 1.3.6.1.4.1.8072 with messages similar to ...

Exception: Could not translate oid: NET-SNMP-EXTEND-MIB::nsExtendOutput1Line."distro"
Tried: snmptranslate -IR -On NET-SNMP-EXTEND-MIB::nsExtendOutput1Line."distro" -M /opt/librenms/mibs

* OIDs with double quotes must be single quoted.  All OID translations work with single quotes, regardless.
2020-01-31 15:07:45 +01:00
Tony Murray
67b28ec4cd Fix Air Fiber port stats (#11079)
* Fix Air Fiber port stats
Define OS port polling includes in a standard way.
Move Air Fiber code to os port polling include.

* Update snmp data

* fix accidental change

* Some formatting fixes

* should be null
2020-01-30 05:40:58 -06:00
HostIRE
761d105847 Added OS definition and discovery for SIAE Alfo80HD (#11063)
* Added definition and sensors for SIAE Alfoplus80HD

* updated the units for the wireless rate sensor

* Added test data

* regenerated test data as requested by PipoCanaja
2020-01-27 19:39:52 +01:00
LEV82
71ccb6a15c Updated test data for arubaos, fs-switch, ifotec, lcos, siklu and trendnet, to pass Travis tests (#11067)
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent

* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent

* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent

* Updated test data for arubaos, fs-switch, ifotec, lcos, siklu and trendnet, to pass Travis tests

* Updated test data for arubaos, fs-switch, ifotec, lcos, siklu and trendnet, to pass Travis tests
2020-01-25 07:39:45 -06:00
Heath Barnhart
59f4491afc SNMP Traps for Juniper Power Supplies (#10965)
* Juniper Power Supply Trap Handlers

* Added unit test

* fixed tests
2020-01-24 05:59:59 -06:00
LEV82
9ce7c83caa Add bad_ifoperstatus for filtering interfaces having a status for example 'notPresent' (#10977)
* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent

* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent

* Add bad_ifoperstatus for filtering interfaces having a status for example notPresent
2020-01-24 05:58:01 -06:00
JohnSPeach
2960fc10f5 Add sensors to Infoblox discovery (nios.yaml) (#11043)
* Update nios.yaml

I tried to pull them all in using {{ index }}, but it didn't actually work.....
This adds the DHCP, DNS and NTP service statuses.

* Dynamic service discovery

* typo

* Create nios_status.snmprec

* Create nios_status.json

* Array

* Typo, more

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-01-24 00:33:41 +01:00
Josh Baird
1c043069b1 Fixed Siklu Voltage Sensor (#10997)
* Fix Siklu Voltage

* Update tests

* Another test fix attempt

* Decimals..

* Ok, enough.

* Restore currently used index value and correctly push num_oid

* Update siklu.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-01-22 09:32:39 +00:00
Vitali Kari
f4a9787178 Added Zyxel MGS-3712 Sensors (#11050)
* intermediate commit
* test data
2020-01-19 22:01:17 +01:00
Misha Komarovskiy
25677e5edc Updated IOS-XR with NCS-5500 support for HW and version (#11044)
* Add version match for newer IOS-XR NCS hardware

* Tested with NCS-5504 and NCS5508

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>

* Add test data for Cisco NCS-5504 and NCS-5508

Signed-off-by: Misha Komarovskiy <zombah@gmail.com>
2020-01-17 20:04:27 +01:00