Commit Graph

19264 Commits

Author SHA1 Message Date
Tony Murray
19e0ad604a PHP8 phpstan fix (#13843) 2022-03-11 10:38:31 -06:00
Charly Forot
e280ea1c8d [new OS] Alpine OptoElectronics TDCM-EDFA support (#13825)
* add alpine optoelectronics mibs for tcdm-edfa

* add alpine optoelectronics logo

* add alpine optoelectronics icon

* add inital detection

* add yaml discovery file

* improve yaml discovery for webUI

* rename os to alpineoe

* rename files

* replace svg logos by png

* add success tests

* Revert "replace svg logos by png"

This reverts commit 71f3dacef6.

* Revert "Revert "replace svg logos by png""

This reverts commit cd4f4cf5e0.

* Revert "add success tests"

This reverts commit 27bb3a96e4.

* add success tests with right icon

* Remove sysDecr not necessary for discovery
2022-03-11 09:48:30 +01:00
Josh Silvas
a9e111f3eb Adds API call to update port notes on devices. (#13834)
* Adds API call to update port notes on devices.

* Lint fixes.

* Fixes file permissions to proper values.
2022-03-10 22:29:08 +01:00
Andy Norwood
061c2e94f4 Add APC upsOnBattery & powerRestored trap handler (#13836)
* Add new apc classes to snmptraps config

* Added new classsed

* Added onbattery handler

* Added Power Restored handler

* Add onbattery test

* Added powerRestored test

* style fixes

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2022-03-10 22:28:32 +01:00
Peca Nesovanovic
64b0c3faa3 [comware] dropped dbfetch from discovery/sensors (#13796)
* [comware] dropped dbfetch from discovery/sensors

* ci

* DeviceCache::getPrimary

* remove unneeded model

* Update includes/discovery/sensors/temperature/comware.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2022-03-10 21:31:40 +01:00
Andy Norwood
f7ca687ceb Add OspfTxRetransmit Trap Handler (#13824)
* OspfTxRetransmit class

* Message tidyup

* Initial test class

* add ospftxretransmit class

* add empty line

* chnage int to string in traptext

* new block to catch non lsupdates trap

* Add second test

* lint fail changes

* extra space removed
2022-03-10 21:29:23 +01:00
Tony Murray
b7d22a768b Fix snmpv3 context when empty SnmpQuery (#13832)
* Fix snmpv3 context when empty SnmpQuery
Fixes: #13820

* Cleaner fix
2022-03-10 21:27:09 +01:00
martinberg
24857b98ce Add VS state for Gaia (#13831)
* Added VS state

* Better naming

* Updated test data
2022-03-10 21:24:56 +01:00
Andy Norwood
20e64d792c Add APC SmartAvrReducing trap handlers (#13839)
* add new classes

* add AvrReducing handler

* Add AvrReducing Test

* add AvrReducingOff handler

* add AvrReducingOff Test
2022-03-10 21:13:09 +01:00
Charly Forot
48e68ec1dd Fix class error name (#13833)
Mistake on $class variable, value was 'er' instead of 'ber'.
This error prevented the ber graph located at Devices->Health->Overview
to correctly appear.
2022-03-09 00:06:19 +01:00
Loic pailhas
a04f4bce50 fix db delete on cisco-vrf-lite discovery (#13823) 2022-03-08 07:18:45 -06:00
Jellyfrog
42c16de54c Fix tests for MariaDB > 10.5.15 (#13829) 2022-03-06 19:52:50 +01:00
Jellyfrog
5ffbceb7e8 Regression fix from b6a8b602b8 for location population (#13819) 2022-03-02 23:37:52 +00:00
Mark Westerterp
86a504e675 Fix Oxidized Config tab showing when Device OS or Device Type is disabled (#13809)
* Fix Oxidized Config tab showing when Device OS or Device Type is disabled

Fixes https://github.com/librenms/librenms/issues/13808

* StyleCI

* Apply Jellyfrogs suggestion to simplify the code
2022-02-27 10:56:33 +01:00
bonzo81
d07e3d6148 Cisco Mac address violation trap handler (#13811)
* Secure MAC Violation event

* Add Cisco Port Sec Mib

* Add CiscoMacViolation class

* removed $ifIndex and $port reference

* change ifDescr for ifName

* New test

* style fix
2022-02-26 20:39:03 +01:00
Hans Erasmus
1e9adb38b2 Add rocky linux OS identification (#13815) 2022-02-25 13:19:08 +01:00
Simon Smith
b8736fa758 Detect truenas scale (#13812)
detect truenas scale
2022-02-24 23:51:35 +01:00
Neil Lathwood
703745d0ed Resolved XSS issue from alert rule list modal (#13805) 2022-02-22 08:28:31 -06:00
Jellyfrog
09929bd686 Implement OAuth and SAML2 support (#13764)
* Implement OAuth and SAML2 support via Socialite

* Add socialite docs

* fixes

* Additional information added

* wip

* 22.3.0 targeted version

* Allow mysql auth as long as there is a password saved

Co-authored-by: laf <gh+n@laf.io>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-02-20 22:05:51 +01:00
Joel Wilson
2e5b343731 Add usage hints for Display Name placeholder usage (#13801) 2022-02-20 12:59:53 -06:00
Wolfgang Steudel
249e5e69b0 Correct divisor in discovery definition for Verity PDUs (#13768)
* Update vertiv-pdu.yaml

VERTIV-V5-MIB states UNITS "decivolts (rms)" for pduPhaseVoltage

* Update vertiv-pdu_mn03edr1.json

Updated test data

Co-authored-by: Neil Lathwood <gh+n@laf.io>
2022-02-18 16:58:04 +00:00
Mark Westerterp
1df78d9503 UI: Fix second menu bar in Apps screens (#13800)
* Fix bug introduced in 2016
Introduced when changing over from tables to divs.
Caused by commit: bda31d7152

* Apps: bring second menu bar in line with main menu
Scope limited to applications

* Style fixes
2022-02-18 09:19:36 -06:00
Jellyfrog
513fbf06e2 Add MIB to OS helper to tests (#13795) 2022-02-18 09:17:40 -06:00
Dan Langille
0c08670acc Bump version to 22.2.1 (#13798)
* Bump version to 22.2.0

This was missed?

* Update Version.php

Co-authored-by: Neil Lathwood <gh+n@laf.io>
22.2.1
2022-02-18 09:12:46 +00:00
PipoCanaja
6ac13825ce Improved search results for port descriptions (#13787)
* restore pre Dec 6 2021 Description display

* restore full ifAlias

* patch from fbourqui to fix type display
2022-02-17 20:57:51 +00:00
Jellyfrog
d8f96a46b0 Fix PHPStan Deprecated test (#13794) 2022-02-16 07:10:32 -06:00
Neil Lathwood
39dde372d9 Added 22.2.0 changelog (#13797) 22.2.0 2022-02-16 10:10:32 +00:00
Jellyfrog
681c994ca1 Docs tweaking (#13792)
* Tweak updating page

* Cleanup docs
2022-02-16 02:43:48 +01:00
Jellyfrog
7c99599b2a Set default DB_TEST_PORT (#13793) 2022-02-16 02:43:11 +01:00
Peca Nesovanovic
700c6ae9c3 [pbn] dropped dbfetch from discovery/sensors (#13789) 2022-02-15 22:39:23 +01:00
Peca Nesovanovic
8b831f5c6f [junos] dropped dbfetch from discovery/sensors (#13784)
* [junos] dropped dbfetch from discovery/sensors

* ci
2022-02-14 23:06:34 +01:00
Knut Petter Ølberg
3926f1aaff Update Switching.md (#13786)
Fix typo in example
2022-02-14 23:05:20 +01:00
PipoCanaja
f24bb42cb2 Hide community and make it XSS safer (#13783)
* sanitize message display

* sanitize message display

* safe display of community, and community hidden until focus occurs
2022-02-14 13:03:01 +00:00
Guilherme Poletto
18ca4566eb New sensors for huawei vrp <tested on NE8000 platform> (#13352)
* Add EntityVoltage Sensors

* Add BoardPower Sensors

* Add Fanspeed Percent sensor

* Add Voltage_Status and Temperature_Status Normal|Minor|Major|Critical indicators, and internal Voltage and Temperature sensors

* set Minor alarm violations to warning status

* remove inconsistently applied empty lines between sections, and trailing newline that caused errors

* fetch thresholds for temperature.sensors and optical.RxPower from SNMP

* Added snmp testfiles for ne8000-m8 variant of VRP platform

* group sensors by card-identifier

* Regenerate testfiles for 5720-32x-ei

* Regenerate testfiles for the whole VRP family

* Optical Bias is reported as miliamps-mA, and not microamps-uA

* Implement divisor detection, VRP or NE8 prepended on sensor for debug-testing

* remove VRP or NE8 prependeds on sensors(put there for debug/testing only)

* use parent OIDs for walking and naming

* ignore per-slot power if unsupported

* regenerated snmp json testfiles

* sanitize bgp-peers value

* restore vrp.json test

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-02-14 10:05:18 +01:00
Neil Lathwood
95970af78e Moved some pages to be within admin route (#13782)
* Moved plugin admin pages to be within admin route
* Wrap html transports page in admin check
* Moved Port group controller to be admin protected
* fixed tests
2022-02-14 08:40:30 +01:00
PipoCanaja
4c9d4eefd8 XSS fixes (#13780) 2022-02-13 20:54:58 +00:00
PipoCanaja
41ddce6377 XSS fix, cont. again (#13778)
* XSS in alert template creation

* XSS in alert rule name

* XSS in service name & desc

* style

* strip_tags in alert_notes

* strip_tags in create_alert_item

* strip_tags in addsrv page
2022-02-13 20:23:07 +01:00
Peca Nesovanovic
0029e9f161 [refactor] Eloquent for includes/html/pages/device/health.inc.php (#13777)
* [rewrite] includes/html/pages/device/health.inc.php
* translate sensor names
* ci
2022-02-13 19:20:47 +01:00
PipoCanaja
4f86915866 XSS fix, cont. (#13776)
https://huntr.dev/bounties/13951f51-deed-4a3d-8275-52306cc5a87d/
2022-02-13 19:07:37 +01:00
PipoCanaja
3ac0de16b2 STP - various fixes (#13773)
* Filter fix
* Add link to device for bridge address and designated root if available
2022-02-13 19:04:12 +01:00
dependabot[bot]
3fb4233c05 Bump follow-redirects from 1.14.7 to 1.14.8 (#13774)
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8.
- [Release notes](https://github.com/follow-redirects/follow-redirects/releases)
- [Commits](https://github.com/follow-redirects/follow-redirects/compare/v1.14.7...v1.14.8)

---
updated-dependencies:
- dependency-name: follow-redirects
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-02-13 11:48:15 +01:00
PipoCanaja
135717a9a0 security - XSS Fix 01
fixing https://huntr.dev/bounties/114ba055-a2f0-4db9-aafb-95df944ba177/ (#13775)
2022-02-13 11:00:56 +01:00
Peca Nesovanovic
c7b63b574f [widget] Top Devices (#13748)
* count only UP ports

* ci
2022-02-12 23:39:17 +01:00
Heath Barnhart
978cd75a32 SNMP Traps: Brocade login traps (#13770)
* initial push

* Some modifications for unit tests
2022-02-12 16:42:28 +01:00
Jellyfrog
67c68b5965 Bump test timeout to 2 hours (#13769) 2022-02-11 09:10:33 -06:00
Tony Murray
7f63737567 add missing icons for progressive web app notifications (#13771) 2022-02-11 16:06:20 +01:00
Tony Murray
b9f3646a2e STP fix, only try contexts on Cisco (#13767)
* STP fix, only try contexts on Cisco
Only Cisco is known to support this type of polling

* merge, not push.

* Fix collection construction

* Fixed the function signature in Interface def

* fixed signature here as well

* Lighter code to return a collection of Stp instances

* Type enforced in signatures

* missing implement for Cisco Class

* style

* Collection methods are immutable indeed 😠

* nullable vlan

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-02-11 08:37:19 -06:00
Santiago Z
7d2ade71f1 [WebUI] Show selected selection option on graphs page (#13765) 2022-02-11 11:06:41 +01:00
Jellyfrog
af98992f9c Upgrade to font awesome 6 (#13760) 2022-02-10 20:33:42 +01:00
flo
a49ee59c06 Fix links to connected devices in old style maps (#13762)
When using the old style maps when you click on one of the connected
devices (bubbles on the right side) the link points to
$HOSTNAME//device... looking at other examples base_url seems to
include the trailing slash. Removing the additional slash fixes the
links for me.
2022-02-10 00:41:47 +01:00