Commit Graph

2731 Commits

Author SHA1 Message Date
angryp
82072b3694 Fix for get_alert API method. Tested on MySQL-community 5.7.22 and MariaDB 10.2.14. (#8658) 2018-05-04 23:51:04 -05:00
Neil Lathwood
80ef4d4324 Fixed clicking notes on device alerts page (#8629) 2018-04-27 11:58:07 -05:00
Tony Murray
c88d28c10a Always update the alert note when acknowledging (#8620)
and unacknowledging
2018-04-27 14:28:08 +01:00
Neil Lathwood
1eee6e8195 alert: Added ability to make notes for acking alerts + record who did so (#8433)
* alert: Added ability to make notes for acking alerts + record who did so

* Updated schema

* moved sql file

* Updated from comments in PR

* warning changed to blue

* reset notes + keep notes on ack
2018-04-26 00:00:56 -05:00
Hans Erasmus
163c595494 feature: Added a third graph to unbound with more metrics (#8616)
* Added a third graph to unbound with more metrics

* Update unbound.inc.php

* Reset composer.lock

* Update unbound.inc.php

* Update unbound.inc.php
2018-04-25 20:52:12 +01:00
Tony Murray
b41e32c7aa Fix missing use statements (#8614) 2018-04-24 21:20:21 -05:00
Sander Steffann
65b8270936 feature: Added random entropy support for applications (#8555) 2018-04-13 17:42:14 +01:00
Paul Heinrichs
ff0063b515 api: Add option to output graphs as base64 (#8535)
* Allow 'option' param in graph endpoint

* Update lint and update docs

* Uncomment api response

* Add imagedestroy on 'tobias_trim' section

* Add base64 to port endpoints also
2018-04-11 08:02:04 -05:00
Tony Murray
7250376104 refactor: Don't access $_SESSION directly for Auth (#8513)
* Don't access $_SESSION directly for Auth

* fix style

* add property annotations
2018-04-07 21:55:28 +01:00
Adam Winberg
2ece84495d webui: Improved fdb search (#8251)
* sort fdb search by number of mac addresses/port to show most likely endpoint switchport first in list. Also add IP search to fdb search

* fix style check error
2018-04-07 20:14:28 +01:00
sorribes22
c22b31506e api: Added lattitude and longitude on devices/device fetch (#8515)
* 'lat' and 'lng' columns added on list_devices()

* 'lat' and 'lng' columns added on device fetch

Helped by https://github.com/laf

* Commit user.name changed
2018-04-07 13:29:46 +01:00
Aldemir Akpinar
18101a93d5 webui: Use toastr for operational messages on alert templates page (#8499)
* webui: Use toastr for operational messages

* Reload template table after insert/update

* Trying to fix travis ci error

* Change error checking to librenms standard
2018-04-07 13:22:08 +01:00
Tony Murray
85d0e3b98e refactor: Move nested defaults to Config::processConfig() (#8429)
* Move nested defaults to Config::processConfig()

Fixes log_file when users set log_dir for example.

Removed stuff:
mibdir
dp_autocreate
base_url: setting http/https before config.php is loaded...
moved collectd setting to it's own config file

* add base_url mod back.
I thought that since definitions is called before config.php it was useless, but it changes the built in definition between http and https.
2018-04-03 15:53:25 +01:00
Tony Murray
214472ba89 refactor: rename array_sort() to avoid function collision (#8494) 2018-04-01 21:27:41 +01:00
Tony Murray
04e24d4671 webui: Alert builder layout optimsation (#8489)
* Alert builder: don't waste space
More space for the ui elements when the dialog is large.
Stop the import button from overlapping things when the dialog is extra small.

* Add divider to alert menubar
2018-03-29 20:57:41 +01:00
Wheel
b1ec1d14f0 webui: Added override default device grouping radius (#8485)
* Override default device grouping radius

Added an option to override the default group_radius 80. Usefull in fullscreenmap

* Update worldmap.inc.php

* Update worldmap.inc.php
2018-03-29 12:05:38 +01:00
Tony Murray
fb701bc1b4 Defaults for alert collection rules (#8474)
Better error message if rule with same name exists.
2018-03-28 22:11:57 -05:00
Tony Murray
d91fe84fc3 Change the default alert delay to 1m (#8462)
Add regex type for numbers
Tooltips for all alert rule dialog items
2018-03-28 22:10:54 -05:00
Michael Corcoran
97d58cc121 fix:: Fixed display of WD drives for smart application (#8471)
WD drives have a dash in the serial number, e.g. WD-WCCXXXXXXXXX.
The librenms-agent script changed to using serial numbers in
librenms/librenms-agent@3a84624615
As we split the name by the same char, we discarded everything after WD,
which made all WD drives in the system appear as one, and broke the generated
links.
2018-03-26 14:36:38 +01:00
Maurice den Braber
9f5b42b028 webui: Allow full search on devices page (#8364)
* Update devices.inc.php

* Update devices.inc.php

* Replace $_POST with $vars

Better protection for SQL injection attempts; Need to verify other files for same issue.

* Fixed whitespace.

*sigh*

* More search options & sql injection fixes.

+Allow full search on devices page;
+Allow sysName search on alertlog page;
+Allow sysName search on alerts page;
+Allow sysName search on eventlog page;
+Allow sysName search on poll-log page;
+Allow sysName search on ports page;

*Replaced all occurrences of $_POST with $vars in librenms/html/includes/table. ($vars are sanity-checked).

* Whitespace fix

* Fixed $where & $param

* Add files via upload

* Whitespaces....

Sometimes you want'em, sometimes you hate'em.
2018-03-25 21:50:09 +01:00
Neil Lathwood
544b363951 alert: Added support for disabling recovery notifications (#8430)
* alert: Added support for disabling recovery notifications

* reversed use of recovery

* removed debug + small update
2018-03-22 12:38:16 -05:00
Mike Rostermund
e13920cdc8 Fix typo (#8444) 2018-03-21 15:10:20 -05:00
Tony Murray
8cc8eb8dd2 refactor: Use elseif instead of else if (#8417) 2018-03-19 21:40:17 +00:00
Dag Bakke
af39200c41 Borderless fullscreen geographical map, with just the nodes. (#8337)
* Added a variant of map.php which allows for a borderless fullscreen geographical map, with just the nodes.

* Signed my work.

* Removed a space.

* delete whitespace

* remove whitespace

* hack to fix some tiles not loading

found the fix here:
https://stackoverflow.com/questions/36246815/data-toggle-tab-does-not-download-leaflet-map/36257493#36257493
https://gis.stackexchange.com/questions/224932/problem-with-map-tiles-loading-with-leaflet-and-bootstrap

You might be able to do something more elegant.

* added menu entry

This removes the need for setting it as a front-page. Now it can be accessed from the menu and LibreNMS can be accessed by navigating back.

* Create fullscreenmap.inc.php

Notice the line:
$pagetitle[] = 'Fullscreen Map';

* REmoved the original fullscreenmap.php

* Revert "REmoved the original fullscreenmap.php"

This reverts commit 570953c5f5.

* addded the resize event to html/pages/fullscreenmap.inc.php for proper leaflet rendering

* Removed old file

* Adjusted CSS and javascript.

* Reverting to original javascript.

* change Leaflet container CSS to white background

* Made the Geographical Map not hide the menu when not in fullscreen mode.

* Cleaned up the CSS-file a bit.

* Added a variant of map.php which allows for a borderless fullscreen geographical map, with just the nodes.

* Signed my work.

* Removed a space.

* delete whitespace

* remove whitespace

* hack to fix some tiles not loading

found the fix here:
https://stackoverflow.com/questions/36246815/data-toggle-tab-does-not-download-leaflet-map/36257493#36257493
https://gis.stackexchange.com/questions/224932/problem-with-map-tiles-loading-with-leaflet-and-bootstrap

You might be able to do something more elegant.

* added menu entry

This removes the need for setting it as a front-page. Now it can be accessed from the menu and LibreNMS can be accessed by navigating back.

* Create fullscreenmap.inc.php

Notice the line:
$pagetitle[] = 'Fullscreen Map';

* REmoved the original fullscreenmap.php

* Revert "REmoved the original fullscreenmap.php"

This reverts commit 570953c5f5.

* addded the resize event to html/pages/fullscreenmap.inc.php for proper leaflet rendering

* Removed old file

* Adjusted CSS and javascript.

* Reverting to original javascript.

* change Leaflet container CSS to white background

* Made the Geographical Map not hide the menu when not in fullscreen mode.

* Cleaned up the CSS-file a bit.
2018-03-18 22:47:06 -05:00
Tony Murray
8890010766 Disable in/not in they don't display right (#8378) 2018-03-14 20:03:58 -05:00
Neil Lathwood
66a3f82269 Fix NOT REGEXP rules (#8376)
* Fix NOT REGEXP rules

* not_regex -> not regex

* Fixed saving rules as well
2018-03-14 21:53:47 +00:00
Neil Lathwood
03076c4025 feature: Added new alert rule builder UI and rule mapping UI (#8293)
* feature: Added new alert rule builder UI

* Updated to export sql queries

* More updates

* more changes

* removed debug

* fix scrut

* Updated to include import options + various other fixes

* fix rule

* Populate name from collection rules.

* Fix default rule import
Allow new and old style rules in the collection.
Don't add new yet as I'm not sure GenSQL() is working.

* Fix GenSQL call

* Extract filter building to class so it is nicely contained in one place

* moved schema

* some fixes and tweaks

* travis fixes

* Some more features / updates

* Fix up my mistakes when adding default rules

* Use a modal for new alert (Incomplete)
Larger dialog!!
Remove page loading stuff.

Working:
Loading rules, resetting dialog, importing from collection.

Not working yet:
select width
device limited rule access? don't know what this is...

Lots of unused stuff to delete...

* reload "table" after save

* fixed editing rule

* Auto select2 width

* Reload window on save

* Restore per-device alert. Remove debug.

* Small cleanups. Rule Name first.

* Restore button to button type. Rename schema.

* Fixes: wrong command to reload window, remove extra attributes, rule is never passed

* Fixed old rule editing

* some small updates for old imports

* travis update to use trusty

* maybe travis fix

* Ability to set alert rule mappings on the rule edit screen

* pip installs one line, no quiet for deploy

* update schema def

* Fix style and some copyright headers

* fix docs missing file

* Allow new versions of snmpsim and libraries

* Parser WIP

* Fix default rules insert

* reorganize

* Legacy import first draft done

* Implement saving
Skip translation to sql for now

* Working on glues

* small rule collection fix

* Working on glues

* Working on glues

* Docs updates + small UI changes

* Parser WIP

* reorganize

* Legacy import first draft done

* Implement saving
Skip translation to sql for now

* Working on glues

* Working on glues

* Working on glues

* Add table mapping, should move to it's own class

* WIP

* Glue working!!

* Extract Schema class

* Some final touches.
revert alerts_rules.json for now.

* Finish up initial implementation
Needs more tests

* Fix a few places

* small doc updates

* Fix finding tables in grouped rules.

* remove unused code

* code format fixes

* Some quick tests for Schema
Simplified output for findRelationshipPath. Always includes start and target in the result.
This simplifies a lot of code in QueryBuilderParser.php
This also always loads the target table data now (which we want)

* Make bill_id the PRIMARY index for the bills table

* Load macros from a json file in misc instead of the database.

* Fix whitespace and wrong key for collection.

* Handle IN properly when generating SQL

* Fix glue (devices.device_id = ports.port_id) is incorrect :D
Show ALL tables we can resolve relationships for in the query builder filter.

* Remove all macros from the database
Remove insert statements, leave updates to update user's existing rules.
2018-03-14 20:25:19 +00:00
Søren Rosiak
ba4c86f4c0 webui: Added Oxidized reload node list button (#8375) 2018-03-14 20:17:08 +00:00
endofline
b70ff543bf webui: S.M.A.R.T visualization improvements (#8310)
* Increase description length in graphs
* Add SMART attr177, previously recorded, but not displayed
* Change the multi-graph titles to better reflect their content
* Change SMART attr numbers to a more human-friendly description
* Minor text corrections
2018-03-13 13:26:23 +00:00
BlackDex
5af51fa46f webui: Added auto width and height dimensions parameters to generic image dashboard widget (#8314)
Added the ability to substituted special parameters for width and height of the Generic-image widget to be added to an Image URL.
2018-03-01 22:12:46 +00:00
Nils Büchner
59f99f1962 api: Added routes to delete,add/edit traffic bills (#8272)
* add API calls to delete,add/edit traffic bills

* scrutinizer fixes

* app needed

* explicitly use === null

* requested changes
2018-02-27 19:51:29 +00:00
Richard Lawley
10829893ec api: Added Billing Graphs & Data (#8245)
* Move Billing/Bandwidth Graphs to common format, extract data generation to central function

* Add API functions to access billing graphs and graph data

* Scrutinizer fixes

* Fix transfer graphs with from/to

* Scrutinizer Fix

* Fix docs, transfer page and missing from API param

* Document and fix reducefactor, Add Graph Stats to Graph Data

* Standardise times in graphdata

* Fixed renamed function for History GraphData
2018-02-20 14:57:56 +00:00
Tony Murray
6887d771aa device: Added CeraOS wireless sensors (#8167)
* CeraOS wireless sensors

* Add CeraOS test data, fix MSE

* fix whitespace
2018-02-18 21:31:18 +00:00
James Andrewartha
8ae48d9543 webui: Allow sorting by toner and searching (#8247)
* Allow sorting by toner

* Add support for searching toner

* Fix up off-by-one error with background colour

* Allow sorting by the bar column too
2018-02-18 20:51:46 +00:00
Rémy Jacquin
8d4fca33b1 webui: Devices in maintenance show as blue on worldmap widget (#8207)
* Added new worldmap widget setting:
The user can chose how down devices under maintenance are shown
Signed-off-by: Rémy Jacquin <remy@remyj.fr>

* Added documentation related to this feature

Signed-off-by: Rémy Jacquin <remy@remyj.fr>

* Change icon to light blue and remove option
Reverted "Added new worldmap widget setting"
Signed-off-by: Rémy Jacquin <remy@remyj.fr>
2018-02-18 20:43:24 +00:00
Richard Mayhew
df724a78b7 webui: Fix panel device header for themes (#8238)
* New event log severity model

* Revert "New event log severity model"

This reverts commit 0783527af8.

* Fixed Panel Bar - #8157

* Reverted back the counter
2018-02-12 15:50:16 +00:00
Tony Murray
561846a44b fix: Fiedx issues with new config init (#8242)
* Fix non-config defaults

* update processConfig and remove file
2018-02-12 09:15:44 +00:00
Neil Lathwood
31fe743273 fix: Fixed the HTML Purifier config so allowed values work (#8239) 2018-02-10 21:27:04 -06:00
Tom Sealey
2f6f99a330 feature: Added gateone link SSH support (#8189)
* adding gateone link

* Added gateone support, now checks config.php for settings

* adding gateone link

* Added gateone support, now checks config.php for settings

* fixed an incorrect url

* fixed syntax errors

* added new option to config.php, $config[gateone][use_librenms_user] is a boolean that inserts the logged in Librenms user to the SSH link if set to true

* removed code duplication

* removed hostbox-menu.inc.php
2018-02-10 20:51:26 +00:00
Aldemir Akpinar
5880f06780 webui: Added sysNames to pulldowns and the main page (#8137)
* Add dependency info for api

* webui: made dev dependency list more like devices page. Also added sysNames to pulldowns and the manin page

* Create common function for sysname display

* A better function name
2018-02-10 13:18:53 +00:00
Richard Lawley
2018c9f804 api: Added History to Billing API Functions (#8209)
* Add Previous Period options to Bill API functions

* Add Bill History API Functions
2018-02-09 21:14:55 +00:00
Martin Nilsson
2bd88a2f2b device: Added support for OpenBSD PF states (#8211)
* First basic support for graphing openbsd pf states

* Now openbsd pf state graphing actually works

* First basic support for graphing openbsd pf states

* Now openbsd pf state graphing actually works

* Wrong graph types for searches, removals and inserts

* Removed unused file "openbsd_pfstates.inc.php"

* Remove openbsd from filenames, make it more generic
2018-02-08 20:54:29 +00:00
Tony Murray
e00597db10 Case insensitive alert rule searching (#8231) 2018-02-08 08:49:19 -06:00
Maurice den Braber
1cdb37d416 Update notes.inc.php (#8219)
Allow from iframe border removal by allowing frameborder attribute.
2018-02-08 08:38:59 -06:00
Tony Murray
6bbe5038e8 fix linkify to work with with ip addresses (#8226)
* fix linkify to work with with ip addresses

* update tests
2018-02-07 20:48:18 -06:00
dnapper
a347e7c8d3 F5 gtm support (#8161)
* initial

* commited correct version of f5-ltm-inc.php

* cleaned up comments

* cleaned up formating for travis

* split GTM discovery from LTM discovery module

* removed blank line at EOF

* updated per comments
2018-02-01 23:35:23 -06:00
Leandro Maciel
06aa3b23f2 change is_file to rrdtool_check_rrd_exists. (#8169) 2018-01-29 09:52:22 -06:00
Leandro Maciel
e95308208f fix: Changed is_file to rrdtool_check_rrd_exists in php-fpm and squid applications graphs. (#8152)
* changed is_file to rrdtool_check_rrd_exists

* changed is_file to rrdtool_check_rrd_exists

* changed is_file to rrdtool_check_rrd_exists

* changed is_file to rrdtool_check_rrd_exists

* changed is_file to rrdtool_check_rrd_exists
2018-01-26 20:52:52 +00:00
tukezor
0a6f113f5a device: Improved FortiManager support (#8102)
Modified with suggested changes

Test data for FortiOS
2018-01-24 09:37:27 +00:00
Neil Lathwood
87ce23bccd fix: Specify table name for list_devices sql query (#8132) 2018-01-22 21:10:39 +00:00