Commit Graph

698 Commits

Author SHA1 Message Date
Tobias Heister
728bc5f790 Improved RARITAN PDU/PDU2 MIB (current, power) and external env. sensors (#10616)
* added support for PDU/PDU2 MIB data (current, power) and added external sensor fpr humidity and temperature on PDU MIB

* added test data of 1 PDU-MIB device and 1 PDU2-MIB device

* Create raritan-pdu.json

* forgot to do save-data on last commit
2019-10-20 21:26:40 +00:00
Vitali Kari
4990c871d6 do not discover dbm sensors on shutdown ports (#10610) 2019-09-18 12:39:52 +00:00
Søren Rosiak
9768790440 CiscoSB: Skip notPresent ports from state sensors (#10545)
* CiscoSB: Skip notPresent ports from state sensors

* Update ciscosb.inc.php

* Create ciscosb_sg350x-48.json
2019-09-14 23:43:08 +02:00
Martijn Schmidt
3a891ba727 Convert opengear to YAML-based discovery, add some new sensors, add test data (#10553)
* Update opengear MIBs to latest version.

* Replace PHP signal discovery with YAML.

* Update Opengear YAML with new sensors.

* Add test data for Opengear.

* Add the test data json for Opengear.

* Named to numbered index to avoid data loss.
2019-08-27 16:54:08 -05:00
Martin Zatloukal
f16805b71d Added support Ericsson MINI-LINK (#10546)
* Added support Ericsson MINI-LINK
* cleaning
2019-08-22 13:19:50 +02:00
ig0rb
3342210067 FS.net pdu (#10424)
* Added support for snmp monitored PDU from fs.com

* Added support for snmp monitored PDU from fs.com

* Fix sysObjectID 1.3.6.1.4.1.30966

* Create fs-net-pdu.json
2019-07-23 22:55:53 -05:00
CirnoT
cafcf417fa Fix NetAgent II battery voltage (#10427)
* Fix NetAgent II battery voltage

* Add new test data and new icon for NetAgent
2019-07-22 23:34:31 -05:00
bergroth
b085703b2d Added support for DGD and BER on newer infinera-groove FW (#10435)
* Added support for DGD and BER that are avalible on newer infinera-groove FW
* updated tests for new groove sensors
* Update infinera-groove.inc.php
* Update infinera-groove.inc.php
* Force test to run again
2019-07-15 12:47:41 +02:00
ospfbgp
fc2f0a4552 Updated RAPID-CITY mib for Extreme VSP (#10406)
* Add files via upload

* Update voss.inc.php

* Update voss.inc.php

* Update voss.yaml

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss_7432cq.json

* Update voss_7432cq.json

* Add files via upload

* Add files via upload

* Update voss_8404.json

* Update voss_8608.json

* Update voss_8608.json

* Update voss_8608.json

* Update voss_8608.json

* Update voss_9012.json
2019-07-09 23:54:21 +02:00
rsys-dev
cfaf913896 Added detection for ZTE zxdsl devices (#10344)
* add yaml files

* Added include/definition/zxdsl.yaml (ZTE ZXDSL Support)
Added include/polling/os/zxdsl.inc.php (Set Hardware)

* Changed includes/definitions/zxdsl.yaml type from "dslam" to "network"
Changed includes/polling/os/zxdsl.inc.php removed unnecessary code
Added Testfiles

* Fixed coding guideline errors (missing spaces)

* Removed unnecessary "use"

* Improved model number discovery
Removed unavailable top graphs
Added System temperature

* Changed Temperature limits according to ZTE datasheet

* Updated Tests
2019-07-05 13:06:27 +02:00
Kevin Krumm
da9e67b296 Aruba IAP: Fix Radio State Sensor (#10335)
* Aruba IAP: Fix Radio State Sensor 

Fix state sensor for radio status from warning when disabled to unknown state.

* Update aruba-instant.json

* Update aruba-instant_105.json
2019-06-15 10:10:37 -05:00
StackOverBuffer
fec165fb86 Add power sensor for eaton ups (#10306)
* Add power sensor for eaton ups

* removed whitespace at end of line

* add test data
2019-06-11 23:46:43 -05:00
Marlinc
93f3528bbf Add Ipoman power consumption support (#10244)
* Add Ipoman power consumption support

* Create ipoman.json
2019-05-31 07:43:54 -05:00
Martijn Schmidt
9455a83478 Convert OS mrv-od to yaml, discover more sensors, discover entity-physical (#10266)
* Dynamic entPhysicalIndex values for YamlDiscovery

* Use degree symbol when displaying temperature values

* Adjust SNMP options for new snmp_get_multi()

The OS polling module for mrv-od was using snmpget commands with
-Ovqs, rather than -OQUs, which meant that the equal sign was
stripped in the snmpget output. But that equal sign is now used
as the explode() delimiter so it broke the construction of the
returned array for the snmp_get_multi() function.

Additionally, I removed the NBS-CMMC-MIB:: prefix which is no
longer returned by snmp_get_multi() as part of the OID. Now,
the mrv-od.inc.php OS polling module is retrieving data from
positions in the array with actual content.

* Convert mrv-od to yaml, improve sensors discovery

Converted sensors discovery for mrv-od to yaml, retaining all
functionality for pre-cache, dbm, and temperature. Replaced specific
SFF-8472 Digital Diagnostics state sensors with generic ones, given that
we are now reading out detailed values through new dbm, current, voltage
sensors.

Reasoning: the generic Digital Diagnostics state sensors report state
diagsOk, or else the worst severity level measured among all of the
Digital Diagnostics values for that optical data point. You'd really
only want to set a generic "alarm" so the box can report that it
thinks something is wrong, whereafter a human can look at the graphs
and/or the CLI to draw their conclusions about the alarm. Otherwise,
things would quickly become too spammy as you are essentially duplicating
every sensor across both regular measurements and state measurements.

Further changes:
- Increase maximum number of detected PSUs from 4 to 8 per the MIB.
- State sensor to detect (in)sufficient power budget for all modules.
- Use skip_values to hide state sensors with the notSupported value.
- Use skip_values to hide sensors which are unsupported per the MIB,
  signified by the device returning special values -1 or -2147483648.
- Add dBm, temperature "over" graphs to the mrv-od device header bar.

* Add mrv-od entity-physical support

MRV does not use the ENTITY-MIB data format, so we had to reconstruct
the inventory from their proprietary format using the following tables
from their NBS-CMMC-MIB:

- nbsCmmcChassisTable
- nbsCmmcSlotTable
- nbsCmmcPortTable

Additionally, since sensors didn't have their own ifindex in the
NBS-CMMC-MIB, I went ahead and appended the last OID digit to
the "containing" ifindex create a unique number. The same was
done for the sensors in the yaml-discovery.

* Test data for mrv-od, fix 2* pre-commit.php issues

* Fix entPhysicalIndex returning 0 instead of null

Some unit test breakage was caused by 62167ebcb which changed
the code to return 0 instead of null when {{ $index }} was
set as the entPhysicalIndex in the YamlDiscovery. So now we
detect if it returns some value which may be interpreted as
false, and if so we set null rather than 0.
2019-05-29 13:30:33 -05:00
Daniele Viganò
e9b3e258e8 Fix power consumption detection on Dell servers (#10250) 2019-05-23 09:54:19 -05:00
Spencer Butler
83522c6fef Added support for East iStars UPS (os: istars) (#10041)
* istars - Added support for East iStars UPS (os: istars)

* typo

* remove duplicate image

* refactored to use rfc1628

* added json

* update is_array to isset for bad rfc1628 implementation

* Update istars.inc.php

* revert rfc1628 changes

* update test data + PR 10240 patch

* update OIDs
2019-05-21 11:03:28 -05:00
Timothy Willey
0d656590ec NEW OS Aruba Instant (#9954)
* New OS: Aruba Instant

* New OS: Aruba Instant

* recreate test data

* remove aruba_instant test data

* remove empty file includes/definitions/discovery/aruba-instant.yaml

* fix state sensor discovery

* remove minor changes to includes/polling/functions.inc.phpwq

* move mac helper functions to Rewrite class

* simplify snmpwalk_group usage, general code cleanup

* fixes

* fixes

* fixes

* fixes

* fixes

* fixes

* recreate test data for 105 variant

* Add Client sensors for 8.4.0.0+

* begin stream-lining discovery and polling. separating discovery functions

* update test data

* update test data

* update test data

* improve mempool discovery/polling, clean up os polling, improve state discovery, improve os definition, misc fixes to wireless sensors module

* attempt to implement custom AP and client discovery and polling

* code fixes

* re-add ap count top graph

* more fixes

* more fixes

* more fixes

* more fixes

* remove some debugging, update test data

* code cleanup

* code cleanup

* address some scrutinizer warnings
2019-05-13 10:06:12 -05:00
Marvin Kuurstra
966ce85c19 Fortigate sessions sensors (#10183)
* Adding sensor for sessions

* Adding test data

* Fix index mistake and update test data (#12)

* Update test data for existing fortigate
2019-05-09 23:58:03 -05:00
Tony Murray
3e7970b814 Fixed Avtech discovery (#10163)
* Fix Avtech discovery
pre-cache stored the data incorrectly

* Fix RA-4E external sensors
sen1 had incorrect oids (duplicate of sen2)
Description oid from data doesn't match the mib, perhaps outdated MIB?

* add test data

* Updated 4E MIB
2019-05-02 21:37:00 +01:00
CirnoT
308145d2da Fixed Raspberry Pi sensors discovery (#10176)
* Fixed Raspberry Pi frequency, voltage and state sensors discovery
* Added tests
2019-05-02 08:10:20 +02:00
Vitali Kari
df2e80544c Extended sensors for Timos devices (#10160)
* additional sensors for timos
change to yaml discovery for sensors
remove obsolete tmnxChassisPowerSupplyTable

* inconsistent data in snmpsim

* fix snmpsim data

* fix snmpsim data

* fix snmpsim data
2019-04-29 20:48:37 +02:00
PipoCanaja
780ee36b10 Updated support for adva_fsp150 devices (#10049)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2019-04-09 13:59:08 +01:00
Spencer Butler
47e0ee1d04 Added support for Liebert PDUs (#10062)
* Added support for Liebert PDUs
2019-04-07 21:19:08 +02:00
TheGreatDoc
5535768d25 New Device: ATS - Automatic Transfer Switch (#9889)
* New Device: ATS - Automatic Transfer Switch

* Small fixes

* Fixed test data

* More fixes, again

* Moved temp to php to retrieve limits from device

* Fixed perms again...

* Final test file. Or I hope so...
2019-03-24 18:48:55 -05:00
KodApa85
8ec2476036 Added support for APC AP9810 zone contacts (#9967)
* device: Added support for APC AP9810 zone contacts

* fix: disconnected sensors been detected. And iemConfigProbesTable certainly does get used and it reference

* fix: load is VA, not to be confused with watts. This could be different per device though...
Apparent Power unit = VA
Real Power unit = Watts

And Keeping codeclimate happy

* feature: updated APC MIB

* feature: added test data for APC Smart UPS SMX750i and AP9810 with contact switches
2019-03-22 00:10:20 +01:00
Yann Gauteron
bafc195ae3 Fix cisco temperature limit (#9985)
* The SNMP value ciscoEnvMonTemperatureThreshold is now stored as high limit (and no more as high warning limit)

* Updating misc/notifications.rss to make the user aware of the behavioral change

* Addition of missing </description> in the misc/notifications.rss
2019-03-19 08:12:54 -05:00
PipoCanaja
70437ae42b Dantel Webmon Improvement (#9977)
* Generic polling for webmon

* Tests update

* clean

* tests and count sensor

* typo + tests

* update user friendly OS

* style
2019-03-17 21:42:47 -05:00
PipoCanaja
59f00dcc6b Improved VRP stack state discovery with one member only to avoid unnecessary alarms (#9925)
* VRP stack state improvement

* tests

* cleaning
2019-03-13 09:03:18 +01:00
ospfbgp
eb82a153d9 Add support for power supply on Extreme BOSS switches (#9898)
* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Update boss.inc.php

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload
2019-03-09 14:24:37 -06:00
tarik
e3e3de1442 Printer paper tray status and error states (#9859)
* adding paper tray status and error states

* adding paper tray test data

* Create jetdirect_papertray.json

* Store printer supply type

* Update json data

* fix style
2019-03-06 18:58:14 -06:00
network-guy
65fba42306 Dantel WebMon Device Support (#9767)
* Dantel WebMon Support

Webmon tep discovery changes

Fix Code Climate Issues

* WebMon - Move MIB to folder and create json reference

* Minor changes to Webmon polling
2019-03-05 00:46:00 -06:00
Florian Beer
80d0a23e8f Add data scrubbing state to Synology RAID status (#9661)
* Add data scrubbing state to Synology RAID status

Adds a new state translation to Synology DSM RAID status sensor, so it displays "DataScrubbing" while the operation is running. Previously it would just show "# 13".

* Update Synology RAID MIB

Downloaded from
https://global.download.synology.com/download/Document/MIBGuide/Synology_MIB_File.zip
2019-03-04 16:06:12 -06:00
KodApa85
7f104d4fd9 Advanced state sensors (#9881)
* refactor: advanced sensor states

mark create_state_index($state_name) as E_USER_DEPRECATED?

* fix: minor corrections

* fix: mib has partialSync(9) and incompatibleVersion(8)

* fix: corrected netagent2upsstate - Sleeping(5)

* fix: NetAgent2 upsThreePhaseUPSStatusInverterOperating correction

* refactor: array() be gone

* Refactoring includes/discovery/sensors/state/extendair.inc.php with arrays
And tidying up array formatting in other files

* fix: minor typo

* standardising array item names

removed redundant "if ($state_index_id !== null) {"

* workaround: procurve & serverscheck

a sensor is causing create_state_index($state) to return null.
The updated code doesn't allow for this and thus a hybrid is being used.

* standardised naming of state info. Caused a typo $state_name instead of $status_name
$state_name is the standard

* converted compas to square arrays

* Converted APC states using preg_match to new create_state_index() call

* Update boss.inc.php
2019-03-04 11:31:17 -06:00
Nick Hilliard
09caced7ef Add support for Infinera-Coriant Groove (#9843)
* Add support for Infinera Groove
2019-03-04 17:31:53 +01:00
KodApa85
3c0d0c9fba Added support for Alpha Comp@s (#9871)
* newdevice: Added support for Alpha Comp@s
http://www.alphainnovations.eu/compas

* fix: Updated state values
state values persist in database, even after deletion of devices.
Not a 100% how to purge them.
create_state_index($state_name, $states) doesn't update the database, if the states have changed

* refactor: comp@s OS state sensor now updated to latest format
2019-03-01 00:14:17 +01:00
ospfbgp
1ea3fdd70a Discovery rcChasPowerSupplyOperStatus for Extreme/Avaya (#9878)
* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss.yaml

* adding support for vsp9012 and vsp8608

* Add files via upload

* Add files via upload

* Add files via upload

* Delete voss_8608.json

* Delete voss_8608.snmprec

* Delete voss_9012.json

* Delete voss_9012.snmprec

* Add files via upload

* Add files via upload

* Delete voss_vsp-9012.json

* Add files via upload

* Add files via upload

* Add files via upload

* Delete voss_vsp-9012.snmprec

* Add files via upload

* Delete voss_8608.json

* Delete voss_8608.snmprec

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload
2019-03-01 00:11:37 +01:00
Vitali Kari
d60a0da7de Add support for Nokia ISAM (#9793)
* add mibs,first commit

* adds support for Nokia ISAM Plattform

* remove some comments

* change os polling to multi oid

* Restore file headers

* Fix discovery by sysObjectID

* first deactivate checks against IHUB (timos), It not necessary so long we can not provide more thatn one snmp community per device

* move snmp state and temperature from pre-cache

* Update os_schema.json
2019-02-12 20:23:02 -06:00
Søren Rosiak
80f31b4831 Fix Arista interface bias current divisor (#9728)
* Remove exception

* Add test data

* Update arista_eos.json
2019-02-07 11:37:46 -06:00
Vitali Kari
65e766156f Add Raisecom Sensors (#9738)
* update some mibs

* extend snmpwalk_cache_twopart_oid function

* add raisecom dbm and temperature sensors

* add test data

* add some more sensors

* Update raisecom.inc.php

* Update raisecom.inc.php
2019-01-30 21:34:15 -06:00
tarik
5197074c4d adding temp/humidity sensors for raritan px2 (#9719)
* adding temp/humidity sensors for raritan px2

* fixing the divisor logic for threshold values of raritan temp sensor

* removing debug's statements and fixing a static check warning

* fixing the bool/str comparison with exact string comparison

* Create raritan-pdu_px2_temp.json
2019-01-27 08:33:28 -06:00
dharpster
fa8d7a008d Fix Sentry3 voltage sensor discovery (#9714)
* Fix Sentry3 voltage sensor discovery

Previous fix broke voltage sensor discovery with superfluous .1 in the SNMP OID.  I have fixed my install with this patch but other testing should probably be done.

* Update sentry3.json
2019-01-22 17:11:26 -06:00
Marvin Kuurstra
e2a8349440 Adding Sonicwall SMA 400 support (#9555)
* Adding Sonicwall SMA 400 support

* Added metric clients for use in SSL VPN client alerting
* Support for specifying multiple sensors for clients metric
* RAM info supported
* CPU info supported
* Added test data

* Dashes in graph aren't really useful

* Updated test data with script from upstream (#10)

* Fix style errors (#11)

* Now 8 spaces on line 56

* port clients sensor to count
Some sensor cleanups (move all icon definitions to one spot)

* update port data

* add sensor test data.  Make a guess at userLicense output since it is missing.

* cleanup missed items

* typo

* Updating test data

* Fixed missing CPU info

* Recreated test data

* Recreate test data after rebase

* Test data without ignore statements in config
2019-01-22 17:00:33 -06:00
Martijn Schmidt
e0da083f5c New OS: Schleifenbauer, entity-physical improvements, various html page fixes (#9471)
* Fix some comment and documentation typos.

* Fix various entphysical page display issues.

- Resolve flickering during loading (missing liClosed for nested items).
- Clicking a sensor actually takes you to the matching graph now.

* Add a few nicecase() calls to clean up html page display.

* Create discover_entity_physical() function

- Add discover_entity_physical() function into includes/discovery/functions.inc.php
- This allows for an easy implementation of OS-specific entity-physical discovery.
- Update includes/discovery/entity-physical/entity-physical.inc.php to use the new function.

* Add power_consumed and power_factor sensors.

* Two new icons, make more entPhysical data visible.

* Pre-commit fix: blank line found at end of control structure.

* Add Schleifenbauer OS support.

* Now really fix the comment typo.

* Fix parsing mistakes.

* Add a generic count sensor.

* Make the Schleifenbauer discovery use count instead of state sensors.

* Don't place count sensor at the top, add sane limits for Schleifenbauer

* Finetuning the rrd_options, changing Schleifenbauer sensor names.

* Update schleifenbauer.svg

* optimize logo too

* add test data

* fix sensor value display (spaces break it)

* update entPhysicalIndex
2019-01-20 12:24:11 -06:00
Tony Murray
5f752361f5 Merge ethernetprobe2 into akcp and improve akcp (#9465)
* Merge ethernetprobe2 into akcp and improve akcp
Use higher resolution temperature values if available
Properly hand F/C temperature scales (LibreNMS always uses C)
Add current, voltage, airflow (no test data)
Move humidity to yaml

* Update akcp.snmprec

* Update akcp-serverprobe8.json

* Add group

* Update test data
remove old MIB
2019-01-17 11:38:33 -06:00
Tony Murray
d8a751b021 Remove broken routeros signal sensor (#9650)
Discovers 2 of 6 found in the test data then updates it to not match.
Setting the wrong oid.
Tracking two specific macs on a single AP that don't match the label.
If they roam it won't change until next discovery.

If this is wanted, it should be written in the wireless section.
2019-01-11 11:51:23 -06:00
Tony Murray
1b29acc275 Fix sentry3 voltage sensors (#9649)
* Fix sentry3 voltage sensors

* don't need check, fix array to string conversion
2019-01-11 10:54:24 -06:00
Tony Murray
3dce7aa90c AirFiber additional modulation rates, fix gpsSync (#9563)
* Add QAM1024 modulation for AirFiber
Move sensors to yaml

* Fix 0 index

* add additional data
make compatible with old sensors

* Fix whitespace
2018-12-28 20:11:24 -06:00
Tony Murray
fad0bffc43 Escape SNMP & IPMI shell commands (#9537)
hopefully doesn't break anything
Mostly issues with snmp oids and options containing spaces.  Try to remove all of those.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-16 13:42:50 +00:00
markoh76
7bf769e19c Ceraos more sensors (#9392)
* Update to Added support for HeliOS 10Ghz failover to 5Ghz state sensor
Converted /includes/discovery/sensors/state/helios.inc.php to yaml
Test units included
CLA has been signed

* Added support for CeraOS TX Mute Status state sensor, NTP Client Lock Status state sensor.
Updated CeraOS temperature sensor, now called from includes/definitions/discovery/ceraos.yaml - removed includes/discovery/sensors/temperature/ceraos.inc.php
Corrected issue with CeraOS temperature reverting to zero after polling (added a trailing . to the num_oid)
Amended includes/definitions/discovery/helios.yaml with changes as advised by Neil Lathwood and Tony Murray

* Added unit test data and corrected ceraos.yaml validation error

* Added support for Ceraos Wireless Sensors (php)
Cross Polar Interference
Wireless Frequency

Added Ceraos state sensors (yaml)
NTP Client Lock Status
Tx Mute Status
Radio Operational Status
Remote Radio Operational Status
IDU Temperature
Power Amplifier Temperature

* Fix up tests, etc

* remove helios changes, fix style
2018-12-11 08:41:26 -06:00
evheros
cf24c7e4de Added HPE Comware temperature limit (#9518)
Changed the Temperature High threshold for a HPE Comware Switch to the values provided by snmp.
This means the actual threshold configured in the switch is used over any predefined/auto calculated thresholds by LibreNMS.


DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-12-05 09:50:53 +00:00