15492 Commits

Author SHA1 Message Date
372b28b888 Test fixes (#9105)
* Fix BENU MIB timestamp

* Fix comware bgp order

* fix ntp json data

* Fix occamos json
2018-08-29 06:55:32 -05:00
8e47a5dfcf Fix comware snmprec order (#9103) 2018-08-28 20:24:18 -05:00
192ed630bb Update devices.bgpLocalAs field from varchar to int (#9098)
* Update devices.bgpLocalAs field from varchar to int

* Fixed reorder

* Fix to requested changes

* Fix reorder again
2018-08-28 14:27:18 -05:00
810baeee3d Add 18.04 install guide and and move 16.04 guide (#9101)
* Add 18.04 install guide and and move 16.04 guide

Adds 18.04 install guides to "Installing LibreNMS" page.
Moves 16.04 install guides to "Old install docs" section.

* Update index.md

Update index tree to 1804 over 1604
2018-08-28 14:23:33 -05:00
f73f7ec5ce Fix invalid test data (#9099)
* Fix invalid test data
and add test for it

* fix bgp

* add missing comma back
2018-08-28 14:18:59 -05:00
31a21ba2bc Additional parameters for list_alerts and list_devices API calls (#9040)
- Add filtering by severity in list_alerts.
- Added ability to filter only active devices (not ignored and not disabled) in list_devices.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-28 17:44:47 +01:00
de2f3028da Create Installation-Ubuntu-1804-Nginx.md (#8630)
* Create Installation-Ubuntu-1804-Nginx.md

A few tweaks are required to the Ubuntu 16.04 instructions to install on the newly released 18.04 version mostly relating to php being bumped to 7.2 from 7.0 and no mcrypt module for this php version in the distro repository.

* Create Installation-Ubuntu-1804-Apache.md

Used instructions from 1604 Apache as template and updated to work on Bionic (18.04).

* Update Installation-Ubuntu-1804-Nginx.md

Removed instructions for installing mcrypt module as I confirmed it works without it and it was mentioned it was no longer needed.

* Update Installation-Ubuntu-1804-Apache.md

The 1604 directions had a mixture of vi and vim for editing files. Since this is ubuntu and we want the instructions to be as easy as possible, I updated editor to be nano. I have no personal preference and can make it whatever we prefer, just figured it should be consistent between the two guides.

* Update mkdocs.yml

Added Ubuntu 18.04 instruction pages

* Update Installation-Ubuntu-1804-Apache.md

Corrected to libapache2-mod-php7.2 from libapache2-mod-php7.0

* Updated Ubuntu install docs

* Added missing mbstring + curl packages
2018-08-28 10:30:37 -05:00
23b46c7681 Improved port polling in certain scenarios (#9082)
* Improved port polling in certain scenarios

* Update ports.inc.php

* Update ports.inc.php

* Remove temporary variables
2018-08-28 10:29:28 -05:00
7ebd6dbe5b Update no-response.yml 2018-08-28 15:21:18 +01:00
24993e7bd3 Fixed PeeringDB AS Selection table (#9096)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

One note: As bgpLocalAs field in database is a varchar, ordering could be inconsistent with 4-byte asn as it will order using the first char.
If you have 2 ASN (203524 and 32137) and your order by ASC (default) you will get:
203524
32137
2018-08-28 10:54:11 +01:00
fb16560552 Added/Updated collectd information (#9089)
Added more information on how to setup collectd. Noted that the rrd location set in config.php needs to match /etc/collectd.conf and /etc/collectd.d/rrdtool.conf.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:08:31 +01:00
90a0bd656a Improved hiveos-wireless OS Detection (#9046)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:06:51 +01:00
557de49ee3 Prevent bgp-peers module from adding json data for every device (#9091)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:03:12 +01:00
0a210208e0 Fixed alert notes (#9093)
Fix test-template.php to work like the actual alert code.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 21:02:36 +01:00
6d62026751 convert NTP to JSON and json_app_get (#9088)
* add tests for v1 of the JSON NTP client stuff

* update the NTP stuff to work with legacy and JSON

* add the NTP client legacy tests

* Update ntp-server.inc.php
2018-08-27 08:16:53 -05:00
84478b4367 Fixed query for alert settings (#9085) 2018-08-27 12:21:25 +01:00
485dc3affb Added Basic Support for Arris D5 EdgeQAM (#9083)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 10:11:16 +01:00
e9ff8c48b6 Fixed IN db queries (#9077)
Most were fine as they hardcoded the in into the query.
Change them all to use PDO properly.
Did not fix IRCBot, they are are all hardcoded.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-26 13:42:21 +01:00
a60dda8217 Added cli options debug and bill_id to poll-billing.php (#9042)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-25 21:57:08 +01:00
b74fcdd0a8 Fixed Debian Stretch rrdcached Base_Path (#8966)
* Fix Debian Stretch Base_Path

* Update RRDCached.md
2018-08-25 21:01:24 +01:00
c0b667ebc0 Isolate poller and discovery modules (#9074)
An exception in one module should not interrupt the process for other modules.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-25 21:00:03 +01:00
0a34a37d9e Fixed xss in deluser (#9079)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-25 12:10:00 +01:00
05a77b7bd2 Optimize OSPF poller (#9080)
if there are no instances, don't check for areas, neighbors, and ports

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-25 09:57:28 +01:00
d46f300260 Fix port_id is null in ospf poller (#9078)
set it to 0 instead of null
2018-08-24 16:45:27 -05:00
af300f7984 Added Basic Support for Allworx VoIP Systems (#9057)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-24 09:06:24 +01:00
f632521bda Display user id for auth_test.php -l (#9066)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-24 09:05:23 +01:00
01e8a6e089 Fix ldap fetching user_id as string (#9067) 2018-08-23 22:40:29 +01:00
5064285f10 Fixed Device->Eventlog to show rows/pages and Syslog hostname filter (#9060)
Fixed Device-> Eventlog to show number of rows per page and pagination.

FIxed when you filter by Hostname in Overview->Syslog, the Hostname filter dissapear as is like you were in Device->Syslog.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-23 21:05:18 +01:00
fefde753f1 Added information on assigning templates to alert rules
I added some description how to attach templates to rules, because this was not very obvious to me.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-22 21:04:36 +01:00
e448190a68 Added transport modules Kayako Classic and SMSFeedback (#9027)
Hello! I've made a first version of Alert Transporting module for Kayako Classic Servicedesk. May be it is possible to use with Kayako OnPremise version (not sure).

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-21 22:41:59 +01:00
d83b675090 Check for incorrect heartbeats in rrdtstep.php script (#9041)
Also, fix some incorrect config names (rrd_step -> rrd.step)

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-21 22:21:55 +01:00
2720ca5f1f Workaround for bill quota/cdr bigint (#9053)
Real fix is to install mysqlnd

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-21 22:15:25 +01:00
73b8dae345 Fix customers display (#9048)
Was trying to inject sql
2018-08-21 15:45:37 -05:00
4158615f85 Fixed OSPF duplicate DB entries (#9051)
Re-write ospf polling using Eloquent

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-21 14:06:49 +01:00
29d51f4727 Workaround for billing with large bps (#9044)
* Workaround for billing with large bps
Workaround for mysqli driver mucking up BIGINT
Real fix is for users to switch to mysqlnd

* Add note

* More bigints
2018-08-21 00:00:02 +01:00
2e3aef6929 Workaround for storage bigint (#9049)
Fix is to use mysqlnd driver instead of mysqli.
2018-08-20 23:58:26 +01:00
1e55601409 Update validate to check for mysqlnd (#9043)
Ran into some annoying bugs with the old mysql library driver and BIGINT.
2018-08-20 23:56:47 +01:00
664e0d7dcf Just disable phan for now (#9045)
Seems like it would take a lot to make it less noisy, phpmd has been more helpful
2018-08-20 23:55:36 +01:00
2d2612de91 Fix broken and unused sql query in billing code (#9039) 2018-08-19 22:35:11 -05:00
d65ea76355 Fix top interfaces for non-admin users (#9038) 2018-08-19 20:21:03 -05:00
e134a55556 convert zfs over to use json_app_get (#8573)
* convert zfs over to use json_app_get

* make the format checker happy

* change array brackets used and update for upcomming changes to json_app_get

* change it over to do exception checking

* styling cleanup

* cleanup error handling

* update to the latest json_app_get

* correct a bit of logic for legacy and cleanup some formatting

* add the snmprec files for the ZFS app

* add the tests for ZFS with legacy extend

* add another check

* convert these from base64 to hex

* remove improper commas

* Match upstream spacing

* fix typo

* fix bad data and zfs metrics, allow float values

* bad capture

* improve comment

* Update db_schema.yaml
2018-08-19 17:44:11 -05:00
478502ac4a Fix laravel start from PDO PR (#9037)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-19 22:44:04 +01:00
7298c135c2 Improved SmartAX OS support. Added CPU&Temperature for each card and … (#9023)
* Improved SmartAX OS support. Added CPU&Temperature for each card and hardware detection

* Minor fixes

* Uploaded test data

* Moved to snmpwalk_array_num()

* Fixed Temperature

* Added sensor power

* Fixed Style issues and proper hardware detection

* Fixed last style issue

* Last update. Added version and serial. Added traffic and processors mini graphs
2018-08-19 13:33:17 +01:00
62190a30d4 Fixed pre-commit (#9035) 2018-08-19 09:29:34 +01:00
2d72d8144e Convert old templates title as well as body (#9034)
* Convert old templates title as well as body

* Update convert-template.inc.php
2018-08-19 09:28:57 +01:00
460d95e1d6 Cleaned up Trango Apex Lynx OS code and added wireless sensors (#9026)
I removed an incorrect mib and added the correct one.  Changed initial detection to use mib instead of numeric oid. Removed trim function.  Added wireless sensor class.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-18 21:00:18 +01:00
8eaffe90ad Added basic support for IBM i (AS/400) (#9030)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-18 20:49:02 +01:00
bc5f01e2c8 Remove accidental cast (#9032)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-18 18:34:02 +01:00
65e07d1951 Fixed widgets from updated dbFacile changes (#9033)
* Fixed widgets from updated dbFacile changes

* Updated top interfaces
2018-08-18 17:07:42 +01:00
3a6f143c81 Fix dbFacile null parameters (#9031) 2018-08-17 20:49:34 -05:00