65 Commits

Author SHA1 Message Date
8c4efc83e1 refactor: Updated graphs to use safer RRD check (#6781)
Graphs that were using `file_exists()` to check for the presence of RRD
files now use `rrdtool_check_rrd_exists()` instead. This is a fix for
distributed poller configurations that are running `rrdcached` on a
different host.
2017-06-05 22:49:04 +01:00
788e5fd75c webui: Include ifAlias (port description) in graph title (#6373)
* Include ifAlias (port description) in graph title

* Resolve duplication where ifAlias == ifDescr

* Revert change to use label back to using ifDescr
2017-04-08 11:14:12 -05:00
1bbbaff58b refactor: Moved ifLabel -> cleanPort and updated the usage (#6288)
* refactor: Moved ifLabel -> cleanPort and updated the usage

* added list of tags allowed

* few updates as per comments from @murrant

* Added simple unit tests

* double display for javascript popover

* Remove ifNameDescr() function
Fix realtime port page

* remove accidental temp code

* Remove double display calls in ajax tables
2017-04-04 08:08:23 +01:00
9b9c10e204 fix: Cleanup printing ifAlias (#4874) 2016-12-12 14:25:48 +00:00
a83e126b40 refactor: Remove inappropriate usages of truncate() (#5028)
Where truncate() is used as substr(), replace with substr()
2016-11-20 11:12:25 +00:00
b8e9b2d917 Implement an autoloader (#4140)
* Implement an autoloader

When cleaning up classes for psr2, things got a bit unwieldy, so I implemented a class autoloader.
I created a PSR-0 compliant LibreNMS directory and moved all classes there that made sense.
Implemented LibreNMS\ClassLoader which supports adding manual class mappings

This reduces the file includes needed and only loads classes when needed.

* Add teh autoloader to graph.php

* Add a small bit of docs
Fix incomplete class in includes/discovery/functions.inc.php
2016-08-21 14:07:14 +01:00
8c639aa5a4 PSR2 Cleanup: /html edition
Travis tests for code conformance. Ignore warnings for now.
Fixed all errors, left most warnings.
2016-08-18 21:29:30 -05:00
68303a96da Merge remote-tracking branch 'upstream/master' into rrd-create-remote 2016-08-08 20:23:15 -05:00
laf
ec4535dae7 Added php lint checking for travis 2016-08-08 19:53:04 +01:00
1f5cfe283e Merge remote-tracking branch 'upstream/master' into rrd-create-remote 2016-07-18 15:58:56 -05:00
6f6b18cbc9 - Add the ability to only graph a single class map
- Add links to the classes on the policy selector.
2016-07-15 07:03:08 +10:00
9826e0915a - Added more colours to the array and added better debugging. 2016-07-14 17:46:50 +10:00
c01d8b7c4e Eradicate is file checks for our rrds (leave them for nfsen and collectd) 2016-07-08 15:09:11 -05:00
57650e4ffc Remove nfs requirement for distributed poller (with rrdtool 1.5+)
Use data_update instead of rrd_update/rrd_create and influx_update
Centralize rrd file check so we can check against a remote rrdcached server too
Use rrd_name() to generate rrd file names
2016-07-07 21:10:06 -05:00
b72c1282d9 Merge pull request #2797 from BarbarossaTM/issue-386-v2
Ability to use ifIndex,ifName and ifDescr to create and update port rrd files
2016-01-29 13:05:03 +00:00
e54e22b56e - Changed upper case variables to lower case. 2016-01-26 23:31:07 +10:00
4d78a0261e Update graph and port pages to use new RRD naming schema.
Signed-off-by: Maximilian Wilhelm <max@rfc2324.org>
2016-01-26 13:49:54 +01:00
bf37312bdc Cisco CBQOS
Implements the CISCO-CLASS-BASED-QOS-MIB to retrieve QOS counters from Cisco devices.
Policy and Class-map details are collected and stored in the database.
Details are presented on a new "CBQoS" tab of the interface that the policy is applied to.
Includes a policy selector that allows you to select which policy-map to show graphs for.

Each class-map has its own rrd file, in which 3 metrics are stored: Bytes, QoS Drops, Buffer Drops.
This can produce a LOT of rrd files.

As an example:
A Cisco 4500 series switch, running MQC on 200 ports. Each port has a common 5 class queueing policy applied, this creates 1000 (5 x 200) RRD's.

Because of this I have currently set:
```
$config['discovery_modules']['cisco-cbqos']    = 0;
```

Includes function snmpwalk_array_num, which performs a numeric SNMPWalk and returns an array containing $count indexes
One Index:
 From: 1.3.6.1.4.1.9.9.166.1.15.1.1.27.18.655360 = 0
 To: $array['1.3.6.1.4.1.9.9.166.1.15.1.1.27.18']['655360'] = 0
Two Indexes:
 From: 1.3.6.1.4.1.9.9.166.1.15.1.1.27.18.655360 = 0
 To: $array['1.3.6.1.4.1.9.9.166.1.15.1.1.27']['18']['655360'] = 0
And so on...
2016-01-21 21:18:14 +10:00
laf
d98387b8b3 Added back the longer words as they still fit 2015-08-10 23:12:33 +00:00
laf
8676a0c22f Updated interface graph formatting for non unicast 2015-08-10 23:01:14 +00:00
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
ebd0f6fc35 Apply "Squiz" code style on old (pre-2014) files 2015-07-11 16:12:35 +02:00
e1a5dd0110 Add ifAlias to graph view.
- Small visual improvement
2015-03-02 18:32:36 +01:00
b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
cc7f01ee26 more rrdtool_escape goodness
git-svn-id: http://www.observium.org/svn/observer/trunk@3230 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-23 10:37:23 +00:00
4db1454e92 move from port_id to interface_id. make ports discovery only discover. add some cleaner functions. add a tiny bit of alerting infrastructure.
git-svn-id: http://www.observium.org/svn/observer/trunk@3195 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-16 13:25:50 +00:00
f768558e7e fix auth for graphs to allow cidr filter. fix schema 006
git-svn-id: http://www.observium.org/svn/observer/trunk@3169 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-11 15:21:42 +00:00
d52042ba47 cleanups to how graphing works. start using device= for device graphs.
git-svn-id: http://www.observium.org/svn/observer/trunk@3167 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-11 13:26:14 +00:00
ee65ae5350 add previous period overlay to generic_bits/bytes and generic_duplex
git-svn-id: http://www.observium.org/svn/observer/trunk@3063 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-20 10:35:13 +00:00
ececd2f8f6 improve generic_multi_simplex_seperated
git-svn-id: http://www.observium.org/svn/observer/trunk@2698 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-25 09:47:45 +00:00
634e944987 ignore adsl stats out of sanity (3.2KdB SNR? GET FUCKED CISCO.) Clean up legend for generic_multi_line. Add CISCO-VPDN-MGMT MIBs
git-svn-id: http://www.observium.org/svn/observer/trunk@2694 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-21 10:54:06 +00:00
180148002c fix gneeric_multi_line and etherlike graphtypes
git-svn-id: http://www.observium.org/svn/observer/trunk@2682 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-12 14:04:27 +00:00
a369c442eb syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@2643 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-04 14:38:54 +00:00
2dc8b807e9 syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@2642 61d68cd4-352d-0410-923a-c4978735b2b8
2011-10-04 09:10:21 +00:00
dc2eb1a261 shorter interface names on graphs. shorter host names on graphs.
git-svn-id: http://www.observium.org/svn/observer/trunk@2543 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-22 15:54:16 +00:00
a9cac94659 rra? no. you mean ds. also make multi_bits_separated prettier
git-svn-id: http://www.observium.org/svn/observer/trunk@2534 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-21 11:59:59 +00:00
d864ce234f kill a whole bunch of trailing spaces
git-svn-id: http://www.observium.org/svn/observer/trunk@2516 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-20 09:55:11 +00:00
e9f14f8f85 many lovely GUI changes.
git-svn-id: http://www.observium.org/svn/observer/trunk@2454 61d68cd4-352d-0410-923a-c4978735b2b8
2011-09-14 13:38:01 +00:00
096f551f6f fix mac account total graph (need to split into different types...)
git-svn-id: http://www.observium.org/svn/observer/trunk@2352 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-20 15:24:46 +00:00
952ae3b365 all graphs to db*
git-svn-id: http://www.observium.org/svn/observer/trunk@2309 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-13 13:27:54 +00:00
38cd6d58cb wtfbbq, ports have fanspeed? (and fix pagp_bits!)
git-svn-id: http://www.observium.org/svn/observer/trunk@2308 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-13 13:08:25 +00:00
28558969c4 improvements to BGP stuff
git-svn-id: http://www.observium.org/svn/observer/trunk@2200 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-29 16:32:55 +00:00
8611d27bd8 add cef switching graphs and un-retard sensors polling
git-svn-id: http://www.observium.org/svn/observer/trunk@2079 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-13 19:08:01 +00:00
5ab12a5641 fix up device/vrfs page
git-svn-id: http://www.observium.org/svn/observer/trunk@2049 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-09 17:02:51 +00:00
f55a30f744 some formatting cleanups, introduce some more FIXMEs to look at, plus replace mysql_fetch_array by mysql_fetch_assoc, for great justice
git-svn-id: http://www.observium.org/svn/observer/trunk@2029 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-06 13:54:50 +00:00
7454791074 code standard/cleanups
git-svn-id: http://www.observium.org/svn/observer/trunk@1978 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-26 19:12:24 +00:00
3c79cafb2c can't stop uniformicationing
git-svn-id: http://www.observium.org/svn/observer/trunk@1915 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-17 16:35:18 +00:00
e1db733590 port graphs cleanup
git-svn-id: http://www.observium.org/svn/observer/trunk@1905 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-17 13:25:37 +00:00
1b7829ec51 fix unauthenticated graphs via $config['allow_unauth_graphs']
git-svn-id: http://www.observium.org/svn/observer/trunk@1691 61d68cd4-352d-0410-923a-c4978735b2b8
2010-08-22 22:12:32 +00:00