Commit Graph

250 Commits

Author SHA1 Message Date
Neil Lathwood
e751206f74 newdevice: Added more detection for IgniteNet FusionSwitch (#7384)
* newdevice: Added more detection for IgniteNet FusionSwitch

* fixed current graphs descr

* small updates

* small updates recommended by murrant
2017-10-25 08:10:02 -05:00
Tony Murray
f01cf38a3a fix: lldp discovery change local port resolution (#7443)
* fix: lldp discovery change local port resolution
dot1dBasePortIfIndex seems to skip some ports in certain configurations on Cisco devices.
Add quirk for Calix devices that return different port labels than they actually are.

* bdcom uses NMS-LLDP-MIB too.

* use dot1dBasePort to look up ifIndex if we can.
2017-10-24 08:21:32 +01:00
Tony Murray
2f2234da70 fix: cdp matching incorrect ports (#7491)
Need either remote device_id or mac_address to find a port, otherwise, we might match an incorrect port.
2017-10-15 19:49:28 +01:00
Tony Murray
f92449e637 fix: issues with recent discovery refactor (#7437)
fix find_port_id() deleting all variables when device_id was given
improve find_port_id() to find ports where only a number is given
fix orphan deletion count
fix insert and update of links with strings where int are required
2017-10-06 08:53:16 -05:00
Tony Murray
c0b267b49c refactor: Discovery protocols re-write (#7380)
* refactor: discovery protocols re-write
extract more code to make it easier to read
use snmpwalk_group
walk lldpRemTable instead of lldpRemoteSystemsData
Optimize discover_device to reduce dns lookups of bad dns names
Make discovery_by_ip behavior consistent between cdp and lldp
move can_skip_discovery to discovery functions

Tested lldp, cdp, and ospf.

* always discover links even if the remote device isn't in system
Fix discover_link always updating

* fix style

* fix update, not fetching id

* increase platform length.  Most devices use sysDescr here, which is max length 255

* remove orphaned links

* update db_schema.yaml
2017-10-04 08:16:23 +01:00
Neil Lathwood
592e8aca4c newdevice: Added sensor detection for APC In Row RD devices (#7385)
* newdevice: Added sensor detection for APC In Row RD devices

* Update apc.yaml

* Update apc.yaml

* Update cooling.inc.php

* Update pressure.inc.php
2017-09-29 21:13:27 +01:00
Tony Murray
b4d804f2ac fix: rfc1628 runtime - allow os quirks (#7340)
* fix: rfc1628 runtime - allow os quirks
Also, properly divide values at discovery
Remove accidental debug output
2017-09-14 21:55:07 +01:00
Tony Murray
f158a56774 fix incorrect getOsSetting arguments (#7339)
Missed calls when the function definition changed.
2017-09-14 00:43:14 -05:00
Neil Lathwood
b3567041dd newdevice: Added support for SmartOptics M-Series (#7314)
* newdevice: Added support for SmartOptics M-Series

* added os polling file
2017-09-13 21:12:56 -05:00
Tony Murray
98786c0ea7 feature: Allow ignore_mount, ignore_mount_string, ignore_mount_regex per OS (#7304)
* feature: Allow ignore_mount, ignore_mount_string, ignore_mount_regex at OS level

* Change the storage settings to override global instead of merge.
Add documentation
2017-09-13 19:43:21 +01:00
Tony Murray
b18c41b1a9 refactor: Use the Config class includes/discovery (#7299)
* refactor: use the Config class includes/discovery

* fix issue with $config variable not accessible in include-dir.inc.php

* improved whitespace

* Tidy up discovery_by_ip
2017-09-11 21:26:41 +01:00
Tony Murray
7b262a6851 refactor: Improve yaml state discovery (#7221)
* feature: Improve yaml state discovery
Handle state values that are returned as strings instead of int
Synchronize state values for existing state translations so we can change them without creating a new translation and losing historical data
More extensive/verbose yaml discovery phpunit tests
dbBulkInsert, use the first entry instead of requiring the first entry to be at index 0

* Update sensor state documentation
re-order values for better readability
remove os check
Use snmpwalk_group since it is more flexible

* Add some more debug output in dynamic discovery
2017-09-03 19:58:39 +01:00
Tony Murray
21deb96d52 fix: Fixed Avtech sensor discovery (#7244)
$valid is no longer a global as it once was
2017-08-29 19:37:24 +01:00
Neil Lathwood
061add5eb1 fix: Re-added changes for #6959 removed by accident in #7128 (#7240) 2017-08-28 13:44:24 -05:00
Neil Lathwood
806f5cce74 newdevice: Added additional sensor support for Cisco ONS (#7096)
* newdevice: Added additional sensor support for Cisco ONS

* updated discovery yaml + added mibs
2017-08-13 20:21:55 +01:00
Tony Murray
1d777693e1 feature: New IP parsing classes. Removes usage of Pear Net_IPv4 and Net_IPv6. (#7106)
* Refactor remove use of pear Net_IPv4 and Net_IPv6

Caution, I added tests to test the functionality of the new functions, but I'm not 100% certain the replaced usages match 100%.  Please test.

Left usage in generate-iplist.php because I'm not sure the use of that script, so I didn't want to implement additional functionality to support it.

Add support for ipv6 fo ipInNetwork() function

Add phpdocs to functions
Remove accidental inclusion

Use binary operations instead of string for networKFromIp()
Tidy up binary operations in ipInNetwork()

tidy parsing cidr network

Change to a class based implementation.

Update phpdocs.
Fully catch exceptions for hex parsing.

Fix mistake.

support older phpunit versions

Fix php shifting to negative with php 5

* Fix graph authorization. Uncaught exception and checking an ipv4 against an ipv6 network == fail.

* Also remove colons from hex strings.

* Fix typo in bgp polling
Two passes of removing invalid characters from hex strings. (That way we don't mangle valid IPs)
2017-08-08 14:14:58 -05:00
Neil Lathwood
d8140467ae newdevice: Added support for Emerson energy systems (#7128)
* newdevice: Added support for Emerson energy systems

* added missing test

* Update ees.yaml
2017-08-08 07:58:57 +01:00
Neil Lathwood
707b6c6954 feature: Added support to cisco sensors to link them to ports + macro/docs for alerting (#6959)
* feature: Added support to cisco sensors to link them to ports + macro/docs for alerting

* renamed sql
2017-08-04 19:37:50 +01:00
Tony Murray
123a90feab feature: Log event if device polling takes too long (#7065)
Move $device_time closer to end of poll_device(), and simplify
remove some unused variables
simplify $device_time in discover_device() too
2017-07-21 23:01:59 +01:00
Neil Lathwood
da7550f55f device: Added additional sensors support for HP ILO4 (#7053)
* device: Improved HP ILO4 support

Added HP ILO4 temperature (HDD, motherboard), power, state (powersupply, HDD, Fans, memory slots) sensors support.
Tested with HP ProLiant ML350p Gen8-Gen9

* actual MIB file!
2017-07-19 22:06:59 +01:00
Neil Lathwood
83cb39a7fd fix: Netbotz state sensors using wrong value (#7027)
* fix: Netbotz state sensors using wrong value

* actual fix
2017-07-13 19:02:26 -05:00
Tony Murray
c874fc5b1e fix: Standardise UPS divisors (#6942)
Set default divisors for all devices and remove per-os overrides for them.
We should only use per-os overrides for non-standard behavior.

High possibility for breakage here if devices not listed here have non-standard behavior.
2017-07-13 18:09:56 +01:00
Neil Lathwood
d30e5660f9 feature: Added ability specify options for sensors yaml discovery (#6985)
* feature: Added ability specify options for sensors yaml discovery

* travis fix for new line + skip_values_* -> skip_value_*
2017-07-10 16:27:46 -05:00
Tony Murray
14ed767edb fix: a couple of issues with the yaml state sensor discovery (#6912) 2017-06-29 21:12:51 +01:00
Neil Lathwood
a4b905e3f6 fix: Fixed netman voltage and load divisor values (#6905)
* fix: Fixed netman voltage and load divisor values

* Update to perform more checks
2017-06-29 07:23:39 -05:00
Neil Lathwood
929d7ece56 fix: Fixed checks for $entPhysicalIndex/$hrDeviceIndex being numeric (#6907) 2017-06-28 16:03:35 -05:00
Neil Lathwood
5e32474d26 feature: Added support for sensors to be discovered from yaml (#6859)
* feature: Added support for sensors to be discovered from yaml

* added discovery definitions

* Updated docs, more code updates + tests

* removed the oid_name use

* pre-set variable from scrut output

* small updates as per comments in pr

* Allow index in descr

* Added ability to skip values

* Check for numeric values

* small update of oid name
2017-06-26 23:27:57 +01:00
Neil Lathwood
d48be5f507 newdevice: Added detection for Cisco EPC devices (#6690)
* newdevice: Added detection for Cisco EPC devices

* updated test file

* added dbm support

* added snr support
2017-05-23 10:28:44 -05:00
Neil Lathwood
895801d855 newdevice: Added more health information for APC units (#6619)
* fix: Fixed apc state support emsOutput

* newdevice: Added more health information for APC devices

* update schema file

* schema file renamed
2017-05-17 22:41:53 +01:00
Marcus Pink
5b9623d8d4 newdevice: Added detection for HPE RT3000 UPS (#6638)
* newdevice: HPE RT3000 UPS

* newdevice: HPE RT3000 UPS

* changed polling to snmp_get_multi_oid, fixed divisor for load and voltage

* fixed blank line in functions.inc.php
2017-05-16 21:42:10 +01:00
FTBZ
6c555c6fb5 fix: Fixed load divisor for eaton-mgeups (rfc1628) (#6566) 2017-05-03 22:38:43 +01:00
Olivier Beytrison
0dcc1d18c5 Fix GE UPS voltage factor (#6558) 2017-05-03 14:30:40 +01:00
Olivier Beytrison
2f5a1742c3 newdevice: Added detection for GE UPS (#6549) (#6553)
* Add support for GE UPS (#6549)

* rename OS and remove sysDescr regex
2017-05-02 15:20:28 +01:00
Neil Lathwood
72a0d8202a newdevice: Added further health support for Netbotz devices (#6529) 2017-04-30 16:32:39 +00:00
Tony Murray
374a4041af fix: inconsistent device discovery (#6518)
There were two or more separate $device arrays during discovery. When one was updated, others were not.
Combine those all.
Make sure the new os is loaded if the os changed.
2017-04-28 22:50:00 +01:00
FTBZ
2aa4145a26 fix: APC/MGE UPS sensors divisor for load and voltage (#6509)
* fix: APCMGE sensors divisors

* Add missing SNMP SIM file

* Add OS test for snmprec file
2017-04-26 08:35:07 -05:00
Neil Lathwood
66b7077a01 fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids (#6495)
* fix: Updated ipv4/ipv6 discovery to exclude IPs with invalid port_ids

* Update the valid IP sql queries to include addresses without a port

* Fix arp-table too.
2017-04-25 21:28:25 +01:00
cahluor
2ced131cf5 Updated logging within discover_new_device() to record device that attempted to discover device
Updated logging within discover_new_device() to record device that attempted to discover device
2017-04-18 21:43:55 +01:00
Tony Murray
e521b39a7d refactor: move rfc1628_compat into os yaml (#6424) 2017-04-17 21:57:27 +01:00
Tony Murray
e005f78211 newdevice: detect more devices as Comware (#6386)
* newdevice: improve comware detection
Only some H3C Comware devices were detected as comware, detect them all.

* Update the test data

FYI, C1234 was just a nonsense string
2017-04-13 10:52:07 +01:00
Neil Lathwood
1bbbaff58b refactor: Moved ifLabel -> cleanPort and updated the usage (#6288)
* refactor: Moved ifLabel -> cleanPort and updated the usage

* added list of tags allowed

* few updates as per comments from @murrant

* Added simple unit tests

* double display for javascript popover

* Remove ifNameDescr() function
Fix realtime port page

* remove accidental temp code

* Remove double display calls in ajax tables
2017-04-04 08:08:23 +01:00
Tony Murray
ea5a4b3586 fix: attempt to fix several bugs with sensor limits and incorrect detection (#6176) 2017-03-12 14:56:56 +00:00
Tony Murray
6993bd122c fix: sensors not being removed from database (#6169) 2017-03-12 00:03:04 +00:00
Neil Lathwood
38cebc5fd7 feature: Added better BGP support for Arista (#6046)
* feature: Added better BGP support for Arista
2017-03-11 23:16:49 +00:00
FTBZ
1d80a0d2a6 fix: Fix Generex voltage sensor divisor (#6156)
* Fix Generex votage sensor divisor and add an exclusion option

* Allow OID to be used to figure out if we need to change the divisor.

* Missed current and found bugs while I was there.

* Use returns swap oid logic
2017-03-09 21:47:58 -06:00
FTBZ
6f2ba2b45b Fix Generex load sensor divisor (#6155) 2017-03-09 14:10:25 -06:00
Neil Lathwood
ecc5b5f5db Update sensor_type (#6108) 2017-03-06 16:37:12 -06:00
Neil Lathwood
339cda3775 fix: Old / duplicate sensors would never be removed, this is fixed by setting the $type correctly #6044 (#6079) 2017-03-06 15:39:56 +00:00
Neil Lathwood
aa24fb62be fix: Do not try and only include files once when they are needed again! #5881 (#6053) 2017-03-01 17:06:11 -06:00
Neil Lathwood
38168832a6 refactor: Centralise device up/down check and use in disco #5862 (#5897)
* refactor: Centralise device up/down check and use in disco #5862

* Remove extra indentation
2017-02-15 15:22:09 +00:00