* Don't call clean() on the inputs to the SNMP settings form, it'll call
strip_tags() and break values with angle brackets in.
* Call htmlspecialchars when outputting DB values to HTML instead
* Escape other stuff that should have been validated elsewhere, just in case
* Added discovery and graphing for JunOS (SRX) RPM probes
* Proposed changes for a percent based sensor type
* Fixed missing MIB declaration in JunOS YAML discovery file
* Updated Health-information.md to reflect the new percentage value type
* Added separate test data for junos_rpm type
* Update sensors.php
* Update sensors.php
* Update functions.inc.php
* test re-run
* Update junos_rpm.json
* percentage -> loss
* add ifSpeed prev test data
* mis-merge
* update sensors
* and bgp...
Co-authored-by: PipoCanaja <[email protected]>
Co-authored-by: Tony Murray <[email protected]>
* Ping only device doesn't display
if os was set to something, ping os wasn't loaded and we try to get overview graphs from it.
* Fix snmp_disable device page load error
When other os is set.
* Revamp os setting loading
the only safe way to access is Config::getOsSetting()
* Remove getOsSetting fallback behavior
Most instances don't use it and it can have unexpected results Config::getOsSetting('blah', 'group') == 'librenms'
* refactor and remove unneeded load_os/loadOs calls now since getOsSetting automatically loads it.
* restore unix overview graphs, they are different
small cleanups
* fix
* Update addhost.inc.php
bugfix: push snmp v3 user settings to the front of the config array and not the back.
To reproduce the bug:
Force add new snmp v3 device.
The v3 settings added to the database will not be the same as entered in the webpage
* Update addhost.inc.php
Minor change in order to trigger travis build
* MPLS updates and bugfixing
* Tests
* tests
* code climate, tests
* tests
* tests
* remove nokiaIfName(), fetch ifName from the database instead
* restore from messed rebase
* tests
* btw, fix travis about the missing docs
* tests
* tests
* clean the messed up test data an generate new for timos
* rebase
* Throw some shit together, rough outline.
* Reorganize tabs, use tab controllers
* Implement performance (into the latency tab)
* Update resources/views/device/header.blade.php
Co-Authored-By: Jellyfrog <[email protected]>
* Add more tabs
* All controllers created
* Implement routes
* Implement smokeping
* routing and auth
* fix smokeping check
* Implement device dropdown menu
* Update deviceUrl to new style
* Use Gates
* Fix style
* use more appropriate gates
* add show-config gate
remove Laravel helper
* Only show vlan tab if VLANs exist for the device :D
* Fix rancid file check will return false
* revert over-zealous file name changes
* don't need to request the location parameter, just cast to string to avoid bugs when not found
* Move latency tab (ping/performance) to the position of performance instead of ping.
Co-authored-by: Jellyfrog <[email protected]>
* BGP Polling: Add error code polling
* Rework describe_bgp_error_code and fix bgp error fields migration
* Add real test data for IOS-XR and Arista EOS
* Delete ports via eloquent event
Chunk delete during purge all operations so we don't use too much memory.
* protect against missing device
* fix whitespace
* fetch less from the database when deleting a device's ports
fix output
* honoring config option `force_ip_to_sysname` in bill creation and editing
* refactored variable name to match it in edit.inc.php
* forgot one variable
* and one more :S
* Update new_bill.inc.php
* Update edit.inc.php
* Update new_bill.inc.php
* Update edit.inc.php
* Update edit.inc.php
* Update edit.inc.php
Co-authored-by: Neil Lathwood <[email protected]>
Co-authored-by: Tony Murray <[email protected]>
* Rewrite Poller Management to Blade/Eloquent
* remove further no more needed file
* Code Climate
* Code Climate
* hardcode tabs
* change URL style
* change prefix from poller-groups to poller
* .
* parameter fix
* Refactor to use more direct routing.
remove switch statement.
Co-authored-by: Tony Murray <[email protected]>
* puppet agent monitoring
* change position of last run graph
* device overview panel
* updating documentation
* mouseover for Overview Dashboard
* adding blank line for code climate
* Asterisk app: add IAX2 peer graphs
* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274
* code climate, round 1
* clarified unit text
* code climate, round 2
* changes needed to properly generate test data
* linux_asterisk-v1 test data
* BUG: From a device page, click Alerts and attempt to ACK or add a Note. Nothing happens because the modals are not on the page.
* This patch corrects pages/device/alert.inc.php to include both modal/alert_notes.inc.php and modal/alert_ack.inc.php
* Don't overwrite real port ids with zeros in the FDB
* Remove space to make codeclimate happy
* Provide links to device config view for oxidized config search results
* Use a bootgrid for Oxidized nodes so we can sort, search etc.
* Add a space for codeclimate
* Fixed device SNMP edit form (and better feedback)
* snmp.inc.php: Fix SNMP Edit form (better feedback)
* The feedback for Max Repeaters and Max OIDs is much better. The constant false errors on save have been corrected. The are no longer applicable and muted when SNMP is turned off. Their feedback now clearly shows the user what has been done.
* Rename & relabel $no_checks as $force_save (Force Save) because that's simpler and more clearly defines what the code is doing when you turn it on.
* Reorder the Force Save checkbox to be right above the Save button so it's even more clear what it does. Force Save and Save are the only elements on the form that do *not* have a database setting. They're ephemeral and now grouped as such.
* Embedded comments about the use of === false as tests for setAttrib() and forgetAttrib()
* snmp.inc.php: code climate updates, round 1
* remove blank lines
* refactor duplicate code blocks
* remove join on string
* move print_messages to the bottom of the form
* snmp.inc.php: code climate, round 2
* avoid deeply nested control flow statements (8)
* snmp.inc.php: when to $force_save and $device_isssnmable
* move $force_save outside of if ($snmp_enabled) so it works properly
when snmp is disabled.
* only check isSNMPable() if snmp is enabled
* snmp.inc.php: move $device_snmp_details
* $device_snmp_details are only needed for isSNMPable(), so only call
them within the same contingency
* snmp.inc.php: cleanup & hardening
* add SNMP Settings header (to better mimic Device Settings, etc)
* use Toastr for feedback, rather than print_message & print_error
* after editing, always unset($_POST) and the other variables used for editing
* unless the save is forced, if !$device_issnpable then don't save *anything* in the database and revert *all* previous form settings (some already were being reverted & some weren't)
* more variables were ordered alphabetically, unused variables were and removed
* for snmpver, don't use .toggle(); use .hide() & .show() so the form reverts properly when it fails
* snmp.inc.php: clarify placeholder for max repeaters
* snmp.inc.php: code climate, round 3
* correct blank line found at the end of control structure (2)
* correct space before opening parenthesis of a function call prohibited (3)
* Initial push
* power trap tests
* vmware heartbeat trap tests
* heartbeat trap test
* created utilclass for common functions
* Changed util class name to better reflect its use
* make vm power state changes to db
* Traps will modify DB
* Removed unecesarry relationship
* Added vminfo modelfactory, tests, and fixed format
* Added suspended state to ui
cjwbathandGitHub
SourceDoctorandGitHub
Lars Elgtvedt SusaasandGitHub
louis-ouiandGitHub
ospfbgpandGitHub
Vitali KariandGitHub
Mathieu PoussinandGitHub
crcroandGitHub
Joseph TingirisandGitHub
Heath BarnhartandJellyfrog