Commit Graph

595 Commits

Author SHA1 Message Date
Mark Westerterp 971404f416 Added "Ping Response" graph to "Ping Only" Device Overview page (#13886)
* Add Ping performance to Device Overview page

Only if device type is "Ping Only"

* Re-use $perf_url
2022-04-03 14:15:23 +01:00
Claude Brown 958556dc18 Ensure 'add_device' API returns indexed-array (as per documented behaviour) (#13887) 2022-04-03 14:03:03 +01:00
Lucas Dousse 427438a08f remove fixed size for vendor column (#13881)
* remove fix size for column mac adresse

* remove fix size for column mac adresse in port arp tab
2022-03-31 15:43:29 +02:00
Jellyfrog 4df7968d81 Fix SQL injection in get-host-dependencies (#13868)
Thanks to raf at TNP Consultants for reporting it
2022-03-23 21:39:24 -05:00
Tony Murray 8df92a5f2b API: device_add support display field (#13846)
* API: device_add support display field
remove legacy code path
update docs
A few improvements to the new code too

* some fixes, port_association_mode was not available

* hand version -> snmpver translation
2022-03-15 06:54:02 -05:00
Neil Lathwood 369617ffa1 Fixed displaying hostname in create bill when port is passed (#13830) 2022-03-14 23:38:59 +00:00
Gene Dela Rosa 85b19ce99e Add configuration support for IPMIv2 Kg key (#13845)
* Add support for IPMIv2 Kg Key in device settings

Some devices require that the Kg key be specified. An example would be a server of mine, a Cisco C220 M3. 

Otherwise, it would error out with `Error: Unable to establish IPMI v2 / RMCP+ session`. 

With verbose output enabled, the connection attempt would stop at `RAKP 4 message has invalid integrity check value`.

* Add Kg key support in Poller

* Sanitize Kg key from debug output

* Added Kg key support for discovery process

And it seems to work like a charm. New fields, such as fan tachometers, were added in automatically.

* Applying StyleCI changes
2022-03-13 22:51:55 +01:00
Tony Murray 1bfd411995 New device:add code (#13842)
* New device:add code
pre-requisite for updating other code paths
includes option to set display name
separate validation code from device creation

* remove duplicate community and v3 creds

* style fixes

* some lint fixes

* fix phpstan

* Exception cleanup
improved messages and translations

* port association mode to enum
well, pseudo enum

* defaults and cleanups

* fixed/improved validation messages

* fix tests

* fix stupid ide refactor mistake

* lint fixes
2022-03-12 16:14:32 -06:00
Tony Murray 6d3bf03074 Display Name in availability map (#13841)
* Display Name option in availability map widget

* fix availability map page and shortDisplayName
2022-03-12 16:14:09 -06:00
Josh Silvas a9e111f3eb Adds API call to update port notes on devices. (#13834)
* Adds API call to update port notes on devices.

* Lint fixes.

* Fixes file permissions to proper values.
2022-03-10 22:29:08 +01:00
Charly Forot 48e68ec1dd Fix class error name (#13833)
Mistake on $class variable, value was 'er' instead of 'ber'.
This error prevented the ber graph located at Devices->Health->Overview
to correctly appear.
2022-03-09 00:06:19 +01:00
Neil Lathwood 703745d0ed Resolved XSS issue from alert rule list modal (#13805) 2022-02-22 08:28:31 -06:00
Joel Wilson 2e5b343731 Add usage hints for Display Name placeholder usage (#13801) 2022-02-20 12:59:53 -06:00
Mark Westerterp 1df78d9503 UI: Fix second menu bar in Apps screens (#13800)
* Fix bug introduced in 2016
Introduced when changing over from tables to divs.
Caused by commit: https://github.com/librenms/librenms/commit/bda31d7152e78b8e484c7b16accdbf7edeaaf96f

* Apps: bring second menu bar in line with main menu
Scope limited to applications

* Style fixes
2022-02-18 09:19:36 -06:00
PipoCanaja 6ac13825ce Improved search results for port descriptions (#13787)
* restore pre Dec 6 2021 Description display

* restore full ifAlias

* patch from fbourqui to fix type display
2022-02-17 20:57:51 +00:00
PipoCanaja f24bb42cb2 Hide community and make it XSS safer (#13783)
* sanitize message display

* sanitize message display

* safe display of community, and community hidden until focus occurs
2022-02-14 13:03:01 +00:00
Neil Lathwood 95970af78e Moved some pages to be within admin route (#13782)
* Moved plugin admin pages to be within admin route
* Wrap html transports page in admin check
* Moved Port group controller to be admin protected
* fixed tests
2022-02-14 08:40:30 +01:00
PipoCanaja 4c9d4eefd8 XSS fixes (#13780) 2022-02-13 20:54:58 +00:00
PipoCanaja 41ddce6377 XSS fix, cont. again (#13778)
* XSS in alert template creation

* XSS in alert rule name

* XSS in service name & desc

* style

* strip_tags in alert_notes

* strip_tags in create_alert_item

* strip_tags in addsrv page
2022-02-13 20:23:07 +01:00
Peca Nesovanovic 0029e9f161 [refactor] Eloquent for includes/html/pages/device/health.inc.php (#13777)
* [rewrite] includes/html/pages/device/health.inc.php
* translate sensor names
* ci
2022-02-13 19:20:47 +01:00
PipoCanaja 4f86915866 XSS fix, cont. (#13776)
https://huntr.dev/bounties/13951f51-deed-4a3d-8275-52306cc5a87d/
2022-02-13 19:07:37 +01:00
PipoCanaja 135717a9a0 security - XSS Fix 01
fixing https://huntr.dev/bounties/114ba055-a2f0-4db9-aafb-95df944ba177/ (#13775)
2022-02-13 11:00:56 +01:00
Santiago Z 7d2ade71f1 [WebUI] Show selected selection option on graphs page (#13765) 2022-02-11 11:06:41 +01:00
Jellyfrog b9e55bc462 Upgrade to font awesome 5 (#13754)
* Upgrade to font awesome 5

* Update memory icon
2022-02-09 00:49:07 +01:00
ilGino 58c88a6db3 [WebUI] Removing colon symbol from multiple dialogs (#13742)
* [WebUI] Removing the colon symbol from dialogs

In order to make multiple pages more visually consistent with other pages in the system, removed the colon simbol ":" to the very right of each control description, where present.

Regards
GG

* Update new_alert_rule.inc.php

* Update alert_schedule.inc.php

* Update alert_template.inc.php
2022-02-03 15:51:51 +01:00
Santiago Z b93a892feb [WebUI] Added the word Actions in the header of the oxidized-nodes table (#13741) 2022-02-02 02:07:35 +01:00
Tony Murray 29bd6789cb Stp module rewrite (#13570)
* STP module rewrite WIP

* Finish rewrite

* Ignore disabled and log root/topology changes

* Remove interfaces for now

* fix style

* Lint fixes

* Document ResolvesPortIds and hide map functions

* whitespace fixes

* Revert to stpInstances in case someone writes mstp support

* missed one

* phpstan fixes

* Handle table and oids separately

* forgot to register observer

* Test data and correct non-table handling in SnmpResponse->table()

* update test

* test data

* revert aos7 silly things

* minimal polling

* Update test data

* order ports_ntp and rename new field to port_index

* forgot the db_schema

* revert ciena-sds port things

* MSTP support, maybe

* Adding test data

* Filter bad lines instead of discarding the entire snmp response
and capture fixes and test data

* fresh data

* add os data

* update data, ignore unfound ports, obviously bad device implementation.

* fixes

* Ignore context files in os detection test

* Remove empty table data

* add ciena-sds vlan

* designatedCost column is too small

* Update stp webui

* Refactor code to interfaces, to allow vendor mibs

* update schema

* fix issues added by abstraction

* STP fixes

* Default to no context for vlan 1

* never store vlan 1

* Update test data

* remove eltex brokenness

* fix style

* fix stan

* Fix Rewrite MAC to Hex padding with floats

* fix sqlite migration
2022-01-30 16:28:18 -06:00
Tony Murray b6a8b602b8 Oxidized update and Device remove (#13730)
* Oxidized + Device remove
Was just working on oxidized, but then to properly update nodes after delete, updated delete_device()

* revert dumb style changes

* baseline update and no DI there...

* Fix OS first load and device deletion missing tables
2022-01-29 21:09:05 -06:00
ilGino d2d07b8c88 Place a more consistent Fontawesome icon for the Export to PDF (#13713)
In Alerts >> Alert History

1 - reword "Export to pdf" to "Export to PDF"
2 - replace the Fontawesome Heartbeat icon with the Fontawesome File to PDF icon.

Regards
GG
2022-01-26 22:43:22 +01:00
Jellyfrog 1debe5e166 Use built in method to render a string with Blade (#13688) 2022-01-26 07:10:06 -06:00
ilGino 20495d648c [WebUI] 2/2 Services - Removing the colon symbol to the right of a control label (#13705)
In order to make the Services Add or Edit pages while adding a Service more visually consistent with other pages in the system, removed the colon simbol ":" to the very right of each control description, where present.

Regards
GG
2022-01-24 22:20:14 +01:00
ilGino aaf8e37c09 [WebUI] 1/2 Services - Removing the colon symbol to the right of a control label (#13704)
In order to make the Services Add or Edit pages while adding a Service more visually consistent with other pages in the system, removed the colon simbol ":" to the very right of each control description, where present.

Regards
GG
2022-01-24 22:20:05 +01:00
ilGino f1e436a55e Removing the colon symbol to the right of a control label (#13698)
In order to make the "Device setting" tab while Editing a device more consistent with other pages in the system, removed the colon simbol ":" to the very right of each control description, where present.
This because in no other HTML pages we find that the label with the control description is followed by a colon symbol.

Regards
GG
2022-01-22 13:28:37 +01:00
Andrea Beccaris 0fc2f9e4c9 Add API-routes for listing MPLS SAPs and services (#13561)
* add apis for mpsl services and saps

* updated docs

* removed dbFetch, orm instead

* changed queries

* Removed unused variables

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api_functions.inc.php

* Update api_functions.inc.php

Co-authored-by: laf <gh+n@laf.io>
2022-01-20 08:15:23 -06:00
SourceDoctor df288edbe3 remove unneccessary Section Description (#13677) 2022-01-15 09:59:56 -06:00
Henne Van Och 8f8872520a Add supervisord application (#13673) 2022-01-13 18:19:27 +01:00
Neil Lathwood 42d84da24a Device tracepath using wrong variables to check for traceroute output (#13674) 2022-01-13 17:34:36 +01:00
Gilles Depeyrot 7453ca65ae Allow filter by display name in device list (#13665)
* Corrected filtering of devices under maintenance

* Fix display of device sysname in alert history stats widget

* Merge LibreNMS master

* Enable searching for devices using display name

* Enable searching for devices using display name
2022-01-11 12:55:43 -06:00
bonzo81 107736697c Add Sla jitter packet loss percent graph (#13600)
* Add sla packet loss percent rrd graph

* Add packet loss percent div

* Add OID for NumPackets

* Fixed CDEF typo

* Rename graph file to include .inc

* Flipped axis for Src and Dst to match key

* Create new rrd file for loss percent

* Remove duplicate rrd data and rename rrd to reflect

* Amend to use second rrd file for NumPackets

* Removed spaces

* dbFetchRow be gone

* insert if statement check

* white space cleanup

* New line at end of file

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-01-09 18:57:16 -06:00
Maikel de Boer fa3367f5c6 Timos sap dot1q graphing fix (#13654)
* Added wireless MSE

* dot1q sap graph fix

* Fix removed files

* fix

* Fixed style

* Fixed style

* Fixed style

* Removed vscode workspace file

* Clarification
2022-01-09 10:33:32 +01:00
Peca Nesovanovic 2d57e49caf Teleste Luminato ports & qam/asi output sensors & yaml (#13616)
* Luminato: bitrate sensor

* bitrate sensor Eloquent

* luminato ports

* luminato ports styleci

* luminato QAM/ASI sensor

* luminato QAM/ASI sensor styleci

* YAML & test

* drop debug $ver from sensor type

* mess with Teleste ifExtPhysInterface/ifExtLogiInterface

* styleci

* test data

* mistake in port discovery

* left out Graphs->Health->Overview->Bitrate label

* fixed Bitrate graph, copy/paste errors
2022-01-08 18:17:08 +01:00
Tony Murray 4b64d33d13 API detect if new location should be fixed by default (#13637) 2021-12-27 17:32:50 -06:00
VTS 1ac60e3b1d set fixed_coordinates via api (#13593)
* set fixed_coordinates via api

* update api doc

* fix style problem

* Update Locations.md

* Update api_functions.inc.php

* Update api_functions.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2021-12-23 15:32:02 -06:00
Denny Friebe e24862545d Fix the displayed unit for frequency and distance in the wireless section (#13614)
* Fix the displayed unit for frequency and distance in the wireless menu

* Small style fix
2021-12-13 08:30:57 -06:00
Tony Murray a95efd6d2a Global search: search device display (#13583)
* Global search: search device display
Add display field to search (also port_desc_descr, portName, and bgpPeerDescr)
Rewrite backend
update typeahead bundle
update devices and ports indexes
reduce some port field sizes so we can index them

* Style fixes

* remove nonsense
2021-12-06 16:12:24 +01:00
Denny Friebe 12a262744e Fix nototal graph option (#13589) 2021-11-30 19:21:09 -06:00
Tony Murray 99fbdeef02 Do not show location in device overview if location is not found (#13572) 2021-11-26 18:54:29 +01:00
Claude Brown 6bf97c6ac9 API 'list_parents_of_host' - mostly doco, but one small code enhancement (#13567)
* Allow 'list_devices' to query by exact device-id

* Remove 'http://' prefix from --dev-addr in doco for 'mkdocs serve'

* Document 'list_parents_of_host' API call by reference to 'list_devices' call

* Remove possibility of SQL injection attacks

* Remove possibility of SQL injection attacks
2021-11-25 22:38:50 +01:00
Feras Al-Kassar 35a6905092 Fix security vuls (#13554)
* Fix XSS vulnerabilities

* fix XSS vulnerabilities in alerts.inc.php

* fix XSS vulnerability in poller-groups.inc.php

* small fix for the integration

* another fix for the inegration

* another fix for the inegration

* change the sanitizer at sources instead of json_encode sinks

* another change sanitizer at sources instead of json_encode sinks

* another change sanitizer at sources instead of common_output and current_config sinks

* fix path manipulation vulnerability
2021-11-24 10:00:25 -06:00
Tony Murray 790c4b3402 Configurable device display name (#13528)
* Configurable device display name
You can just set the display name in device settings.

It also accepts simple template format with  the variables: hostname, sysName, sysName_fallback, ip

Default controlled by device_display_default, (set from old force_hostname_to_sysname and force_ip_to_sysname settings

* remove second argument to format_hostname()

* Style fixes

* Update schema

* update phpstan baseline

* Improved settings strings (and add for translation)
2021-11-18 15:46:22 -06:00