Commit Graph

7643 Commits

Author SHA1 Message Date
Tony Murray
aefd14d3aa Graph API use new code path (#14493)
* Graph API use new code path
Improves error handling significantly

* Actually base64 encode it
2022-10-22 14:58:51 -05:00
SourceDoctor
04f0574132 show id on device dependencies (#14497) 2022-10-22 19:52:51 +02:00
Jellyfrog
9422b34294 RFC1628: Correct upsBypassVoltage oid (#14488)
* RFC1628: Correct upsBypassVoltage oid

* Update istars.json
2022-10-22 11:46:51 +02:00
Jellyfrog
19cff69c28 Liebert: use correct description oid (#14489)
* Update liebert.json

* Update liebert.inc.php
2022-10-22 11:46:34 +02:00
Zane C. Bowers-Hadley
a166df006a base64 gzip compression support for json_app_get (#14169)
* add lnms_return_optimizer

* add compression test using zfs-v1

* minor style fix

* save the original output if not json

* replace gzinflate with gzdecode as apparently that does not require yanking the header

* Minor comment cleanup. Also note it in the application notes as well.

* update docs on how it is called

* update the spelling of it in a few places

* and a few more

* dev docs updated a bit

* the suricata extend has native support for this now

* add exception handling for base64 and gzip decoding failure

* minor cleanup for new exceptions

* minor misc changes

* minor formatting fix

* more phpdoc tweaks

* minor formatting tweak

* remember to actually include the new exceptions

* more phpdoc tweaking

* correct name in JsonAppGzipDecodeException

* add debug and verbose output

* style fix

* not base64 is it starts with a line with only a integer
2022-10-21 10:05:49 -05:00
Jellyfrog
0f13b37b4c Fix fetch ifEntry logic (#14483)
* Fix fetch ifEntry logic

* Update includes/polling/ports.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-21 07:28:41 -05:00
Jellyfrog
3848941d55 hpe ilo: fix filesystem type regex (#14485)
* Update hpe-ilo.inc.php

* Update hpe-ilo_4_with_bat_checks.json

* Update hpe-ilo_5_with_bat_checks.json
2022-10-20 22:50:00 +02:00
Jellyfrog
56d0c7af19 intelliflash: correct variable typo (#14486)
* intelliflash: correct variable typo

* Update intelliflash.json
2022-10-20 22:49:46 +02:00
Jellyfrog
b18ba17af0 Miscellaneous cleanup - part 4 (#14452)
* Miscellaneous cleanup - part 4

* wip

* wip
2022-10-19 01:33:06 +02:00
Jellyfrog
31a237b114 Miscellaneous cleanup - part 3 (#14450)
* Miscellaneous cleanup - part 3

* Apply fixes from StyleCI
2022-10-19 00:34:19 +02:00
Jellyfrog
34a58c3f9f Miscellaneous cleanup, mostly undefined variables - part2 (#14445)
* Miscellaneous cleanup, mostly undefined variables - part2

* wip

* Update Number.php

* Update BridgeMib.php

* Update Xdsl.php

* Update cisco.inc.php

* Update Cisco.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update avtech.inc.php

* Update functions.inc.php

* Update HostResources.php

* Update ports.inc.php

* Update route.inc.php

* Update cisco.inc.php

* Update Cisco.php
2022-10-18 13:30:42 +02:00
Jellyfrog
1c9234adf1 Hikvision: Dont include empty storage sensor (#14453) 2022-10-18 12:33:41 +02:00
Jellyfrog
2e187d82b2 Benuos: Remove undefined sensors (#14449) 2022-10-18 12:33:19 +02:00
Jellyfrog
2ca4596594 Drac: use correct low warn limit variable (#14447) 2022-10-18 12:32:10 +02:00
Tony Murray
d86cbcd96d Fix alert rules XSS (#14471)
Fixes html injection for map items
2022-10-17 12:32:58 -05:00
ottorei
abf00ea75e Fix missing device_id from device alert logs (#14460) 2022-10-17 11:15:41 -05:00
Tony Murray
43cb72549d Fix billing xss (#14465)
bill_name and bill_notes fields allow html injection
2022-10-17 09:04:22 +02:00
Tony Murray
ae3925b09a Fix memcached unserialize vulnerability (#14459)
Allows code injection, so remove it entirely.
This requires a memcached application script to restore functionality.

https://github.com/librenms/librenms-agent/pull/428
2022-10-16 11:15:17 -05:00
Tony Murray
8e85698aa3 Fix possible RSS XSS (#14457)
Escape titles when shown.  Body was already cleaned.
2022-10-14 13:24:22 -05:00
Jellyfrog
bc48c8412a Correct aviatModemCurModulationRx oid (#14446)
* Update aviat-wtm.yaml

* Update aviat-wtm.json
2022-10-12 20:30:26 +02:00
bnerickson
4efbb83d9b Add pwrstatd application (#14365)
* Add pwrstatd application

* Adding pwrstatd test json and correcting pwrstatd snmprec file.  Pwrstatd tests pass.
2022-10-12 11:01:09 +02:00
Tony Murray
fafd989971 Fix pseudowires pages (#14441)
Thanks to @scottbob09 from #14340
2022-10-11 16:09:59 -05:00
PipoCanaja
1fd915c8a3 Fix VRP duplicate BGP Peers (#14431)
* fix VRP not cleaning BGP peers properly

* fix missing field in BgpPeer model

* Update includes/discovery/bgp-peers/vrp.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-11 20:26:56 +02:00
Jellyfrog
7207614437 Trim whitespaces from device data (#14429)
* Trim whitespace from sensor and ports data

* Update arista_eos_vrf.json

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update Os.php

* wip

* wip

* wip

* Update querybuilder.json
2022-10-11 12:50:38 -05:00
Jellyfrog
bc9228ca8d snmpwalk functions: dont include invalid data (#14438)
* snmpwalk functions dont include invalid data

* wip

* wip
2022-10-11 09:03:08 -05:00
Jellyfrog
be1a2cec50 Miscellaneous fixes, mostly undefined variables (#14432)
* Miscellaneous fixes, mostly undefined variables

* Update phpstan-baseline.neon
2022-10-11 11:30:00 +02:00
Jellyfrog
071173ffb9 Remove tabs from yaml (#14437)
* Remove tabs from yaml

* Remove tabs from random files
2022-10-10 18:13:10 +02:00
Jellyfrog
9d00b0c12c Run CI on ubuntu 22.04 (#14379)
* Run CI on ubuntu 20.04

* wip

* wip

* wip

* Update all test data

* remove slashes

* wip

* wip

* wip

* wip

* wip

* wip

* iwp

* wip

* wip

* wip

* wip

* wip

* wip

* wip

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-10 16:44:11 +02:00
Martin22
19540900a3 Added support for Ubiquiti UFiber OLT (#14256)
* Added support for Ubiquiti UFiber OLT

* Fixed php files with port detection

* Added missing MIB file

* Fixed test data

* Fixed php script to detect ports compatible with php 8.1

* Fix styleci

* Enforcement of new control styleci

* Apply fixes from StyleCI

* Port detection override

* Changed all "Entry" to "Table".

Co-authored-by: StyleCI Bot <bot@styleci.io>
2022-10-07 22:42:03 +02:00
rhinoau
b8b4b8ebd8 Added support for additional Moxa EDS-G models (#14405)
* Added support for additional Moxa EDS-G models

* MIBs and tests
2022-10-07 21:52:31 +02:00
carbinefreak
ff5b565fec MNI Microwave OS Add (#14427)
* Add files via upload

* Create mni.yaml

* Create mni.yaml

* Add files via upload

* Add files via upload

* Update Mni.php

* Update Mni.php

* Add files via upload

* Add files via upload

* More Formatting Fixes

* Add files via upload

* Add files via upload

* Update mni.yaml

* Create MNI-PROTEUS-AMT-MIB

* Add files via upload

* Update Mni.php

* Update Mni.php
2022-10-06 20:24:37 +02:00
Tony Murray
e4fdbbd82d Fix bgp-peers bgpIfAce bug and update test data (#14420)
* Update bgp-peers test data

* Fix bgp-peer bgpPeerIface

* Update test data, requires ipv4_addresses table
2022-10-03 12:55:49 -05:00
PipoCanaja
0e14dea12d Fix bgp_peer array_merge error (#14416) 2022-10-03 18:16:23 +02:00
Tony Murray
878666bb26 Revert "Update common.inc.php (#14407)" (#14419)
This reverts commit 698275dd12.
2022-10-03 08:23:44 -05:00
jgelinas
3b5e93242a Skip empty drac state sensors (#14409)
* Newer iDrac includes empty dimm slots in the memoryDeviceTable
creating ', 0 MB' state sensors. Work around this by not discovering
entities that don't have descr_oid.

* Create drac_3.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-10-02 20:00:42 +02:00
Daniel
de524f2e05 Issue samsung printer m4080 fx (#14391)
* Added printer support to Samsung M4080FX which appears as generic

* Added printer support to Samsung M4080FX which appears as generic

* Create samsungprinter_m4080fx.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-10-02 19:54:53 +02:00
PipoCanaja
daa8c757f6 Fix a few Db* to Eloquent requests (#14278)
* Eloquent for 2 requests

* Eloquent for 1 request

* a few in Dell

* Model

* and more with timos

* and more with timos

* and firebrick

* firebrick

* one query instead of many

* Should use collection get

* Update timos.inc.php

* Update dell-os10.inc.php

* avoid changing timos as it breaks something

* new try with timos

* deps for BGP

* revert deps for BGP

* style

* style

* deps for BGP, 2nd try

* typo

* revert aos7

* fix create

* firebricktests

* firebrick

* firebrick

* cipsec-fix

* cipsec

* timos fix 100th time :)

* ./scripts/save-test-data.php -m os,ports,processors,mempools,vrf,sensors,bgp-peers,mpls,ospf  -o timos -v 7705

* remove timos from this PR

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-02 16:04:08 +02:00
Tony Murray
e4451714e2 version and git helper improvements (#14412)
* Fix up version and git helpers
Improve method names
Move all git calls into the git helper
Allow runtime and external cache of results where appropriate
Consolidate version headers for discovery, poller, and validate

* Style fixes

* improve consistency in git calls

* fix style

* don't send name inconsistently

* Improve database versions

* No need to cache Version it is not used more than once currently.
2022-10-02 00:41:56 -05:00
O Palivan
a0316f4b9e Added OS tait-tnadmin for TN9300 (#14413) 2022-09-30 23:22:24 +02:00
Maikel de Boer
0faaee0ac6 Enexus system output current fix (#14324)
* enexus fix

* added test data

* added testdata

* add test data

* added testdata

* added testdata

* added testdata

* removed variant

* added testdata

* added test data

* added testdata

* added testdata
2022-09-30 11:30:41 -05:00
Kevin Zink
698275dd12 Update common.inc.php (#14407)
Place the Y grid dynamically based on the graph's Y range. The algorithm ensures that you always have a grid, that there are enough but not too many grid lines, and that the grid is metric. That is the grid lines are placed every 1, 2, 5 or 10 units. This parameter will also ensure that you get enough decimals displayed even if your graph goes from 69.998 to 70.001. (contributed by Sasha Mikheev).
2022-09-30 13:21:10 +02:00
Lucas Gasenzer
833dab7a83 Enhanced Service Overview on Device Overview Page (#14410)
* changed viewbox and scale as fix for safari

* enhanced service overview with "$name ($type)"
2022-09-30 10:22:01 +02:00
Tony Murray
f60b6788d3 Cache version data (#14404)
* Cache version data
Calling cli commands can be expensive, cache the results.

* style fixes

* Fix pre-laravel usage

* fix lint
2022-09-28 23:23:32 -05:00
Tony Murray
59f9d90559 Fix rpi codec state sensor (#14400) 2022-09-27 14:44:01 -05:00
Tony Murray
14f449e567 Fix libvirt count() uncountable error (#14398) 2022-09-27 09:43:27 -05:00
Tony Murray
467cb0ab6b Fix Firebrick local ASN (#14397) 2022-09-27 07:45:51 -05:00
Tony Murray
5b432ddc05 Fix ups nut PHP 8.1 issue (#14392)
https://community.librenms.org/t/sensors-initialisation-fails-with-php-8-1/19697
2022-09-26 12:02:42 -05:00
Tony Murray
e990dfcb35 Disable plugins that have errors (#14383)
* Disable plugins that have errors
Disable plugin if a hook throws an error and set a notification
Move notification code to class, so we can access it
Clear notification when plugin is attempted to be enabled again

* fix style and lint fixes

* another lint fix and handle if property is missing
2022-09-25 22:47:58 -05:00
Félix Bouynot
333ba7c2cd Fix oxidized web requests unclosed connections or responding fast enough (#14370)
* Fix oxidized web requests not closing connections or responding fast enough

* Update showconfig.inc.php

* Add method to get the text content of an oxidized page

* Use Oxidized getContent method instead of file_get_content

* Too much brackets with copy paste

* Fix carriage return errors because of copy paste

* Fix copy paste error again

* Fix indent

* PHPStan is waiting for a return even outside of the if loop

* Single quotes

* Variabilize timeout in baseapi

* Set Oxidized Api class timeout var to 90 because oxidized is slow and to be sure not to break half the installs here

* fix typo

* Variabilize timeout

* Variabilize timeout

* Variabilize timeout

* Variabilize timeout

* Variabilize timeout

* Spacing

* Remove timeout type because of this error

Unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in app/ApiClients/BaseApi.php on line 34

* Lint needs type finally

* Use contruct instead of setting variable

* Type hinting instead for php7.3

* Type hinting fix

* Set property value instead of calling parent constructor

* Typo

* Remove unneededconstructors

* Remove unneeded constructors

* Remove unneeded constructors

* Remove unneeded constructors

* Remove unneeded constructors

* Remove unneeded constructors

* Typing not casting

* Typing not casting

* Cannot type variables outside of a class

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-09-24 14:24:11 -05:00
Kayck Matias
64dcfcb8cc Alert map location fix (#14380)
* Update devices in alert-logs to init_select2

* Fix function ->exists

* Add init_select2 to location filter in ports

* fixes

* Fixed alerts rule system not filtering by location
2022-09-23 14:15:46 -05:00