Commit Graph

534 Commits

Author SHA1 Message Date
Geoffrey Ferk
8919e96efe Correct unset in custom load discovery file 2020-06-23 15:09:43 -05:00
Geoffrey Ferk
5251487141 Corrected order of variables 2020-06-22 13:17:16 -05:00
Geoffrey Ferk
ceca1db568 Reduced number of snmp_gets by using snmp_get_multi_oid 2020-06-22 13:17:16 -05:00
Geoffrey Ferk
86adadbb61 Corrected indentation issue 2020-06-22 13:17:16 -05:00
Geoffrey Ferk
400ecca650 Added additional check to prevent state discover when current is empty 2020-06-22 13:17:16 -05:00
Geoffrey Ferk
a1693abf56 Added additional check so service does not get added if snmp data is empty 2020-06-22 13:17:15 -05:00
Geoffrey Ferk
21754f84e5 Made scrutinizer recommended changes 2020-06-22 13:17:15 -05:00
Geoffrey Ferk
4de39dbb2e Changed double quotes to single for consistency 2020-06-22 13:17:15 -05:00
Geoffrey Ferk
3093ee72cd Made adjustments based on scrutinizer recommendations 2020-06-22 13:17:15 -05:00
Geoffrey Ferk
277401d78b Modified dhcpatriot load discovery 2020-06-22 13:17:15 -05:00
Geoffrey Ferk
30656481d9 New OS: DHCPatriot (dhcpatriot) 2020-06-22 13:17:15 -05:00
yon2004
953def1518 Added discovery for ups-nut status (#11606)
* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Added UPS NUT state sensors

* Update linux_ups-nut.snmprec

* Fixed UPS states so making alerts easier.

* Fixed

* Actually Fixed it

* Added alert rules for UPS-NUT
2020-06-18 09:43:11 +02:00
ryanheffernan
801d9a1dcf Workaround for bad entSensorPrecision values (#11757) 2020-06-04 22:23:59 -05:00
Dragan Savic
79ca57ed28 Fix cisco sensor thresholds (#11547)
* Update functions.inc.php

Skip changing the high limit threshold to low limit threshold value when high limit threshold doesn't exist for a sensor. If low limit threshold value was set by discovery process or manually, the same value would be also set for high limit threshold.

* Update cisco-entity-sensor.inc.php

Skip invalid sensor threshold values, which some Cisco ASR devices (probably other families too) return.

* Add snmprec data for Cisco ASR9010

* Create iosxr_asr9010.josr

* Create iosxr_asr9010.json

* Delete iosxr_asr9010.josr

* Update iosxr_asr9010.json

* Update iosxr_asr9010.json

Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-05-25 13:53:38 +02:00
joseUPV
abd9600ba4 Fix unit state sensor oid for aos6 (#11639)
* Fix unit state sensor oid for aos6

* added fixed aos6 test data
2020-05-19 14:36:20 -05:00
joseUPV
9ac05f48b8 AOS Advanced Support. (#11500)
* Comes from PR11322.

* Code changes to solve github-apply warnings. Removed aos tests.

* Added new aos tests.
2020-05-18 07:50:13 -05:00
Tony Murray
0e9cd8fbc4 SIAE Radio: add additional sensors and data (#11498)
* SIAE add additional sensors and data
Improved labels
Modulation
Rate
Serial Number
Hardware name

* Add total rates

* was supposed to be divisor

* Short array syntax
2020-05-01 22:11:35 -05:00
Jurrian van Iersel
d61cfb5688 Added sensors for outlets on Schleifenbauer devices. (#10949)
* Added sensors for outlets on Schleifenbauer devices. Also use the outlet name when configured.

* Updated tests for Schleifenbauer

* Fixed on test for Schleifenbauer

* Optimized polling by retriving only outlets from the device with the network connection, not all devices on the data-bus.

* Fixed code styling

* Use shorthand comparisons for names

* Fix for conflicting $entPhysicalIndex
2020-04-27 00:35:00 +02:00
dGs-
a50558cbc7 doesn't add not available sensors (#11259) 2020-04-26 13:33:11 +02:00
robwilkes
daebf8c765 Cisco sensor discovery fixes (#11077)
* Sev and Rel terminology varies between devices

* Most temp sensors don't have low limits, so adding

* update test data

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-04-23 22:30:27 -05:00
priiduonu
3263839780 rename $state to $state_name (#11473)
rename $state to $state_name to keep better consistency with other modules
2020-04-23 13:44:02 -05:00
priiduonu
4df3310d4d Fix: Raspberry Pi frequency sensors discovery (#11460)
* Fix: Raspberry Pi frequency sensors discovery

* updated test data

* update test data again

* fixed Raspberry Pi codec states
2020-04-22 21:53:27 -05:00
Tony Murray
1c08c11a77 Remove Laravel helpers (#11428)
* Remove Laravel helpers

* Replace qualifier with import
2020-04-18 00:37:56 +02:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Kevin Zink
b03c3bb996 Changed USV bypass state from alert to warning (#11356)
* Changed USV bypass state from alert to warning

* add /opt/librenms/tests/data/dell-ups_tower1000w.json

* add deltaups.json

* orvaldi-ups

* add generex-ups.json

* include two more generex-ups variants

* add eaton-mgeups_5px.json

* add tree more

* add istars.json

* restart hanging CI
2020-03-30 11:37:08 +02:00
Kevin Zink
3567386c48 Add Device: Innovaphone (#11225)
* Add Device: Innovaphone

* fix typo

* Move mib to subdir and Refresh testdata

* Fix typo

* Fix discovery index

* force test re-run

* Cleanup

* image

* Update innovaphone.yaml

* Update innovaphone.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-03-06 23:33:31 +01:00
Kevin Zink
7254f13b26 Aruba cluster userfriendly read (#11217)
* Aruba-Instant: Include hostnames as a better identifier for mesh members sensors

* Refresh testdata
2020-02-27 15:35:28 -06:00
Heath Barnhart
e83583f6f4 Adva FSP150cc Health Sensors (#11168)
* initial commit adding sensors

* changed dbm logic for port exclusions

* update mib, added xg116 support, update disc logic

* sfp health appears on ports page

* added sfp temps

* updated mib file names

* updated mib file names

* removed .mib extension

* replace ADVA-MIB

* Add test data

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-02-26 12:00:48 -06:00
Kevin Zink
06b9ace0fb device: Correct ups-nut sensors (#11113)
* Change ups-nut sensors
* Revert the dd-wrt files
2020-02-09 20:47:03 +01:00
Martijn Schmidt
a64bd45dbc Update IronWare sensors & bgp-peers discovery, allow skip_values to target a specific index appended to the OID (#10941)
* Migrate ironware sensor discovery from php to yaml.

* More sensors, add grouping.

* dynamic_discovery_get_value() becomes getValueFromData()

* Target a specific index with skip_values.

* Improve Brocade BGP session discovery/polling

This commit allows for the correct discovery of BGP sessions
with 32-bit ASNs, IPv6 neighbors using the BGP4V2-MIB which is
based on draft-ietf-idr-bgp4-mibv2-11 and also polls for IPv4
unicast received routes through the FOUNDRY-SN-BGP4-GROUP-MIB.

Copied most of the code from PR#8877 by @Mikeburke14, cleaned
up the code a little bit to match the normal LibreNMS style,
and fixed bgpPeers_cbgp discovery as well as polling for the
ipv4.unicast neighbors.

Note that older Brocade IronWare firmware versions are known
to have multiple defects relating to the BGP4V2-MIB which
might result in certain missing non-established neighbors.

Related vendor defect numbers:

- DEFECT000633962
-- Symptom: The OID bgp4V2PeerAdminStatus does not return the
            correct value
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00g

- DEFECT000583319
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
            does not display all the BGP entries
-- Reported: NI 05.6.00
-- Resolved: NI 05.8.00e

- DEFECT000550309
-- Symptom: SNMP polling on bgp4V2PeerTable (OID brcdIp.3.5.1.1.2)
            does not display the full information
-- Reported: NI 05.7.00
-- Resolved: NI 05.8.00c

* Add ironware CER & ICX platform test data.

* Re-add ironware.json compatible with current master branch.
2020-02-01 23:28:03 +01:00
Josh Baird
1c043069b1 Fixed Siklu Voltage Sensor (#10997)
* Fix Siklu Voltage

* Update tests

* Another test fix attempt

* Decimals..

* Ok, enough.

* Restore currently used index value and correctly push num_oid

* Update siklu.json

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2020-01-22 09:32:39 +00:00
Josh Baird
664ca1fee3 Added state sensor for Packetflux Sitemonitor Switch Input (#10994)
* Initial stab at switch input state sensor

* Fix indentions

* Fix indentions

* Index updates

* More useless changes.

* And it finally works.

* Open should be a WARNING state.

* Update email

* Add line

* One empty line, not three.

* This is getting ridic.

* Add test data
2020-01-10 15:52:26 +00:00
PipoCanaja
c9ae2891dd Rewrite Microsemi Midspan Power Sensors with mib (#10959)
* rewrite with mib
* tests
2019-12-18 09:59:34 +01:00
PipoCanaja
d9c7772804 Avoid state collisions between 'dell' and 'drac' OSes (#10539)
* avoid state collisions between dell and drac OSes
2019-11-03 12:59:08 +01:00
Erik
610fde83ec Removed double Stack Temperature Discovery and Fixed typos in dbm discovery for Dell Switches (#10630)
* Fixed typos in dbm discovery for Dell Switches

Fixed typos in dbm discovery for Dell Switches

* Skip value 0 in temperature sensors

* Update dnos.yaml

* Remove temp M-serie from php, already in yaml

* Create dnos_s4048.snmpsim

* Rename dnos_s4048.snmpsim to dnos_s4048.snmprec

* Create dnos_s4048.json

* Create dell-net.inc.php

Added mempool for Dell Net switches

* Update dnos.yaml

Removed whitespaces in dnos.yaml

* Update dnos_s4048.json

* Delete dnos.json

* Create dnos.json
2019-10-21 01:41:32 +00:00
joseUPV
e0cff12f69 Better Support of Alcatel Switches (#10672)
* Added model, processor, fan and power supply for Alcatel Omnistack Switches

* Removed Index from description of Fan and power supply

* Merged PR #10655

* Added Temperature Sensor for AOS7+ Alcatel Enterprise Switches

* Added AOS7 mempools

* Added Tests

* Update aos.yaml

* Update alerts levels in state sensors

* Add test data
2019-10-20 22:26:21 +00:00
Tobias Heister
728bc5f790 Improved RARITAN PDU/PDU2 MIB (current, power) and external env. sensors (#10616)
* added support for PDU/PDU2 MIB data (current, power) and added external sensor fpr humidity and temperature on PDU MIB

* added test data of 1 PDU-MIB device and 1 PDU2-MIB device

* Create raritan-pdu.json

* forgot to do save-data on last commit
2019-10-20 21:26:40 +00:00
Vitali Kari
4990c871d6 do not discover dbm sensors on shutdown ports (#10610) 2019-09-18 12:39:52 +00:00
Søren Rosiak
9768790440 CiscoSB: Skip notPresent ports from state sensors (#10545)
* CiscoSB: Skip notPresent ports from state sensors

* Update ciscosb.inc.php

* Create ciscosb_sg350x-48.json
2019-09-14 23:43:08 +02:00
Martijn Schmidt
3a891ba727 Convert opengear to YAML-based discovery, add some new sensors, add test data (#10553)
* Update opengear MIBs to latest version.

* Replace PHP signal discovery with YAML.

* Update Opengear YAML with new sensors.

* Add test data for Opengear.

* Add the test data json for Opengear.

* Named to numbered index to avoid data loss.
2019-08-27 16:54:08 -05:00
Martin Zatloukal
f16805b71d Added support Ericsson MINI-LINK (#10546)
* Added support Ericsson MINI-LINK
* cleaning
2019-08-22 13:19:50 +02:00
ig0rb
3342210067 FS.net pdu (#10424)
* Added support for snmp monitored PDU from fs.com

* Added support for snmp monitored PDU from fs.com

* Fix sysObjectID 1.3.6.1.4.1.30966

* Create fs-net-pdu.json
2019-07-23 22:55:53 -05:00
CirnoT
cafcf417fa Fix NetAgent II battery voltage (#10427)
* Fix NetAgent II battery voltage

* Add new test data and new icon for NetAgent
2019-07-22 23:34:31 -05:00
bergroth
b085703b2d Added support for DGD and BER on newer infinera-groove FW (#10435)
* Added support for DGD and BER that are avalible on newer infinera-groove FW
* updated tests for new groove sensors
* Update infinera-groove.inc.php
* Update infinera-groove.inc.php
* Force test to run again
2019-07-15 12:47:41 +02:00
ospfbgp
fc2f0a4552 Updated RAPID-CITY mib for Extreme VSP (#10406)
* Add files via upload

* Update voss.inc.php

* Update voss.inc.php

* Update voss.yaml

* Update voss.inc.php

* Update voss.inc.php

* Update voss.inc.php

* Update voss_7432cq.json

* Update voss_7432cq.json

* Add files via upload

* Add files via upload

* Update voss_8404.json

* Update voss_8608.json

* Update voss_8608.json

* Update voss_8608.json

* Update voss_8608.json

* Update voss_9012.json
2019-07-09 23:54:21 +02:00
rsys-dev
cfaf913896 Added detection for ZTE zxdsl devices (#10344)
* add yaml files

* Added include/definition/zxdsl.yaml (ZTE ZXDSL Support)
Added include/polling/os/zxdsl.inc.php (Set Hardware)

* Changed includes/definitions/zxdsl.yaml type from "dslam" to "network"
Changed includes/polling/os/zxdsl.inc.php removed unnecessary code
Added Testfiles

* Fixed coding guideline errors (missing spaces)

* Removed unnecessary "use"

* Improved model number discovery
Removed unavailable top graphs
Added System temperature

* Changed Temperature limits according to ZTE datasheet

* Updated Tests
2019-07-05 13:06:27 +02:00
Kevin Krumm
da9e67b296 Aruba IAP: Fix Radio State Sensor (#10335)
* Aruba IAP: Fix Radio State Sensor 

Fix state sensor for radio status from warning when disabled to unknown state.

* Update aruba-instant.json

* Update aruba-instant_105.json
2019-06-15 10:10:37 -05:00
StackOverBuffer
fec165fb86 Add power sensor for eaton ups (#10306)
* Add power sensor for eaton ups

* removed whitespace at end of line

* add test data
2019-06-11 23:46:43 -05:00
Marlinc
93f3528bbf Add Ipoman power consumption support (#10244)
* Add Ipoman power consumption support

* Create ipoman.json
2019-05-31 07:43:54 -05:00
Martijn Schmidt
9455a83478 Convert OS mrv-od to yaml, discover more sensors, discover entity-physical (#10266)
* Dynamic entPhysicalIndex values for YamlDiscovery

* Use degree symbol when displaying temperature values

* Adjust SNMP options for new snmp_get_multi()

The OS polling module for mrv-od was using snmpget commands with
-Ovqs, rather than -OQUs, which meant that the equal sign was
stripped in the snmpget output. But that equal sign is now used
as the explode() delimiter so it broke the construction of the
returned array for the snmp_get_multi() function.

Additionally, I removed the NBS-CMMC-MIB:: prefix which is no
longer returned by snmp_get_multi() as part of the OID. Now,
the mrv-od.inc.php OS polling module is retrieving data from
positions in the array with actual content.

* Convert mrv-od to yaml, improve sensors discovery

Converted sensors discovery for mrv-od to yaml, retaining all
functionality for pre-cache, dbm, and temperature. Replaced specific
SFF-8472 Digital Diagnostics state sensors with generic ones, given that
we are now reading out detailed values through new dbm, current, voltage
sensors.

Reasoning: the generic Digital Diagnostics state sensors report state
diagsOk, or else the worst severity level measured among all of the
Digital Diagnostics values for that optical data point. You'd really
only want to set a generic "alarm" so the box can report that it
thinks something is wrong, whereafter a human can look at the graphs
and/or the CLI to draw their conclusions about the alarm. Otherwise,
things would quickly become too spammy as you are essentially duplicating
every sensor across both regular measurements and state measurements.

Further changes:
- Increase maximum number of detected PSUs from 4 to 8 per the MIB.
- State sensor to detect (in)sufficient power budget for all modules.
- Use skip_values to hide state sensors with the notSupported value.
- Use skip_values to hide sensors which are unsupported per the MIB,
  signified by the device returning special values -1 or -2147483648.
- Add dBm, temperature "over" graphs to the mrv-od device header bar.

* Add mrv-od entity-physical support

MRV does not use the ENTITY-MIB data format, so we had to reconstruct
the inventory from their proprietary format using the following tables
from their NBS-CMMC-MIB:

- nbsCmmcChassisTable
- nbsCmmcSlotTable
- nbsCmmcPortTable

Additionally, since sensors didn't have their own ifindex in the
NBS-CMMC-MIB, I went ahead and appended the last OID digit to
the "containing" ifindex create a unique number. The same was
done for the sensors in the yaml-discovery.

* Test data for mrv-od, fix 2* pre-commit.php issues

* Fix entPhysicalIndex returning 0 instead of null

Some unit test breakage was caused by 62167ebcb which changed
the code to return 0 instead of null when {{ $index }} was
set as the entPhysicalIndex in the YamlDiscovery. So now we
detect if it returns some value which may be interpreted as
false, and if so we set null rather than 0.
2019-05-29 13:30:33 -05:00