Commit Graph

55 Commits

Author SHA1 Message Date
Tony Murray
e2eea17ee8 Work around jpgraph bug (#11425)
apparently GD now returns false when getting the bounding box of empty strings, this causes jpgraph to throw an incorrect error.  Work around that by setting all possible text to a single space character.
2020-04-16 09:18:44 -05:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Tony Murray
a59ab553be Don't show deleted ports in device overview (#11344) 2020-03-25 15:10:14 +01:00
fusedsynapse
68f957e0bc Fix invalid paths introduced in librenms/librenms#9883 (#11337) 2020-03-24 12:48:18 +01:00
Tony Murray
6c4d53d5e5 Fix previous with rrdgraph_real_percentile (#11306)
start and end only work with DEF (and are already devined for inoctetsX and outoctetsX.
2020-03-19 20:12:29 -05:00
Tony Murray
22e8b16530 Fix show rrdtool command (#11305) 2020-03-19 10:12:00 -05:00
Tony Murray
df16de9d2f Refactor Datastores to allow future improvements. OpenTSDB Tags. (#11283)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues

* Make sure port data is stored the same way as before for Graphite and OpenTSDB
Add ifIndex tag to all to be compatible

* Missed rrdtool_tune() call

* Test update WIP

* OpenTSDB now includes tags

* fix style
2020-03-16 09:17:58 -05:00
crcro
2ee2862357 app: mailcow-dockerized postfix stats (#11058)
* app-mailcow-dockerized-postfix

* fix docs

* updated niceCase

* test-data

* snmprec upload

* new test data

* new test data
2020-03-13 10:16:03 +01:00
Tony Murray
7fe895bd08 Revert "Refactor datastores to classes (#9179)" (#11273)
This reverts commit e5dad7a64e.
2020-03-11 07:52:52 -05:00
Tony Murray
e5dad7a64e Refactor datastores to classes (#9179)
* Datastores to object oriented code, using the Laravel IoC container

Change instantiation
better DI
move OpenTSDB

Small re-orgs

remove unused stuff

Fix graphs and other scripts

Use DI for all except rrd

fix up connection error handling

Add tests, fix up a "few" things
Add Config::forget()

Style fixes

Don't reference legacy code

remove accidental code paste

Add datastores phpunit groups

some tests

* rebase fixes

* some test fixes

* shorter tests

* shorter tests

* Don't except when rrdtool can't be started.

* restore tests

* fix rrd tests

* fix iterable change upstream

* fix isValidDataset

* fix invalid data bug

* fix mysql incorrect ds

* fix issue with data that is too long

* use regular data_update()

* Use log facade

* OpenTSDB mis-ordered arguments fix

* Making a singleton with different options makes different singletons.  Just use the global config settings to disable datastores.

* only filter tags for datastores that won't it don't modify the tags permanently

* Update copyrights to include original authors.

* Stats for all datastores

* Fix mysql sends different rrd / other ds names

* fix snmp last stats not initialized
remove unused function

* remove unused function and move single use function closer to its use

* InfluxDB does not need to update null or U values.
Skip write if all fields are empty

* Fix smart value checks

* fix style issues
2020-03-10 19:08:00 -05:00
SourceDoctor
2cfc7c6f14 Extended unbound monitoring (#11255) 2020-03-05 11:35:23 +01:00
SourceDoctor
d32273decd Graph CPU Steal and IO Wait (#11235) 2020-03-03 13:17:42 +01:00
SourceDoctor
53dc564ef5 Puppet Agent Monitoring (#10827)
* puppet agent monitoring

* change position of last run graph

* device overview panel

* updating documentation

* mouseover for Overview Dashboard

* adding blank line for code climate
2020-02-12 08:26:02 +01:00
Joseph Tingiris
02bc15c206 Asterisk app: add IAX2 peer graphs (#11078)
* Asterisk app: add IAX2 peer graphs

* It's an entirely new graph and will not break existing graphs.
* The asterisk extend script must be updated to provide the appropriate poller data.
* The PR for librenms-agent/snmp/asterisk is here: https://github.com/librenms/librenms-agent/pull/274

* code climate, round 1

* clarified unit text

* code climate, round 2

* changes needed to properly generate test data

* linux_asterisk-v1 test data
2020-02-03 18:47:27 +01:00
Hayden
46028521d2 add aggregate totals to multiport_bits graph, similar to port_bits (#11065) 2020-01-24 05:48:35 -06:00
SourceDoctor
6ffde9ce2d PureFTPd Application (#11048)
* PureFTPd Application

* graphing connected Users
2020-01-21 18:50:11 -06:00
louis-oui
934260cc75 Feature: Custom OID polling and graphing (#10945)
* merge

* fix db migration

* fix new auth

* fix new auth

* fix new auth

* fix new auth

* fix db schema tests

* fix polling customoid

* fix polling customoid

* fix graph

* fix graph

* fix graph

* fix CI

* fix CI

* always update prev value

* typo
2019-12-18 18:17:21 -06:00
PipoCanaja
8c04da9689 Use "format_hostname" for graphs' default title (#10891) 2019-11-29 16:20:18 +01:00
Tony Murray
7ad0735488 Port packet graphs should be pps not B (#10886) 2019-11-27 00:56:14 +01:00
Jozef Rebjak
c69efb3444 Added support for Mikrotik LTE Modem (#10805)
* Added support for Mikrotik LTE Modem

* Deleted mistaken file

* Travis fix

* Another Travis fix
2019-11-13 11:31:32 +00:00
SourceDoctor
4d50feffb3 Added certificate file validity check for services (#10354)
* snmp extend for monitoring certificate file validity

* Update Applications.md

* Update Applications.md
2019-11-05 21:56:31 +00:00
SourceDoctor
a0743d86dc Fixed mdadm sync speed title description (#10773) 2019-11-03 12:38:50 +01:00
SourceDoctor
8f1c77545d Added Seafile Server Monitoring (#10465)
* Seafile Monitoring

* generalized function for application with multiple similar entries

* adding snmprec file

* Create linux_seafile-v1.json

* Update linux_seafile-v1.snmprec

Updated linux_seafile-v1.snmprec to use 4x for encoding json data response

* Update Applications.md
2019-10-21 23:28:21 +01:00
pobradovic08
7f32af4f7b Add CISCO-IF-EXTENSION port stats for IOS/IOS-XE (#10644)
* Add CISCO-IF-EXTENSION polling and graph

* Added test data

* Code style

* Move CISCO-IF-EXTENSION-MIB to cisco mib dir

* Test data?

* Recollect test data again

* ios-xe variant 'ports' with ports test data

* Removed unnecessary test data
2019-10-21 00:39:14 +00:00
Tony Murray
1d7347dd62 Validate config schema, add types to all (#10723)
* Vaildate config_definitions.json schema

* finish adding types and other cleanups
2019-10-20 23:08:40 +00:00
pobradovic08
a2c69cd62f Added Cisco QFP module (#10637)
* QFP Discovery module
* QFP Polling module - Utilization
* Add Cisco QFP module in module list
* Web UI QFP discovery module
* Add average packet size graph
* Health overview QFP graph
* Polling and UI improvements, test data
* Reformatting and style checks
* Readd snmprec data
* Fix module performance stats collecting
2019-10-05 11:10:34 +02:00
SourceDoctor
ee2a847c0b Storage RRD - descriptionlength fix - percent column fix (#10607)
* Storage RRD - descriptionlength fix - percent column fix

* changed percentage column description

* increase also column length on furhter graphs

* fix column title length
2019-09-26 02:51:07 +00:00
SniperVegeta
82ea950263 Extended 'port previous' graphs (#10556)
* Update ping_perf.inc.php
* Update poller_perf.inc.php
* Update generic_data.inc.php
* Update generic_multi_seperated.inc.php
* Update poller_modules_perf.inc.php
* Update poller_perf.inc.php
* Update ping_perf.inc.php
remove // comment (old code)
* Update poller_perf.inc.php
remove // comment (old code)
* Update generic_multi_seperated.inc.php
remove // comment (old code)
* Update poller_perf.inc.php
remove // comment (old code)
2019-09-14 23:45:38 +02:00
Tony Murray
f1a7379f4a Fixed some graphs having the wrong timeframe (#10554) 2019-08-22 22:23:24 +01:00
PipoCanaja
d6862b0e34 Added Cisco-voice IP graphs (#10538)
* Cisco VoIP stats

* Cisco VoIP stats

* codeclimate

* codeclimate
2019-08-20 11:26:44 -05:00
Tony Murray
8d669a8a39 Simple linear port graph prediction (#10520)
* Simple linear port graph prediction
Simple linear prediction line for in and out if graph "to" value is in the future
Improve graph date handling

* thinner line

* Make test specify timezone
2019-08-19 22:53:48 -05:00
Tony Murray
f1c67ac5f4 Ports API: Workaround for ifNames with slashes (#10502)
* Workaround for ifNames with slashes

Basically,

/api/v0/devices/3/ports/0%2f4 -> /api/v0/devices/3/ports/ifName?ifName=0/4
/api/v0/devices/3/ports/0%2f4/port_bits -> /api/v0/devices/3/ports/ifName/port_bits?ifName=0/4

Or you can just use port_id.

* Fix API ports using ifName with slashes
hand parse the path for the ports graph endpoints
this way we can respect the original way of handling slashes (%2F)
2019-08-12 09:46:36 -05:00
SourceDoctor
a9cc36bc7f smart -power on hour - view fix (#10466)
* smart id9 view fix

* Update smart.inc.php

* Update smart_runtime.inc.php

* Update smart.inc.php
2019-08-07 07:32:25 -05:00
Zane C. Bowers-Hadley
0a6ded9ba3 nfdump support for with NFSen (#10376)
* rework the nfsen stuff

* add the new netflow stats page

* update the docs for nfsen

* add the functions back in

* readd the defaults

* rework lowest_five_minutes into lowest_time

* nfsen_channel_rrds removed and will rework it in later post rewriting

* rework something that accidentally got nuked in merging

* rework formatting a bit

* remove a accidentaly added chunk of text =^.^=

* rework some tag capitalization

* remove a accidentally added [

* '='=>' = '
2019-08-06 19:16:34 -05:00
Tony Murray
e99f421511 Remove legacy auth usage of $_SESSION (#10491)
* Remove auth use of $_SESSION

Will break plugins that depend on $_SESSION, Weathermap was already fixed.
Port them to use Auth::check()/Auth::user()/Auth:id()

* revert accidental replacement
2019-08-05 14:16:05 -05:00
Tony Murray
89fae9be1d Move API routing to Laravel (#10457)
* Add more api helper functions
to centralize code more

* Enable cors

* Initial Legacy route in Laravel

* Force api v0 responses to json
Add a couple more routes

* more paths, pretty print the json response
pass parameters to the api function

* devices basic functions

* Port generic graph function
check permissions function accepts callback to avoid lots of if statements

* move vlans

* links

* graphs

* fdb

* health

* wireless

* port graphs

* ip functions
split em up

* port_stack

* components

* compoment add/edit/delete

* get_device_groups

* port stats

* port graphs

* get_devices_by_group

* port_groups

* api_get_graph

* show_endpoints

* get_bill

* get_bill_graph

* get_bill_graphdata

* get_bill_history

* get_bill_history_graph

* remaining bill functions

* list_alerts

* ack/unmute alert

* Some cleanups

* Some cleanups

* list_alert_rules

* alert rule add/edit/delete

* inventory

* list_cbgp

* vrf

* list_ipsec

* list_fdb

* list_links (fix both usages)

* list_locations

* list_locations

* list_vlans

* list_ip_addresses

* list_arp

* list_ip_networks

* cleanup

* services

* list_logs and fix authlog.......

* cleanup

* cleanup 2

* remove slim

* don't load schema more than once

* basic test

* fix style

* downgrade laravel-cors to a version that supports PHP 7.1
2019-07-29 16:32:37 -05:00
jozefrebjak
625864ffa2 Added Support For Teltonika RUT2XX Devices (#10358)
* Added Support For TLT RUT2XX Devices

* Deleted unnecessary vaules

* required changes

* delete group unix

* updated tests

* Update rutos-2xx.json

* Update rutos-2xx.yaml

* Update rutos-2xx.json
2019-07-23 20:56:42 -05:00
Serazio
902aedcd82 Added F5 ssl tps, global server/client connection rate and active connections (#9883)
* Added ssl tps, global server/client connection rate and active connections

* Added ssl tps, global server/client connection rate and active connections

* Added ssl tps, global server/client connection rate and active connections

* Added ssl tps, global server/client connection rate and active connections

* Moved from  2x snmp_get to snmp_get_multi for SSL TPS

* Rewrite of polling module for f5.  Thanks to @PipoCanaja for code examples.

* Moved files to includes/html/

* changed array definition
2019-07-14 18:33:20 -05:00
Sander Steffann
164f3a096a Fixed smokeping graphs (#10415)
* Remove duplicate code

* Fix smokeping rrd file discovery

* Fix Smokeping outgoing graphs
2019-07-09 10:28:35 +01:00
SniperVegeta
242ab51e4e Fix atuc chan curr tx rate/atur chan curr tx rate (#10383)
* Update adsl_speed.inc.php

Change AtucChanCurrTxRate and AturChanCurrTxRate

AtucChanCurrTxRate  = Downstream
AturChanCurrTxRate  = Upstream

* Update adsl_snr.inc.php

AtucCurrSnrMgn = Down
AturCurrSnrMgn = Up

* Update adsl_attainable.inc.php

AtucCurrAttainableR = Down
AturCurrAttainableR = Up

* Update adsl_attenuation.inc.php

AtucCurrAtn = Down
AturCurrAtn =Up

* Update adsl_power.inc.php
2019-06-29 20:32:42 -05:00
Tony Murray
f3ba8947f7 Use Config helper (#10339)
remove usage of global variable
2019-06-23 00:29:12 -05:00
SourceDoctor
349e102b73 enhance smart to show power_on_hours also (#10261) 2019-06-06 23:39:22 -05:00
SourceDoctor
b9ed72f1c7 mdadm rrd graph fix (#10312) 2019-06-06 23:35:20 -05:00
Tony Murray
2f96570c3f fix smokeping graphs (#10317)
include pointed to the wrong place
2019-06-06 09:08:34 -05:00
jozefrebjak
bee4dbcd44 Changed color of Non Unicast Packets (#10289) 2019-06-03 22:25:22 -05:00
Tony Murray
437a577dba allow -24h style to/from for graphs again (#10294) 2019-06-02 01:18:50 -05:00
Tony Murray
9faae11381 Sanitize graph input (#10276)
Could execute arbitrary rrdtool commands such as cd and ls.
2019-05-31 07:43:12 -05:00
Llarian
0e36e52a63 Fixed Quick Graphs bug w/ Aggregate 95th code (#10269)
* Added configuration options to aggregate input and output bits before making 95th percentile billing calculations

* Changed aggregate to per-bill instead of global.  Added config options for making aggregate the default selected option.  Refactored out mres() calls in touched files.  Changed to Config::get where appropriate.

* Fixed documentation typo

* Fixed scope of aggregate default config option to be under billing

* Fixed getRates issue in Quick Graphs section of 95th percentile bill

* Added configuration options to aggregate input and output bits before making 95th percentile billing calculations

* Changed aggregate to per-bill instead of global.  Added config options for making aggregate the default selected option.  Refactored out mres() calls in touched files.  Changed to Config::get where appropriate.

* Fixed documentation typo

* Fixed scope of aggregate default config option to be under billing

* Fixed getRates issue in Quick Graphs section of 95th percentile bill

* Fixed formatting
2019-05-28 23:39:31 -05:00
Jozef Pivarník
2dc05ee501 Fixed Cisco MAC accounting discovery, polling and HTML templates. (#10158)
* Fix Cisco MAC acounting discovery, polling and HTML templates.

* Remove empty code.

* Provide test data for cisco-mac-accounting module.

* Added module test dependency.
2019-05-20 20:56:19 -05:00
SourceDoctor
96f7f142ba add mdadm support (#10159)
* add mdadm support

* Update mdadm.inc.php
2019-05-12 23:42:03 -05:00