Commit Graph

689 Commits

Author SHA1 Message Date
mabra94 fbfd0a72ee Bug - Handle Division by 0 error for SvcFdbTable (#14672) 2022-11-23 17:04:56 +01:00
Tony Murray 41967743f4 Fix neighbours XSS (#14658)
Reported via Huntr.dev by @zluudg
2022-11-19 21:44:14 -06:00
SourceDoctor df0c41672a custom port view fix (#14637)
* custom port view fix

* .

* code adjustment

* code adjustment

* .
2022-11-18 16:28:39 -06:00
Tony Murray 752bbc1531 Port search API search more than one fields (#14646)
* Fix port search columns

* Port search API search more than one fields
Fixup port APIs
Change validate_column_list api helper to throw a renderable exception on error and return the valid columns
DeviceCache::get() can handle a bigger range of input

* whitespace

* Refactor exceptions a bit

* change throws type to be more generic

* Lint fixes
2022-11-18 16:27:56 -06:00
electrocret 4c0ebb6f74 Add Columns to search_ports API function (#14348)
* Add Columns to search_ports function

* StyleCI

* StyleCI

* Add to Docs

* Suggested If fix
2022-11-17 10:18:09 -06:00
Tony Murray cb9e01a030 Fix device poller modules graph (#14640) 2022-11-16 13:48:30 -06:00
bnerickson 9b41fa3f30 Adding wireguard app to the apps overview page (#14629) 2022-11-13 22:58:00 +01:00
bnerickson bb536bb6fe Adding wireguard application support (#14625) 2022-11-13 11:07:24 +01:00
Kim Håkonsen f37def7986 Set 0 as integer in loading of graylog. (#14621)
#14476 probably made this require integer instead of empty string as default.
2022-11-12 15:03:24 -06:00
geg347 96c7e7166e Adding device's field in get_alert_rule and list-alert-rules API function (new) (#14481)
* Adding device's field in get_alert_rule and lis-alert-rules API function

* Converting SQL request for list/get_alert_rules to Eloquent (thanks a lot to Murrant)

* Manually added #14500 to pass pipeline

* Fixing StyleCI error + trying to fix PHPStan errors

* Trying to fix PHPStan errors (part 2)
2022-11-09 08:21:41 -06:00
Jellyfrog 71d740770b Remove Log::event (#14526)
* Remove Log::event

Use the Eventlog class directly instead

* wip

* wip

* wip

* Apply fixes from StyleCI

* Update Eventlog.php
2022-11-09 09:47:19 +01:00
Talk Straight Ltd 9826fa9089 feat: Add sortorder parameter to list_logs (#14600) 2022-11-08 18:20:34 +01:00
Zane C. Bowers-Hadley 8511611f64 add HV Monitor, a generic means for monitoring hypvervisors (#14218)
* add HV::Monitor support

* document hv monitor

* add HV Monitor tests

* style cleanup

* fix a few missed style items

* test fix

* more test cleanup

* more minor test tweaks

* more test cleanup

* more test tweaking

* test ordering fix all done... hopefully

* more test cleanup

* minor formatting change
2022-11-07 13:35:48 -06:00
Tony Murray 9cb6e7b665 Fix port neighbors missing (#14586)
Inverted check when fixing another bug
2022-11-06 17:06:10 -06:00
Jellyfrog 009d69a48d Use Collection instead of collect() (#14527)
* Use Collection instead of collect()

* wip
2022-11-05 10:04:36 +01:00
Tony Murray 78d6ed49ee Fix some icons (#14584)
fa-info icons, update to FA6 style
2022-11-04 23:13:36 -05:00
Tony Murray 539ef9ff90 Fix graph errors wrong content type (#14574)
Some code was returning too soon and messing up the return type
Other code was simply not setting it
2022-11-03 15:07:17 -05:00
Tony Murray 95e81a53a8 Fix device bits overview when no ports are included (#14573) 2022-11-03 13:29:17 -05:00
Tony Murray 2fb81ce429 Fix graph previous period getting partially applied (#14572) 2022-11-03 12:33:29 -05:00
Tony Murray 511e345321 API graphs, variable whitelist (#14552)
* API graphs, variable whitelist
Restore several missing parameters that relied on graphing code fetching from $_GET directly.
Whitelist valid parameters to set on the request get
Move common parameter handling into common code

* Fix style

* Include previous
2022-11-03 01:08:52 -05:00
Tony Murray 2dea36f70f Remove graph_min (#14561)
* Remove graph_min
it doesn't do anything
(scale_min sets minimum graph scale)
(graph_max shows a line at max on some graphs)

* fix style
2022-11-02 09:55:28 -05:00
Tony Murray 95a0050074 Remove $_GET from graphs (#14554)
Fixes issues setting variables in other contexts
2022-11-02 08:24:42 -05:00
Tony Murray 07cc9f4cdc Fix XSS in api access (#14551)
api access page didn't escape username allowing for injection.
2022-11-01 11:20:08 +01:00
bnerickson d28b1cac3f Adding systemd application (#14540) 2022-10-30 14:18:02 -05:00
Tony Murray 4b65dc41d2 Graphing cleanup (#14492)
* WIP

* Fixes and cleanups

* Move parseAtTime to Time util class

* lint fixes, explicitly define variables

* Style fixes
2022-10-28 08:06:29 -05:00
Jellyfrog b90fbcb9bf Undefined array key fixes (#14532)
* Undefined array key fixes

* Update check-services.php
2022-10-27 21:02:27 +02:00
SourceDoctor 505abd7136 Sort alert transport by name (#14464)
* sort alert transport by name

* .

* .

* code update

* code update
2022-10-25 08:43:54 -05:00
PipoCanaja 8e3fe223ef Sensors - Allow changing RRD type in YAML and PHP sensor discovery (#14208)
* new row variant

* syntax

* syntax

* DB

* syntax

* schema

* test

* allAdvaTests

* Tests

* Tests

* Tests

* missingMigration

* missingMigration

* Tests

* Tests

* Tests

* Tests

* tests

* tests

* tests

* tests

* tests

* test

* fix_Aos7

* fix snmprec arista

* fix snmprec arista

* fix snmprec arista

* tests

* merge_fix

* aos7 backslash

* aos7

* more

* more

* defaultValue

* arista

* typehint

* tests

* tests

* voss

* aos7

* aos7

* aos7

* testWithoutarista-mos_metamux48-c-0-16.json

* tests

* ciscosb

* new tests with 2004 and only sensors module

* adding wireless module again

* adding wireless module again (cont)

* airos

* aos7

* arista

* arista

* bdcom

* fortigate

* fortigate

* fortigate

* ftos

* ftos

* tests on 1804

* tests once more

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* tests once more, cont

* more

* bdcom

* comware

* edgeosolt

* enexus

* arista-mos

* removeAristaAgain

* ies500_manual_edit

* ies500_manual_edit

* mni

* volius

* zywal

* manually imported arista-mos

* manually imported arista-mos

* arista-mos test is triggering something ...

* restoreArista

* tests

* tests

* aristamos

* ies52xxM_4206.json

* revert linux_supermicro.json

* revert linux_supermicro.json

* benuos

* fortiadc

* rnx-updu
2022-10-25 08:31:02 -05:00
Lucas Gasenzer 707f2cd29f Check if service_name is empty or equal to service_type (#14499)
* Check if name empty or name == service

* Linting ("" → '')
2022-10-23 20:00:29 +02:00
rhinoau 6372041d39 Fix update_device hostname handling #14435 (#14448)
* Fix device_update hostname handling #14435

* Use Eloquent

* Update Device.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-22 15:45:47 -05:00
Tony Murray aefd14d3aa Graph API use new code path (#14493)
* Graph API use new code path
Improves error handling significantly

* Actually base64 encode it
2022-10-22 14:58:51 -05:00
SourceDoctor 04f0574132 show id on device dependencies (#14497) 2022-10-22 19:52:51 +02:00
Tony Murray d86cbcd96d Fix alert rules XSS (#14471)
Fixes html injection for map items
2022-10-17 12:32:58 -05:00
ottorei abf00ea75e Fix missing device_id from device alert logs (#14460) 2022-10-17 11:15:41 -05:00
Tony Murray 43cb72549d Fix billing xss (#14465)
bill_name and bill_notes fields allow html injection
2022-10-17 09:04:22 +02:00
Tony Murray 8e85698aa3 Fix possible RSS XSS (#14457)
Escape titles when shown.  Body was already cleaned.
2022-10-14 13:24:22 -05:00
bnerickson 4efbb83d9b Add pwrstatd application (#14365)
* Add pwrstatd application

* Adding pwrstatd test json and correcting pwrstatd snmprec file.  Pwrstatd tests pass.
2022-10-12 11:01:09 +02:00
Tony Murray fafd989971 Fix pseudowires pages (#14441)
Thanks to @scottbob09 from #14340
2022-10-11 16:09:59 -05:00
Jellyfrog be1a2cec50 Miscellaneous fixes, mostly undefined variables (#14432)
* Miscellaneous fixes, mostly undefined variables

* Update phpstan-baseline.neon
2022-10-11 11:30:00 +02:00
Jellyfrog 071173ffb9 Remove tabs from yaml (#14437)
* Remove tabs from yaml

* Remove tabs from random files
2022-10-10 18:13:10 +02:00
Tony Murray 878666bb26 Revert "Update common.inc.php (#14407)" (#14419)
This reverts commit 698275dd12.
2022-10-03 08:23:44 -05:00
Tony Murray e4451714e2 version and git helper improvements (#14412)
* Fix up version and git helpers
Improve method names
Move all git calls into the git helper
Allow runtime and external cache of results where appropriate
Consolidate version headers for discovery, poller, and validate

* Style fixes

* improve consistency in git calls

* fix style

* don't send name inconsistently

* Improve database versions

* No need to cache Version it is not used more than once currently.
2022-10-02 00:41:56 -05:00
Kevin Zink 698275dd12 Update common.inc.php (#14407)
Place the Y grid dynamically based on the graph's Y range. The algorithm ensures that you always have a grid, that there are enough but not too many grid lines, and that the grid is metric. That is the grid lines are placed every 1, 2, 5 or 10 units. This parameter will also ensure that you get enough decimals displayed even if your graph goes from 69.998 to 70.001. (contributed by Sasha Mikheev).
2022-09-30 13:21:10 +02:00
Lucas Gasenzer 833dab7a83 Enhanced Service Overview on Device Overview Page (#14410)
* changed viewbox and scale as fix for safari

* enhanced service overview with "$name ($type)"
2022-09-30 10:22:01 +02:00
Félix Bouynot 333ba7c2cd Fix oxidized web requests unclosed connections or responding fast enough (#14370)
* Fix oxidized web requests not closing connections or responding fast enough

* Update showconfig.inc.php

* Add method to get the text content of an oxidized page

* Use Oxidized getContent method instead of file_get_content

* Too much brackets with copy paste

* Fix carriage return errors because of copy paste

* Fix copy paste error again

* Fix indent

* PHPStan is waiting for a return even outside of the if loop

* Single quotes

* Variabilize timeout in baseapi

* Set Oxidized Api class timeout var to 90 because oxidized is slow and to be sure not to break half the installs here

* fix typo

* Variabilize timeout

* Variabilize timeout

* Variabilize timeout

* Variabilize timeout

* Variabilize timeout

* Spacing

* Remove timeout type because of this error

Unexpected 'int' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in app/ApiClients/BaseApi.php on line 34

* Lint needs type finally

* Use contruct instead of setting variable

* Type hinting instead for php7.3

* Type hinting fix

* Set property value instead of calling parent constructor

* Typo

* Remove unneededconstructors

* Remove unneeded constructors

* Remove unneeded constructors

* Remove unneeded constructors

* Remove unneeded constructors

* Remove unneeded constructors

* Typing not casting

* Typing not casting

* Cannot type variables outside of a class

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2022-09-24 14:24:11 -05:00
Kayck Matias 64dcfcb8cc Alert map location fix (#14380)
* Update devices in alert-logs to init_select2

* Fix function ->exists

* Add init_select2 to location filter in ports

* fixes

* Fixed alerts rule system not filtering by location
2022-09-23 14:15:46 -05:00
Tony Murray fd6fdeeb5b Fix ports list exists (#14372) 2022-09-19 15:47:36 -05:00
Kayck Matias 1e80780dd3 Load device selection dynamically on Ports page (#14353)
* Add search in real-time to Ports page

* Update to init_select2 and remove old query

* fixed styleci

* fixed styleci

* fixing email

* Finish up

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-09-16 08:40:03 -05:00
bp0 384e0449c1 API: allow delete location by id (#14334)
* API: allow delete location by id

Otherwise impossible to delete location "".

* docs/API: location can be name or id for edit and delete
2022-09-13 09:03:55 -05:00
bp0 94830fe47e API update_device, make location field work (as does location_id) (#14325)
* update_device, add location to list of bad_fields

The field 'location' can't be changed using API update_device_field, even when used with 'override_sysLocation'. It should not return success, with the "Device fields have been updated" message that is untrue.

* Actually make it work

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-09-09 11:40:55 -05:00