Commit Graph

241 Commits

Author SHA1 Message Date
Tony Murray
533c9022c9 Fixed Procera ports ifIndex and ports added by the poller (#9384)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-11-28 21:08:42 +00:00
Neil Lathwood
a10503b927 Ensure the checks for ASA context devices are strict (#9441) 2018-11-10 21:05:25 +00:00
PipoCanaja
e367f46fee device: Initial support for CXR-Networks Terminal Server (#9169)
* device: Initial support for CXR-Networks Terminal Server

* device: Support for CXR-Networks Terminal Server - CodeClimate + cleaning

* device: renamed cxr-networks-ts and code improvement

* device: cxr-networks-ts test data

* device: renamed os as cxr-ts

* device: renamed os as cxr-ts, test data
2018-09-10 21:32:06 -05:00
Neil Lathwood
23b46c7681 Improved port polling in certain scenarios (#9082)
* Improved port polling in certain scenarios

* Update ports.inc.php

* Update ports.inc.php

* Remove temporary variables
2018-08-28 10:29:28 -05:00
Tony Murray
e5fb7c9f16 Selective Port polling improvements (#8650)
Don't delete skipped ports when using selected polling
Improve output of port polling module.
Update ifOperStatus and ifAdminStatus even when skipping.

Warning! causes a semantic change where ifAdminStatus_prev and ifOperStatus_prev are updated every poll, so they will only be mismatched for one poll.  This could cause alerts to behave differently.

Add an optimization if less than 10% of the ports are disabled (or less than 5), walk the base oids.
Time improvement on test device Full: 12s, Selective: 8s, Optimized 4s. (no disabled ports on device, many down)

Another test device.

![image](https://user-images.githubusercontent.com/39462/40066671-46cdc956-582a-11e8-928a-80bbd81dd423.png)


DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-04 22:10:57 +01:00
Tony Murray
eeb3d58f5b Improved Logging and Debugging (#8870)
Use Log facility when Laravel is booted.
Update init.php so we can easily boot Laravel for CLI scripts. (and just Eloquent, but that may go away)
Move all debug setup into set_debug() function and use that across all scripts.
Log Laravel database queries.
Send debug output to librenms log file when enabling debug in the webui.
Allow for colorized Log CLI output. (currently will leave % tags in log file output)

** Needs testing and perhaps tweaking still.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-07-13 23:08:00 +01:00
Paul Heinrichs
f22e1a6ba6 Improved support for cambium cmm and added cmm4 (#8737)
- Added port discovery for cmm3 (not available for cmm4, not that i could find)
- Added discovery for cmm4
- Added Power port cmm4
- Removed Processor bug by disabling processor on device.

I am unable to test CMM4 and may need someone to do so or review for possible errors.

Fixes Issues #8732, #8731

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-07-07 13:56:54 +01:00
RobJE
82d01eb1a1 feature: Include adsl stats for vdsl ports (#8670)
* also include adsl stats for vdsl ports

* Update ports.inc.php
2018-05-21 19:33:57 +01:00
PipoCanaja
33589b7478 Optimisation - VRP - Only fetch the necessary OIDs for POE polling (#8744)
Hello

For VRP devices supporting POE, the goal is to fetch only the strict necessary values instead of all the table to improve the polling time (devices tested, 5720, are quite slow to return SNMP values).

Test Data is unchanged. 

Bye
PipoCanaja

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-05-20 14:45:29 +01:00
PipoCanaja
a1a13de0f6 feature: Added PoE graphs and improved PoE polling code (#8705)
* Poe Polling Code, Poe Graphs, and Huawei MIB

* Reverting the reindent done after pre-commit script

* Cleaning of code not used for Cisco IOS, removal of untested Procurve code, and restore of legacy generic code (tested with Cisco+huawei)

* Rename MIB file

* Rearranged duplicated code

* Cleaning of variable not used

* Cleaning of commented code after night validation in test environnement

* Cleaning after pre-commit.php comments

* test data with PoE oids for huawei 5720

* test data with PoE oids for cisco 2960X
2018-05-15 21:39:36 +01:00
cchance27
09d6b2fd54 feature: Added Prometheus PushGateway metric support (#8437)
* Added Prometheus PushGateway support

* fixed formatting

* fix set_curl_proxy to correct variable

* add documentation

* Update Metric-Storage.md

* Update mkdocs.yml
2018-04-13 15:46:19 +01:00
papatango71
7ed7885ca7 Add ifAlias to tag influxdb port data (#8461)
* Update ports.inc.php

Adding ifAlias to the $tags that are sent into influxdb

* Remove space
2018-03-23 12:43:50 -05:00
Neil Lathwood
faf48311b2 refactor: Small improvement to per port polling (#8431) 2018-03-22 13:40:11 -05:00
Michael Renner
b5273969a0 feature: Fetch ifAlias data for devices on the bad_ifXEntry list (#8275)
* fetch ifAlias data for devices on the bad_ifXEntry list

* add test data for SG350-10
2018-02-27 16:57:24 +00:00
Neil Lathwood
92f83c2567 fix: Validate ifHighSpeed is > 0 in selected port polling (#7885) 2017-12-11 15:51:29 -06:00
Zmegolaz
e31b884cc9 Feature: selected_ports per OS. Fixed layout of example MySQL table. (#7674)
* selected_ports per OS. Fixed layout of example MySQL table.

* Better table markdown.
2017-11-09 12:57:00 +00:00
Daniel Preussker
0cf8c2615f fix: Update ifIndex update on polling when ifIndex is not the port association mode (#7574) (#7575) 2017-10-30 19:44:01 +00:00
Paul Heinrichs
f038bcb6a1 device: Add more Procera interfaces (#7422)
* Add procera MIBS

* Add Channel ports to procera

* Fix whitespace

* CI Fix

* Remove unnecessary procera mib_dir

* Use snmpwalk_group

* CI fix

* Add more fields and change depth to snmpgroup_walk

* Minor style updates

* Add interface regex to procera.yaml
2017-10-19 08:09:45 -05:00
Lorenzo Zafra
f66d73de89 refactor: Use ifName if ifDescr is blank
* Add if statement for ROS os when querying remote port id for LLDP map

* Apply ifDescr fix in ports polling instead.
2017-07-29 12:09:15 +01:00
Yacine Benamsili
294ec4d73d feature: Added support for sending metrics to OpenTSDB (#7022)
* Create OpenTSDB.md

* Send collected data to OpenTSDB

* Send collected data to OpenTSDB

* Update build.sql

* Send collected data to OpenTSDB

* Delete 200.sql

* Update db_schema.yaml

* Update datastore.inc.php

* Update OpenTSDB.md

* Added OpenTSDB to mkdocs.yaml
2017-07-15 10:28:27 +01:00
Tony Murray
f5931535b4 fix: Check HC counters individually (#6828)
* fix: Check HC counters individually
Vendors are very inconsistent returning ifXTable values.
Some only implement some of them (seemingly randomly).
Others return them, but they are always 0.

This attempts to fix that by checking each value individually.

* A couple of small cleanups

* Change the logic, The (if < hc) logic will be messed up when the counters roll.
Just make sure it is not 0 or an empty string.
2017-06-15 08:11:10 +01:00
Neil Lathwood
3bf7e207a7 fix: Check for ifHCInOctets and ifHighSpeed before falling back to if… (#6777)
* fix: Check for ifHCInOctets and ifHighSpeed before falling back to ifEntry

* switched && to ||
2017-06-10 06:50:40 -05:00
Neil Lathwood
da68e50c00 refactor: Update some snmpwalks for ports polling to improve speed (#6341) 2017-04-05 16:13:57 +01:00
David Bell
a1b62cea73 Update ports.inc.php (#6253) 2017-03-23 14:11:18 +00:00
Falk Stern
affe5090f4 feature: Send collected data to graphite server (#6201)
* Initial support for graphite

* Enable graphite include

* fixed typos.

* Fixed port naming to graphite metric names

* Added documentation for Graphite

* added documentation for graphite

* fixed style

* replace / with _ in interface names for graphite

* sets default graphite port

* adds rrd-name tags to the metric, otherwise metrics get lost

* add suggested storage schema for graphite

* add whitespace

* Updated to show some output

* bad english
2017-03-22 10:35:44 -05:00
Søren Rosiak
5cf779c60b refactor: Cisco ASA Polling Performance Improvements (#6139) 2017-03-22 00:22:48 -05:00
David Bell
31ae41beed Use HC counters even if one direction is reporting as 0 (#6106)
* Use HC counters even if one direction is reporting as 0

* Change to >=

* Change this to a for loop

Treats each item individually.  I left it as >, because if the HC value is 0, then the normal value is 0. And it no longer affects other values as we treat each one individually.

* Change check again...

* Update test for HC being used

* Last time?

* Typo
2017-03-22 00:20:58 -05:00
Neil Lathwood
58442e0a75 refactor: Further speed improvements to port poller (#6037) 2017-03-07 21:14:24 -06:00
Neil Lathwood
fad5aca1b7 feature: Allow customisation of rrd step/heartbeat when creating new rrd files (#5947)
* feature: Allow customisation of rrd step/heartbeat when creating new rrd files

* revert defaults

* added docs + webui config option

* Move RrdDefinition to an Object to make them easier to create and remove the possibility of typos.

* Fix style/lint issues and missing use statements

* 3 more missing use statements

* updated doc + moved schema file
2017-02-23 22:45:50 +00:00
Neil Lathwood
cc51a68f85 feature: Optional partial port polling (#5805)
* feature: Added ability to switch port polling mode

* update, speed things up slightly by walking certain tables

* more fixes

* updates

* updates

* update to exclude ports that are down

* wrong variable used

* update to set previous port status when null

* small update to port disco
2017-02-14 17:26:07 -06:00
Richard Mayhew
e4f48e661e Add additional eventlog severity levels (#5879) 2017-02-13 22:32:02 +00:00
Richard Mayhew
5bfd23e7eb webui: New eventlog severity classification (#5830)
* New event log severity model

* Revert "New event log severity model"

This reverts commit 0783527af8.

* New event log severity model

* Fixed spaces vs tabs

* Learning the format requirements

* Learning the format requirements

* Moved the colours in to the stylesheet

* change SQL file to stop conflicting

* refactor log_event so severity isn't last, but reference is.

* keep having to move the file due to new PR conflicts

* Revert "keep having to move the file due to new PR conflicts"

This reverts commit f3030e7218.

* extended support to dashboard and eventlog page

* formatting
2017-02-12 22:41:05 +00:00
Neil Lathwood
21898a3c29 Disco / Poller tidy up + Added display of module mem usage (#5778)
* tidyup + added mem usage for poller modules

* tidied up discovery modules

* fix sensors
2017-02-07 22:54:30 -06:00
Neil Lathwood
df3e9af3f9 Use ifDescr for ifName if it is empty #5392 (#5447) 2017-01-19 22:57:10 +00:00
Neil Lathwood
bfe6ce610c remove set numeric from ports (#5442) 2017-01-15 15:46:00 +00:00
Neil Lathwood
d5296319fb refactor: MySQL strict and query fixes (#5338)
* refactor: MySQL strict and query fixes

* moved sql file
2017-01-13 06:47:16 -06:00
Neil Lathwood
f62cff8974 fix: Updated bad_ifXEntry to be case insensitive and added cisco2811 to ios.yaml #5283 (#5285) 2017-01-03 09:29:52 -06:00
Tony Murray
5c156e7e01 fix: Remove usage of -CI, it is not allowed for snmpbulkwalk #5164 2016-12-20 16:58:20 +00:00
Søren Rosiak
e56d26327a refactor: More Cisco ASA Polling Performance Improvements (#5104) 2016-12-12 14:25:20 +00:00
Neil Lathwood
61b461503c feature: added support for f5 custom interface mib (#4842) 2016-10-21 10:13:32 -05:00
Neil Lathwood
5b96c67ec5 refactor: Cleanup poller include files (#4751) 2016-10-15 00:43:14 +01:00
Neil Lathwood
5c4d383f80 fix: Fixed the old port rrd migration code to work with new rrdtool functions (#4616) 2016-09-27 09:18:57 -05:00
Tony Murray
6fbd8b3f05 fix: port ifLastChange polling (#4541)
* fix: port ifLastChange polling

* Small changes, default to 0

* Don't update 0->0
2016-09-22 11:39:15 -05:00
Tony Murray
299f4d91d3 feature: Add last changed, connected, and mtu to all ports data
Thanks to sysvival on reddit for the idea and help with the calculations
2016-09-21 13:19:52 -05:00
Neil Lathwood
0d2c443ee9 fix: Added ability to force devices to use ifEntry instead of ifXEntry (#4100) 2016-09-02 12:53:35 -05:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
Mickael Marchand
63cdd8210d fix ifName randomly defined, breaking influxdb updates (#4202) 2016-08-25 11:55:27 +01:00
Neil Lathwood
e112302e40 Fixed not sending port_descr_type (#4188) 2016-08-24 11:01:56 -05:00
laf
ef7fac9a91 Fixed errors 2016-08-18 21:38:06 +01:00
laf
61e5aa6883 Update of ifSpeed checking in ports poller 2016-08-17 23:08:32 +01:00