Commit Graph

35 Commits

Author SHA1 Message Date
Steve Calvário
c7e0a14489 Avoid DivisionByZeroError (#16464)
* Avoid DivisionByZeroError

* Use match for entPhySensorPrecision

* Fix style

* Add zepto

* Update match condition
2024-10-01 10:51:40 -05:00
Tony Murray
f15f8fa63a Sensors remove reliance on global variable (#16344)
* Sensors remove reliance on global variable

* Apply fixes from StyleCI

* Clear the instance instead of reset.
Remove $valid['sensors'] from docs

---------

Co-authored-by: Tony Murray <murrant@users.noreply.github.com>
2024-09-03 21:04:34 -05:00
Tony Murray
64c0d6ff7f Ignore entity-sensor invalid values (#16347) 2024-09-02 21:44:29 -05:00
Tozz
718abd47de Fix for FortiSwitch RPM/percentage fans (#15829)
* Update entity-sensor.inc.php

* FSW Test data

* FSW Test data JSON

* StyleCI

* Update fortiswitch.yaml - Correct state sensor index

* Update fortiswitch.yaml

* Add files via upload

* Fix sensor value at discovery
2024-03-05 00:11:04 +01:00
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
Leo-FJ
149ecad745 Update entity-sensor.inc.php for xos' os (#15552)
* Update entity-sensor.inc.php for xos' os

* Update entity-sensor.inc.php - removed space

* Test data added
2023-11-21 16:51:16 -06:00
Jellyfrog
68e0b3df28 Apply fixes from StyleCI (#14899)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-03-13 22:32:22 +01:00
Jellyfrog
b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
Jellyfrog
34a58c3f9f Miscellaneous cleanup, mostly undefined variables - part2 (#14445)
* Miscellaneous cleanup, mostly undefined variables - part2

* wip

* Update Number.php

* Update BridgeMib.php

* Update Xdsl.php

* Update cisco.inc.php

* Update Cisco.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update entity-sensor.inc.php

* Update avtech.inc.php

* Update functions.inc.php

* Update HostResources.php

* Update ports.inc.php

* Update route.inc.php

* Update cisco.inc.php

* Update Cisco.php
2022-10-18 13:30:42 +02:00
Jellyfrog
7207614437 Trim whitespaces from device data (#14429)
* Trim whitespace from sensor and ports data

* Update arista_eos_vrf.json

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* Update Os.php

* wip

* wip

* wip

* Update querybuilder.json
2022-10-11 12:50:38 -05:00
Jellyfrog
29f45ca352 Apply fixes from StyleCI (#12124) 2020-09-21 15:59:34 +02:00
Jellyfrog
82f43cb98d Apply fixes from StyleCI (#12120) 2020-09-21 15:40:17 +02:00
TheGreatDoc
29b09c8845 Arista EOS: Added groups and better sensor names (#11990)
* Arista EOS: Added groups and better sensor names

* Changed few sensors naming to remove redundancy

* Test files

* Better naming v2

* More rewriting and grouping

* And more grouping/rewritting

* Update arista_eos_vrf.json

* Minor code format fix

Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-08-18 08:36:14 -05:00
Tony Murray
1c08c11a77 Remove Laravel helpers (#11428)
* Remove Laravel helpers

* Replace qualifier with import
2020-04-18 00:37:56 +02:00
KodApa85
7f104d4fd9 Advanced state sensors (#9881)
* refactor: advanced sensor states

mark create_state_index($state_name) as E_USER_DEPRECATED?

* fix: minor corrections

* fix: mib has partialSync(9) and incompatibleVersion(8)

* fix: corrected netagent2upsstate - Sleeping(5)

* fix: NetAgent2 upsThreePhaseUPSStatusInverterOperating correction

* refactor: array() be gone

* Refactoring includes/discovery/sensors/state/extendair.inc.php with arrays
And tidying up array formatting in other files

* fix: minor typo

* standardising array item names

removed redundant "if ($state_index_id !== null) {"

* workaround: procurve & serverscheck

a sensor is causing create_state_index($state) to return null.
The updated code doesn't allow for this and thus a hybrid is being used.

* standardised naming of state info. Caused a typo $state_name instead of $status_name
$state_name is the standard

* converted compas to square arrays

* Converted APC states using preg_match to new create_state_index() call

* Update boss.inc.php
2019-03-04 11:31:17 -06:00
Søren Rosiak
80f31b4831 Fix Arista interface bias current divisor (#9728)
* Remove exception

* Add test data

* Update arista_eos.json
2019-02-07 11:37:46 -06:00
Neil Lathwood
a10503b927 Ensure the checks for ASA context devices are strict (#9441) 2018-11-10 21:05:25 +00:00
TheGreatDoc
485dc3affb Added Basic Support for Arris D5 EdgeQAM (#9083)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-27 10:11:16 +01:00
Tony Murray
b01ccd7f9c Fix missed variable rename. (#8916)
Walk was in another file.
2018-07-17 10:54:19 -05:00
Tony Murray
eeb3d58f5b Improved Logging and Debugging (#8870)
Use Log facility when Laravel is booted.
Update init.php so we can easily boot Laravel for CLI scripts. (and just Eloquent, but that may go away)
Move all debug setup into set_debug() function and use that across all scripts.
Log Laravel database queries.
Send debug output to librenms log file when enabling debug in the webui.
Allow for colorized Log CLI output. (currently will leave % tags in log file output)

** Needs testing and perhaps tweaking still.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-07-13 23:08:00 +01:00
Tony Murray
b9dc7773d7 refactor: Don't do unneeded snmp queries (#7841)
* Don't do uneeded snmp queries
sensors discovery 26 -> 16
wrapped some poller modules in db checks.  The same could be done for some others, but more work is needed.

* travis fix
2017-12-02 23:18:45 +00:00
Tony Murray
a21a3fb2b6 feature: Added support Entity State polling (#7625)
* Entity state sensors??

* feature: Entity State polling
Display entity state on the Inventory page.
Allows for alerting based on states.

* fix empty last changed, timezones, alarm parsing, and db updates

* do not display unavailable alarms (80)
add tooltip with state value

* remove debug

* Entity state sensors??

* feature: Entity State polling
Display entity state on the Inventory page.
Allows for alerting based on states.

* fix empty last changed, timezones, alarm parsing, and db updates

* do not display unavailable alarms (80)
add tooltip with state value

* remove debug

* Use a discovery module and only fetch the rest of the data if entStateLastChanged is updated.

* A little more efficient sql use in the case nothing has changed.

* disabled by default, add to docs.

* moved schema file to 220.sql
2017-12-02 20:23:56 +00:00
Neil Lathwood
f7e14df90e newdevice: Updated Arista entity-physical support to use high/low values from device (#7156)
* fix: Fixed the high/low thresholds for Arista devices

* final updates

* push threshold changes

* more updates

* another update

* updated entity-sensor for current value calc

* hoping final update
2017-09-07 08:49:32 -05:00
FTBZ
138fd2923a fix: Fixed Rittal LCP sensor divisors (#7014)
* Better values for some graphs

* Change definition order

* Update rittal-lcp.yaml
2017-07-13 18:23:55 +01:00
Søren Rosiak
cbe476ad2f fix: Fix bad Cisco dBm discovery on some IOS versions (#6789) 2017-06-06 22:46:29 +01:00
Neil Lathwood
924137ebd8 fix: Updated the arista initial current value for dbm sensors (#6771)
* fixed spelling mistake in process_config

* fix: Updated the arista initial current value for dbm sensors
2017-06-02 07:29:49 -05:00
Neil Lathwood
21898a3c29 Disco / Poller tidy up + Added display of module mem usage (#5778)
* tidyup + added mem usage for poller modules

* tidied up discovery modules

* fix sensors
2017-02-07 22:54:30 -06:00
Daniel Preussker
883095deac fix: Arista watts to dbm conversion 2017-02-05 20:46:13 +01:00
Søren Rosiak
597a619417 fix: Cisco ASA Sensor Discovery, use correct variable (#5021) 2016-11-19 13:42:49 +00:00
Søren Rosiak
a0fec9e574 refactor: Improve Cisco ASA Polling Performance (#4999) 2016-11-15 19:57:47 +00:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
laf
b831d096a9 For entity-sensor, changed variable name again 2015-12-07 03:02:06 +00:00
laf
3560a39b52 Updated thisisnotbullshit variable 2016-01-28 09:38:31 +00:00
laf
427c4f07c6 Added ability to ignore device sensors from entity mib 2016-01-25 22:37:38 +00:00
laf
b5d1155006 Updated discovery sensors module directory structure 2016-01-17 20:47:47 +00:00