Commit Graph

286 Commits

Author SHA1 Message Date
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
craig-nokia
c97fd4e6f5 bug - "null" checks for SAR 7705 release 8.X (#15657)
Added null for SAR 7705 release 8.X
2023-12-18 16:40:06 +01:00
PipoCanaja
b12ee04bda bug - timos MPLS - more poller fixes (#15624)
* fix 1, ErrorException: Undefined array key sdpFarEndInetAddress in /opt/librenms/LibreNMS/OS/Timos.php:584

* fix2: don't try mplsSdpBinds polling if prerequisites not met

* fix 3: ErrorException: Attempt to read property lsp_path_id on null in /opt/librenms/LibreNMS/OS/Timos.php:790

* style

* fix phpstan

* schema_update

* schema

* migration_style

* migration drops and recreate

* migration drops and recreate

* migration drops and recreate

* style
2023-12-17 20:15:46 -06:00
Adam James
66cc34dbd2 Add support for Fortinet FortiAPs (#15641) 2023-12-14 11:29:02 -06:00
PipoCanaja
b0a355e8ba ?? null (#15613) 2023-12-04 03:54:19 +01:00
PipoCanaja
f59388d7f9 vrp - 'unknown (huawei)' state and change hwWlanRadioFreqType to hwWlanRadioType (#15564) 2023-11-11 20:19:42 +01:00
Gerald VINCENT
11903150c8 Zyxel AP wireless client discovery enhancement (#14704)
* Update Zyxelnwa.php

Discovering wireless clients on all bands

* Update ZYXEL-ES-WIRELESS

Replace '_' by '-' as it is a bad practice to use underscores in values

* Update Zyxelnwa.php

* Update ZYXEL-ES-WIRELESS

* Update zyxelnwa.snmprec

* Create zyxelnwa.json

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update ZYXEL-ES-WIRELESS

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update Zyxelnwa.php

* Update Zyxelnwa.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-06 00:43:59 -06:00
Janno Schouwenburg
5b63f109c6 Dantherm hostname (#14223)
* Support for configured hostname to override sysName

* Update and add test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 19:25:56 -05:00
Tony Murray
44521ab2f1 UCD buffers and cache discovered with inverted free/used values (#15538)
* UCD buffers and cache discovered with inverted free/used values
(polling was correct)

* UCD Discovery was also double calculating "available"

* update test data

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 11:22:04 -05:00
Tony Murray
b9881bbf36 Cisco WLC: fetch LWAPP SSIDs for client counts (#15531)
* Cisco WLC: fetch LWAPP SSIDs

* Apply fixes from StyleCI

* no need to check twice

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 11:21:11 -05:00
Tony Murray
e1f6b77204 Fix Ciscowlc error when bsnApIfNoOfUsers is not present (#15529)
fixes #15517
2023-10-31 08:25:35 -05:00
metrojworthington
7bd1a57c3e Mcc valere (#14753)
* modifications needed for update of VALERE-DC-POWER-MIB with new file ELTEK-BC2000-DC-POWER-MIB

* add test results for BC2000 post update

* updated test file data

* re-upload of updated files

* reverted valere.json to defaults and recreated with proper varient .json

* replace vpwrShelfIndex with vpwrBayIndex

* updated test data

* Update test data

* try again valere_bc2000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-19 07:22:46 -05:00
Tony Murray
5b77dfc75c Huawei VRP AP controller fixes (#15450) 2023-10-13 22:26:33 -05:00
Tony Murray
afc78d7890 Timos MPLS nullables round 2 (#15448) 2023-10-12 18:53:05 -05:00
Tony Murray
2f33421aed Stop libvirt ssh attempts (#15438)
If enable_libvirt is not enabled, do not attempt to ssh to the target device.
2023-10-11 18:49:16 -05:00
Tony Murray
b7ab5be347 Fix VRP polling (#15428)
Was using deprecated database functions.
Use current methods
2023-10-11 18:36:35 -05:00
Tony Murray
6e3261f801 Fix timos mpls, add checks (#15430) 2023-10-11 09:56:09 -05:00
Tony Murray
d8c372bbf4 Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-06 07:34:14 -05:00
Tony Murray
087d588102 Vmware vminfo modernize (#15008)
* Vmware vminfo
Remove legacy file and migrate to OS discovery

* tighter

* ios_stp-vlans working correctly now

* Make vmwVmGuestOS nullable

* Discover os info too

* VM Info module

* Apply fixes from StyleCI

* Fix log severity

* Fix log severity (more)

* VM Info module

* Poll with ESXi too because it is lightweight
add test data

* poller data now too

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 19:49:26 -05:00
Tony Murray
be24993cbb Remove snmp functions that are barely used (#15377)
* Remove snmp functions that are barely used
Replace them with SnmpQuery calls

* Apply fixes from StyleCI

* Fix missing namespace

* Import Oid

* No more variables left may be repeated multiple times at the end with snmpsim, remove them all

* update data fixed by SnmpResponse bugfix

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 01:29:22 -05:00
Tony Murray
c1258320f8 Availability module fixes (#15369)
* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 10:32:59 -05:00
I-FGSD
e89f97057a Update Windows.php (#15350)
I added Server 2022 and Windows 10/11 22H2 (and a few other popular but older windows builds that people might still have in use).

I also propose changing the naming of windows machines to better reflect the release and version of windows. This naming is derived from this page: https://en.wikipedia.org/wiki/List_of_Microsoft_Windows_versions

For example, for Windows Server it was previously set to something like 'Windows Server 2019 1809 (NT 6.3)' which is incorrect as MS stopped using NT 6.3 since Windows 10 version 1507. Now it'll display as 'Windows Server 2019 (1809)'. The kernel/version is in parentheses and isn't also in the main part of the name as it's redundant/duplicated information.
2023-09-26 20:54:57 -05:00
Tony Murray
6e4d124619 Misc fixes 2 (#15190)
* Fix error when missing poller data

* Apparently impossible to detect regex without error, so require regex always.  Update docs.

* Apparently this adva code is garbage :D

* Missing count sensor type

* Processor handle missing input

* Handle missing ifName a little better

* Yep, ports module is a dumpster fire.  Attempt to clean up some.

* apparently os yaml trying to replace on non-existent fields

* Might as well define all sensor type units

* revert previous fix, real issue was vlans module does not have polling.
2023-08-13 18:43:52 +02:00
Tony Murray
d1b7004fef Severity Enum (#14620)
* Severity Enum
Replace old Alert constants

* Fix whitespace

* Additional uses

* style fixes

* Fix test too

* More missed locations

* More
2023-08-05 12:12:36 -05:00
Tony Murray
9382959c8c Set mibs explicitly in SnmpQuery (#15199)
* Set mibs explicitly in SnmpQuery
Always override system mibs, so we have consistency
New method to control mibs

* Lint fixes
2023-08-05 14:45:15 +02:00
Tony Murray
523e76db71 Fix sensor discovery fetch issue (#15193)
* Fix sensor discovery fetch issue

* value is not in an array

* Fix type

* remove exception...

* Update HarmonyEnhanced

* update test data
2023-08-04 13:25:19 +02:00
Janno Schouwenburg
ffffdd2663 Fix Timos SAR Cellular RSRP and RSSI sensors (#15163)
* Fix Timos SAR Cellular RSRP and RSSI sensors

* For some reason test data generated on dev machine double quoted backslashes, fixed
2023-07-26 01:04:35 +02:00
Jellyfrog
b14e2d4609 Apply fixes from StyleCI (#15101)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-06-13 13:35:00 +02:00
Garcia MICHEL
e547945985 Improve OpenWRT detection (#15096)
* Improve OpenWRT detection

* Add test data

* Remplace openwrt date with new one
2023-06-12 13:59:24 +02:00
Jellyfrog
2b3575a5e9 Laravel 10.x Shift (#14995)
* Apply code style

* Remove explicit call to register policies

* Shift core files

* Shift config files

* Default config files

In an effort to make upgrading the constantly changing config files
easier, Shift defaulted them and merged your true customizations -
where ENV variables may not be used.

* Bump Laravel dependencies

* Add type hints for Laravel 10

* Shift cleanup

* wip

* wip

* sync translation

* Sync back config

* Public Path Binding

* QueryException

* monolog

* db::raw

* monolog

* db::raw

* fix larastan collections

* fix phpstan bug looping forever

* larastan errors

* larastan: fix column type

* styleci

* initialize array

* fixes

* fixes

---------

Co-authored-by: Shift <shift@laravelshift.com>
2023-05-24 22:21:54 +02:00
Mathias Bøhn Grytemark
204abe0cf2 add advantech icr-os for advantech routers (#14171) 2023-04-25 07:54:41 -05:00
Dan Baker
a340672e86 Added graphing of DDoS-protection related OIDs for PAN-OS (#14847) 2023-04-06 19:11:16 -05:00
Jellyfrog
68e0b3df28 Apply fixes from StyleCI (#14899)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-03-13 22:32:22 +01:00
GeantRA
2da5d4505b Refactored Juniper SLA to include support for TWAMP and remove ambigu… (#14787) 2023-02-24 13:09:52 +01:00
carbinefreak
d869b879d1 Nokia PMC Microwave Improvements (#14761) 2023-01-19 23:31:57 +01:00
not-known
87a062a48d Stop net-snmp from interpreting the octet-string from rttMonEchoAdmin… (#14676) 2023-01-10 16:42:54 +01:00
Nick Peelman
d21d4422b4 Add AXOS sensor data for PON Transceivers (the only transceivers Cali… (#14741) 2023-01-02 11:24:59 +01:00
Tony Murray
510f9d340d Fix ArubaInstance channel decode issue (#14732)
* Fix ArubaInstance channel decode issue
PHP no longer implicitly casts in this situation

* missing import
2022-12-15 19:36:57 -06:00
Noah Roufus
359e00f602 Adjusted PMP to accomodate various other 450 models. (#14652) 2022-11-18 16:30:05 -06:00
Tony Murray
f2e7da0c96 AIX: remove extends and hardware detection support (#14626)
Because the aix snmpd returns NULL instead of a non-existent oid error, remove support for extends and additional hardware detection
2022-11-12 15:18:36 -06:00
Tony Murray
b9d8a7c33c Improved AIX os information collection (#14595)
* Improved AIX os information collection

* Fix-up merged data

* remove baseline
2022-11-09 12:04:56 +01:00
Jellyfrog
71d740770b Remove Log::event (#14526)
* Remove Log::event

Use the Eventlog class directly instead

* wip

* wip

* wip

* Apply fixes from StyleCI

* Update Eventlog.php
2022-11-09 09:47:19 +01:00
Tony Murray
0801af7a81 Consolidate and improve snmptranslate usage (#14567)
* Consolidate and improve snmptranslate usage

* Fix style

* lint fixes

* fix typo

* allow multiple mib directories

* Only add mib if it is not already set

* oid first, in case we have key length issues

* if there is a full oid, don't add other mibs

* debug in ci

* more debug in ci

* better debug in ci

* remove debug

* Use numeric index

* revert dlink change

* Don't add -On twice

* unit tests and hopefully better heuristics

* remove dump and add one more set of tests

* style fixes

* handle bad input in old functions

* shortcut whole snmp_translate function
2022-11-07 12:00:47 -06:00
mabra94
a01e8188d3 Timos - Improve SAP stats graphing (#14534)
* Update Timos.php

Adding InProf and HiPrio counters to allow proper SAP Stats graphing

* Update Timos.php
2022-11-06 16:22:12 -06:00
PipoCanaja
8760454ad8 Bug in Ciscowlc AP graphs definition (#14585) 2022-11-06 04:03:49 +01:00
Jellyfrog
009d69a48d Use Collection instead of collect() (#14527)
* Use Collection instead of collect()

* wip
2022-11-05 10:04:36 +01:00
Tony Murray
7612aa7d86 Support regex in os field replace (#14563)
* Support regex in os field replace

* Support regex in os field replace
2022-11-02 12:32:36 -05:00
Jellyfrog
b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
Mark Westerterp
db4dce298a Fortinet FortiADC detection and basic statistics (#14434)
* FortiADC detection and basic statistics

* Style fix

* Fixed test data

* Fix test data

* Recollected all test data

* Add num_oid
2022-10-24 18:28:47 +02:00
Jellyfrog
b18ba17af0 Miscellaneous cleanup - part 4 (#14452)
* Miscellaneous cleanup - part 4

* wip

* wip
2022-10-19 01:33:06 +02:00