Commit Graph

4974 Commits

Author SHA1 Message Date
Richard Lawley
c56f04e1e2 fix: Set API log start at 0 rather than 1(#7772) 2017-11-20 15:31:21 +00:00
Tony Murray
1cc0e7cd6d fix: Fixed empty group query for devices (#7760)
* fix: empty device group query

* fix: empty device group query
Optimize it a bit to use the relationship.
2017-11-19 21:54:09 +00:00
mcq8
c9728a1f71 refactor: Refactored authorizers to classes (#7497)
* Refactored authorizers to classes

* Merge changes for #7335

* ! fix php 5.3 incompatibility

* Update ADAuthorizationAuthorizer.php

* Fix get_user -> getUser

* Rename AuthorizerFactory to Auth, fix interface missing functions

* Add phpdocs to all interface methods and normalize the names a bit.

* Re-work auth_test.php AD bind tests to work properly with the new class.
Reflection is not the nicest tool, but I think it is appropriate here.
Handle exceptions more nicely in auth_test.php

* Restore AD getUseList fix

Not sure how it got removed

* fix auth_test.php style
2017-11-18 10:33:03 +00:00
Neil Lathwood
38be66993f webui: Updated sensors overview header to be consistent with others (#7761)
* webui: Updated sensors overview header to be consistent with others

* added line break
2017-11-18 10:26:12 +00:00
Tony Murray
de35e6e3a5 fix: notification read count doesn't decrement in menu bar (#7750)
* fix: notification read count doesn't decrement in menu bar

* also remove red color if we reach 0
2017-11-16 20:10:20 -06:00
Neil Lathwood
c6a0c9d124 api: Added support for Oxidized asking for a single host (#7705) 2017-11-16 21:21:52 +00:00
FTBZ
5443112dbb device: Added sensor state support for HWg STE2 and added new logos (#7729)
* device: Changing HWg STE2 to YAML and adding new logos

* small logo change

* add again all modules

* change indexes

* update index for state
2017-11-15 11:04:07 +00:00
David Ediger
3c94ce7da0 fix: basic input validation for screen width and height (#7713) 2017-11-14 09:42:06 -06:00
Richard Lawley
00fc5bf0e8 API: Validate columns parameter against fields in table (#7717)
* Validate columns parameter against fields in table

* Removed unused return var

* Replace schema check from DB with yaml

* Style fixes
2017-11-14 09:15:12 -06:00
Chris A. Evans
64aed60f09 newdevice: Add OS detection and temperature sensor support for Asentria SiteBoss (#7655)
* Initial commit. OS definition/polling, temp sensor discovery/polling, MIBs, logo, snmprec test

* replaced logo with 32x32, shortened sysObjectID in definitions, modifided sensor discovery

* fix syntax error caught by inspection

* requested chases to siteboss temp discovery file, removal of siteboss temp polling file

* converted temp sensor to yaml and added better support to skip values

* updated to use pre_cache with index
2017-11-14 08:35:32 -06:00
Neil Lathwood
4e59dd47c9 webui: Expose pollers link to show total poll time for all devices per poller (#7699)
* webui: Expose pollers link to show total poll time for all devices per poller

* Update pollers.inc.php
2017-11-13 12:18:07 -06:00
Neil Lathwood
75ee23c6b3 webui: Updated poll-log page to honour force_ip_to_sysname (#7712) 2017-11-13 08:06:48 -06:00
Tony Murray
b79d106c56 fix: Errors with missing posix extension (#7666)
* fix: errors with missing posix extension
It should be an optional dependency

* add php71w-process to the CentOS 7 install docs
2017-11-10 15:20:47 +00:00
bergroth
a16c142658 * Health/sensor view for specific device/ports/port (#7684)
* * Health/sensor view for specific device/ports/port

* Removed code that didn't comply with standard

* added extra check html/pages/device/port/sensors.inc.php

* Update sensors.inc.php
2017-11-09 15:28:26 -06:00
Tony Murray
8b3bd57303 fix: Number comparisons in alerts and device groups (#7695)
Remove quotes so if the field we are comparing against is a string type, we still do a number comparison.
2017-11-09 20:37:45 +00:00
tomarch
7f18c458db newdevice : Added detection for Stormshield devices (#7646)
* initial support for stormshield

* renamed stormshield os to ns-bsd

* remove trim
2017-11-08 14:37:38 +00:00
deepseth
ea646bae2c Trailing slash in multi_data graphs removed (#7673) 2017-11-08 14:32:46 +00:00
Neil Lathwood
f84844f2a7 fix: Better validation on callback url for Pagerduty integration (#7658) 2017-11-07 09:32:09 -06:00
Tony Murray
4dd56bc72e refactor: Wifi cleanup (#7607)
* refactor: remove duplicated data collection in old wifi module
Still a bit more work before we can fully remove it

* remove unused graphs
update overview graphs for some wireless os
2017-11-02 21:07:58 +00:00
Tony Murray
1c31b06768 webui: Don't disable the applications check boxes in settings if the discovery module is disabled. (#7615)
It disables the check boxes because it will automatically disabled/enabled based on data returned from the device.
2017-11-02 20:38:17 +00:00
Robert (KHobbits)
ea477e1b28 Add support for a wider range of link speeds when mapping links. (#7533)
Use a formula to work out link speed on network map, rather than using defined speeds.
2017-11-01 23:14:03 -05:00
Zmegolaz
a7f42361ae Fix: Better sanity check of hostname when adding device. (#7582)
* Better sanity check of hostname when adding device.

* Style fix.

* clean() before hostname validity check. IP::isValid to support IPv6 addresses.

* Even more checks to catch invalid input.

* Long if-else, better error message.

* Code re-arranging
2017-11-01 11:06:39 -05:00
Tony Murray
6e3ea8b28e fix: Only show the neighbour tab if there are neighbors to show (#7591)
Also, fix up the sql statements in this file.  No reason to count entries if we only want to know if at least one entry exists.
2017-10-31 20:35:49 +00:00
Neil Lathwood
f00e896e93 webui: Added toner support in health metrics list (#7595) 2017-10-31 20:31:56 +00:00
Tony Murray
087dbbd173 webui: Hide rediscover button for ping only devices (#7594) 2017-10-31 19:48:15 +00:00
Zmegolaz
03820d3bd8 Fix: availability-map showed ping devices as warning. (#7592) 2017-10-31 08:15:23 -05:00
Tony Murray
9d73cd401a feature: LDAP auth update: alerts, api, remember me (#7335)
* feature: LDAP auth update: alerts, api, remember me
Defer ldap connection until it is needed (saves connections from pollers)
Add ability to use a bind account if the server does not allow anonymous bind.
If the server does allow anonymous bind, no config change is needed.
Use Config class

FYI, I have no way to test this.

TODO: update/validate docs

* prevent duplicate users in get_userlist()

* fix bug in Config get for auth_ldap_uid_attribute, `.` should have been `,`
Change case of uidNumber to match common configs (should be case insensitive anyway)

* revert uidnumber case changes and fix up user supplied ones as it is unintuitive that they need to be lowercase.
Add auth_ldap_binddn setting to allow more a more specific way to enter the bind user.
2017-10-30 19:28:40 +00:00
Florian Beer
f92dae6915 webui: Fix Services container alignment (#7583)
This has been bugging me for a while... ;)
The services container wasn't properly aligned with the rest of the boxes (e.g. Events, Syslog etc.). This small HTML change fixes that.
2017-10-30 12:45:58 -05:00
François LASSERRE
e33392a812 Fix librenms install go to stage 0 to 6. (#7571) 2017-10-28 10:48:28 +01:00
Zmegolaz
f8d7ccfe0d feature: Support for up/down detection of ping only devices.
* Added support for ping only devices.

* Renamed sql-schema/206 to 207.

* Discovery tried to detect the OS when it shouldn't.

* Updated db_schema.yaml

* Added ping icon.

* Don't show unused graphs and tabs when SNMP is disabled.

* Allow the user to specify OS of ping only devices.

* Removing custom OS now changes it to 'ping'.

* Removed unnecessary use of mres().

* UI select box for SNMP enable/disable.

* Hide device_ping_perf if ping is disable on device.

* Fixed SNMP settings update status messages.

* Added functionality to add ping only devices via the web ui.

* Added ping only option to addhost.php

* Added ping only support to snmp-scan.py

* Moved sql 208 to 211

* Fixed scrutinizer issues.

* Fixed broken ossearch.

* Added ping only support to the API.

* Updated API doc.

* Added (optional) to OS and hardware description. Hid Port Settings, Applications, Modules, Storage, Processors, Memory and Components from the edit menu

* Style fix.

* Updated ping icon.

* clean() instead of mres(). More escaping. Better help in snmp-scan.py and addhost.php

* Fixed scrutinizer issue.

* Always try SNMP in snmp-scan.py, new option for it in addhost.php. Slice instead of chunk in ajax_ossuggest.php. Other minor style changes.

* Updated sql modifications to insert the new column in the same place as in db_schema.yaml.
2017-10-27 22:59:25 -05:00
tomarch
db3d9dc4ab newdevice: Added detection for proxmox devices (#7543)
* initial proxmox detection

* minor changes

* fixed detection

* change sysdescr
2017-10-27 21:14:26 +01:00
Neil Lathwood
752ba5153c Small UI tweak for validate page (#7559) 2017-10-26 21:11:51 +01:00
Joel Kociolek
bc3d1ed47e feature: Improve Freeswitch agent: add ability to get data via snmp and graph more data (#7549)
* Add ability to get Freeswitch application data via snmp

On your Freeswitch server install the script from
https://github.com/librenms/librenms-agent/blob/master/agent-local/freeswitch
into /etc/snmp, make it executable and adjust it to your installation.
Configure your snmpd to use the sript as an extension. For example on Debian
add the following line to your /etc/snmp/snmpd.conf:

extend freeswitch /etc/snmp/freeswitch

Activate the Freeswitch application for your server on your LibreNMS server.
it should now start to receive data from your Freeswitch server via snmp.

* Graph "Calls" and "Channels" of Freeswitch agent

The Freeswitch agent sends Calls and Channels count and they weren't graphed
up to now.  This is especially useful in settings where the Freeswitch
server does not act as a Gateway and thus the agent does not sent
Incoming and Outgoing Call numbers.

* Cleanup commented code and add myself to authors
2017-10-26 11:27:11 +01:00
Tony Murray
51ba934e11 feature: Added web validation (#7474)
* refactor: convert validations to modules to prep for gui integration

* accidentally dropped, schema update

* fix accidental output to webui

* mention discovery-wrapper.py and re-arrange.

* refine some fix statements

* rename the Config validation group to Configuration.

* fix some scrutinizer issues
remove as many local functions from validator.php as possible
move extensions from pre-check
remove duplicate timezone check
looks like there is some db schema differences between mariadb 10.1 and 10.2, investigating

* mariadb version diff take2

* Check schema version first for database.
Remove stop to go back to command line for install docs.
Add helpful link when there is no devices added to /addhost

* fix incorrect validation for empty string defaults

* Fix style

* Add additional file permissions checks

* catch exception and fail for invalid timezone
Change visuals a bit.

* add php version warning

* fix space
2017-10-26 07:56:09 +01:00
Chris A. Evans
a6ad9b86be newdevice: Added Mitel Standard Linux OS detection (#7513)
* Added Mitel Standard Linux OS Support

* removed duplicate svg, added snmprec test file, un-enable vmware discovery module

* msl os definition/polling improvements, mitel mib_dir creation
2017-10-25 16:38:53 +01:00
Neil Lathwood
e751206f74 newdevice: Added more detection for IgniteNet FusionSwitch (#7384)
* newdevice: Added more detection for IgniteNet FusionSwitch

* fixed current graphs descr

* small updates

* small updates recommended by murrant
2017-10-25 08:10:02 -05:00
Alan Gregory
50413ff9ae newdevice: Added support for logmaster(ups vendors) devices (#7524)
* added logmaster icon

* added LogMaster Ups Mibs

* Added battery temperature

* Added LogMaster Os discovery

* Added PPC UPS top level mib

* Added more sensors

* Added test for Os

* Added log image

* Disable unused modules to improve polling

* Changed discovery to match all second level.

* Fix logo size to 32x32

* Remove duplicated mib.

* Removed .mib extension

* Fix mib name.

* Added rfc1628 compatibility.

* Removed duplicated sensors due to rfc support

* Added sensor that differs from rfc 1628.
2017-10-24 14:37:36 +01:00
Paul Heinrichs
f2c4563c85 newdevice: Added initial detection for netmodule NB1600 (#7514) 2017-10-20 16:41:32 +01:00
Florian Beer
ab1658e90a webui: Show only authorized services in availability map (#7498)
* Show only authorized services in availability map

Up until now, normal users could see all configured services in availability map. This PR checks for permissions first, before displaying the items. I haven't looked at the dashboard widget yet, maybe it needs similar changes.

* Update to use userlevel helper function
2017-10-19 07:49:07 +01:00
Neil Lathwood
1205f12f10 security: Stop accepting other variables in install that we do not use (#7511) 2017-10-18 13:19:16 +01:00
ZedTheYeti
ee5c223669 Supply MySQL database hostname when using Unix sockets to connect (#7471)
* Supply MySQL database hostname when using Unix sockets to connect

* Pass unix_socket parameter when db_socket is set

* Set db_host to localhost when db_socket is set
2017-10-17 21:55:41 -05:00
FTBZ
89ff05ebea newdevice: Added firewall graphs for Palo Alto Networks firewall (#7483)
* Features: Add firewall graphs for Palo Alto Networks firewall

* Features: Add firewall graphs for Palo Alto Networks firewall

* Update db_schema.yaml
2017-10-17 12:42:13 +01:00
Tony Murray
96ccc49026 security: Escape sql credentials during install (#7494) 2017-10-17 11:49:56 +01:00
Martin Zatloukal
6e379bfbbd newdevice: Added support for Alcoma wireless devices (#7476)
* New os Alcoma

* New os Alcoma

* Update AlcomaAlmp.php
2017-10-17 08:57:31 +01:00
Ryan Medlyn
62867a6661 webui: Allow user to display ok/warning/critical alerts only (#7484)
* Allow user to display ok/warning/critical alerts only

* Update alerts.inc.php

* Update alerts.inc.php
2017-10-15 19:50:55 +01:00
Mihai Petracovici
348f5012b1 api: Added sysname as filtering group for oxidized (#7485)
* Add sysname as filtering group for oxidized

* Updated Oxidized docs with new filtering option
2017-10-15 19:37:20 +01:00
Martin Zatloukal
f48cff0f1b newdevice: Added support for Racom RAy devices (#7466) 2017-10-15 19:31:44 +01:00
Søren Rosiak
a9ab96e83f feature: Improve Device Neighbour WebUI (#7487) 2017-10-15 09:26:01 -05:00
Felix Eckhofer
26c9a45ca6 fix: Allow Options in .htaccess to be merged (#7472)
Apache will replace `Options` from the server config with new ones
provided in `.htaccess` unless all of the parameters start with either
`+` or `-`. This effectively disables `+ExecCGI` and others that might
be needed for proper operation.
2017-10-12 09:51:53 +00:00
Yunchih Chen
82fb20cc19 feature: Configurable 95th percentile (#7442)
See issue #7406 for detail.
2017-10-11 13:21:11 +01:00