Commit Graph

39 Commits

Author SHA1 Message Date
Tony Murray
c1258320f8 Availability module fixes (#15369)
* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 10:32:59 -05:00
Tony Murray
f2f169ae78 Modernize mempools (#12282)
* mempools to modern module
quick hacky hrstorage port

* port ucd-snmp-mib to Mempools

* Populate DB for ucd
Prep for yaml

* initial yaml attempt

* more complex conversions
fixes to YamlDiscovery, make leading $ optional and allow mib::oid format

* walk full tables and skip values
normalize percentages above 100

* handle precent only ones (specify total as 100)

* Move default polling out of YamlMempoolsDiscovery

* fixes

* Update test data hrstorage should be correct.

* perc_warn for hrstorage

* Host Resources, record buffer, cached, and shared

* Host Resources is always better, don't do both HR and UCD

* fix unix, include warning levels

* variable size

* consolidate skip_values

* define mempools schema

* number instead of integer

* more schema refactor

* one more skip_values reference

* throw error for invalid oid translation
aos6

* a*  and Cisco

* updated test data

* update almost all hrstorage data files

* b*

* c* with test data
use standard cache for hrStorage

* use cache for storage module too

* hand bsnmp properly

* bdcom

* exclude total oid from yaml so it is not polled
May add a way to ignore this behavior and poll it, but I don't know if that is needed.

* automatically handle percent only values

* ciscowlc

* only poll used or free if we have used, free, and total.

* fix skipping

* the dlinkoning
fix find value when value "name" is numeric

* support numeric oids

* dnos/ftos attempt

* I guess we can't filter on total > 0

* edgecos

* e*

* f WIP

* f*

* gwd (aka g*)

* h* + procurve

* i*

* j*

* m*

* support 0% used memory (however unlikely)

* n*

* CISCO-PROCESS-MIB memory, share cache with processors module

* ignore mempools with invalid total

* p*

* quanta

* r*
fix raisecom mibs terribly broken

* s-z

* style fixes

* Move VRP back to PHP and make it actually work

* fix zynos

* update schema

* Update Cisco processor data for description bug fixes

* fix comware processors

* comware mempools with memory size
default precision to 1

* sophos-xg updated data

* hrstorage use ram size for buffers, cache, and shared

* Show memory available instead of free in device overview

* UCD, use same rrd format, store available instead of free in the db.

* Calculate availability for HOST-RESOURCES-MIB

* Convert UCD to standard polling

* rename old rrd files

* initial graph work

* graph WIP

* Graph looking decent

* Graph looking decent for hr

* remove old ucd_graph code

* handle availability mempool
more graph cleanup

* color adjustments

* remove accidental free calculation

* Update test data and fix corner cases

* fis pfsense

* update schema

* add default value for mempool_class

* fix whitespace

* update schema

* update schema correctly

* one more time

* fortigate_1500d-sensors missing oids

* Update docs.

* fix indent

* add implements MempoolsDiscovery explicitly to OS

* remove ucd_memory graph references
remove unused device_memory graph

* remove unused functions

* set devices with mempools to rediscover to prevent/minimize gaps

* use a subquery

* add overview graph

* port health mempools table

* Update device mempool

* only show overview if multiple

* Don't override user set warn percentages in discovery

* fix missed usage

* fix style

* Safety check to not rename rrd files incorrectly if migration has not been run.

* Fix overview percent bar and represent available and used on the bar

* missed an item to convert to mempool_class

* percent on the wrong side
2020-11-23 15:35:35 -06:00
Jellyfrog
2fc3a21211 Apply fixes from StyleCI (#12121) 2020-09-21 15:43:38 +02:00
Tony Murray
f3ba8947f7 Use Config helper (#10339)
remove usage of global variable
2019-06-23 00:29:12 -05:00
Neil Lathwood
fad5aca1b7 feature: Allow customisation of rrd step/heartbeat when creating new rrd files (#5947)
* feature: Allow customisation of rrd step/heartbeat when creating new rrd files

* revert defaults

* added docs + webui config option

* Move RrdDefinition to an Object to make them easier to create and remove the possibility of typos.

* Fix style/lint issues and missing use statements

* 3 more missing use statements

* updated doc + moved schema file
2017-02-23 22:45:50 +00:00
Neil Lathwood
d5296319fb refactor: MySQL strict and query fixes (#5338)
* refactor: MySQL strict and query fixes

* moved sql file
2017-01-13 06:47:16 -06:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
Tony Murray
57650e4ffc Remove nfs requirement for distributed poller (with rrdtool 1.5+)
Use data_update instead of rrd_update/rrd_create and influx_update
Centralize rrd file check so we can check against a remote rrdcached server too
Use rrd_name() to generate rrd file names
2016-07-07 21:10:06 -05:00
laf
7b14aada4e Rebased 2015-10-26 11:08:19 +00:00
Daniel Preussker
7832868dd6 Added generic memcached support to dbFacile.*
Remove now obsolete memcached code in:
  html/ajax_rulesuggest.php

Remove all the broken memcached code in:
  html/pages/device/health/mempool.inc.php
  html/pages/device/overview/generic/sensor.inc.php
  html/pages/device/overview/mempools.inc.php
  html/pages/device/port.inc.php
  html/pages/device/ports.inc.php
  html/pages/health/sensors.inc.php
  includes/polling/functions.inc.php
  includes/polling/mempools.inc.php
  includes/polling/ports.inc.php
  includes/polling/storage.inc.php
2015-09-27 19:33:17 +00:00
Daniel Preussker
ba7bf5f60b Merge pull request #1715 from laf/rrdoptions
Updated rrdtool_update() to use new array format
2015-09-22 12:15:59 +00:00
Mark Schouten
55a2e0423d Remove all unneeded if($debug)-statements and replace them with d_echo 2015-08-21 16:10:00 +02:00
laf
433562d351 More updates for influx 2015-08-19 20:58:02 +00:00
laf
987634e463 Updated rrdtool_update() to use new array format 2015-08-18 16:26:55 +00:00
Job Snijders
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
laf
6e84535031 Dynamic config system 2015-05-14 21:54:33 +01:00
Alexander Sosna
5a7988e2e4 chmod 0644 to php files not directly executed 2015-04-28 22:58:03 +02:00
mchasteen
d7ea7e71bf Fixed polling mempool thing so that NULL values don't break things. 2015-02-26 23:03:48 +00:00
Adam Amstrong
1d4b392876 push more state to memcached fix sensors poller to not retry all temperature sensors where return >9000 5 times (lmsensors returns milliC, so 30000 for 30C)
git-svn-id: http://www.observium.org/svn/observer/trunk@3244 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 18:35:17 +00:00
Adam Amstrong
b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong
cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Adam Amstrong
22dad0dae4 revert change changing mempool/storage format
git-svn-id: http://www.observium.org/svn/observer/trunk@3091 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-26 16:15:11 +00:00
Adam Amstrong
2b8178bb5b move all RRA decisions to config. switch mempool/storage to new rrds (sorry, data lost, the old rrds sucked). added some more apps pages.
git-svn-id: http://www.observium.org/svn/observer/trunk@3068 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-20 17:37:58 +00:00
Adam Amstrong
66b34b8999 more db* (and add on-the-fly discovery of ports and removal of OSPF areas)
git-svn-id: http://www.observium.org/svn/observer/trunk@2338 61d68cd4-352d-0410-923a-c4978735b2b8
2011-05-16 21:56:01 +00:00
Adam Amstrong
efd9d30ee7 move percentage colour mappings to function. make graphs for memory/storage match percentage colours (should we do this for others?)
git-svn-id: http://www.observium.org/svn/observer/trunk@2160 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-25 17:15:36 +00:00
Tom Laermans
f55a30f744 some formatting cleanups, introduce some more FIXMEs to look at, plus replace mysql_fetch_array by mysql_fetch_assoc, for great justice
git-svn-id: http://www.observium.org/svn/observer/trunk@2029 61d68cd4-352d-0410-923a-c4978735b2b8
2011-04-06 13:54:50 +00:00
Tom Laermans
ecbcd1db43 clean up polling source files, remove dead code
git-svn-id: http://www.observium.org/svn/observer/trunk@1865 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-16 01:11:27 +00:00
Tom Laermans
b4fcb6eb5d fix snmp retries/timeout typo, fix division by zero with broken mempools and don't discard lm-sensors fans faster than 500rpm - found by Corentin Chary
git-svn-id: http://www.observium.org/svn/observer/trunk@1779 61d68cd4-352d-0410-923a-c4978735b2b8
2011-03-02 15:03:05 +00:00
Adam Amstrong
86f0647ded poller output cleanups (i think we should start to put some colour in here, to make it all sexypants)
git-svn-id: http://www.observium.org/svn/observer/trunk@1649 61d68cd4-352d-0410-923a-c4978735b2b8
2010-08-05 23:00:35 +00:00
Adam Amstrong
29f5afa472 split netstats pollers into protocols. update $graphs array for each one successfully polled
git-svn-id: http://www.observium.org/svn/observer/trunk@1501 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-28 12:59:59 +00:00
Adam Amstrong
538e96462f Move mempool polling scripts into their own directory. add Juniper ScreenOS CPU/Memory hardcoded discovery/poller
git-svn-id: http://www.observium.org/svn/observer/trunk@1467 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-23 18:15:54 +00:00
Adam Amstrong
fdff9dd065 even more debugging
git-svn-id: http://www.observium.org/svn/observer/trunk@1411 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-18 09:59:34 +00:00
Adam Amstrong
ab99bf5ef8 wipe out mempool cache on new host
git-svn-id: http://www.observium.org/svn/observer/trunk@1409 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-18 09:57:48 +00:00
Adam Amstrong
29b3d90fd8 use precision for processors
git-svn-id: http://www.observium.org/svn/observer/trunk@1321 61d68cd4-352d-0410-923a-c4978735b2b8
2010-07-09 14:09:29 +00:00
Adam Amstrong
152dc52b4e fix bug where mempool >2GB was broken. (i blame sid3windr for this, he was probably distracting me with talk of printers or something)
git-svn-id: http://www.observium.org/svn/observer/trunk@1047 61d68cd4-352d-0410-923a-c4978735b2b8
2010-03-26 18:30:27 +00:00
Adam Amstrong
1e2d5266ff add CISCO-ENHANCED-MEMPOOL-MIB support to new mempool discovery/poller
git-svn-id: http://www.observium.org/svn/observer/trunk@1002 61d68cd4-352d-0410-923a-c4978735b2b8
2010-03-11 02:53:17 +00:00
Adam Amstrong
1c70cab047 junos mempools
git-svn-id: http://www.observium.org/svn/observer/trunk@949 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-25 01:30:07 +00:00
Adam Amstrong
81eb203abe storage fixes, moving things from graphing page, ironware dynamic memory pool (static!)
git-svn-id: http://www.observium.org/svn/observer/trunk@947 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-25 00:56:13 +00:00
Adam Amstrong
d58bd29035 add generic memory pool poller and add old-cisco-memory-pool-mib support
git-svn-id: http://www.observium.org/svn/observer/trunk@931 61d68cd4-352d-0410-923a-c4978735b2b8
2010-02-22 00:57:13 +00:00