Commit Graph

39 Commits

Author SHA1 Message Date
Jellyfrog
b6620746c5 Miscellaneous cleanup - part 5 (#14502)
* Miscellaneous cleanup - part 5

* Update includes/discovery/sensors/pre-cache/ipoman.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>

* Update ipoman.inc.php

* string for trim()

* Update ciscosb.inc.php

Co-authored-by: Tony Murray <murraytony@gmail.com>
2022-10-25 19:27:28 +02:00
Jellyfrog
a5b1ef61bc Check dot1dBasePortIfIndex exists before using it (#14337)
* Check dot1dBasePortIfIndex exists before using it

Fixes: array_flip(): Can only flip STRING and INTEGER values!

* Update vlans.inc.php

* Update vlans.inc.php
2022-09-12 15:18:43 +02:00
Tony Murray
465fa3986a Fix Undefined variable/key warnings (#14134)
* Fix Undefined variable/key warnings

* massage for test data

* restore set_numeric, only generates noise

* Fix ucd storage used (apparently free is not stored in discovery...)
2022-08-21 16:23:43 -05:00
Jellyfrog
82f43cb98d Apply fixes from StyleCI (#12120) 2020-09-21 15:40:17 +02:00
Tony Murray
e9ff8c48b6 Fixed IN db queries (#9077)
Most were fine as they hardcoded the in into the query.
Change them all to use PDO properly.
Did not fix IRCBot, they are are all hardcoded.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-08-26 13:42:21 +01:00
Tony Murray
eeb3d58f5b Improved Logging and Debugging (#8870)
Use Log facility when Laravel is booted.
Update init.php so we can easily boot Laravel for CLI scripts. (and just Eloquent, but that may go away)
Move all debug setup into set_debug() function and use that across all scripts.
Log Laravel database queries.
Send debug output to librenms log file when enabling debug in the webui.
Allow for colorized Log CLI output. (currently will leave % tags in log file output)

** Needs testing and perhaps tweaking still.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-07-13 23:08:00 +01:00
Tony Murray
b41e32c7aa Fix missing use statements (#8614) 2018-04-24 21:20:21 -05:00
Neil Lathwood
245c15807d refactor: Update include files for disco/poller to be dynamic (#8597) 2018-04-24 20:08:06 -05:00
ospfbgp
4245469785 Update vlans.inc.php (#8592)
vlans module on discovery not working after the rebranding of avaya-ers to boss.  This seems to be a hidden easter egg. :-)
2018-04-22 13:20:06 +01:00
Neil Lathwood
b5d24a533a fix: Fixed the empty() vlan detection check (#7241) 2017-08-28 20:24:43 +01:00
Neil Lathwood
e1ffdedb6b newdevice: Added additional vlan support for Juniper devices (#7203) 2017-08-22 20:52:01 +01:00
Neil Lathwood
a435c7c2f6 Update vlans.inc.php 2017-08-02 07:59:36 +01:00
Tom Sealey
d344629eda added check for Avaya-ERS OS 2017-08-01 10:09:47 +01:00
Neil Lathwood
4d0832e412 refactor: Updated vlan discovery to support JunOS (#6597) 2017-05-13 23:06:14 +01:00
Tony Murray
924b751be4 fix: vlan port mappings not removed (#6423)
Thanks to @diodo for supplying this fix.
2017-04-15 20:08:49 +01:00
Neil Lathwood
21898a3c29 Disco / Poller tidy up + Added display of module mem usage (#5778)
* tidyup + added mem usage for poller modules

* tidied up discovery modules

* fix sensors
2017-02-07 22:54:30 -06:00
Neil Lathwood
da5783d917 feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY (#5327)
* feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY

* fix all schema errors and update system
2017-01-07 11:32:38 -06:00
Tony Murray
4ff9e84f4e refactor: populate native vlans in the ports_vlan table for cisco devices too (#4805) 2016-10-19 22:44:49 +01:00
Eldon Koyle
7ca80410d5 feature: Add q-bridge-mib tagged VLAN membership #3285 2016-10-11 22:29:06 +01:00
Neil Lathwood
7dec670494 refactor: Updated a lot of references to LibreNMS - copyright still left intact (#4339) 2016-09-08 08:12:23 -05:00
Tony Murray
9284bc60ff Update code in includes to be PSR-2 compliant (#4220)
refactor: Update code in /includes to be psr2 compliant #4220
2016-08-28 18:32:58 +01:00
laf
558dfb2344 Pretty up the discovery process output 2016-06-21 00:59:43 +01:00
Job Snijders
d8693f05ae Fix coding style part 2 2015-07-15 11:04:22 +02:00
laf
15cc00c27d Tidying up 2015-02-26 23:04:10 +00:00
mchasteen
b73f642bc6 Fixed vlan discover so there isn't any more SQL errors. Will need further testing. 2015-02-26 23:03:17 +00:00
Paul Gear
45d8325e97 Revert "Merge pull request #160 from laf/issue-159"
This reverts commit 59dfe4eee2, reversing
changes made to e6fa7d433d.

This commit does not constitute agreement with the claim of copyright violation made by Adam Armstrong at
59dfe4eee2
2014-04-28 20:10:36 +10:00
laf
fe100a499a Fix for Cisco kit where match prefix is switched off. 2014-03-05 15:02:04 +00:00
Adam Amstrong
b273e04241 /// -> //
git-svn-id: http://www.observium.org/svn/observer/trunk@3240 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 12:24:34 +00:00
Adam Amstrong
cacf913a55 # -> / for phpdoc
git-svn-id: http://www.observium.org/svn/observer/trunk@3239 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-25 11:29:53 +00:00
Adam Amstrong
4db1454e92 move from port_id to interface_id. make ports discovery only discover. add some cleaner functions. add a tiny bit of alerting infrastructure.
git-svn-id: http://www.observium.org/svn/observer/trunk@3195 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-16 13:25:50 +00:00
Tom Laermans
1f9eae3699 add snmpv3 support to old snmp queries - patch by gl
git-svn-id: http://www.observium.org/svn/observer/trunk@3184 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-15 13:45:26 +00:00
Tom Laermans
613e8b1e29 syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@3117 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-02 22:02:30 +00:00
Adam Amstrong
dc66830e95 move vlan discovery scripts into a directory
git-svn-id: http://www.observium.org/svn/observer/trunk@3115 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-02 15:12:04 +00:00
Adam Amstrong
4f1ec54a47 updated vlan detection
git-svn-id: http://www.observium.org/svn/observer/trunk@3113 61d68cd4-352d-0410-923a-c4978735b2b8
2012-05-02 15:04:31 +00:00
Tom Laermans
ed6ffa6067 syntaxer run
git-svn-id: http://www.observium.org/svn/observer/trunk@2964 61d68cd4-352d-0410-923a-c4978735b2b8
2012-04-05 16:17:41 +00:00
Tom Laermans
20ec00368f don't print header when no dot1d data is available
git-svn-id: http://www.observium.org/svn/observer/trunk@2841 61d68cd4-352d-0410-923a-c4978735b2b8
2012-01-19 14:00:29 +00:00
Adam Amstrong
9bf9edb20b comment
git-svn-id: http://www.observium.org/svn/observer/trunk@2839 61d68cd4-352d-0410-923a-c4978735b2b8
2012-01-19 10:33:15 +00:00
Adam Amstrong
f2d7f81a62 only try per-vlan community on cisco :)
git-svn-id: http://www.observium.org/svn/observer/trunk@2838 61d68cd4-352d-0410-923a-c4978735b2b8
2012-01-19 10:04:06 +00:00
Adam Amstrong
8cecfb8f77 add vlan discovery module (HERP DERP!)
git-svn-id: http://www.observium.org/svn/observer/trunk@2837 61d68cd4-352d-0410-923a-c4978735b2b8
2012-01-19 08:49:26 +00:00