Commit Graph

8305 Commits

Author SHA1 Message Date
Wooboy
3cf5a6ceae Add definition fujifilmprinter (#15381)
* Add support for Fujifilm printer

* Add support for Fujifilm printer

* fix Fujifilmprinter.yaml

* Add Fujifilm printer test unit

* remove snmprec supply descr contains utf8 character

* fix discovery yaml
2023-11-01 23:03:45 -05:00
Alexis Vézina
fc79d6b157 Wip/apc ap 7900b (#1) (#15392)
* skip negative values on power/power_consumed

* skip negative values on voltage for apc.inc.php
  adds comment in apc.yaml definition.

* add test data
2023-11-01 23:02:24 -05:00
Tony Murray
ce02f001ce TrueNAS no longer supports zpool space usage (#15490)
* Freenas zpool improvement
Don't try to multiply two strings (cast units to int)
No need to double fetch database entries to check if it exists.
Only poll zpoolUsed to speed up polling

* Block zpool usage on new devices, they dropped support.
TRUENAS-MIB included for reference

* Fix polling, update test data
2023-11-01 23:00:58 -05:00
Wheel
f0bbab2419 Minor fix and tweak for graylog integration (#15455)
* Minor fix and tweak for graylog integration

* More flexible in other use cases

* fix again?
2023-11-01 22:35:44 -05:00
Wheel
9ca95a9ba5 Dark mode fix routing tabs & pages (#15485)
* Dark mode fix routing tabs

* Fix styling

* Fix styling

* move tbody

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-01 22:34:09 -05:00
VTS
47c6842b01 API: get poller group (#15493)
* API: get poller group

* missed string in doc

* return all poller groups if name/id aren't specified

* add missing doc link

* style fixes

* more style

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-01 22:33:35 -05:00
Galileo77
0fb72b39a2 vertiv pdu mg02e4w1 (#15484)
* Update vertiv-pdu.yaml

Detection of Vertiv Geist PDU type MG02E4W1

* Add files via upload

Testfile for Vertiv Geist PDU MG02E4W1

* Add files via upload

Testfile

* Update vertiv-pdu.yaml

* Update vertiv-pdu_mg02e4w1.json

* Add missing sensors from OP

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-01 22:33:09 -05:00
bnerickson
a8b4068922 [bugfix] Passing $device into data_update_helper functions instead of declaring it as global. (#15542)
* Passing @device into data_update_helper functions instead of declaring it as global.

* Style fixes
2023-11-01 20:32:41 -05:00
Tony Murray
95eab0d42e Fix health temperature degree display (#15541)
* Fix health temperature degree display
It will be converted to html later. (otherwise it was double converted)

* Remove all &deg; it will only cause troubles
2023-11-01 20:35:35 +01:00
Tim de Boer
bcf700c5fe Added BGP Remote peer link and graph in Routing Overview (#15532) 2023-10-31 13:27:21 -05:00
Nick Peelman
88b9744e02 Add sysObjectIDs for other models of PSS shelves (#15525) 2023-10-30 22:13:28 +01:00
Nick Peelman
f1c0d312ae Add support for Nokia 1830 PSS Optical gear (#15516)
* Add support for Nokia 1830 PSS Optical gear

Tested against 1830 PSS-8 Chassis, in single and multi-chassis configurations
Supports Optical Power, temperature, current, power, and a variety of card states, alarms, and trail status.

Of note: With multi-chassis nodes, reading values from the non-master can be a "slow" process, slow in that the default timeout Libre ships with can cause the SNMP client to begin issuing retries.  This can result in the chassis daemon rate limiting and/or blocking the client.  The solution here is to raise the SNMP timeout within each device's configuration; unfortunately those values are not configurable on a per-OS basis (at least not at this time).

* Removing Unused / Duplicate MIBs
2023-10-30 13:53:22 -05:00
Nick Peelman
30c95b7a76 Add Support for Samlex America PSR-1200-48 Inverters (#15515) 2023-10-28 23:34:16 +02:00
Peter Childs
520e53c4cd add Wrong Type work around to snmp_get function (#15509)
* add Wrong Type work around to snmp_get function

* style-ci
2023-10-26 21:32:27 -05:00
Tony Murray
7e0b41a05a IP::fromHexString handle ascii (#15504)
* IP::fromHexString handle ascii
Some bad MIBs convert the hex to ascii on display.
Attempt to decode that if the situation is detected.

fixes #15501

* add ascii tests
2023-10-26 10:03:03 -05:00
Tony Murray
91b829edd3 Fix API get_location by ID (#15506) 2023-10-25 13:05:04 -05:00
Tony Murray
8c38d3336e Fix websensor temp user_func (#15492)
default should be null, not ''
2023-10-23 12:17:20 -05:00
Tony Murray
f0aa80e73d ports ifPhysAddress use MAC helper (#15478)
* Ports min polled period of 1
Prevent divide by 0
Use Mac utility

* fix bad snmprec for airos-af-ltu

* Update a large amount of invalid mac addresses
either the script is capturing them wrong or users are mangling them

* More updated test data

* Update test data with bad input

* Fix ones using encoded <private> and attempt to fix capture

* Update awplus data

* restore missing data

* update other DNOS

* Fix ones using encoded <private> and attempt to fix capture

* Fix ones using encoded <private> and attempt to fix capture

* fix typo

* Update some data

* update data

* update ruijie
2023-10-19 20:10:52 +02:00
metrojworthington
7bd1a57c3e Mcc valere (#14753)
* modifications needed for update of VALERE-DC-POWER-MIB with new file ELTEK-BC2000-DC-POWER-MIB

* add test results for BC2000 post update

* updated test file data

* re-upload of updated files

* reverted valere.json to defaults and recreated with proper varient .json

* replace vpwrShelfIndex with vpwrBayIndex

* updated test data

* Update test data

* try again valere_bc2000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-19 07:22:46 -05:00
Félix Bouynot
bd7c1bd15d Discover AEN with sysobjectid instead of sysdescr (#15482)
* Discover AEN with sysobjectid instead of sysdescr

According to: 
- https://docs.vmware.com/en/VMware-Smart-Assurance/10.1.11/ncm-dsr-support-matrix-33HF1/GUID-C98227E4-830C-4044-894C-157D3CE71058.html
- https://oid-rep.orange-labs.fr/get/1.3.6.1.4.1.22420.1.1
- the fact that the AEN yaml file use ACD-DESC-MIB which is under this same OID (https://www.circitor.fr/Mibs/Html/A/ACD-DESC-MIB.php)

I'm changing the discovery mode, so it won't prevent devices with AEN in their sysname to be properly discovered.
Solve https://github.com/librenms/librenms/issues/15476

* Change to sysdescr_regex

* Add regex delimiters
2023-10-18 14:43:47 -05:00
Justin Lentz
66af1a54e8 ARP Discovery use MacHelper (#15479)
* Update arp-table.inc.php

* Import class

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-18 13:14:33 -05:00
Tony Murray
36080f5ca3 Ports min polled period of 1 (#15472)
Prevent divide by 0
2023-10-18 09:06:07 -05:00
Tony Murray
0e453e5938 API: allow add device to set location (#15469) 2023-10-18 02:00:39 -05:00
Tony Murray
78a85fe3ef Ports module: fix nulls not updating (#15467)
* Ports module fix nulls not updating

* Fix broken test data
I'd like to see how it came out broken in the first place, but I don't have access

* Update json data

* Fix fortivoice snmprec

* Fix scs-ks

* Fix bad siteboss550 data
2023-10-18 01:59:18 -05:00
Jellyfrog
187a4d36de Allow inserting null values for sensors (#15470)
* Allow inserting null values for sensors

* Update ericsson-ml.inc.php

* Update rittal-cmc-iii-sensors.inc.php
2023-10-17 13:18:17 +02:00
Tony Murray
7a8e479b61 Unix Agent and Application fixes (#15460)
* Unix Agent and Application fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-16 03:40:40 -05:00
Tony Murray
a51e70d067 Graphing: error when device is not found (#15459) 2023-10-15 06:02:21 -05:00
bnerickson
78a4bfb9d9 Adding Socket Statistic Application Support (#15307) 2023-10-13 22:45:03 -05:00
cwispy
c30c24e22c Fortimail add mail queues message count (#15444)
* Update fortimail.yaml

Added mail queues message count

* Update fortimail.snmprec

Update test data for FortiMail queues

* Add sensors fortimail.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-13 22:24:47 -05:00
Tony Murray
a5198d7d57 Remove some lightly used or unused dbFacile functions (#15418)
* Remove some lightly used or unused dbFacile functions
['NULL'] legacy behavior seems unsupported, replace with actual nulls

* Fix refactor mishap

* another

* update baseline

* these were very wrong... what happened?
2023-10-12 09:15:03 -05:00
Tony Murray
0540c56d0f Add application metrics model and relationships (#15417)
* Add application metrics model and relationships

* update schema check file

* Add missed index

* Update testing definition

* sqlite can't create the id later

* update schema dumps

* update testing_persistent schema

* update baseline
2023-10-12 02:24:27 -05:00
Tony Murray
7c5b0e3612 Fix port module wrong null (#15431)
* Fix port module wrong null

* Update test data

* revert incidental data changes
2023-10-11 20:42:05 -05:00
Tony Murray
e6be5f777b Use modern device attrib handling (#15429)
* Use modern attrib handling
Remove device attribs array.

fixes #15422

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 18:29:47 -05:00
Tony Murray
a8b69c1393 Fix discovery protocols again (#15434)
* Fix discovery protocols again
earlier fix had a typo

fixes #15432

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 10:20:12 -05:00
Tony Murray
aa455862e9 Fix bug saving snmpv3 device changes (#15419) 2023-10-08 18:56:48 -05:00
Tony Murray
14d9d66529 Agent: Packages fixes (+pacman) (#15415)
* Agent: Packages fixes
Don't try to save invalid packages, probably due to script failure on device.
Add pacman support

* Apply fixes from StyleCI

* Add version

* cast to number

* Update includes/polling/unix-agent/packages.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2023-10-08 18:37:33 -05:00
Tony Murray
c87c6e8b8e Remove legacy addhost code (#15376)
* Remove legacy addhost code
Update webui addhost
Update device snmp settings page
Update discovery protocols device discovery (no longer force full new device discovery in process)

* remove baseline exceptions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 22:02:45 -05:00
Tony Murray
685d11d4f1 Misc fixes 42 (#15413)
* Misc Fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 21:39:16 -05:00
Tony Murray
ac23c133d9 Fix an agent bug if a process ran more than 999 days (#15411)
* Fix an agent bug if a process ran more than 999 days
Increase it to 274 years before that happens ;)
Fix a few other small bugs

* Update schema check file
2023-10-07 20:14:00 -05:00
Tony Murray
e53436b6a3 Calculate downtime from device_outages table (#15397)
* Calculate downtime from device_outages table

* refactor
2023-10-06 20:37:23 -05:00
Tony Murray
6d9178cd42 Fix graph errors (#15407)
Some graphs were generating an error that wasn't being correctly output as an image
2023-10-06 08:22:22 -05:00
Tony Murray
d8c372bbf4 Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-06 07:34:14 -05:00
Tony Murray
908aef6596 Fix MAC search sql injection (#15402)
unparameterized variable
2023-10-05 23:04:04 -05:00
Tony Murray
7fe2614114 Fix xss in device groups overview (#15399) 2023-10-05 23:03:26 -05:00
Tony Murray
37eb0f1fa6 Hide unchangeable core module (#15395)
Core is an internal module do not show a toggle for it as it cannot be disabled.
2023-10-05 21:00:14 -05:00
Tony Murray
087d588102 Vmware vminfo modernize (#15008)
* Vmware vminfo
Remove legacy file and migrate to OS discovery

* tighter

* ios_stp-vlans working correctly now

* Make vmwVmGuestOS nullable

* Discover os info too

* VM Info module

* Apply fixes from StyleCI

* Fix log severity

* Fix log severity (more)

* VM Info module

* Poll with ESXi too because it is lightweight
add test data

* poller data now too

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 19:49:26 -05:00
Tony Murray
9fca01830c Update Tnmsne table backend (#15384)
remove ridiculous sql injection vulnerability
2023-10-05 10:32:21 +02:00
Tony Murray
be24993cbb Remove snmp functions that are barely used (#15377)
* Remove snmp functions that are barely used
Replace them with SnmpQuery calls

* Apply fixes from StyleCI

* Fix missing namespace

* Import Oid

* No more variables left may be repeated multiple times at the end with snmpsim, remove them all

* update data fixed by SnmpResponse bugfix

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 01:29:22 -05:00
Tony Murray
e0444bffcf Deprecate poller.php (#15370)
* Deprecate poller.php

* Apply fixes from StyleCI

* Remove references to poller.php
Leave wrapper...

* fix python style

* update wraper to call lnms device:poll

* Quiet output too

* make pb happy

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 16:32:02 -05:00
rolfbergheim
008efe41cd eNexus: added some groups and corrected some references (#15129)
* Added grouping on the Voltage displays

Added groupings to better show which voltage and current variables that belongs together.

* Update enexus.json

* Update enexus_eltek-smartpack2-syst.json

* Update enexus_enexus.json

* Update enexus_smartpacks.json

* Update enexus_smartpacks2.json

* Update enexus_sp2touch.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-04 16:26:32 -05:00