Commit Graph
495 Commits
Author SHA1 Message Date
Tony MurrayandGitHub 1b1907a09f Update database tests to prepare for more (#6500)
* Update database tests to prepare for more
Add test_db_name, test_db_user, test_db_pass to allow developers to have a dedicated testing database.
Extract DBTestCase to include common functionality for database based tests. Use transactions to isolate tests.
Enable STRICT_TRANS_TABLE, test for it's existence (only when we have a user that can set it)
Move the database cleanup to register_shutdown_function, this makes it happen every time at the end of tests.
If the was not empty, only truncate the tables (that aren't prepopulated) instead of drop the database.
Use our schema functions for schema tests.
Fix some missing array indexes so it doesn't clutter test output.

* Fix style
2017-04-26 07:56:00 -05:00
Tony MurrayandNeil Lathwood b4c4c39f55 feature: allow _except suffix in yaml os discovery (#6444)
Negates the selected check
2017-04-18 21:39:08 +01:00
Tony MurrayandNeil Lathwood 72ce39cf9b refactor: schema updates (#6370)
Test the schema files with STRICT_TRANS_TABLES and fix any issues
2017-04-13 10:18:12 +01:00
Tony MurrayandGitHub 0fd0b7cd6c Include the index name so the manual sql fix validates. (#6365) 2017-04-05 10:20:14 -05:00
Neil LathwoodandGitHub 03deb6434a feature: Added ability to validate database schema (#6303)
* feature: Added ability to validate database schema

* small scrut fixes

* Check for extra tables and columns
Print 30 items of schema updates, easier to copy paste sql

* Now supports detections and suggested fix for:
tables: missing, extra
columns: missing, extra, incorrect
indexes: missing, extra, incorrect

* final changes + hook into travis
2017-04-05 09:00:28 +01:00
Neil LathwoodandDavid Bell be9f4839bf sql query bug fix (#6248) 2017-03-23 10:08:48 +00:00
pblasquezandNeil Lathwood c32a41a5bf Load config for new get_proxy function (#6247) 2017-03-23 06:48:10 +00:00
Neil LathwoodandGitHub 5f5dc2a854 feature: Peeringdb integration to show the Exchanges and peers for your AS' (#6178) 2017-03-22 10:17:13 +00:00
Tony MurrayandNeil Lathwood 58495a3910 Add php docs for log_event, small cleanups (#6141)
* Add php docs for log_event, clean up eventlog_severity a bit.

* Update functions.php
2017-03-12 13:05:31 +00:00
towsterandTony Murray 7bb9d58a07 feature: Store the username in eventlog for any entries created through the Webui (#6032)
* Added identification of user who removed a device to eventlog entry

* Fixed spaces

* updated to store username for all eventlog where applicable

* moved sql file

* updated
2017-03-11 07:03:52 -06:00
Neil LathwoodandTony Murray 8f96b14975 fix: API, remove extra utf8 encoding for json function (#6118) 2017-03-07 22:08:28 -06:00
Neil LathwoodandGitHub 296360b204 fix: Update OSTicket transport to use the from email address #5739 (#5927) 2017-03-03 18:22:33 +00:00
towsterandNeil Lathwood 6612cb029d When 'mydomain' is set have host_exists check for both sysName and sysName.mydomin (#6052) 2017-03-03 14:27:56 +00:00
Tony MurrayandNeil Lathwood 20ae9e2ecd webui: Improve device header layout (#5990)
* webui: Improve device header layout

* Update css style version to break caches
Remove unused css.
2017-02-24 09:59:30 +00:00
Neil LathwoodandGitHub 171e8da4bf fix: Remove sensors_to_state_indexes data before carrying on with generic data removal for delete_device() (#5982) 2017-02-23 23:03:07 +00:00
Neil LathwoodandGitHub 92433f3511 feature: Added snmp_check() to decide if a device is up/down for snmp #5946 (#5948)
* feature: Added snmp_check() to decide if a device is up/down for snmp #5946

* added missing line

* Update snmp.inc.php
2017-02-23 22:47:18 +00:00
gilrimandNeil Lathwood 1c9cbc42f5 api: Add ability to return all device info for get_devices_by_group() (#5971)
* Changed GetDevicesFromGroup to output all columns if  is defined in url
2017-02-22 09:37:40 +00:00
Tony MurrayandNeil Lathwood 8d528124a9 fix: addhost.php throw proper exception when database add fails (#5972)
* fix: addhost.php throw proper exception when database add fails
createHost() now throws an exception when adding to the database fails with a hint to run ./validate.php
Add phpdocs to createHost()
2017-02-22 09:12:31 +00:00
Tony MurrayandNeil Lathwood 0b7b24fd9d Add tests for functions (#5915)
cast isHexString to bool
2017-02-16 08:15:20 +00:00
Neil LathwoodandGitHub 38168832a6 refactor: Centralise device up/down check and use in disco #5862 (#5897)
* refactor: Centralise device up/down check and use in disco #5862

* Remove extra indentation
2017-02-15 15:22:09 +00:00
Tony MurrayandNeil Lathwood ebb1516db1 Icon was updated to an empty variable because it was not set on the $device array() (#5893) 2017-02-14 23:04:55 +00:00
Neil LathwoodandGitHub b4da5de452 refactor: Centralised the updating of device logo #5873 (#5874) 2017-02-14 12:56:16 +00:00
Richard MayhewandNeil Lathwood 5bfd23e7eb webui: New eventlog severity classification (#5830)
* New event log severity model

* Revert "New event log severity model"

This reverts commit 0783527af8.

* New event log severity model

* Fixed spaces vs tabs

* Learning the format requirements

* Learning the format requirements

* Moved the colours in to the stylesheet

* change SQL file to stop conflicting

* refactor log_event so severity isn't last, but reference is.

* keep having to move the file due to new PR conflicts

* Revert "keep having to move the file due to new PR conflicts"

This reverts commit f3030e7218.

* extended support to dashboard and eventlog page

* formatting
2017-02-12 22:41:05 +00:00
Tony MurrayandNeil Lathwood a75ec7ab31 refactor: small function cleanups (#5865)
found while working on my snmp refactor
mac_clean_to_readable is about 33% improvement
hex2str is a moderate improvement
2017-02-12 13:20:06 +00:00
Neil LathwoodandTony Murray aab1cdac49 Throw error when host already exists rather than say it is due to snmp (#5789) 2017-02-06 08:16:00 -06:00
Tony MurrayandNeil Lathwood 03f09118c1 refactor: move hp jetdirect discovery to yaml (#5757) 2017-02-04 10:02:05 +00:00
Neil LathwoodandGitHub 7dc52654db fix: Ignore ports where we only have two entries in the array, this signals bad data #1366 (#5722)
* update to check for valid ports

* fix: Ignore ports where we only have two entries in the array, this signals bad data #1366

* Update functions.php
2017-02-03 19:49:40 +00:00
Neil LathwoodandTony Murray a19b2614dc fix: added some timeout safeguards for curl calls (#5743) 2017-02-03 08:12:42 -06:00
Neil LathwoodandGitHub ba2f88ee72 Possible fix for #5318, if delete_device called in webui then continue to run (#5703)
* Possible fix for #5318, if delete_device called in webui then continue to run

* derp
2017-02-01 20:17:35 +00:00
Neil LathwoodandGitHub 4390347508 fix: Ignore toners with values -2 which is unknown #5637 (#5654) 2017-01-31 08:07:50 +00:00
Tony MurrayandNeil Lathwood f6fc5fdf71 webui: new generic os SVG icon (#5645) 2017-01-28 10:13:55 +00:00
Neil LathwoodandGitHub 86445befde quick tidy up of dnslookup function #5633 (#5639) 2017-01-28 00:02:39 +00:00
Neil LathwoodandGitHub d464916136 fix code (#5586) 2017-01-24 23:36:33 +00:00
Tony MurrayandNeil Lathwood da2c6c5d3c feature: support large vendor logos (#5573)
These are often wider than icons, with a fallback to icons if the logo is not present
Logos are stored in /html/images/logos
SVG is preferred for HiDPI
2017-01-24 22:16:01 +00:00
Tony MurrayandNeil Lathwood ab03af889a fix: hostnames returned by discovery protocols with trailing dot (#5571) 2017-01-24 21:56:51 +00:00
Tony MurrayandNeil Lathwood 20dbda0829 Update os icon the handling. Add title to the os image (#5424) 2017-01-14 22:14:33 +00:00
Neil LathwoodandTony Murray d5296319fb refactor: MySQL strict and query fixes (#5338)
* refactor: MySQL strict and query fixes

* moved sql file
2017-01-13 06:47:16 -06:00
Tony MurrayandNeil Lathwood 78cdca0222 refactor: yaml discovery code (#5408) 2017-01-12 17:01:34 +00:00
Tony MurrayandNeil Lathwood 8156fd547f refactor: move include based discovery after yaml discovery (#5401) 2017-01-11 22:22:16 +00:00
Rob NicholsandNeil Lathwood f98829ba9d fix: Added support for autotls in mail transport #5314 2017-01-10 10:03:47 +00:00
Julian KandTony Murray 5ad8fd3c0c feature: Add support for SVG images (#5275)
* I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.

* feature: Add support for SVG images

* docs: Add instructions for adding OS images

* Replace PNG os images by SVG
2017-01-08 13:32:17 -06:00
Neil LathwoodandTony Murray da5783d917 feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY (#5327)
* feature: Add mysql failed query logging + fixed queries that break ONLY_FULL_GROUP_BY

* fix all schema errors and update system
2017-01-07 11:32:38 -06:00
Neil LathwoodandGitHub 61094f0466 fix: Do not use generic icon by default (#5303) 2017-01-04 08:05:32 +00:00
Neil LathwoodandTony Murray cc8e31d1a1 newdevice: Added support for Dasan NOS #5179 + disco change (#5255)
* newdevice: Added support for Dasan NOS #5179

* sysName -> sysDescr - doh

* updated functions

* Updated discovery of OS functions

* added missing test units

* mibs added

* Allow multiple regex statements per sysDescr_regex

* Fix style/code issues

* added docs
2017-01-03 14:04:18 -06:00
Neil LathwoodandGitHub 11345e1c73 changed truee to true! (#5266) 2016-12-30 00:13:12 +00:00
Tony MurrayandNeil Lathwood 9fef312a20 fix: better Cisco hardware formatting (#5184) 2016-12-16 23:04:37 +00:00
Tony MurrayandNeil Lathwood db240cb4eb refactor: Collection and output of db and snmp stats (#5049) 2016-11-23 06:57:19 +00:00
Tony MurrayandNeil Lathwood 9a33464c52 refactor: Centralize includes and initialization (#4991) 2016-11-21 20:12:59 +00:00
jonathon-kandNeil Lathwood 0955d0271e webui: Allow admin users to modify hostnames in web UI #3445 2016-11-13 00:19:22 +00:00
laf 46d2f578e7 added central function and updated 2016-10-18 03:06:03 +00:00