Commit Graph

7973 Commits

Author SHA1 Message Date
Tony Murray
e6be5f777b Use modern device attrib handling (#15429)
* Use modern attrib handling
Remove device attribs array.

fixes #15422

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 18:29:47 -05:00
Tony Murray
a8b69c1393 Fix discovery protocols again (#15434)
* Fix discovery protocols again
earlier fix had a typo

fixes #15432

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-11 10:20:12 -05:00
Tony Murray
aa455862e9 Fix bug saving snmpv3 device changes (#15419) 2023-10-08 18:56:48 -05:00
Tony Murray
14d9d66529 Agent: Packages fixes (+pacman) (#15415)
* Agent: Packages fixes
Don't try to save invalid packages, probably due to script failure on device.
Add pacman support

* Apply fixes from StyleCI

* Add version

* cast to number

* Update includes/polling/unix-agent/packages.inc.php

Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Jellyfrog <Jellyfrog@users.noreply.github.com>
2023-10-08 18:37:33 -05:00
Tony Murray
c87c6e8b8e Remove legacy addhost code (#15376)
* Remove legacy addhost code
Update webui addhost
Update device snmp settings page
Update discovery protocols device discovery (no longer force full new device discovery in process)

* remove baseline exceptions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 22:02:45 -05:00
Tony Murray
685d11d4f1 Misc fixes 42 (#15413)
* Misc Fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-07 21:39:16 -05:00
Tony Murray
ac23c133d9 Fix an agent bug if a process ran more than 999 days (#15411)
* Fix an agent bug if a process ran more than 999 days
Increase it to 274 years before that happens ;)
Fix a few other small bugs

* Update schema check file
2023-10-07 20:14:00 -05:00
Tony Murray
e53436b6a3 Calculate downtime from device_outages table (#15397)
* Calculate downtime from device_outages table

* refactor
2023-10-06 20:37:23 -05:00
Tony Murray
6d9178cd42 Fix graph errors (#15407)
Some graphs were generating an error that wasn't being correctly output as an image
2023-10-06 08:22:22 -05:00
Tony Murray
d8c372bbf4 Refactor MAC utilities into a single class (#15379)
* Refactor MAC utils to a new utility class

* Apply fixes from StyleCI

* Inline functions
Add tests
Handle bridgeid format

* Apply fixes from StyleCI

* Dedicated code path for stp bridge parsing, and improve STP output a bit

* Correctly parse dot1dBaseBridgeAddress and don't store int in bool field

* trim any unexpected character from bridge addresses, add extra test data.

* better comment

* barsBridge can handle dot1dBaseBridgeAddress correctly now

* parseBridge, check for properly formatted mac first.

* update test data, empty data = empty mac

* Fix new usage after rebase

* import

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-06 07:34:14 -05:00
Tony Murray
908aef6596 Fix MAC search sql injection (#15402)
unparameterized variable
2023-10-05 23:04:04 -05:00
Tony Murray
7fe2614114 Fix xss in device groups overview (#15399) 2023-10-05 23:03:26 -05:00
Tony Murray
37eb0f1fa6 Hide unchangeable core module (#15395)
Core is an internal module do not show a toggle for it as it cannot be disabled.
2023-10-05 21:00:14 -05:00
Tony Murray
087d588102 Vmware vminfo modernize (#15008)
* Vmware vminfo
Remove legacy file and migrate to OS discovery

* tighter

* ios_stp-vlans working correctly now

* Make vmwVmGuestOS nullable

* Discover os info too

* VM Info module

* Apply fixes from StyleCI

* Fix log severity

* Fix log severity (more)

* VM Info module

* Poll with ESXi too because it is lightweight
add test data

* poller data now too

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 19:49:26 -05:00
Tony Murray
9fca01830c Update Tnmsne table backend (#15384)
remove ridiculous sql injection vulnerability
2023-10-05 10:32:21 +02:00
Tony Murray
be24993cbb Remove snmp functions that are barely used (#15377)
* Remove snmp functions that are barely used
Replace them with SnmpQuery calls

* Apply fixes from StyleCI

* Fix missing namespace

* Import Oid

* No more variables left may be repeated multiple times at the end with snmpsim, remove them all

* update data fixed by SnmpResponse bugfix

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-05 01:29:22 -05:00
Tony Murray
e0444bffcf Deprecate poller.php (#15370)
* Deprecate poller.php

* Apply fixes from StyleCI

* Remove references to poller.php
Leave wrapper...

* fix python style

* update wraper to call lnms device:poll

* Quiet output too

* make pb happy

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 16:32:02 -05:00
rolfbergheim
008efe41cd eNexus: added some groups and corrected some references (#15129)
* Added grouping on the Voltage displays

Added groupings to better show which voltage and current variables that belongs together.

* Update enexus.json

* Update enexus_eltek-smartpack2-syst.json

* Update enexus_enexus.json

* Update enexus_smartpacks.json

* Update enexus_smartpacks2.json

* Update enexus_sp2touch.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-04 16:26:32 -05:00
Daniele Santi
96e5c5ee78 Fix Raisecom devices having not increasing OIDs on snmpwalk (#15365)
* Add useful IF-MIB entries as 'unordered oids'
to Raisecom ROS and ROAP definitions because
they don't have increasing OIDs in snmpwalk

* Bump composer/composer from 2.5.8 to 2.6.4 (#15364)

Bumps [composer/composer](https://github.com/composer/composer) from 2.5.8 to 2.6.4.
- [Release notes](https://github.com/composer/composer/releases)
- [Changelog](https://github.com/composer/composer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/composer/composer/compare/2.5.8...2.6.4)

---
updated-dependencies:
- dependency-name: composer/composer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update aviat-wtm.json (#15368)

* sort services by type and name (#15367)

* Added support for Cambium cnMatrix switches (#15351)

* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs

* Rearrange AD auth settings (#15363)

so it makes more sense, add missing settings

* Specify radius attributes for auth roles (#15374)

* Specify radius attributes for auth roles

* Clarify that any role can be defined

* Fixes check_dns against localhost when a search-domain is configured (#15373)

* Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372)

* Moxa EDS improve discovery (#15375)

Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.

* Remove unused functions (#15371)

* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

* Availability module fixes (#15369)

* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Justin Lentz <monkeybrains7@gmail.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@googlemail.com>
Co-authored-by: Noah Roufus <noaheroufus@gmail.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
Co-authored-by: barryodonovan <barry.odonovan@lightnet.ie>
Co-authored-by: Tim de Boer <tim@tim427.net>
Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 15:24:33 -05:00
Tony Murray
c1258320f8 Availability module fixes (#15369)
* Refactor poller to allow modules to run even if the device is down
Include core in config (but not webui) to avoid silly shenanigans
Inject datastore into polling

* Needed to split datastore interface

* Cleanup some data_udpate() references

* Apply fixes from StyleCI

* Fix legacy poller :D

* Output to the correct stream

* Fix lint issues

* Apply fixes from StyleCI

* Fix discovery not including core and submodule handling

* Use whereRaw

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 10:32:59 -05:00
Tony Murray
4211b1c46f Remove unused functions (#15371)
* Remove unused functions
inline other legacy functions

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-04 10:17:34 -05:00
Tony Murray
3366ecad39 Moxa EDS improve discovery (#15375)
Consolidate walks so less need to be performed.
This should help a lot since each device model has its own MIB.
2023-10-04 10:17:18 -05:00
Tim de Boer
15fd452b8a Added extra ASN-range comments, added Priv eBGP on host details, changed color to light-blue instead of red (#15372) 2023-10-04 10:07:14 -05:00
Tim de Boer
27be56ecf1 Fixes check_dns against localhost when a search-domain is configured (#15373) 2023-10-04 09:15:54 -05:00
Noah Roufus
d472c5cbff Added support for Cambium cnMatrix switches (#15351)
* Added support for Cambium cnMatrix switches

* Fixed styling issues

* Fixed styling issues

* Fixed duplicate, incorrectly labeled LLDP-EXT-DOT3-MIB and LLDP-EXT-DOT1-MIB

* Corrected MIB with the same name but with different OIDs configured: LLDP-EXT-MED/-CAMBIUM/-MIB

* Removed my added duplicate MIBs

* Removed unused MIBs
2023-10-04 01:50:41 -05:00
SourceDoctor
65daa10b1b sort services by type and name (#15367) 2023-10-04 01:40:53 -05:00
Noah Roufus
ca5b75a200 Added support for Cambium cnWave60 gear (#15358) 2023-09-27 18:07:08 -05:00
Tim de Boer
36cc6c3237 Fixing Private eBGP visualization, corrected 16bit ASN private range, added 32bit ASN range (#15357)
* Updated Install-LibreNMS.md

Default PHP version of Debian 11 (following this documentation) is 8.2 currently, instead of 8.1

* Fixed Markdown/Parse mode for Telegram

* Fixing Private eBGP visualization, corrected 16bit ASN private range, added 32bit ASN range

* Removed quotes
2023-09-27 13:48:27 -05:00
Tim de Boer
c1008c44b8 Fix BGP peer IP missing in Routing page (#15352)
* Updated Install-LibreNMS.md

Default PHP version of Debian 11 (following this documentation) is 8.2 currently, instead of 8.1

* Fixed Markdown/Parse mode for Telegram

* Changed peer_iden to peer_addr in routing/bgp.inc.php
2023-09-27 07:14:13 -05:00
Tim
2ee837eb90 Fix incorrect pages offset on app ntp page (#15349)
* Update app_ntp.inc.php

Fixes ISSUE 15344
- Corrects start point in table when showing NTP APP
- Corrects blank page when showing ALL NTP entries

* Update app_ntp.inc.php

Use row count for page start not a hard coded 10
2023-09-26 20:47:45 -05:00
Cyril LAVIER
f9ef5fe3fe Add model for Christie Digital projectors (#15088) 2023-09-25 18:39:20 -05:00
PipoCanaja
584768549a Improve "count" graphs for F5OS (#15335)
* fix rrd_type: COUNTER and change index to force new graphs

* tests

* remove number in index
2023-09-25 18:28:40 -05:00
Noah Roufus
57e1d3ff48 Calix AXOS Sensor Changes (#15343)
* Sync'd up MIB changes

* Added new ONT sensors: admin/oper state, rx/tx levels
2023-09-25 15:30:30 -05:00
PipoCanaja
91fed0b118 Refactor discovery-protocols (#15324)
Refactor discovery-protocols

Update zynos.yaml
Update discovery-protocols.inc.php
Allow unordered for LLDP-MIB discovery in Zyxel switches
2023-09-24 15:20:10 -05:00
PipoCanaja
6ba103db68 Device NAC page to Laravel Blade (#15329) 2023-09-24 15:19:25 -05:00
SourceDoctor
5c9f3c80e5 show device group on device overview (#15338)
* show device group on device overview

* .

* better styling on device group display
2023-09-24 11:32:01 -05:00
SourceDoctor
6e592f99c1 Scale disk spezific SMART Graph from 0 (#15339) 2023-09-24 18:12:11 +02:00
SourceDoctor
c0a233700c show never polled information (#15341) 2023-09-24 18:10:11 +02:00
SourceDoctor
88eee297c4 show Temperature Graphs on Smart App Overview (#15342) 2023-09-24 18:09:25 +02:00
James
3e3d15c297 Adding Active Power in Watts to APCs (#15337)
* Adding oid upsAdvOutputActivePower

Adding oid upsAdvOutputActivePower under the power section as this value is in watts.

* Create apc_smx750.json

Adding test JSON data for APC changes

* Create apc_smx750.snmprec

Adding snmpsim test data for APC changes

* Update apc_smx750.json

* Update apc_smx750.snmprec

* Update apc_smx750.json
2023-09-23 16:35:40 -05:00
Wheel
52bc8dc7de Device stulz WIB8000 (#15271)
* Device stulz WIB8000

* Fix multiplier oid is in bar + 1 decimal

* Fixed multiplier

* More stulz sensors
2023-09-20 06:41:31 -05:00
Tony Murray
274a89bcb4 Fix eventlog debug code left in (#15331) 2023-09-18 09:14:52 -05:00
Tony Murray
8fd8d9b06a Fix unescaped output in ipv6 search page (#15327) 2023-09-15 16:05:08 -05:00
MrMoCoDev
7bbe0a22fd FIX TP-Link JetStream 3.0.0 Build 20180511 Rel.36491(s) T1500-28PCT 3.0 (#15318) 2023-09-14 10:33:23 -05:00
Tony Murray
52e264a417 Allow port search API to search ifAlias again (#15320)
Was accidentally omitted when fixing a security issue with the API.
fixes #15316
2023-09-14 08:45:20 -05:00
Tony Murray
2c5960631c Fix injection vulnerability in fdb search page (#15315)
unescaped search output
reported by: https://huntr.dev/users/hainguyen0207
2023-09-14 00:22:42 -05:00
Tony Murray
cfd642be6a Fix injection vulnerability in ports pages (#15314)
* Fix injection vulnerability in ports pages
Unescaped output
reported by: https://huntr.dev/users/hainguyen0207

* fix style
2023-09-14 00:19:12 -05:00
Tony Murray
03c4da62c8 Fix another addcslashes incorrect escape in eventlog (#15313)
and many more
reported by: https://huntr.dev/users/hainguyen0207
2023-09-14 00:07:08 -05:00
Tony Murray
e4c46a4536 Fix another injection in ipv4 search page (#15312)
Reported by: https://huntr.dev/users/trunggg02
2023-09-13 23:48:24 -05:00
Tony Murray
1194934d31 Fix injection in search pages ipv4, etc (#15311)
Reported by: https://huntr.dev/users/hainguyen0207
2023-09-13 23:35:49 -05:00