Commit Graph

5196 Commits

Author SHA1 Message Date
Tony Murray 1e7ed0784e fix: ServerTech discovery (#7668)
This should be using sysObjectID
snmprec updated from stats and ticket.

fixes: #7654
2017-11-07 20:25:24 +00:00
Tony Murray cbe6cb532d Fix: Discovery validation with ping-only devices (#7665)
* fix: validation check cli php extensions
Fix fatal errors when mysql is not loaded / can't connect

* fix: discovery validation incorrectly detects on ping only devices.
2017-11-07 20:09:49 +00:00
barryodonovan 48b564703d newdevice: Added support for Eltek enexus (#7552)
* initial discovery

eltek-enexus discovery and polling

discovery and polling using yaml for subset of features

discovery and polling using yaml for subset of features

removed a few bits

removed some snmp_get() and renamed MIB

 removed header bar mini graph

added snmpget discovery to yaml

renamed os to enexus

undo rebase

* Update enexus.yaml
2017-11-06 17:25:24 +00:00
Tony Murray 3dba5cd39d newdevice: Support Avtech RoomAlert 32E/W and RoomAlert 11E (#7614)
* newdevice: support Avtech RoomAlert 32E/W
Move avtech discovery to yaml, took a bit of trickery

* More flexibility when checking pre-cached data
A little cleanup

* Add support for RoomAlert 32E/W external and wish temp sensors
Add RoomAlert 11E support (just temp sensors)
Updated ROOMALERT32E-MIB
2017-11-04 21:25:13 +00:00
Chris A. Evans 5b42044d04 Fix IronWare mempool device type detection in polling module (#7620) 2017-11-04 21:20:14 +00:00
tomarch 100995294e device: Update hwg-ste and add hwg-ste-plus support (#7610)
* update hwg-ste and add hwg-ste-plus support

* remove humidity graph over
2017-11-04 21:18:02 +00:00
Tony Murray 54b476c769 fix: devices detected as ibmtl or generic (#7618)
* fix: devices detected as ibmtl
Guess at the sysObjectID, please report if you have devices that should be ibmtl and are no longer detected.
Add output of os in discovery.

* Always load all os for discovery.  Should be cached most of the time.
2017-11-03 16:10:24 -05:00
FTBZ aef1a5f28a newdevice: Added state sensors for Palo Alto Networks firewall (#7482)
* Features: Add state sensors for Palo Alto Networks firewall

* Removed the MIBs files

* fix: Removing echo

* Migrate to YAML

* Migrate to YAML

* Change passive to unknow
2017-11-02 21:41:51 +00:00
Tony Murray 4dd56bc72e refactor: Wifi cleanup (#7607)
* refactor: remove duplicated data collection in old wifi module
Still a bit more work before we can fully remove it

* remove unused graphs
update overview graphs for some wireless os
2017-11-02 21:07:58 +00:00
Zmegolaz d9df643927 fix: Use correct sensor ID when removing device. (#7611) 2017-11-02 20:40:51 +00:00
Tony Murray 0d07f85257 feature: Allow snmpget in os discovery yaml (#7587)
* feature: Allow snmpget in os discovery yaml

Re-submit after release

* Remove extra trim in discovery and in snmp_get.
also trim() always returns a string, so is_string() check is a waste of cpu cycles.
2017-11-02 12:41:18 +00:00
Paul Heinrichs 771ff3669c fix: Added runtime divisor to fxm sensor (#7600)
* Add runtime divisor to fxm

* Update mib definition
2017-11-02 12:40:05 +00:00
Tony Murray fb45f00340 fix: ping fails on servers that don't set PATH in cron (#7603)
* fix: ping fails on servers that don't set PATH in cron
Find the full path to fping and persist it in the database.
Adds the ability to persist settings with Config::set()

* Add ability to set webui settings.
No display of for paths, because it would be inconsistent.
2017-11-01 21:56:47 +00:00
Chris A. Evans 47b999cebd device: Change Ironware mempools NetIron checking logic from sysObjectID to sysDescr (#7602)
* Changed the NetIron checking logic from sysObjectID to sysDescr

* updated method of checking sysDescr in ironware mempool files

* Update ironware-dyn.inc.php
2017-11-01 21:41:15 +00:00
Martin Zatloukal 1dfcde3060 fix: function snmp_get delete quotes in snmp query (#7467)
* fix: ups-nut delete quotes in snmp query

* fix: ups-nut delete quotes in snmp query

* Update snmp.inc.php

* Update snmp.inc.php

* Update snmp.inc.php

* Update snmp.inc.php

* Update snmp.inc.php
2017-10-31 21:50:18 +00:00
Neil Lathwood b2c5d069a7 fix: Updated hpe iPdu to remove power and fix load values (#7596) 2017-10-31 21:08:26 +00:00
Neil Lathwood a71c33fb63 newdevice: Added Temp and Humidity support for ServersCheck devices (#7588) 2017-10-31 20:32:18 +00:00
Neil Lathwood f00e896e93 webui: Added toner support in health metrics list (#7595) 2017-10-31 20:31:56 +00:00
Zmegolaz 297e5ae874 fix: Fail isPingable() if fping fails, take 2 (#7585)
* Fail isPingable() if fping fails, take 2.

* Fixed scrutinizer issues.

* Filter out the values we want instead of multi level array.
2017-10-31 08:31:29 -05:00
Zmegolaz e74b1c3e51 Fix: discovery.php -h all stops working after ping only device (#7593)
* Temporary array per device in discovery.

* Return at the beginning of discover_device() if snmp_disable.
2017-10-31 08:26:25 -05:00
Daniel Preussker 0cf8c2615f fix: Update ifIndex update on polling when ifIndex is not the port association mode (#7574) (#7575) 2017-10-30 19:44:01 +00:00
Alan Gregory 0dfc48d8c1 newdevice: Added additional sensors for logmaster Os
* Disabled rfc1628, to many false positives.

* Added compatible sensors.
2017-10-30 19:38:23 +00:00
Neil Lathwood 3e94077a71 Revert "Update RFC1123 Hostname Check" (#7577)
* Revert "Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)"

This reverts commit 426916dbe4.

* Revert "fix: lldp find_port_id finds not the most correct port (#7564)"

This reverts commit 7e05fff615.

* Revert "fix: Update RFC1123 Hostname Check (#7572)"

This reverts commit ebcfa45a93.
2017-10-29 20:05:59 +00:00
Tony Murray 426916dbe4 Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)
This reverts commits:
193db02475
b73c4e9d6e
a93bb6635d
2017-10-29 14:04:26 -05:00
Tony Murray 7e05fff615 fix: lldp find_port_id finds not the most correct port (#7564)
Order statements to give some results precedence over others.
Union the results but limit 1 so we can stop when we get the first result.
Checking if variables doesn't work very well without the device_id
2017-10-29 13:37:39 -05:00
Parth Laxmikant Kolekar ebcfa45a93 fix: Update RFC1123 Hostname Check (#7572)
* Update RFC1123 Hostname Check

The regex was wrong. It failed to match devices like `cisco-3750x` even though it is a valid hostname. 
I picked this regex from the RFC1123 documentation, and updated it.

* Update CommonFunctionsTest.php

Update tests

* Updated to allow domains ending with a dot
2017-10-29 11:12:32 +01:00
Tony Murray a93bb6635d refactor: Use one snmpget during os discovery (#7566)
Use only one snmpget to fetch sysObjectId and sysDescr
fix multiline data in snmp_get_multi_oid()
add snmp_get_multi_oid() to mock.snmp.inc.php
2017-10-28 11:53:05 +01:00
Zmegolaz f8d7ccfe0d feature: Support for up/down detection of ping only devices.
* Added support for ping only devices.

* Renamed sql-schema/206 to 207.

* Discovery tried to detect the OS when it shouldn't.

* Updated db_schema.yaml

* Added ping icon.

* Don't show unused graphs and tabs when SNMP is disabled.

* Allow the user to specify OS of ping only devices.

* Removing custom OS now changes it to 'ping'.

* Removed unnecessary use of mres().

* UI select box for SNMP enable/disable.

* Hide device_ping_perf if ping is disable on device.

* Fixed SNMP settings update status messages.

* Added functionality to add ping only devices via the web ui.

* Added ping only option to addhost.php

* Added ping only support to snmp-scan.py

* Moved sql 208 to 211

* Fixed scrutinizer issues.

* Fixed broken ossearch.

* Added ping only support to the API.

* Updated API doc.

* Added (optional) to OS and hardware description. Hid Port Settings, Applications, Modules, Storage, Processors, Memory and Components from the edit menu

* Style fix.

* Updated ping icon.

* clean() instead of mres(). More escaping. Better help in snmp-scan.py and addhost.php

* Fixed scrutinizer issue.

* Always try SNMP in snmp-scan.py, new option for it in addhost.php. Slice instead of chunk in ajax_ossuggest.php. Other minor style changes.

* Updated sql modifications to insert the new column in the same place as in db_schema.yaml.
2017-10-27 22:59:25 -05:00
Tony Murray b73c4e9d6e refactor: Allow os discovery deferral (#7561)
Defer some os till last, generic or slow ones. (linux, freebsd, ibmtl)
last file standing is ubnt.inc.php
2017-10-27 21:55:14 +01:00
tomarch db3d9dc4ab newdevice: Added detection for proxmox devices (#7543)
* initial proxmox detection

* minor changes

* fixed detection

* change sysdescr
2017-10-27 21:14:26 +01:00
Tony Murray 8a051aa295 fix: Fix a couple of OS cache invalidation issues (#7567)
* fix: fix a couple of OS cache invalidation issues
Fixes issues where we might be using outdated os definitions.

* use Config and fix style issue

* only pull in settings from config.php (otherwise will possibly contain populated os config)
2017-10-27 21:03:58 +01:00
Neil Lathwood 65b0c8bfe4 newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS (#7447)
* newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS

* Update ciscowap.yaml
2017-10-27 19:45:04 +01:00
Tony Murray 193db02475 feature: Allow snmpget in os discovery yaml (#7558)
* feature: Allow snmpget in os discovery yaml
Convert all remaining os except airos.

Affected OS: asuswrt-merlin, ddnons, dsm, extrahop, huaweiups, ibmtl, pcoweb, pktj, qnap, remoteeye4, sentry3, sentry4, tomato

There should be not change in detection.

* Fix, asuswrt-merlin and tomato with snmpsim.  May not have been an issue with actual devices because of -Oa leading " was a bit odd.

* missed file
2017-10-26 20:48:33 +01:00
barryodonovan e968e37cdc docs: Updated default list of modules in poller and discovery support docs. (#7532)
* updated default list of modules in poller and discovery support docs.

*  changed PollerSupport.md and DiscoverySupport.md to relect config.php as the correct location for local per-os module overrides

* removed 'tnms-nbi' module from docs and from defaults file. Removed 'wifi' from docs.
2017-10-26 11:43:09 +01:00
Aldemir Akpinar f18f5eb3b9 newdevice: Fixed Moxa cpu polling, add support for EDS-G508E and power (#7477)
* Fix Moxa cpu polling problem, also add support for EDS-G508E, and power graphs

* Dynamic discovery support for EDS-G508E-T and IKS-6726A-2GTXSFP-T

* fixes as requested

* Added another snmp_cache_multi_oid and fixed a typo

* Revert back to old file name
2017-10-26 11:41:50 +01:00
Joel Kociolek bc3d1ed47e feature: Improve Freeswitch agent: add ability to get data via snmp and graph more data (#7549)
* Add ability to get Freeswitch application data via snmp

On your Freeswitch server install the script from
https://github.com/librenms/librenms-agent/blob/master/agent-local/freeswitch
into /etc/snmp, make it executable and adjust it to your installation.
Configure your snmpd to use the sript as an extension. For example on Debian
add the following line to your /etc/snmp/snmpd.conf:

extend freeswitch /etc/snmp/freeswitch

Activate the Freeswitch application for your server on your LibreNMS server.
it should now start to receive data from your Freeswitch server via snmp.

* Graph "Calls" and "Channels" of Freeswitch agent

The Freeswitch agent sends Calls and Channels count and they weren't graphed
up to now.  This is especially useful in settings where the Freeswitch
server does not act as a Gateway and thus the agent does not sent
Incoming and Outgoing Call numbers.

* Cleanup commented code and add myself to authors
2017-10-26 11:27:11 +01:00
Tony Murray 51ba934e11 feature: Added web validation (#7474)
* refactor: convert validations to modules to prep for gui integration

* accidentally dropped, schema update

* fix accidental output to webui

* mention discovery-wrapper.py and re-arrange.

* refine some fix statements

* rename the Config validation group to Configuration.

* fix some scrutinizer issues
remove as many local functions from validator.php as possible
move extensions from pre-check
remove duplicate timezone check
looks like there is some db schema differences between mariadb 10.1 and 10.2, investigating

* mariadb version diff take2

* Check schema version first for database.
Remove stop to go back to command line for install docs.
Add helpful link when there is no devices added to /addhost

* fix incorrect validation for empty string defaults

* Fix style

* Add additional file permissions checks

* catch exception and fail for invalid timezone
Change visuals a bit.

* add php version warning

* fix space
2017-10-26 07:56:09 +01:00
Alan Gregory 383557f628 newdevice Disable poller/discovery modules for fibrehome devices 2017-10-25 21:21:06 +01:00
Tony Murray 6367c81977 device: Always allow empty ifDescr on fortigate (#7547)
fixes: #3859
2017-10-25 20:57:18 +01:00
Chris A. Evans a6ad9b86be newdevice: Added Mitel Standard Linux OS detection (#7513)
* Added Mitel Standard Linux OS Support

* removed duplicate svg, added snmprec test file, un-enable vmware discovery module

* msl os definition/polling improvements, mitel mib_dir creation
2017-10-25 16:38:53 +01:00
Neil Lathwood e751206f74 newdevice: Added more detection for IgniteNet FusionSwitch (#7384)
* newdevice: Added more detection for IgniteNet FusionSwitch

* fixed current graphs descr

* small updates

* small updates recommended by murrant
2017-10-25 08:10:02 -05:00
Søren Rosiak 6701fad686 fix: Fix some YAML formatting (#7544) 2017-10-25 13:22:06 +01:00
barryodonovan fea6351088 newdevice: Removed unused poller and discovery modules for ceraos devices
* added poller modules to ceraos.yaml

* added disabled discovery modules to ceraos.yaml

* removed default disabled modules from ceraos.yaml
2017-10-24 22:37:35 +01:00
TomEvin 2e54108197 newdevice: Moved Riverbed temp/state into yaml (#7535)
Riverbed Temperature and State discovery move to Yaml and fixed State display
2017-10-24 22:22:12 +01:00
Alan Gregory 50413ff9ae newdevice: Added support for logmaster(ups vendors) devices (#7524)
* added logmaster icon

* added LogMaster Ups Mibs

* Added battery temperature

* Added LogMaster Os discovery

* Added PPC UPS top level mib

* Added more sensors

* Added test for Os

* Added log image

* Disable unused modules to improve polling

* Changed discovery to match all second level.

* Fix logo size to 32x32

* Remove duplicated mib.

* Removed .mib extension

* Fix mib name.

* Added rfc1628 compatibility.

* Removed duplicated sensors due to rfc support

* Added sensor that differs from rfc 1628.
2017-10-24 14:37:36 +01:00
Tony Murray f01cf38a3a fix: lldp discovery change local port resolution (#7443)
* fix: lldp discovery change local port resolution
dot1dBasePortIfIndex seems to skip some ports in certain configurations on Cisco devices.
Add quirk for Calix devices that return different port labels than they actually are.

* bdcom uses NMS-LLDP-MIB too.

* use dot1dBasePort to look up ifIndex if we can.
2017-10-24 08:21:32 +01:00
tomarch 42b1fc48de fix: Don't discard storage_cache array (#7531)
This array has already been init in the mempools polling.
Be deleting this init, we use the $storage_cache array  populated by mempools polling, so we bypass a new snmp call.
This not just a optimisation, this also resolve issue with some WINDOWS (it timeout the second time we call hrstorage in a few second) like in #4929
2017-10-23 20:30:03 -05:00
Neil Lathwood a4388e6010 fix: Fixed ospf polling not removing stale data (#7503)
* fix: Fixed ospf polling not removing stale data

* Fixed arrays

* Fix port_id check for neighbors
2017-10-23 06:59:25 -05:00
Alan Gregory 0f8966a564 newdevice: Added temperature sensor to datacom switches. (#7522)
* Update most recent Mib

* Added switch emeperature sensor.

* Revert manual limits.
2017-10-21 15:04:28 +01:00
Alan Gregory a99e6526b3 newdevice: Added support for new Fiberhome OLT Models (#7499)
* Added suporte for new medium model 5506-04

* Added tests for AN5516-04B

* Added tests for AN5516-04

* Added sysObjectID test for olts.

* Commit to trigger travis-ci

* Update fiberhome.yaml
2017-10-20 16:50:16 +01:00