* Refactor remove use of pear Net_IPv4 and Net_IPv6
Caution, I added tests to test the functionality of the new functions, but I'm not 100% certain the replaced usages match 100%. Please test.
Left usage in generate-iplist.php because I'm not sure the use of that script, so I didn't want to implement additional functionality to support it.
Add support for ipv6 fo ipInNetwork() function
Add phpdocs to functions
Remove accidental inclusion
Use binary operations instead of string for networKFromIp()
Tidy up binary operations in ipInNetwork()
tidy parsing cidr network
Change to a class based implementation.
Update phpdocs.
Fully catch exceptions for hex parsing.
Fix mistake.
support older phpunit versions
Fix php shifting to negative with php 5
* Fix graph authorization. Uncaught exception and checking an ipv4 against an ipv6 network == fail.
* Also remove colons from hex strings.
* Fix typo in bgp polling
Two passes of removing invalid characters from hex strings. (That way we don't mangle valid IPs)
* webui: facelift for alert templates, also converted the custom code to bootgrid
* Update alert_template.inc.php
removed var = action line, no longer needed.
* Fix bug get_graph_by_port_hostname() only hostname
From the documentation:
Function: get_graph_by_port_hostname top
Get a graph of a port for a particular device.
hostname can be either the device hostname or id
But the function is only works with a hostname and not with a ID.
I have modified a few things that solve the problem.
* Update api_functions.inc.php
Fix missing IPs because the ARP entries are on different port_id
Update arp discovery to use snmpwalk_group() additional fix in that function
Fix removal of arp entries
Fix a debug output type in fdb discovery
always check that the base sql has been imported.
async db building
After this merge, we could move install.php to the end of the install documentation. Makes a more natural flow.
* feature: support fdb table on generic devices
refactored code to use snmpwalk_group
refactored ajax table code to use joins and reduce extra queries
add indexes for device_id and port_id, drop primary index
Make all columns sortable
Fix a few other small issues
* Add index for vlan_id since that field can be searched by the user
* fix whitespace
* Rename 197.sql to 198.sql
* set row count for table
* Fixed an issue with the output including all services from a host that had a single matched service regardless of whether they matched the filter.
* Cleaned up some bits
* Updated based on murrants suggestions
* A couple small cleanups
* Enable secure cookies for authentication
Enables secure cookies for authentication when HTTPS is used.
* Add line with example secure session cookies
* Fix comment line that's too long
* Remove session secure cookie config
* Added secure cookie config to init.php
Commented out because having this enabled will prevent the server from sending cookies over HTTPS.
* Enable secure cookies if config value provided
* Make code formatting consistent
* Remove secure cookie config
* Use $config['secure_cookies'] to set cookies
* Add default option to turn secure cookies on
* Fix formatting issues
* Set secure cookies to default to false
* Add info about secure cookies
* Fix formatting
* Remove trailing whitespace
* move secure cookie default config to defaults.inc.php
* Remove trailing whitespace
* Fix formatting
* Remove empty line by rrd config
* Remove whitespace
* feature: FDB TABLES for ios and timos
* Fixed coding style issues
* renamed fdb.sql to 191.sql
* fixed travisCI issue
* FDB table discovery working on IOS
* Fixed bug: failing to insert fdb entries into database
* Fix phpcbf issue
* moved sql schema
* rename sql schema
* Add (tentative) FDB support for HP Comware switches
* build schema
* schema changes
* run build schema.......
* FBD Table discovery working on HP ComWare
* FBD Table discovery working on HP ComWare
* Add FDB support for HP Comware
* Discovery regex fix, tested and works for cisco 3750, 2960, 6509
* Use vlan_id instead of raw vlan. Remove Nokia implementation as vlans are not being discovered for it at the moment.
* Use vlan_id instead of vlan.
* Add debug messages, comware support
* Sorry.. phpunit isnt working for me
* Use a file structure instead of if statement per OS
* Make inserts to vlan table if entry does not exist.
* Rename sql schema file
* Use existing context name
Improve output and database synchronization
Remove chromephp and if ios
rename sqlfile
add comware back
update schema
* Delete TIMETRA-CHASSIS-MIB
* Delete TIMETRA-FILTER-MIB
* change index to bigint to be safe
Graphs that were using `file_exists()` to check for the presence of RRD
files now use `rrdtool_check_rrd_exists()` instead. This is a fix for
distributed poller configurations that are running `rrdcached` on a
different host.
* fix: Fixed http-auth not honouring http_auth_guest
* Always fall back to http_auth_guest.
Make sure $username is set, otherwise, we won't try to authenticate.
* reverted elseif to default to http-auth-guest
* Update authenticate.inc.php
simplify logic
* fix: Two-Factor Auth
Moved library to a class to take advantage of namespacing and auto loading.
Update the two factor code to use the AuthenticationException for error messages.
Fix remember me to work with 2fa.
* missing change
* fix: minimize session open time
page/graphs speedup part 2
Write close the session as soon as we no longer need to write to it. Prevents the session from blocking other requests.
Do not run through full authentication functions if the session is already authenticated.
Removes password from the session as well as some items to prevent session fixation from #4608.
WARNING: This will cause issues for ad/ldap users who do not have a bind user configured!
* Do no erase username when using cookie auth.
Properly close the session in ajax_setresolution.php
* write close the session as soon as possible in ajax_setresolution.php
* Remove session regeneration. It is not compatible with the current code and would require more changes.
* Totally refactor authentication. Extract code to functions for re-use and improved readability
* Use exceptions for authentication and error logging
Tested: mysql, ad_auth with and without bind user
* fix a couple scrutinizer issues
* fix reauthenticate in radius
* feature: Added script (scripts/test-template.php) to test alert templates
* moved remaining functions, fixed php 5.3 and include dir
* added docs on use for test-template script
* refactor: move default alert rules into the collection
Also adds the wireless rules to the default set.
* Added additional defaults to extra
* Fix up the extra value
Also, missed `rule` column when creating default rules
* newdevice: Add connected AP count for Cisco WLCs
Adds ap-count wireless sensor type
fixes: #4295
* better detection
Update the overview graph to the new one
fixes: #5264
The issue was all the string concatenation...
But I decided to try loading the select via ajax. Seems ok. We could just use something like select2. Opinions? Use this approach or load at page load.
I was able to reduce the loading of the 4000 select items from 1.6s to 0.6s on my laptop by optimizing the sql.
I added 4000 devices to my database to check this :)
* Increased speed of loading syslog pages.
I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md.
* moved schema 186->189
