99 Commits

Author SHA1 Message Date
Tony Murray
f2f169ae78 Modernize mempools (#12282)
* mempools to modern module
quick hacky hrstorage port

* port ucd-snmp-mib to Mempools

* Populate DB for ucd
Prep for yaml

* initial yaml attempt

* more complex conversions
fixes to YamlDiscovery, make leading $ optional and allow mib::oid format

* walk full tables and skip values
normalize percentages above 100

* handle precent only ones (specify total as 100)

* Move default polling out of YamlMempoolsDiscovery

* fixes

* Update test data hrstorage should be correct.

* perc_warn for hrstorage

* Host Resources, record buffer, cached, and shared

* Host Resources is always better, don't do both HR and UCD

* fix unix, include warning levels

* variable size

* consolidate skip_values

* define mempools schema

* number instead of integer

* more schema refactor

* one more skip_values reference

* throw error for invalid oid translation
aos6

* a*  and Cisco

* updated test data

* update almost all hrstorage data files

* b*

* c* with test data
use standard cache for hrStorage

* use cache for storage module too

* hand bsnmp properly

* bdcom

* exclude total oid from yaml so it is not polled
May add a way to ignore this behavior and poll it, but I don't know if that is needed.

* automatically handle percent only values

* ciscowlc

* only poll used or free if we have used, free, and total.

* fix skipping

* the dlinkoning
fix find value when value "name" is numeric

* support numeric oids

* dnos/ftos attempt

* I guess we can't filter on total > 0

* edgecos

* e*

* f WIP

* f*

* gwd (aka g*)

* h* + procurve

* i*

* j*

* m*

* support 0% used memory (however unlikely)

* n*

* CISCO-PROCESS-MIB memory, share cache with processors module

* ignore mempools with invalid total

* p*

* quanta

* r*
fix raisecom mibs terribly broken

* s-z

* style fixes

* Move VRP back to PHP and make it actually work

* fix zynos

* update schema

* Update Cisco processor data for description bug fixes

* fix comware processors

* comware mempools with memory size
default precision to 1

* sophos-xg updated data

* hrstorage use ram size for buffers, cache, and shared

* Show memory available instead of free in device overview

* UCD, use same rrd format, store available instead of free in the db.

* Calculate availability for HOST-RESOURCES-MIB

* Convert UCD to standard polling

* rename old rrd files

* initial graph work

* graph WIP

* Graph looking decent

* Graph looking decent for hr

* remove old ucd_graph code

* handle availability mempool
more graph cleanup

* color adjustments

* remove accidental free calculation

* Update test data and fix corner cases

* fis pfsense

* update schema

* add default value for mempool_class

* fix whitespace

* update schema

* update schema correctly

* one more time

* fortigate_1500d-sensors missing oids

* Update docs.

* fix indent

* add implements MempoolsDiscovery explicitly to OS

* remove ucd_memory graph references
remove unused device_memory graph

* remove unused functions

* set devices with mempools to rediscover to prevent/minimize gaps

* use a subquery

* add overview graph

* port health mempools table

* Update device mempool

* only show overview if multiple

* Don't override user set warn percentages in discovery

* fix missed usage

* fix style

* Safety check to not rename rrd files incorrectly if migration has not been run.

* Fix overview percent bar and represent available and used on the bar

* missed an item to convert to mempool_class

* percent on the wrong side
2020-11-23 15:35:35 -06:00
Jellyfrog
1220d583e9 Apply fixes from StyleCI (#12336) 2020-11-21 22:52:58 -06:00
PipoCanaja
9797be3677 Update DSL stats even if port is down (#12262)
* Update DSL stats even if port is down

* Correct swapped Upload/download on graphs

* Display attainable line speed in the ADSL page

* Correct SNR graph

* Rewrite labels to avoid misunderstanding

* last swap I hope
2020-10-29 02:08:29 +01:00
Hayden
397a10e73f new sensors for siteboss OS + new sensor type: percentage (%) (#11958)
* split siteboss 530 and 550 into multiple OS

* add more sensors to siteboss550 and new Percent sensor

* fix contact closure event state values

* split os polling for siteboss to siteboss530 and siteboss550

* add test unit for siteboss550, rename test unit for siteboss to siteboss530

* refactor siteboss os polling to \Librenms\OS

* implement OSPolling to Sitebos550

* force save in pollOS() to keep custom sysName during polling

* updated unit test

* update device graphs

* remove pollOS and extra save()

* siteboss550 no longer extends OSPolling

* update siteboss550 test data

* update discoverOS() to match recent os discovery changes

* styleCI changes

* fix siteboss hardware discovery; add check to OS polling if os_group .inc file exists

* collapse siteboss to single OS, implement siteboss sensors in advanced discovery

* add siteboss unit tests

* removed unneeded OS disco defs

* styleCI changes

* more styleCI changes

* split siteboss os to siteboss530 and siteboss550

* split siteboss os to siteboss530 and siteboss550

* move php polling back into yaml

* keep original siteboss OS name

* resave snmp data for siteboss OS

* resave snmp data for siteboss550 OS
2020-10-20 19:11:12 -05:00
Tony Murray
2793585cce Fix SQL injection vulnerability in MAC Accounting graph (#12204)
* Fix SQL injection vulnerability in MAC Accounting graph
I didn't have any real test data, so tried to keep the changes minimal.

* fix style
2020-10-11 01:17:25 +02:00
Jellyfrog
bef67751a3 Add PHP CS Fixer (#12128)
* Add PHP CS Fixer

Based on https://gist.github.com/laravel-shift/cab527923ed2a109dda047b97d53c200

* Apply PHP CS
2020-09-21 19:52:01 -05:00
Jellyfrog
29f45ca352 Apply fixes from StyleCI (#12124) 2020-09-21 15:59:34 +02:00
Jellyfrog
0d56bbd946 Apply fixes from StyleCI (#12123) 2020-09-21 15:51:53 +02:00
Jellyfrog
82f43cb98d Apply fixes from StyleCI (#12120) 2020-09-21 15:40:17 +02:00
Avinash Kumar
78fa539628 Icecast, Opensips and Voip monitor Application (#12070)
* Icecast added

* Opensips added

* Voip Monitor added

* Icecast documentation

Icecast corrections

* Opensips documentation added

Opensips corrections

* Voip monitor documentation added

Voip monitor corrections

* Icecast corrections

* Opensips corrections

* Voip monitor corrections

* test data added for icecast

* test data added for opensips
2020-09-18 16:49:20 +02:00
Tony Murray
941037e44e Convert OS discovery to new style (#12099)
* terra

* airos

* port cisco os polling
old wwan polling was broken and deprecated anyway

* enterasys

* Brother, a few changes

* AW Plus

* Fabos

* set expected test data

* 3com

* Adva FSP150

* advantech

* airos-af

* aix

* akcp

* allied

* allworx and missed mibs

* anyos

* fixup some zyxel shared stuffs
zywall graph polling

* aos

* apc

* apex

* apsoluteos

* fix copyrights

* arris

* arris

* aruba-instant

* ArubaOS

* Ascom

* asuswrt-merlin, ats

* audiocodes

* avocent

* avtech

* barracuda

* binox

* boss

* canonprinter

* cdata

* ceraos

* ciena-waveserver

* fix 3com

* fix airos

* fix brother yaml?

* fix aos more

* fix and improve apc

* fix arista test data

* yaml discovery (basic)

* cimc

* mib not used

* remove old discovery file

* ciscosat

* ciscosb fixes + improvements

* comware

* ctm

* cumulus

* cxr-ts

* cyberoam-utm

* cyberpower

* dahua-nvr

* dasan-nos

* datadomain

* dcn-software and fallback oids

* dd-wrt

* dell-laser

* d*

* e* and location

* forti, post processing, oid coalescing

* Freebsd array of sysDescr regex

* finish f*

* g*

* h*

* i* WIP

* i*

* Junos

* j*

* k*

* unix refactor previous to yaml more
inject $device

* fixes

* fixes

* l*

* m*

* n* ability to set other fields in regex
tnmsne polling to eloquent

* o*

* p*

* q* + bonus calix

* r*

* s* WIP

* s*

* t*

* u*

* v*
rework vrp to yaml (hybrid)

* w*

* x*

* z*

* a* easy no-data

* fixes

* style fixes

* missed ApexPlus

* fix signature

* Add missing location data

* rename getDevice functions

* add new cisco ftd data

* update docs

* revert sill snmp format

* fix snmp options

* update for new smartax test data

* rebase dsm

* fix voss
2020-09-18 15:12:07 +02:00
pobradovic08
736169d4e1 WebUI: Fixed URL of detailed graphs for jitter SLA probe (#11984)
* Fix single SLA page

* Update slas.inc.php

blank lines at the start and end of control structure
2020-09-18 00:58:20 -05:00
SourceDoctor
06889c4a0f Set RRD minimum to 0 to see the real change relation (#11986) 2020-08-01 06:22:08 +02:00
Nick Peelman
57362c1ff5 Refresh device_bits graph; align column headers, use wider descriptio… (#11922)
* Refresh device_bits graph; align column headers, use wider description on wider graphs

* Fix a couple of code climate issues...

* use float_precision variable like we do everywhere else...

* remove unnecessary substr
2020-07-23 23:14:36 -05:00
Tony Murray
020c5fd7e1 Remove legacy code and fix missing device graphs (#11950)
* removing $graphs global

* remove unused things

* fix some additional graphs

* Fix graphs persisting too soon

* correct name for poller module performance graph

* only one type of graph is used here
2020-07-23 09:57:22 -05:00
seros1521
389b271073 CBQoS improvement (#11926)
* Deduplicate CBQoS code

* Additional CBQoS metrics
2020-07-18 00:36:27 +02:00
Nick Peelman
8af976a951 Mult graphs bits spacing (#11907)
* Make Multiport-Bits-Separated graph Description field wider for larger and medium graphs

* Fix Aggregate Graph In/Out Alignment; make Consistent with Interface I/O Alignment

* Remove misplaced slashes

* Align headers...

* Fix Total units

* Fix code climate gripe
2020-07-10 10:45:01 +02:00
Jellyfrog
a3ae3805d1 Sanitize graph title input (#11919) 2020-07-09 12:48:36 -05:00
Andreas
98d6fc1ace Fix graphing with generic_v3_multiline_float (#11916)
#11853 introduced a bug which broke graphing (e.g. for the pi-hole app)
2020-07-09 08:29:56 -05:00
SourceDoctor
ed70b2636a RRD Float Precision Customization (#11853) 2020-06-25 21:51:55 +02:00
SourceDoctor
f2ed5452b3 Revert "RRD Graph Float Precision adjustment (#11812)" (#11850)
This reverts commit fd5c2bcaeb73a4e67582cbf9110dee897ef4c1c6.
2020-06-23 13:08:06 +02:00
SourceDoctor
fd5c2bcaeb RRD Graph Float Precision adjustment (#11812) 2020-06-23 12:13:36 +02:00
SourceDoctor
4e6a7291a2 Device Availability Calculation (#11784)
* Device Availability Calculation

* Travis fix

* .

* schema corrections

* flexible duration

* travis

* .

* .

* .

* .

* remove not needed code

* line Text to RRD

* update humantime

* .

* only set up again if device was marked as down

* set RRD area transparency

* save uptime also, to keep last availability as good as possible

* file description correction

* look for outages even if uptime > duration
2020-06-22 22:57:30 +02:00
Tony Murray
9372074b6d Merge pull request #11728 from yac01/master
Feature: F5 LTM bandwidth controller
2020-06-19 13:39:36 -05:00
SourceDoctor
8e60f8f56f Application Puppet Agent RRD Runtime Graph fix (#11837) 2020-06-18 18:15:52 +02:00
SourceDoctor
62f850aef9 Cleanup functions.inc.php (#11835) 2020-06-17 14:00:18 +02:00
Tony Murray
867aa132c1 Merge pull request #11661 from SourceDoctor/app_dhcp_enhancement
Application DHCP Upgrade
2020-06-16 17:03:45 -05:00
SourceDoctor
e911eef0c8 remove unecessary function 2020-06-16 21:13:56 +02:00
Anael Mobilia
22916afb9e Apps - backupninja (#11010)
* GUI - graphs

* GUI - Apps

* Polling

* GUI - apps

* Add backupninja to documentation

* Apps - backupninja : add link to librenmsagent script

* Add backupninja snmprec file

* Delete backupninja.snmprec

No Regression tests on apps (yet), only on devices.

* Remove old debug

* Update language : FR -> EN

* Add debug informations

* File path moved to /etc/snmp/

* Python script now use json

* Update following example on puppet script

* Update installation instructions following puppet example

* Update apps.inc.php

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: SourceDoctor <sourcehhdoctor@gmail.com>
2020-06-16 01:04:30 +02:00
arrmo
ba1302805f Change Units on Noise Floor (#11790)
* Change Units on Noise Floor

I may be wrong, but I think this should just be dBm (i.e. integrated over the carrier bandwidth). The numbers look much too high to me to be on a per Hz basis.

If I am correct here, this should also be updated in the web interface.

Thanks!

* Update php, correct units for Wireless noise-floor

* Wireless Frequency, don't format_si, to avoid kMHz units

* Update Wireless noise-floor units, in RRD plots
2020-06-10 10:41:36 +02:00
SourceDoctor
1093315700 Merge branch 'master' into app_dhcp_enhancement 2020-06-08 20:51:41 +02:00
SourceDoctor
9836aab818 Show full description text on Asterisk RRDs (#11742) 2020-06-04 23:14:15 -05:00
PelliX
5f3b82de6f Added discovery and graphing for JunOS (SRX) RPM probes (#11187)
* Added discovery and graphing for JunOS (SRX) RPM probes

* Proposed changes for a percent based sensor type

* Fixed missing MIB declaration in JunOS YAML discovery file

* Updated Health-information.md to reflect the new percentage value type

* Added separate test data for junos_rpm type

* Update sensors.php

* Update sensors.php

* Update functions.inc.php

* test re-run

* Update junos_rpm.json

* percentage -> loss

* add ifSpeed prev test data

* mis-merge

* update sensors

* and bgp...

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
Co-authored-by: Tony Murray <murraytony@gmail.com>
2020-05-30 18:24:43 -05:00
SourceDoctor
6b7b143cbb Show full description text on MySQL RRDs (#11738)
* Show full description text on MySQL Connections

* further adjustments
2020-05-30 11:46:58 -05:00
Yacine BENAMSILI
1a152edc67 feature: F5 LTM bandwidth controller 2020-05-29 03:00:42 +02:00
Yacine BENAMSILI
fa52264de2 Fix: F5 LTM bandwidth controller 2020-05-28 23:15:35 +02:00
SourceDoctor
cbe572f959 Application DHCP Upgrade 2020-05-22 23:02:19 +02:00
Facundo Caselles
2f86c66afa WebUI - Improved "dark" theme (#11417)
* -Real dark mode, (themed bootstrap)
-removed inverted colors in navbar

* Test data

* FIX: navbar in mono theme.

* Dark mode rrdtool

* Changed background on gridster to match background of the dark theme

* - Icons and links now are grey
- Modernized tabs style into pills,
- button pagemenu-selected fixed

* Improvements:
- bootgrid-th, are now visible (dark mode to the table headings)
- Changed line color of poller and ping in rrdtool

* Fix some codeclimate errors

* Fix airos.snmprec, reverted to original file
2020-05-21 19:04:54 -05:00
Tony Murray
d5a52ca4eb Fix various issues with loading os definitions (#11640)
* Ping only device doesn't display
if os was set to something, ping os wasn't loaded and we try to get overview graphs from it.

* Fix snmp_disable device page load error
When other os is set.

* Revamp os setting loading
the only safe way to access is Config::getOsSetting()

* Remove getOsSetting fallback behavior
Most instances don't use it and it can have unexpected results Config::getOsSetting('blah', 'group') == 'librenms'

* refactor and remove unneeded load_os/loadOs calls now since getOsSetting automatically loads it.

* restore unix overview graphs, they are different
small cleanups

* fix
2020-05-19 14:35:32 -05:00
SourceDoctor
4edff1e88a Application - Redis (#11612)
* Application - Redis

* Travis fix
2020-05-15 22:05:40 +02:00
SourceDoctor
d941fbe91b Adjust RRDCached Event Graph Adjustment (#11528) 2020-05-01 21:46:58 -05:00
Johan "Zwixxel" Zaxmy
7bfc2f9f57 Fixes evaluation order so unathenticated access works (#11485) 2020-04-26 12:45:31 +02:00
Tony Murray
52e1187314 Fix two more jpgraph (#11448)
* missed one jpgraph string

* missed one jpgraph string
2020-04-20 15:32:11 -05:00
Tony Murray
22dd4333d0 missed one jpgraph string (#11447) 2020-04-20 15:25:36 -05:00
Tony Murray
e2eea17ee8 Work around jpgraph bug (#11425)
apparently GD now returns false when getting the bounding box of empty strings, this causes jpgraph to throw an incorrect error.  Work around that by setting all possible text to a single space character.
2020-04-16 09:18:44 -05:00
Tony Murray
217969e140 Update php-codesniffer (#11368)
* PHPCS 3.5+

* Fix newly detected style issues
2020-04-03 08:41:24 -05:00
Tony Murray
a59ab553be Don't show deleted ports in device overview (#11344) 2020-03-25 15:10:14 +01:00
fusedsynapse
68f957e0bc Fix invalid paths introduced in librenms/librenms#9883 (#11337) 2020-03-24 12:48:18 +01:00
Tony Murray
6c4d53d5e5 Fix previous with rrdgraph_real_percentile (#11306)
start and end only work with DEF (and are already devined for inoctetsX and outoctetsX.
2020-03-19 20:12:29 -05:00
Tony Murray
22e8b16530 Fix show rrdtool command (#11305) 2020-03-19 10:12:00 -05:00