Commit Graph

5174 Commits

Author SHA1 Message Date
Neil Lathwood
3e94077a71 Revert "Update RFC1123 Hostname Check" (#7577)
* Revert "Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)"

This reverts commit 426916dbe4.

* Revert "fix: lldp find_port_id finds not the most correct port (#7564)"

This reverts commit 7e05fff615.

* Revert "fix: Update RFC1123 Hostname Check (#7572)"

This reverts commit ebcfa45a93.
2017-10-29 20:05:59 +00:00
Tony Murray
426916dbe4 Revert "feature: Allow snmpget in os discovery yaml (#7558)" (#7576)
This reverts commits:
193db02475
b73c4e9d6e
a93bb6635d
2017-10-29 14:04:26 -05:00
Tony Murray
7e05fff615 fix: lldp find_port_id finds not the most correct port (#7564)
Order statements to give some results precedence over others.
Union the results but limit 1 so we can stop when we get the first result.
Checking if variables doesn't work very well without the device_id
2017-10-29 13:37:39 -05:00
Parth Laxmikant Kolekar
ebcfa45a93 fix: Update RFC1123 Hostname Check (#7572)
* Update RFC1123 Hostname Check

The regex was wrong. It failed to match devices like `cisco-3750x` even though it is a valid hostname. 
I picked this regex from the RFC1123 documentation, and updated it.

* Update CommonFunctionsTest.php

Update tests

* Updated to allow domains ending with a dot
2017-10-29 11:12:32 +01:00
Tony Murray
a93bb6635d refactor: Use one snmpget during os discovery (#7566)
Use only one snmpget to fetch sysObjectId and sysDescr
fix multiline data in snmp_get_multi_oid()
add snmp_get_multi_oid() to mock.snmp.inc.php
2017-10-28 11:53:05 +01:00
Zmegolaz
f8d7ccfe0d feature: Support for up/down detection of ping only devices.
* Added support for ping only devices.

* Renamed sql-schema/206 to 207.

* Discovery tried to detect the OS when it shouldn't.

* Updated db_schema.yaml

* Added ping icon.

* Don't show unused graphs and tabs when SNMP is disabled.

* Allow the user to specify OS of ping only devices.

* Removing custom OS now changes it to 'ping'.

* Removed unnecessary use of mres().

* UI select box for SNMP enable/disable.

* Hide device_ping_perf if ping is disable on device.

* Fixed SNMP settings update status messages.

* Added functionality to add ping only devices via the web ui.

* Added ping only option to addhost.php

* Added ping only support to snmp-scan.py

* Moved sql 208 to 211

* Fixed scrutinizer issues.

* Fixed broken ossearch.

* Added ping only support to the API.

* Updated API doc.

* Added (optional) to OS and hardware description. Hid Port Settings, Applications, Modules, Storage, Processors, Memory and Components from the edit menu

* Style fix.

* Updated ping icon.

* clean() instead of mres(). More escaping. Better help in snmp-scan.py and addhost.php

* Fixed scrutinizer issue.

* Always try SNMP in snmp-scan.py, new option for it in addhost.php. Slice instead of chunk in ajax_ossuggest.php. Other minor style changes.

* Updated sql modifications to insert the new column in the same place as in db_schema.yaml.
2017-10-27 22:59:25 -05:00
Tony Murray
b73c4e9d6e refactor: Allow os discovery deferral (#7561)
Defer some os till last, generic or slow ones. (linux, freebsd, ibmtl)
last file standing is ubnt.inc.php
2017-10-27 21:55:14 +01:00
tomarch
db3d9dc4ab newdevice: Added detection for proxmox devices (#7543)
* initial proxmox detection

* minor changes

* fixed detection

* change sysdescr
2017-10-27 21:14:26 +01:00
Tony Murray
8a051aa295 fix: Fix a couple of OS cache invalidation issues (#7567)
* fix: fix a couple of OS cache invalidation issues
Fixes issues where we might be using outdated os definitions.

* use Config and fix style issue

* only pull in settings from config.php (otherwise will possibly contain populated os config)
2017-10-27 21:03:58 +01:00
Neil Lathwood
65b0c8bfe4 newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS (#7447)
* newdevice: Updated Cisco WAP detection and merged in ciscosmblinux OS

* Update ciscowap.yaml
2017-10-27 19:45:04 +01:00
Tony Murray
193db02475 feature: Allow snmpget in os discovery yaml (#7558)
* feature: Allow snmpget in os discovery yaml
Convert all remaining os except airos.

Affected OS: asuswrt-merlin, ddnons, dsm, extrahop, huaweiups, ibmtl, pcoweb, pktj, qnap, remoteeye4, sentry3, sentry4, tomato

There should be not change in detection.

* Fix, asuswrt-merlin and tomato with snmpsim.  May not have been an issue with actual devices because of -Oa leading " was a bit odd.

* missed file
2017-10-26 20:48:33 +01:00
barryodonovan
e968e37cdc docs: Updated default list of modules in poller and discovery support docs. (#7532)
* updated default list of modules in poller and discovery support docs.

*  changed PollerSupport.md and DiscoverySupport.md to relect config.php as the correct location for local per-os module overrides

* removed 'tnms-nbi' module from docs and from defaults file. Removed 'wifi' from docs.
2017-10-26 11:43:09 +01:00
Aldemir Akpinar
f18f5eb3b9 newdevice: Fixed Moxa cpu polling, add support for EDS-G508E and power (#7477)
* Fix Moxa cpu polling problem, also add support for EDS-G508E, and power graphs

* Dynamic discovery support for EDS-G508E-T and IKS-6726A-2GTXSFP-T

* fixes as requested

* Added another snmp_cache_multi_oid and fixed a typo

* Revert back to old file name
2017-10-26 11:41:50 +01:00
Joel Kociolek
bc3d1ed47e feature: Improve Freeswitch agent: add ability to get data via snmp and graph more data (#7549)
* Add ability to get Freeswitch application data via snmp

On your Freeswitch server install the script from
https://github.com/librenms/librenms-agent/blob/master/agent-local/freeswitch
into /etc/snmp, make it executable and adjust it to your installation.
Configure your snmpd to use the sript as an extension. For example on Debian
add the following line to your /etc/snmp/snmpd.conf:

extend freeswitch /etc/snmp/freeswitch

Activate the Freeswitch application for your server on your LibreNMS server.
it should now start to receive data from your Freeswitch server via snmp.

* Graph "Calls" and "Channels" of Freeswitch agent

The Freeswitch agent sends Calls and Channels count and they weren't graphed
up to now.  This is especially useful in settings where the Freeswitch
server does not act as a Gateway and thus the agent does not sent
Incoming and Outgoing Call numbers.

* Cleanup commented code and add myself to authors
2017-10-26 11:27:11 +01:00
Tony Murray
51ba934e11 feature: Added web validation (#7474)
* refactor: convert validations to modules to prep for gui integration

* accidentally dropped, schema update

* fix accidental output to webui

* mention discovery-wrapper.py and re-arrange.

* refine some fix statements

* rename the Config validation group to Configuration.

* fix some scrutinizer issues
remove as many local functions from validator.php as possible
move extensions from pre-check
remove duplicate timezone check
looks like there is some db schema differences between mariadb 10.1 and 10.2, investigating

* mariadb version diff take2

* Check schema version first for database.
Remove stop to go back to command line for install docs.
Add helpful link when there is no devices added to /addhost

* fix incorrect validation for empty string defaults

* Fix style

* Add additional file permissions checks

* catch exception and fail for invalid timezone
Change visuals a bit.

* add php version warning

* fix space
2017-10-26 07:56:09 +01:00
Alan Gregory
383557f628 newdevice Disable poller/discovery modules for fibrehome devices 2017-10-25 21:21:06 +01:00
Tony Murray
6367c81977 device: Always allow empty ifDescr on fortigate (#7547)
fixes: #3859
2017-10-25 20:57:18 +01:00
Chris A. Evans
a6ad9b86be newdevice: Added Mitel Standard Linux OS detection (#7513)
* Added Mitel Standard Linux OS Support

* removed duplicate svg, added snmprec test file, un-enable vmware discovery module

* msl os definition/polling improvements, mitel mib_dir creation
2017-10-25 16:38:53 +01:00
Neil Lathwood
e751206f74 newdevice: Added more detection for IgniteNet FusionSwitch (#7384)
* newdevice: Added more detection for IgniteNet FusionSwitch

* fixed current graphs descr

* small updates

* small updates recommended by murrant
2017-10-25 08:10:02 -05:00
Søren Rosiak
6701fad686 fix: Fix some YAML formatting (#7544) 2017-10-25 13:22:06 +01:00
barryodonovan
fea6351088 newdevice: Removed unused poller and discovery modules for ceraos devices
* added poller modules to ceraos.yaml

* added disabled discovery modules to ceraos.yaml

* removed default disabled modules from ceraos.yaml
2017-10-24 22:37:35 +01:00
TomEvin
2e54108197 newdevice: Moved Riverbed temp/state into yaml (#7535)
Riverbed Temperature and State discovery move to Yaml and fixed State display
2017-10-24 22:22:12 +01:00
Alan Gregory
50413ff9ae newdevice: Added support for logmaster(ups vendors) devices (#7524)
* added logmaster icon

* added LogMaster Ups Mibs

* Added battery temperature

* Added LogMaster Os discovery

* Added PPC UPS top level mib

* Added more sensors

* Added test for Os

* Added log image

* Disable unused modules to improve polling

* Changed discovery to match all second level.

* Fix logo size to 32x32

* Remove duplicated mib.

* Removed .mib extension

* Fix mib name.

* Added rfc1628 compatibility.

* Removed duplicated sensors due to rfc support

* Added sensor that differs from rfc 1628.
2017-10-24 14:37:36 +01:00
Tony Murray
f01cf38a3a fix: lldp discovery change local port resolution (#7443)
* fix: lldp discovery change local port resolution
dot1dBasePortIfIndex seems to skip some ports in certain configurations on Cisco devices.
Add quirk for Calix devices that return different port labels than they actually are.

* bdcom uses NMS-LLDP-MIB too.

* use dot1dBasePort to look up ifIndex if we can.
2017-10-24 08:21:32 +01:00
tomarch
42b1fc48de fix: Don't discard storage_cache array (#7531)
This array has already been init in the mempools polling.
Be deleting this init, we use the $storage_cache array  populated by mempools polling, so we bypass a new snmp call.
This not just a optimisation, this also resolve issue with some WINDOWS (it timeout the second time we call hrstorage in a few second) like in #4929
2017-10-23 20:30:03 -05:00
Neil Lathwood
a4388e6010 fix: Fixed ospf polling not removing stale data (#7503)
* fix: Fixed ospf polling not removing stale data

* Fixed arrays

* Fix port_id check for neighbors
2017-10-23 06:59:25 -05:00
Alan Gregory
0f8966a564 newdevice: Added temperature sensor to datacom switches. (#7522)
* Update most recent Mib

* Added switch emeperature sensor.

* Revert manual limits.
2017-10-21 15:04:28 +01:00
Alan Gregory
a99e6526b3 newdevice: Added support for new Fiberhome OLT Models (#7499)
* Added suporte for new medium model 5506-04

* Added tests for AN5516-04B

* Added tests for AN5516-04

* Added sysObjectID test for olts.

* Commit to trigger travis-ci

* Update fiberhome.yaml
2017-10-20 16:50:16 +01:00
crcro
2a15da2228 fix: Ignore OEM ipmi sensors that returns unreadable values (#7518)
* fix for OEM ipmi server that doesn't return hreshold

* escape chars, typo
2017-10-20 16:43:27 +01:00
Paul Heinrichs
f2c4563c85 newdevice: Added initial detection for netmodule NB1600 (#7514) 2017-10-20 16:41:32 +01:00
Paul Heinrichs
f038bcb6a1 device: Add more Procera interfaces (#7422)
* Add procera MIBS

* Add Channel ports to procera

* Fix whitespace

* CI Fix

* Remove unnecessary procera mib_dir

* Use snmpwalk_group

* CI fix

* Add more fields and change depth to snmpgroup_walk

* Minor style updates

* Add interface regex to procera.yaml
2017-10-19 08:09:45 -05:00
Tony Murray
186ff42ef8 newdevice: Updated Unifi AC HD detection (#7516)
* fix Unifi AC HD detection
dot11manufacturerName.5 doesn't exist, only .30-.33

* add unit test
2017-10-19 08:07:00 +01:00
FTBZ
23389de928 Readd PA Active Session graph (#7517) 2017-10-19 08:01:44 +01:00
FTBZ
163d0b4f88 fix: Errors in the documentations for CentOS 7 (#7510)
* fix: Erros in the documentations for CentOS 7

* fix: Erros in the documentations for CentOS 7

* fix: Erros in the documentations for CentOS 7

* fix: Erros in the documentations for CentOS 7

* Some corrections to make docs work as intended.

* re-add httpd_execmem for nginx
2017-10-18 14:38:56 -05:00
FTBZ
fc6386bf5f fix: Add missing MIB for Palo Alto Networks firewall (#7509)
* fix: Add missing MIB for Palo Alto Networks firewall

* fix: MIBs directory
2017-10-18 13:34:53 -05:00
Chris A. Evans
04bb65b762 newdevice: Added Brocade IronWare interface dBm sensor support (#7434)
* Added IronWare iface dBm sensor and related OID pr~e-cache

* fixed syntax violations

* added return_num() function and modified ironware dbm sensor to use it

* Update functions.php

* Update ironware.inc.php
2017-10-17 17:36:49 +01:00
tomarch
c643d13cb5 newdevice: Added vpn state and flash usage for zywall usg (#7500) 2017-10-17 17:09:52 +01:00
FTBZ
89ff05ebea newdevice: Added firewall graphs for Palo Alto Networks firewall (#7483)
* Features: Add firewall graphs for Palo Alto Networks firewall

* Features: Add firewall graphs for Palo Alto Networks firewall

* Update db_schema.yaml
2017-10-17 12:42:13 +01:00
Martin Zatloukal
6e379bfbbd newdevice: Added support for Alcoma wireless devices (#7476)
* New os Alcoma

* New os Alcoma

* Update AlcomaAlmp.php
2017-10-17 08:57:31 +01:00
Neil Lathwood
cdf31c47e1 Revert "bug: fail isPingable if fping errors" (#7496)
* Revert "fix: Fixed clickatell alert transport (#7446)"

This reverts commit 9774acd055.

* Revert "newdevice: Added support for Eaton ATS devices (#7448)"

This reverts commit 1318e5871c.

* Revert "newdevice: Updated Zhone MXK detection (#7488)"

This reverts commit 81667b9e20.

* Revert "docs: Added HipChat V2 WebUI Config Example (#7486)"

This reverts commit a31eaa9839.

* Revert "fix: Fail isPingable if fping errors (#7426)"

This reverts commit 1998845f06.
2017-10-16 11:56:47 +01:00
Neil Lathwood
9774acd055 fix: Fixed clickatell alert transport (#7446)
* fix: Fixed clickatell alert transport

* Set a default value for two config columns to ensure mysql strict

* fixed schema

* fixed schema
2017-10-15 23:49:51 -05:00
tomarch
1318e5871c newdevice: Added support for Eaton ATS devices (#7448)
* eaton-ats: add definition, voltage, frequency and state

* eaton-ats: missing snmprec file

* fix some syntax error

* fix some syntax error, again

* exclude eaton-ats from eaton-mgeups definition

* change eaton-ats definition

* move state and output voltage to yaml syntax

* Update eaton-mgeups.yaml
2017-10-15 21:06:11 +01:00
Søren Rosiak
81667b9e20 newdevice: Updated Zhone MXK detection (#7488)
* newdevice: Improve Zhone MXK Discovery

* Fix test name
2017-10-15 21:02:39 +01:00
Daniel Preussker
1998845f06 fix: Fail isPingable if fping errors (#7426) 2017-10-15 20:29:08 +01:00
Tony Murray
2f2234da70 fix: cdp matching incorrect ports (#7491)
Need either remote device_id or mac_address to find a port, otherwise, we might match an incorrect port.
2017-10-15 19:49:28 +01:00
Martin Zatloukal
f48cff0f1b newdevice: Added support for Racom RAy devices (#7466) 2017-10-15 19:31:44 +01:00
Neil Lathwood
a2de3ff681 newdevice: Added detection for SmartOptics T-Series devices (#7433) 2017-10-14 14:45:57 +02:00
Neil Lathwood
6b44ac784a newdevice: Added support for Huawei OceanStor devices 2017-10-12 19:55:25 +02:00
Neil Lathwood
f61dfa3bcd newdevice: Added more support for Avocent devices (#7444)
* newdevice: Added more support for Avocent devices
2017-10-12 19:54:55 +02:00
Yunchih Chen
82fb20cc19 feature: Configurable 95th percentile (#7442)
See issue #7406 for detail.
2017-10-11 13:21:11 +01:00