5 Commits

Author SHA1 Message Date
4ad8faecdc refactor: Added detection of vlan name changes (#7348) 2017-09-16 21:19:54 -05:00
52f1b53a05 subtracting 1 from the $port_id value in the egress_ids loop
This is to fix an off by one error.
The ERS reports VLAN membership using a bitmask, but the MSB is always 0.
So using the `q_bridge_bits2indices` function results in the reported ports membership being +1 wrong.
The best fix for this would be to create a new function exactly the same as `q_bridge_bits2indices` which subtracts the 1 before returning the array. 
I tried this, but it broke my install :)
Not sure how to add to the `functions.inc.php` file without breaking it.
2017-08-01 11:20:27 +01:00
01fca2ebd5 fixed more formatting errors 2017-08-01 10:35:14 +01:00
bd0e003e27 fixed code formatting errors 2017-08-01 10:25:07 +01:00
9f65a3c1d7 created avaya-ers.inc.php
Avaya do not use the Q-Bridge MIB for Vlans.
They also store untagged vlan info in 2 seperate ways:
rcVlanPortDefaultVlanId stores the actual native VLAN or PVID per switch port.
rcVlanPortPerformTagging tells us the ports tagging mode, this can be true (all tagged or trunk), false (no tagging or access), 3 (only tag the PVID) or 4 (untag the PVID and tag everything else).
Due to how these bits of information are presented, for each VLAN ID we then need to loop through all the ports checking if their PVID matches the VLAN ID and if the tagging mode is false or 4. If both are true we add that port to the list of untagged ports for that VLAN.
2017-08-01 10:08:49 +01:00