Commit Graph

5302 Commits

Author SHA1 Message Date
TheGreatDoc
f8ec6c51b6 Merge pull request #9354 from laf/alert-settings-reorg
Reorg the alert settings page to show what options are deprecated
2018-10-21 21:30:02 +02:00
angryp
0cf11b02d3 Removed redundant grouping from SQL query in FDB Search (#9338) 2018-10-21 20:03:35 +01:00
Neil Lathwood
654411aae2 Update alerting.inc.php 2018-10-21 20:00:05 +01:00
laf
1d207ec943 Renamed section from Transport -> options 2018-10-19 22:13:11 +01:00
laf
e7ed9b7d35 Reorg the alert settings page to show what options are deprecated 2018-10-19 22:01:35 +01:00
Tony Murray
607a567090 Don't check file permissions on every request, handle failures (#9264)
* Don't check file permissions on every request, handle failures
Improve error page visually

* only print minimal mkdir

* invert file_exists check, whoops

* docblock

* revert accidental changes

* rename variable

* Change database errors to use the new layout

* Add support url to the default layout

* Replaced \n for && in fix for user perms

* fix web output
2018-10-18 21:08:46 -05:00
Andy Rosen
4e5a0fa4d7 Added Twilio SMS as an Alerting Transport (#9305)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-17 17:19:28 +01:00
JohnSPeach
001d7d7643 Added F5 APM current sessions graphing (#9334)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

While this creates the graphs under Apm for the F5s, there is no data. I can pull the data manually. Maybe I have the definition incorrect in includes/polling/os/f5.inc.php?

snmpget -m /opt/librenms/mibs/f5/F5-BIGIP-APM-MIB -v 3 -u <user> -l authPriv -a SHA -A  <password> -x AES -X <password> <server>  apmAccessStatCurrentActiveSessions.0
F5-BIGIP-APM-MIB::apmAccessStatCurrentActiveSessions.0 = Wrong Type (should be Counter64): Gauge32: 1245

or maybe it's because the OID has the incorrect type in it, although the result is actually correct.
2018-10-17 17:16:52 +01:00
PipoCanaja
417e518ae2 Oxidized list now checks device permission based on user (#9331)
* webui: display only devices that the user is allowed to view in oxidized node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS

* webui: display only devices that the user is allowed to view in oxidized node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS (CodeClimate)
2018-10-17 17:12:24 +01:00
Tony Murray
10432b1764 Escape services commands properly. (#9269)
* Attempt to escape services commands properly.

* Add LC_NUMERIC="C" back

* Updated create-service to only faily if a dbUpdate fails
2018-10-17 16:46:07 +01:00
TheGreatDoc
4a23f8dddd Fixed search & device eventlog (#9329)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

In #9252 search box and inside device eventlog where broken.

Noticed in https://community.librenms.org/t/bug-set-filter-in-device-eventlog-shows-filtered-events-from-all-devices/5633

I hope my fix does the job :)
2018-10-17 08:44:04 +01:00
TheGreatDoc
1dfa7975c9 Added support for Glass Way EYDFA WDM Optical Amplifier (#9125)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

NOTE: Those devices come all with same `sysName` so `$config['allow_duplicate_sysName'] = true;` is needed to have more than 1 working.
2018-10-12 22:37:08 +01:00
cchance27
dd39a1ab03 Allow zoom to be decimal and switch zoomSnap to 0.1 for World map (#9259)
Allow 1 decimal place for initial zoom and lower zoom snap interval to improve initial zoom in widgets.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-06 23:08:11 +01:00
Tony Murray
7c09f698a4 Don't call to legacy auth to get dashboards. (#9297)
Can cause a lot of ldap calls for example.
Should improve dashboard page load time on certain auth methods.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-06 22:56:22 +01:00
Neil Lathwood
d1772ea1f2 Check if array exists for new alert rules and create if not (#9303)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.

Fixes: https://community.librenms.org/t/i-can-t-add-alert-rules-from-the-collection-webgui/5737
2018-10-06 22:15:07 +01:00
Tony Murray
71e5aac527 Fixed devices state filter when state = 0 (#9277)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-10-03 21:45:42 +01:00
jozefrebjak
c9bbaf5a9f Added support for PBI Digital Decoder (#9223)
* added PBI MIB

I finally found a MIB for PBI device

* added PBI-MAIN-MIB

* added another PBI MIB

* added PBI MGSYSTEM-MIB

* added ird.yaml to definition

* added senors discovery for PBI devices

* added ird.inc.php for polling

* added logo for PBI

* added ird.json

* Rename PB-MAIN-MIB to PBI-MAIN-MIB

* Update ird.json

* Update PBI-4000P-5000P-MIB

* Update PBI-MAIN-MIB

* Update PBI-MGSIGNALCHARACTERISTICS-MIB

* Update PBI-MGSYSTEM-MIB

* Create ird.snmprec

* Updated json test file

* deleted frequency from yaml

I think that better will be see values from frequency in wirelles frequency, where it is in MHz

* Create Ird.php

* Update Ird.php

* Update Ird.php

* Update ird.json

* Update Ird.php
2018-09-30 21:28:33 -05:00
jozefrebjak
56481c6681 Added support for Teleste Luminato (#9061)
* Create teleste.yaml

* Create teleste.inc.php

* Create teleste.snmprec

* Add files via upload

* Add files via upload

* Update teleste.inc.php

* Delete teleste.svg

* Add files via upload

* Update teleste.yaml

* Update teleste.inc.php

* Delete HOST-RESOURCES-TYPES.mib

* Changed os to luminato

* Update and rename teleste.inc.php to luminato.inc.php

* Delete HOST-RESOURCES-MIB.mib

* Delete RFC1155-SMI.mib

* Delete RFC1213-MIB.mib

* Delete SCTE-HMS-HE-COMMON-MIB.mib

* Delete SCTE-HMS-HEADENDIDENT-MIB.mib

* Delete SCTE-HMS-PROPERTY-MIB.mib

* Delete SCTE-HMS-ROOTS.mib

* Delete SCTE-ROOT.mib

* Delete UCD-SNMP-MIB.mib

* Delete TELESTE-COMMON-MIB.mib

* Delete TELESTE-LUMINATO-MIB.mib

* Delete TELESTE-LUMINATO-MIB2.mib

* Delete TELESTE-ROOT-MIB.mib

* Create teleste.md

* Delete teleste.md

* Create telestefilename.md

* Delete telestefilename.md

* added TELESTE-COMMON-MIB

* edited os polling

* Update luminato.inc.php

* Update luminato.inc.php

* Create TELESTE-LUMINATO-MIB

* added discovery sensors for luminato

* Update luminato.inc.php

* Updated and added test files

* added TELESTE-ROOT_MIB

* Create TELESTE-LUMINATO-MIB2

* Added missing json test file

* Fixed TELESTE-ROOT-MIB

* Updated test data
2018-09-30 21:28:08 -05:00
Tony Murray
14a168b2a9 Keeps the dashboard sessions from expiring. (#9263)
* Keeps the dashboard sessions from expiring.
Route dashboard ajax calls through Laravel.
Boots minimal cookies and sessions.
Does not fix other pages for now, real fix is to fully port.

* Check Laravel auth for the legacy calls.
Display Laravel errors in the dashboard.
legacy auth checks are mostly extraneous now.
2018-09-30 21:23:00 -05:00
Tony Murray
6242f941f6 Update Eventlog WebUI/backend to use ajax (#9252)
* WIP Eventlog table

* Initial Eventlog rework

* fromdevice is not a request parameter

* updates

* remove unneeded field

* Cleanups
2018-09-24 08:07:00 +01:00
Allison
63aec0c4a7 Improved ASUSWRT-Merlin (#9253)
higher resolution icon for ASUSWRT-Merlin
2018-09-22 13:53:47 +01:00
Tony Murray
5bf4ca2b6c Fix syslog select2 theme (#9248)
Wrong one :/
htmlentities the rest...
2018-09-21 08:22:15 -05:00
Tony Murray
f81552e1c1 Syslog fixes (#9246) 2018-09-21 07:33:34 -05:00
Tony Murray
21ca8bf0b0 Update syslog display and backend (#9228)
* Update syslog display backend
select boxes now dynamically load instead of loading all on pageload
select and table ajax backends completely redone with Laravel (just syslog for now)
duplicate url creation to Url utility class for now (uses Device model instead of array)
build short hostname functionality into Device->displayName() helper

* Fix whitespace

* Some tidying up. Split out displayName() and shortDisplayName()

* Enable auto-sizing.
Fix small error in Url

* Eager load device
Use bootstrap theme for select2
2018-09-20 21:33:03 +01:00
TheGreatDoc
c30d494505 Fixed edit dashboard permissions + moved to toastr (#9236)
* Fixed edit dashboard permissions + moved to toastr

* Moved $_POST to $vars
2018-09-20 12:21:38 -05:00
Neil Lathwood
4f6e2b488a Update new_alert_rule.inc.php (#9240) 2018-09-20 12:35:54 +01:00
TheGreatDoc
1a89e27de7 Disable used rules in template map for select them (#9212)
* Disable used rules in template map for select them

* WIP Enable/Disable options dynamically

* Enable/Disable options dynamically

* Even better. Selected options for template are not disabled

* Didnt work so reverting back

* Update attach_alert_template.inc.php
2018-09-20 00:04:52 +01:00
Neil Lathwood
86d862fb25 Added support for allowing alerts to un-ack (#9136)
* Add support for allowing alerts to un-ack

* Updated db_schema.yaml

* Update and rename 263.sql to 265.sql

* Fix up ui a bit.

* Renamed sql file
2018-09-19 23:38:01 +01:00
TheGreatDoc
ba8497d484 Added Transit+Peering to Port Aggregator in the graph widget (#9234) 2018-09-19 15:50:40 -05:00
Neil Lathwood
466b5a35a8 Added ability to set a custom SQL query for alert rules. (#9094)
* Added support for AVG in rules

* More updates

* Final work to have advanced sql queries

* Added missing use

* Fix exception when invalid json is passed

* Fixed api for alert rules

* updated docs
2018-09-19 07:47:45 -05:00
Tony Murray
173b1339e9 Fixed install.php not redirecting when it should (#9224)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
After you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.
2018-09-18 20:56:48 +01:00
TheGreatDoc
cf31776a6b Show sensors warnings values + moved to json and toastr (#9210)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-16 18:23:12 +01:00
PipoCanaja
9aa429c8dc WebUI: Use generate_url for Oxidized List device (#9200) 2018-09-13 21:10:28 -05:00
TheGreatDoc
6908063fae Fixed routing edit to use LegacyAuth (#9188) 2018-09-12 08:11:32 -05:00
Tony Murray
e8cf6bb385 Fix API auth issues (#9185)
* Fix API auth issues
Api access page now creates tokens with the correct ID.
Correctly creates users for legacy user tokens.
Fix Ldap comparison
Laravel Util class to make code easier to access/read

* More api access page fixes

* fix style
2018-09-11 22:36:52 -05:00
Tony Murray
32a7c50189 Use Laravel authentication (#8702)
* Use Laravel for authentication
Support legacy auth methods
Always create DB entry for users (segregate by auth method)

Port api auth to Laravel

restrict poller errors to devices the user has access to

Run checks on every page load.  But set a 5 minute (configurable) timer.
Only run some checks if the user is an admin

Move toastr down a few pixels so it isn't as annoying.

Fix menu not loaded on laravel pages when twofactor is enabled for the system, but disabled for the user.
Add two missing menu entries in the laravel menu

Rewrite 2FA code
Simplify some and verify code before applying

Get http-auth working
Handle legacy $_SESSION differently.  Allows Auth::once(), etc to work.

* Fix tests and mysqli extension check

* remove duplicate Toastr messages

* Fix new items

* Rename 266.sql to 267.sql
2018-09-11 07:51:35 -05:00
TheGreatDoc
d475665601 Added BGP Peer Descriptions (#9165)
* Added BGP Peer Descriptions

* Fixed formatting

* Added to device routing tab too

* Some text formatting

* Test files

* Added default null to bgpPeerDescr

* Added db_schema.yaml

* Fix default value for bgpPeerDescr

* Fixed Order and Search box

* Added glyphicon for success/error

* Switch to toastr notification

* Removed unused bootstrap code
2018-09-10 22:54:46 -05:00
PipoCanaja
e367f46fee device: Initial support for CXR-Networks Terminal Server (#9169)
* device: Initial support for CXR-Networks Terminal Server

* device: Support for CXR-Networks Terminal Server - CodeClimate + cleaning

* device: renamed cxr-networks-ts and code improvement

* device: cxr-networks-ts test data

* device: renamed os as cxr-ts

* device: renamed os as cxr-ts, test data
2018-09-10 21:32:06 -05:00
PipoCanaja
56aed0ffbe WebGUI Oxidized - Add author+message + refresh button (#9163)
* WebGUI Oxidized - Add author+message + refresh button

* WebGUI Oxidized - Add author+message + refresh button

* WebGUI oxidized - move refresh_oxidized_node to js/librenms.js

* WebGUI oxidized - Style upgrade for refresh button

* WebGUI oxidized - move refresh_oxidized_node to js/librenms.js

* Update showconfig.inc.php
2018-09-10 09:04:39 -05:00
TheGreatDoc
9f0afa2927 Fixed edit processors/storage/memory search query (#9172)
* Fixed edit processors search query

* Fixed 2 more search queries
2018-09-08 09:43:56 -05:00
Tony Murray
3c530d6a4f Sanitize data in dashboard add/edit/delete (#9171)
* sanitize data in dashboard add/edit/delete

* handle access differently
2018-09-08 08:54:03 -05:00
TheGreatDoc
67e883f1a0 Fixed template to alert mapping (#9173) 2018-09-08 08:53:14 -05:00
Dan Langille
e6d67a9dbd change Indexs -> Indexes (#9161)
I think Indexes is the proper word.  What flow-on affects will this have?
2018-09-05 21:16:13 -05:00
TheGreatDoc
4bb9ac7797 Fixed PeeringDB module (#9158)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

Fixed "Show connected IXes" that I broke in my past PR (Sorry for that)
Changed remote_as in pdb_ix_peers from varchar to unsigned int for correct ordering.
Also I've corrected a typo in the "Show connected IXes" button
2018-09-05 19:26:18 +01:00
Tony Murray
4d9924242f Database schema cleanup (#9064)
* target db_schema

* Database schema cleanup
Remove several inconsistencies (mostly with data types and lengths)
Make things a bit nicer to implement with Laravel database migrations.
poller* tables had f'd up indexes

* Update tests, extra noise because db returns numeric types now.

* Update test data again.

* fix 253 migration for mysql 5.3
2018-09-05 07:34:50 -05:00
PipoCanaja
3f806fdff3 WebUI: Oxidized Device List: Link to config and refreshDevice Btn (#9129)
* WebUI: Direct link to oxidized config from list, oxidized refresh device capability

* WebUI: Direct link to oxidized config from list, oxidized refresh device capability

* Move oxidized_node_update in functions.php to avoid code duplication

* Update refresh-oxidized-node.inc.php

* Update functions.php
2018-09-04 19:09:27 -05:00
dupondje
fbb6d35061 Added support for Rancid git (#9036)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`


This pull req adds support for Rancid GIT backend (instead of the current supported SVN).
Not only git is preferred these days, also php-svn is non-existing on php 7+, so the only Rancid option is broken on PHP 7+, so might be nice to have this included :)
2018-09-04 22:41:51 +01:00
Neil Lathwood
fe45eacae9 Fixed print date selector (#9142) 2018-09-04 10:24:02 +01:00
Tony Murray
30790bafd1 Remove js symlinks and extra files (#9134)
All symlinks are removed except:
./html/api_v0.php -> index.php
./html/pages/device/neighbours/list.inc.php -> ../ports/neighbours.inc.php

Allows things to mostly work on Windows Linux subsystem when LibreNMS resides on the ntfs partition.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
2018-09-02 23:32:58 +01:00
Neil Lathwood
a8f10deee5 Fixed web installer to allow users to change db creds if we can't connect (#9126) 2018-09-01 10:54:25 -05:00