Commit Graph

1451 Commits

Author SHA1 Message Date
PipoCanaja
f115de989e OSPF instances and missing mandatory fields fix attempt (#15712)
* dirty fix

* better fix

* more column checks

* double check not necessary

* get out of both loops
2024-01-15 22:45:59 +00:00
kakohegyi
4456640e51 Zyxel Wireless Controller OS ( Zyxel NXC series ) (#15694)
* zyxelwlc

* Zyxel Wireless Controller OS

* Zyxel Wireless Controller OS

* Update Zyxelwlc.php

* test data

* sensor count graph

* sensor count graph

* sensor count graph

* sensor count graph

* fix indent

* trailing CR

* Trailing CR

* fix count def

* Delete includes/html/graphs/device/sensor-count-zyxelwlc-sessions.inc.php

Not necessary

* Delete includes/html/pages/device/graphs/sensor-count-zyxelwlc-sessions.inc.php

Not necessary

* fix tests

* fix tests for real

* session graph in core section

* session graph in core section

* session graph in core section

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-01-14 14:02:28 +01:00
Gil Obradors
5856e2c6cd Rename JiraServiceManagement.php to Jiraservicemanagement.php (#15717)
* Rename JiraServiceManagement.php to Jiraservicemanagement.php

#15716 Filenames must not be PascalCase, only the first letter can be uppercase.

* Update Jiraservicemanagement.php

Following class name conventions

* Update Jiraservicemanagement.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2024-01-09 16:05:29 +01:00
Peter Reinhold
8fb94c07c4 Handle icmpjitter SLA parsing for iosxe (#15707)
* Added MIB file CISCO-RTTMON-ICMP-MIB to Cisco collection
Query rttMonLatestIcmpJitterOperTable when polling SLAs
Extended icmpJitter parsing to allow retrieval of jitter related data from multiple locations in MIB tree

Fixes #15658

* Appended snmprec data to testdata

* Update iosxe_c9300.json

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2024-01-08 18:42:00 +01:00
Hamza Khan
166026d251 Add JiraServiceManagement Transport (#15593) 2024-01-08 16:49:14 +01:00
Neil Lathwood
421f2c7d38 Bump version to 24.1.0 2024-01-07 15:49:52 +00:00
Jellyfrog
071ca9bc2a Apply fixes from StyleCI (#15698)
Co-authored-by: StyleCI Bot <bot@styleci.io>
2024-01-04 22:39:12 -06:00
Tony Murray
6bea8cffa6 New utility Number::constrainInteger() (#15663)
* New utility Number::constrainInteger()
Fixes a bug with Number::unsignedAsSigned() and implements signed support as well.

* cleanup

* Apply fixes from StyleCI

* Remove default cases

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-12-20 09:21:40 -06:00
craig-nokia
c97fd4e6f5 bug - "null" checks for SAR 7705 release 8.X (#15657)
Added null for SAR 7705 release 8.X
2023-12-18 16:40:06 +01:00
PipoCanaja
b12ee04bda bug - timos MPLS - more poller fixes (#15624)
* fix 1, ErrorException: Undefined array key sdpFarEndInetAddress in /opt/librenms/LibreNMS/OS/Timos.php:584

* fix2: don't try mplsSdpBinds polling if prerequisites not met

* fix 3: ErrorException: Attempt to read property lsp_path_id on null in /opt/librenms/LibreNMS/OS/Timos.php:790

* style

* fix phpstan

* schema_update

* schema

* migration_style

* migration drops and recreate

* migration drops and recreate

* migration drops and recreate

* style
2023-12-17 20:15:46 -06:00
Brian Egge
470e2ae34f Update Pushover.php (#15652)
Entities are html encoded so this will cause them to be displayed correctly in pushover alerts

---------

Co-authored-by: PipoCanaja <38363551+PipoCanaja@users.noreply.github.com>
2023-12-17 00:20:42 +01:00
PipoCanaja
648a5ea7d3 bug - XDSL adslAtucCurrOutputPwr exception (Cisco CSCvj53634) (#15614)
* Cisco CSCvj53634

tests

change RRD minimas to accept negative dbm output power

unnecessary tests

* unsignedAsSigned function

* use new function Number::unsignedAsSigned

* negative power for Vdsl as well

* style

* style

* Add types

* simplify and exception if over max value

* Add tests

* Style fixes

* Tell phpstan to shut up

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-12-15 10:06:52 -06:00
Adam James
66cc34dbd2 Add support for Fortinet FortiAPs (#15641) 2023-12-14 11:29:02 -06:00
PipoCanaja
c88fba0b64 bug - ADSL ifIndex to port error not handled (#15617)
* fix

* add an error message
2023-12-05 07:11:46 -06:00
PipoCanaja
b0a355e8ba ?? null (#15613) 2023-12-04 03:54:19 +01:00
Justin Lentz
d61c71bcbe Change default graph image to SVG (#15586)
* Update config_definitions.json

* Update Rrd.php
2023-11-27 18:43:15 -06:00
Tony Murray
54ff1d7e63 Bump version to 23.11.0 2023-11-16 20:57:41 -06:00
Tony Murray
2755676131 Fallback to default alert template and give reason (#15583)
* Fallback template, give reason
Print the error and notice of the fallback template being used.

* more strict typing
2023-11-16 15:18:12 +00:00
eskyuu
cc7e02cbcd Device links formatting changes (#15580)
Make the images inline so they appear side by side
Put newlines between the major device information sections (name, model/OS, location)
2023-11-16 08:54:29 -06:00
PipoCanaja
d107af1363 bug - Fix API Content-Type Header handling (#15574)
* Fix API Content-Type Header

* compacted and commented

* style
2023-11-14 07:26:00 -06:00
not-known
cf69a00cd0 Add option to disable the send of acknowledgement alerts. (#15208) 2023-11-13 21:56:06 -06:00
PipoCanaja
f59388d7f9 vrp - 'unknown (huawei)' state and change hwWlanRadioFreqType to hwWlanRadioType (#15564) 2023-11-11 20:19:42 +01:00
Tony Murray
63eeeb7172 Mail Transport use BCC option (#15554)
Option to use BCC instead of to field for emails
2023-11-08 08:36:09 -06:00
Gerald VINCENT
11903150c8 Zyxel AP wireless client discovery enhancement (#14704)
* Update Zyxelnwa.php

Discovering wireless clients on all bands

* Update ZYXEL-ES-WIRELESS

Replace '_' by '-' as it is a bad practice to use underscores in values

* Update Zyxelnwa.php

* Update ZYXEL-ES-WIRELESS

* Update zyxelnwa.snmprec

* Create zyxelnwa.json

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update ZYXEL-ES-WIRELESS

* Update Zyxelnwa.php

* Update zyxelnwa.snmprec

* Update Zyxelnwa.php

* Update Zyxelnwa.php

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-06 00:43:59 -06:00
Tony Murray
1dd1ddc2ca Prometheus on failure, disable for rest of run (#15546) 2023-11-05 18:29:25 -06:00
Janno Schouwenburg
5b63f109c6 Dantherm hostname (#14223)
* Support for configured hostname to override sysName

* Update and add test data

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 19:25:56 -05:00
Tony Murray
4622742629 Misc device column cleanups (#15518)
* Misc device column cleanups
Update last_ping on poll

* Revert inserted change for now
2023-11-02 01:51:52 -05:00
Tim de Boer
d5c6d0aaf4 Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS (#15535)
* Fixed BGP Remote peer link and graph in Routing Overview, or just static text when not a device in LibreNMS

* Added extra space

* Reverted back to overlibLink (due to BGP update graphs on hover)

* Added extra space

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer)

* Removed unnecessary/unused code

* Remove graph for remote peer, as it is falsely (showed earlier the Updates Graph for local peer), replaced with just a DeviceLinks

* Change Url::deviceLink to return $text if the device doesn't exist.  Default to ''
Import some of the things to improve readability.

* update phpdoc

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-11-02 00:41:19 -05:00
Peter Childs
828be4bb52 add auth_ldap_cacertfile and auth_ldap_ignorecert options (#15526)
* add auth_ldap_cacertfile and auth_ldap_ignorecert options

* style-ci
2023-11-01 20:48:44 -05:00
Tony Murray
183f9559f4 New command: lnms report:devices (#15539)
* New report:devices command
Print out a list of devices with user specified fields, optionally in csv format

* Polish

* Apply fixes from StyleCI

* Use spaces instead of tab for none type

* Fix method call

* other commands use whereDeviceSpec

* Apply fixes from StyleCI

* update command help and back to tab for separator

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 13:52:21 -05:00
Tony Murray
44521ab2f1 UCD buffers and cache discovered with inverted free/used values (#15538)
* UCD buffers and cache discovered with inverted free/used values
(polling was correct)

* UCD Discovery was also double calculating "available"

* update test data

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 11:22:04 -05:00
Tony Murray
b9881bbf36 Cisco WLC: fetch LWAPP SSIDs for client counts (#15531)
* Cisco WLC: fetch LWAPP SSIDs

* Apply fixes from StyleCI

* no need to check twice

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-11-01 11:21:11 -05:00
PipoCanaja
63f33642b8 string VS array (#15533) 2023-10-31 15:22:18 -05:00
Tony Murray
e1f6b77204 Fix Ciscowlc error when bsnApIfNoOfUsers is not present (#15529)
fixes #15517
2023-10-31 08:25:35 -05:00
Tony Murray
7c542d70af SnmpQuery runtime cache (#15512)
* SnmpQuery runtime cache
Optionally cache the SnmpResponse from queries for the rest of the runtime.
It would be nice to have cache hits for these to help prevent wasting memory caching data that is only used once.
Key data must match: device, context, options, oids

* Apply fixes from StyleCI

* Add command to the cache key

* Caching in the wrong spot, cache individual commands...

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-29 22:46:04 -05:00
Tony Murray
c22b74d46b Bump version to 23.10.0 2023-10-26 22:47:36 -05:00
Tony Murray
db17036f5d Ospf metrics fix (#15508)
* Ospf metrics fix
If the device gave an invalid IP for metrics, it would fail.
Fix this issue, and optimize the sql queries so less are needed.

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-26 11:21:08 -05:00
Tony Murray
7e0b41a05a IP::fromHexString handle ascii (#15504)
* IP::fromHexString handle ascii
Some bad MIBs convert the hex to ascii on display.
Attempt to decode that if the situation is detected.

fixes #15501

* add ascii tests
2023-10-26 10:03:03 -05:00
Tony Murray
811416eec4 Fix poller perf graph time (#15500) 2023-10-24 07:16:23 -05:00
Tony Murray
98992345fa Do not update device IP when DNS resolution fails (#15499) 2023-10-23 20:09:55 -05:00
Tony Murray
79cc5c9114 IS-IS polling handle missing data (#15491)
fixes #15489
2023-10-23 11:02:17 +02:00
Félix Bouynot
6ce43a300b Fix regression causing wall of ping latency (#15486)
Fix https://github.com/librenms/librenms/issues/15382
2023-10-20 07:30:51 -05:00
Tony Murray
f0aa80e73d ports ifPhysAddress use MAC helper (#15478)
* Ports min polled period of 1
Prevent divide by 0
Use Mac utility

* fix bad snmprec for airos-af-ltu

* Update a large amount of invalid mac addresses
either the script is capturing them wrong or users are mangling them

* More updated test data

* Update test data with bad input

* Fix ones using encoded <private> and attempt to fix capture

* Update awplus data

* restore missing data

* update other DNOS

* Fix ones using encoded <private> and attempt to fix capture

* Fix ones using encoded <private> and attempt to fix capture

* fix typo

* Update some data

* update data

* update ruijie
2023-10-19 20:10:52 +02:00
metrojworthington
7bd1a57c3e Mcc valere (#14753)
* modifications needed for update of VALERE-DC-POWER-MIB with new file ELTEK-BC2000-DC-POWER-MIB

* add test results for BC2000 post update

* updated test file data

* re-upload of updated files

* reverted valere.json to defaults and recreated with proper varient .json

* replace vpwrShelfIndex with vpwrBayIndex

* updated test data

* Update test data

* try again valere_bc2000.json

---------

Co-authored-by: Tony Murray <murraytony@gmail.com>
2023-10-19 07:22:46 -05:00
Tony Murray
8f91fb3877 Fix polling down retry (and other items) (#15483)
* Only update last_polled if polled
Because availability now runs always, we need to check if we ran any other modules successfully, if so, we can update last_polled

* Tally results and act accordingly

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-19 06:55:41 -05:00
Wade Fitzpatrick
27ef398907 Add alert transport for Grafana Oncall (#15330)
* Add alert transport for Grafana Oncall

* Add doc for Grafana Oncall

* Fix lint

* Fix comment lint
2023-10-18 22:24:40 -05:00
Tony Murray
921872369d Fix rrd exists check (#15466)
Filename incorrect for test
2023-10-16 12:48:01 -05:00
Tony Murray
fb59cfec1c Module status cleanups (#15461)
* Module status helper

* Correct reference

* Rename function to make it more explicit

* Same for exists checks, normalize argument names

* Use new functions
2023-10-16 07:03:32 -05:00
Tony Murray
abf4fa0004 Exclude availability module from default testing (#15462) 2023-10-16 07:02:35 -05:00
Tony Murray
7a8e479b61 Unix Agent and Application fixes (#15460)
* Unix Agent and Application fixes

* Apply fixes from StyleCI

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
2023-10-16 03:40:40 -05:00