6 Commits

Author SHA1 Message Date
Tony Murray
da0d04a5b6 Double check before throwing an exception. (#4790)
Since we are running two processes, we could leak one if we throw an exception and execution stops.
2016-10-15 18:21:46 +01:00
Tony Murray
edbb6ae0e3 refactor: Centralize MIB include directory specification (#4603)
* refactor: Centralize MIB include directory specification
The default is now:
```
$config['mib_dir'].'/mibdirname:'.$config['mib_dir']
```
This means we exclude OS mibs and only use ours  (we could prepend `+` if we want to include os mibs.
All snmp calls should only include the name of the subdirectory under the mibs directory.

* Remove d_echo from Proc
Fix snmpsim tests.
2016-09-28 14:19:28 +01:00
Neil Lathwood
744a2280a2 fix: Broken graphs 2016-09-23 23:41:23 +01:00
Tony Murray
00b9896eda fix: LibreNMS/Proc improvements
Should fix sending rrdtool the quit command without a newline at the end. (not sure if this is an issue)
2016-09-23 15:01:43 -05:00
Tony Murray
abc6a5b799 PSR-2 Final cleanup (#4247)
refactor: Final PSR2 cleanup
2016-08-28 23:32:55 +01:00
Tony Murray
200e670315 Fix defunct process issues: create Proc class (#4210)
* Proc class
Encapsulate processes in a class, when they go out of scope, we can use the __destruct() process to make sure the process terminates.

* Fix rrdtool_last checks failing

* Don't close rrdtool in rrd_graph
Try to start rrdtool process if they haven't been started yet
Remove some extra debug output

* phpdocs added
several cleanups
should still be functioning the same
Only open one  rrdtool process for graph.php
2016-08-26 07:50:29 +01:00