mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
angrypandNeil Lathwood
5af520a687
This is a fix for #8746, which added support of SFP module discovery on Procurve devices. I noticed a lot of false positive alerts for current bias when we launched this in production, so looked once more through MIB/code. MIB data: hpicfXcvrBias - Tx bias current in microamps hpicfXcvrBiasHiAlarm - Transceiver bias high alarm threshold limit in microamps hpicfXcvrBiasLoAlarm - Transceiver bias low alarm threshold limit in microamps Sensor discovery sample: hpicfXcvrBias.49 = 23254 hpicfXcvrBiasHiAlarm.49 = 100000 hpicfXcvrBiasLoAlarm.49 = 0 hpicfXcvrBiasHiWarn.49 = 90000 hpicfXcvrBiasLoWarn.49 = 100 So yes, my mistake was to use 10^-7 instead of 10^-6 divisor for these fields. Fix is in this pull request. Sorry for the inconveniences caused. DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`
25 lines
1.4 KiB
PHP
25 lines
1.4 KiB
PHP
<?php
|
|
$multiplier = 1;
|
|
$divisor = 1000000;
|
|
$divisor_alarm = 1000000;
|
|
foreach ($pre_cache['procurve_hpicfXcvrInfoTable'] as $index => $entry) {
|
|
if (is_numeric($entry['hpicfXcvrBias']) && $entry['hpicfXcvrBias'] != 0) {
|
|
$oid = '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.13.' . $index;
|
|
$dbquery = dbFetchRows("SELECT `ifDescr` FROM `ports` WHERE `ifIndex`= ? AND `device_id` = ? AND `ifAdminStatus` = 'up'", array(
|
|
$index,
|
|
$device['device_id']
|
|
));
|
|
$limit_low = $entry['hpicfXcvrBiasLoAlarm'] / $divisor_alarm;
|
|
$warn_limit_low = $entry['hpicfXcvrBiasLoWarn'] / $divisor_alarm;
|
|
$limit = $entry['hpicfXcvrBiasHiAlarm'] / $divisor_alarm;
|
|
$warn_limit = $entry['hpicfXcvrBiasHiWarn'] / $divisor_alarm;
|
|
$current = $entry['hpicfXcvrBias'] / $divisor;
|
|
$entPhysicalIndex = $index;
|
|
$entPhysicalIndex_measured = 'ports';
|
|
foreach ($dbquery as $dbindex => $dbresult) {
|
|
$descr = makeshortif($dbresult['ifDescr']) . ' Port Bias Current';
|
|
discover_sensor($valid['sensor'], 'current', $device, $oid, 'hpicfXcvrBias.' . $index, 'procurve', $descr, $divisor, $multiplier, $limit_low, $warn_limit_low, $warn_limit, $limit, $current, 'snmp', $entPhysicalIndex, $entPhysicalIndex_measured);
|
|
}
|
|
}
|
|
}
|