mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
5076deccf3
* Improve the efficiency of some queries Mostly by switching from whereIn to whereIntegerInRaw. This inserts integers directly into the query instead of using placeholders (also escapes them) also remove extra json_encode/json_decode in PingCheck * Fix return types Probably will result in some missing baseline exceptions. * Update PingCheck.php * whitespace
105 lines
3.9 KiB
PHP
105 lines
3.9 KiB
PHP
<?php
|
|
|
|
// Build a dictionary of vlans in database
|
|
use LibreNMS\Config;
|
|
|
|
$vlans_dict = [];
|
|
foreach (dbFetchRows('SELECT `vlan_id`, `vlan_vlan` from `vlans` WHERE `device_id` = ?', [$device['device_id']]) as $vlan_entry) {
|
|
$vlans_dict[$vlan_entry['vlan_vlan']] = $vlan_entry['vlan_id'];
|
|
}
|
|
$vlans_by_id = array_flip($vlans_dict);
|
|
|
|
// Build table of existing vlan/mac table
|
|
$existing_fdbs = [];
|
|
$sql_result = dbFetchRows('SELECT * FROM `ports_fdb` WHERE `device_id` = ?', [$device['device_id']]);
|
|
foreach ($sql_result as $entry) {
|
|
$existing_fdbs[(int) $entry['vlan_id']][$entry['mac_address']] = $entry;
|
|
}
|
|
|
|
$insert = []; // populate $insert with database entries
|
|
if (file_exists(Config::get('install_dir') . "/includes/discovery/fdb-table/{$device['os']}.inc.php")) {
|
|
require Config::get('install_dir') . "/includes/discovery/fdb-table/{$device['os']}.inc.php";
|
|
} elseif ($device['os'] == 'ios' || $device['os'] == 'iosxe' || $device['os'] == 'nxos') {
|
|
//ios,iosxe,nxos are all Cisco
|
|
include Config::get('install_dir') . '/includes/discovery/fdb-table/ios.inc.php';
|
|
}
|
|
|
|
if (empty($insert)) {
|
|
// Check generic Q-BRIDGE-MIB and BRIDGE-MIB
|
|
include Config::get('install_dir') . '/includes/discovery/fdb-table/bridge.inc.php';
|
|
}
|
|
|
|
if (! empty($insert)) {
|
|
$update_time_only = [];
|
|
$now = \Carbon\Carbon::now();
|
|
// synchronize with the database
|
|
foreach ($insert as $vlan_id => $mac_address_table) {
|
|
echo " {$vlans_by_id[$vlan_id]}: ";
|
|
|
|
foreach ($mac_address_table as $mac_address_entry => $entry) {
|
|
if ($existing_fdbs[$vlan_id][$mac_address_entry]) {
|
|
$new_port = $entry['port_id'];
|
|
$port_fdb_id = $existing_fdbs[$vlan_id][$mac_address_entry]['ports_fdb_id'];
|
|
|
|
// Sometimes new_port ends up as 0 if we didn't get a complete dot1dBasePort
|
|
// dictionary from BRIDGE-MIB - don't write a 0 over a previously known port
|
|
if ($existing_fdbs[$vlan_id][$mac_address_entry]['port_id'] != $new_port && $new_port != 0) {
|
|
DB::table('ports_fdb')
|
|
->where('ports_fdb_id', $port_fdb_id)
|
|
->update([
|
|
'port_id' => $new_port,
|
|
'updated_at' => $now,
|
|
]);
|
|
echo 'U';
|
|
} else {
|
|
$update_time_only[] = $port_fdb_id;
|
|
echo '.';
|
|
}
|
|
unset($existing_fdbs[$vlan_id][$mac_address_entry]);
|
|
} else {
|
|
if (is_null($entry['port_id'])) {
|
|
// fix SQLSTATE[23000]: Integrity constraint violation: 1048 Column 'port_id' cannot be null
|
|
// If $entry['port_id'] truly is null then Illuminate throws a fatal errory and all subsequent processing stops.
|
|
// Cisco ISO (and others) may have null ids. We still want them inserted as new
|
|
// strings work with DB::table->insert().
|
|
$entry['port_id'] = '';
|
|
}
|
|
|
|
DB::table('ports_fdb')->insert([
|
|
'port_id' => $entry['port_id'],
|
|
'mac_address' => $mac_address_entry,
|
|
'vlan_id' => $vlan_id,
|
|
'device_id' => $device['device_id'],
|
|
'created_at' => $now,
|
|
'updated_at' => $now,
|
|
]);
|
|
echo '+';
|
|
}
|
|
}
|
|
|
|
echo PHP_EOL;
|
|
}
|
|
|
|
DB::table('ports_fdb')->whereIntegerInRaw('ports_fdb_id', $update_time_only)->update(['updated_at' => $now]);
|
|
|
|
//We do not delete anything here, as daily.sh will take care of the cleaning.
|
|
|
|
// Delete old entries from the database
|
|
}
|
|
|
|
unset(
|
|
$vlan_entry,
|
|
$vlans_by_id,
|
|
$existing_fdbs,
|
|
$portid_dict,
|
|
$vlans_dict,
|
|
$insert,
|
|
$sql_result,
|
|
$vlans,
|
|
$port,
|
|
$fdbPort_table,
|
|
$entries,
|
|
$update_time_only,
|
|
$now
|
|
);
|