mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
2b3ca49bea
fixes: #5264 The issue was all the string concatenation... But I decided to try loading the select via ajax. Seems ok. We could just use something like select2. Opinions? Use this approach or load at page load. I was able to reduce the loading of the 4000 select items from 1.6s to 0.6s on my laptop by optimizing the sql. I added 4000 devices to my database to check this :)
35 lines
1.2 KiB
PHP
35 lines
1.2 KiB
PHP
<?php
|
|
/**
|
|
* hostnames.inc.php
|
|
*
|
|
* -Description-
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @package LibreNMS
|
|
* @link http://librenms.org
|
|
* @copyright 2017 Tony Murray
|
|
* @author Tony Murray <murraytony@gmail.com>
|
|
*/
|
|
|
|
if (is_admin() || is_read()) {
|
|
echo json_encode(dbFetchRows('SELECT `device_id` AS id, `hostname` AS value FROM `devices`'));
|
|
} else {
|
|
$sql = 'SELECT `devices`.`device_id` AS id, `hostname` AS value FROM `devices`
|
|
LEFT JOIN `devices_perms` ON `devices`.`device_id` = `devices_perms`.`device_id`
|
|
WHERE `devices_perms`.`user_id` = ?';
|
|
|
|
echo json_encode(dbFetchRows($sql, $_SESSION['user_id']));
|
|
}
|