mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
5af520a687
This is a fix for #8746, which added support of SFP module discovery on Procurve devices. I noticed a lot of false positive alerts for current bias when we launched this in production, so looked once more through MIB/code. MIB data: hpicfXcvrBias - Tx bias current in microamps hpicfXcvrBiasHiAlarm - Transceiver bias high alarm threshold limit in microamps hpicfXcvrBiasLoAlarm - Transceiver bias low alarm threshold limit in microamps Sensor discovery sample: hpicfXcvrBias.49 = 23254 hpicfXcvrBiasHiAlarm.49 = 100000 hpicfXcvrBiasLoAlarm.49 = 0 hpicfXcvrBiasHiWarn.49 = 90000 hpicfXcvrBiasLoWarn.49 = 100 So yes, my mistake was to use 10^-7 instead of 10^-6 divisor for these fields. Fix is in this pull request. Sorry for the inconveniences caused. DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`