mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
- Fix location so it is a regular database relation (this allows multiple devices to be accurately linked to one location and saves api calls) - Parse coordinates from the location more consistently - Add settings to webui - ~~Used [PHP Geocoder](http://geocoder-php.org/), which has lots of backends and is well tested. (also includes reverse and geoip)~~ - Google Maps, Bing, Mapquest, and OpenStreetMap supported initially. - Default to OpenStreetMap, which doesn't require a key. They will liberally hand out bans if you exceed 1 query per second though. - All other Geocoding APIs require an API key. (Google requires a credit card on file, but seems to be the most accurate) - Update all (I think) sql queries to handle the new structure - Remove final vestiges of override_sysLocation as a device attribute - Update existing device groups and rules in DB - Tested all APIs with good/bad location, no/bad/good key, and no connection. - Cannot fix advanced queries that use location This blocks #8868 DO NOT DELETE THIS TEXT #### Please note > Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting. - [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/) #### Testers If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926` After you are done testing, you can remove the changes with `./scripts/github-remove`. If there are schema changes, you can ask on discord how to revert.
132 lines
4.3 KiB
PHP
132 lines
4.3 KiB
PHP
<?php
|
|
/**
|
|
* OSModulesTest.php
|
|
*
|
|
* Test discovery and poller modules
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @package LibreNMS
|
|
* @link http://librenms.org
|
|
* @copyright 2017 Tony Murray
|
|
* @author Tony Murray <murraytony@gmail.com>
|
|
*/
|
|
|
|
namespace LibreNMS\Tests;
|
|
|
|
use LibreNMS\Exceptions\FileNotFoundException;
|
|
use LibreNMS\Exceptions\InvalidModuleException;
|
|
use LibreNMS\Util\ModuleTestHelper;
|
|
|
|
class OSModulesTest extends DBTestCase
|
|
{
|
|
/**
|
|
* Test all modules for a particular OS
|
|
*
|
|
* @group os
|
|
* @dataProvider dumpedDataProvider
|
|
*/
|
|
public function testDataIsValid($os, $variant, $modules)
|
|
{
|
|
// special case if data provider throws exception
|
|
if ($os === false) {
|
|
$this->fail($modules);
|
|
}
|
|
|
|
$this->assertNotEmpty($modules, "No modules to test for $os $variant");
|
|
}
|
|
|
|
/**
|
|
* Test all modules for a particular OS
|
|
*
|
|
* @group os
|
|
* @dataProvider dumpedDataProvider
|
|
* @param string $os base os
|
|
* @param string $variant optional variant
|
|
* @param array $modules modules to test for this os
|
|
*/
|
|
public function testOS($os, $variant, $modules)
|
|
{
|
|
$this->requireSnmpsim(); // require snmpsim for tests
|
|
global $snmpsim;
|
|
|
|
try {
|
|
$helper = new ModuleTestHelper($modules, $os, $variant);
|
|
$helper->setQuiet();
|
|
|
|
$filename = $helper->getJsonFilepath(true);
|
|
$expected_data = $helper->getTestData();
|
|
$results = $helper->generateTestData($snmpsim, true);
|
|
} catch (FileNotFoundException $e) {
|
|
$this->fail($e->getMessage());
|
|
return;
|
|
} catch (InvalidModuleException $e) {
|
|
$this->fail($e->getMessage());
|
|
return;
|
|
}
|
|
|
|
if (is_null($results)) {
|
|
$this->fail("$os: Failed to collect data.");
|
|
}
|
|
|
|
// output all discovery and poller output if debug mode is enabled for phpunit
|
|
$debug = in_array('--debug', $_SERVER['argv'], true);
|
|
|
|
foreach ($modules as $module) {
|
|
$expected = $expected_data[$module]['discovery'];
|
|
$actual = $results[$module]['discovery'];
|
|
$this->assertEquals(
|
|
$expected,
|
|
$actual,
|
|
"OS $os: Discovered $module data does not match that found in $filename\n"
|
|
. print_r(array_diff($expected, $actual), true)
|
|
. $helper->getDiscoveryOutput($debug ? null : $module)
|
|
. "\nOS $os: Discovered $module data does not match that found in $filename"
|
|
);
|
|
|
|
if ($expected_data[$module]['poller'] == 'matches discovery') {
|
|
$expected = $expected_data[$module]['discovery'];
|
|
} else {
|
|
$expected = $expected_data[$module]['poller'];
|
|
}
|
|
$actual = $results[$module]['poller'];
|
|
$this->assertEquals(
|
|
$expected,
|
|
$actual,
|
|
"OS $os: Polled $module data does not match that found in $filename\n"
|
|
. print_r(array_diff($expected, $actual), true)
|
|
. $helper->getPollerOutput($debug ? null : $module)
|
|
. "\nOS $os: Polled $module data does not match that found in $filename"
|
|
);
|
|
}
|
|
}
|
|
|
|
|
|
public function dumpedDataProvider()
|
|
{
|
|
$modules = array();
|
|
|
|
if (getenv('TEST_MODULES')) {
|
|
$modules = explode(',', getenv('TEST_MODULES'));
|
|
}
|
|
|
|
try {
|
|
return ModuleTestHelper::findOsWithData($modules);
|
|
} catch (InvalidModuleException $e) {
|
|
// special case for exception
|
|
return [[false, false, $e->getMessage()]];
|
|
}
|
|
}
|
|
}
|