mirror of
https://github.com/librenms/librenms.git
synced 2024-10-07 16:52:45 +00:00
* lnms config:set works for os settings validate against os schema (gives us path and value validation) fix unset in config:set json formatted output in config:get to match input parsing * inline errors * Check that OS exists * Fix lock file * Set param type * correct method name, it no longer returns a boolean * rename --json to --dump tests and fixes * fix whitespace * missed one whitespace * typehints * add connection typehint * try again
136 lines
5.2 KiB
PHP
136 lines
5.2 KiB
PHP
<?php
|
|
/*
|
|
* TestSetConfigCommand.php
|
|
*
|
|
* -Description-
|
|
*
|
|
* This program is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* @package LibreNMS
|
|
* @link http://librenms.org
|
|
* @copyright 2021 Tony Murray
|
|
* @author Tony Murray <murraytony@gmail.com>
|
|
*/
|
|
|
|
namespace LibreNMS\Tests\Feature\Commands;
|
|
|
|
use LibreNMS\Config;
|
|
use LibreNMS\Tests\InMemoryDbTestCase;
|
|
|
|
class TestConfigCommands extends InMemoryDbTestCase
|
|
{
|
|
public function testSetting(): void
|
|
{
|
|
// simple
|
|
Config::set('login_message', null);
|
|
$this->assertCliSets('login_message', 'hello');
|
|
|
|
// nested
|
|
Config::forget('allow_entity_sensor.amperes');
|
|
$this->assertCliSets('allow_entity_sensor.amperes', 'false');
|
|
|
|
// set inside
|
|
$this->assertCliGets('auth_ldap_groups.somegroup', null);
|
|
$this->artisan('config:set', ['setting' => 'auth_ldap_groups.somegroup', 'value' => '{"level": 3}'])->assertExitCode(0);
|
|
$this->assertCliGets('auth_ldap_groups.somegroup', ['level' => 3]);
|
|
$this->artisan('config:set', ['setting' => 'auth_ldap_groups.somegroup'])
|
|
->expectsConfirmation(trans('commands.config:set.forget_from', ['path' => 'somegroup', 'parent' => 'auth_ldap_groups']), 'yes')
|
|
->assertExitCode(0);
|
|
|
|
// test append
|
|
$community = Config::get('snmp.community');
|
|
$this->assertCliGets('snmp.community', $community);
|
|
$community[] = 'extra_community';
|
|
$this->artisan('config:set', ['setting' => 'snmp.community.+', 'value' => 'extra_community'])->assertExitCode(0);
|
|
$this->assertCliGets('snmp.community', $community);
|
|
|
|
// os bool
|
|
$this->assertCliSets('os.ios.rfc1628_compat', true);
|
|
|
|
// os array and append
|
|
$this->assertCliSets('os.netonix.bad_iftype', ['ethernet', 'psuedowire']);
|
|
// $this->artisan('config:set', ['setting' => 'os.netonix.bad_iftype.+', 'value' => 'other'])->assertExitCode(0);
|
|
// $this->assertCliGets('os.netonix.bad_iftype', ['ethernet', 'psuedowire', 'other']);
|
|
|
|
// dump
|
|
$this->artisan('config:get', ['--dump' => true])
|
|
->expectsOutput(Config::toJson())
|
|
->assertExitCode(0);
|
|
}
|
|
|
|
public function testInvalidSetting(): void
|
|
{
|
|
// non-existent setting
|
|
$this->artisan('config:set', ['setting' => 'this_will_never_be.a.setting'])
|
|
->assertExitCode(2);
|
|
|
|
// invalid type
|
|
$this->artisan('config:set', ['setting' => 'alert_rule.interval', 'value' => 'string', '--no-ansi' => true])
|
|
->expectsOutput(trans('settings.validate.integer', ['value' => '"string"']))
|
|
->assertExitCode(2);
|
|
|
|
// non-existent os
|
|
$this->artisan('config:set', ['setting' => 'os.someos.this_will_never_be.a.setting'])
|
|
->expectsOutput(trans('commands.config:set.errors.invalid_os', ['os' => 'someos']))
|
|
->assertExitCode(2);
|
|
|
|
// non-existent os setting
|
|
$this->artisan('config:set', ['setting' => 'os.ios.this_will_never_be.a.setting'])
|
|
->doesntExpectOutput(trans('commands.config:set.errors.invalid_os', ['os' => 'ios']))
|
|
->assertExitCode(2);
|
|
|
|
// append to non-array
|
|
Config::set('login_message', 'blah');
|
|
$message = Config::get('login_message');
|
|
$this->artisan('config:set', ['setting' => 'login_message.+', 'value' => 'something', '--no-ansi' => true])
|
|
->expectsOutput(trans('commands.config:set.errors.append'))
|
|
->assertExitCode(2);
|
|
}
|
|
|
|
/**
|
|
* @param string $setting
|
|
* @param mixed $expected
|
|
*/
|
|
private function assertCliSets(string $setting, $expected): void
|
|
{
|
|
$this->assertCliGets($setting, null);
|
|
$this->artisan('config:set', ['setting' => $setting, 'value' => json_encode($expected)])->assertExitCode(0);
|
|
$this->assertCliGets($setting, $expected);
|
|
$this->artisan('config:set', ['setting' => $setting])
|
|
->expectsQuestion(trans('commands.config:set.confirm', ['setting' => $setting]), true)
|
|
->assertExitCode(0);
|
|
$this->assertCliGets($setting, null);
|
|
}
|
|
|
|
/**
|
|
* @param string $setting
|
|
* @param mixed $expected
|
|
*/
|
|
private function assertCliGets(string $setting, $expected): void
|
|
{
|
|
$this->assertSame($expected, \LibreNMS\Config::get($setting));
|
|
|
|
$command = $this->artisan('config:get', ['setting' => $setting]);
|
|
if ($expected === null) {
|
|
$command->assertExitCode(1);
|
|
|
|
return;
|
|
}
|
|
|
|
$command->assertExitCode(0)
|
|
->expectsOutput(is_string($expected) ? $expected : json_encode($expected, JSON_PRETTY_PRINT))
|
|
->assertExitCode(0);
|
|
}
|
|
}
|