From 2120a436d995e4e86d0beff3dae4cff9cee13dc2 Mon Sep 17 00:00:00 2001 From: Maksym Pavlenko Date: Wed, 4 Jan 2017 16:45:10 -0800 Subject: [PATCH] Better error response while resolving video link --- src/Podsync/Controllers/DownloadController.cs | 8 +++++++- src/Podsync/Services/Resolver/YtdlWrapper.cs | 4 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/Podsync/Controllers/DownloadController.cs b/src/Podsync/Controllers/DownloadController.cs index 7a9833b..ce9bd93 100644 --- a/src/Podsync/Controllers/DownloadController.cs +++ b/src/Podsync/Controllers/DownloadController.cs @@ -55,7 +55,13 @@ namespace Podsync.Controllers ["VideoId"] = videoId }); - return BadRequest("Could nou resolve URL"); + var response = "Could nou resolve URL"; + if (ex is InvalidOperationException) + { + response = ex.Message; + } + + return BadRequest(response); } // Report metrics diff --git a/src/Podsync/Services/Resolver/YtdlWrapper.cs b/src/Podsync/Services/Resolver/YtdlWrapper.cs index 734fd2c..b7ad564 100644 --- a/src/Podsync/Services/Resolver/YtdlWrapper.cs +++ b/src/Podsync/Services/Resolver/YtdlWrapper.cs @@ -8,8 +8,8 @@ namespace Podsync.Services.Resolver { public class YtdlWrapper : IResolverService { - private static readonly TimeSpan ProcessWaitTimeout = TimeSpan.FromSeconds(30); - private static readonly TimeSpan WaitTimeoutBetweenFailedCalls = TimeSpan.FromSeconds(15); + private static readonly TimeSpan ProcessWaitTimeout = TimeSpan.FromMinutes(1); + private static readonly TimeSpan WaitTimeoutBetweenFailedCalls = TimeSpan.FromSeconds(30); private const string Ytdl = "youtube-dl";