2020-03-03 12:04:46 -05:00
|
|
|
from django.contrib.postgres.fields import JSONField
|
2018-02-22 17:46:50 -05:00
|
|
|
from drf_yasg import openapi
|
2020-06-17 09:57:17 -04:00
|
|
|
from drf_yasg.inspectors import FieldInspector, NotHandled, PaginatorInspector, SwaggerAutoSchema
|
2019-03-04 03:24:45 +02:00
|
|
|
from drf_yasg.utils import get_serializer_ref_name
|
2018-02-22 17:46:50 -05:00
|
|
|
from rest_framework.fields import ChoiceField
|
Fix type mismatches in API view (#2429)
* Fix tags field to be shown as array in API view
`tags` field in serializers is defineded as `TagListSerializerField`.
It should be shown as an array value in API view but actually, it is a
simple string value.
This fixes it by introducing a new `FieldInspector` to handle
`TagListSerializerField` type field as an array. It doesn't affects any
other type fields.
* Fix SerializedPKRelatedField type API expression
A field definded as `SerializedPKRelatedField` should be shown as an
array of child serializer objects in a response value definition in API
view but it is shown as an array of primary key values (usually
`integer` type) of a child serializer.
This fixes it by introducing a new `FieldInspector` to handle the field.
It doesn't affect any other type fields.
* Fix request parameter representation in API view
In API view, representation of a parameter defined as a sub class of
`WritableNestedSerializer` should be vary between a request and a
response. For example, `tenant` field in `IPAddressSerializer` should be
shown like following as a request body:
```
tenant: integer ...
```
while it should be shown like following as a response body:
```
tenant: {
id: integer ...,
url: string ...,
name: string ...,
slug: string ...
}
```
But in both cases, it is shown as a response body type expression. This
causes an error at sending an API request with that type value.
It is only an API view issue, API can handle a request if a request
parameter is structured as an expected request body by ignoring the
wrong expression.
This fixes the issue by replacing an implicitly used default auto schema
generator class by its sub class and returning a pseudo serializer with
'Writable' prefix at generating a request body. The reason to introduce
a new generator class is that there is no other point which can
distinguish a request and a response. It is not enough to distinguish
POST, PUT, PATCH methods from GET because former cases may return a JSON
object as a response but it is also represented as same as a request
body, causes another mismatch.
This also fixes `SerializedPKRelatedField` type field representation. It
should be shown as an array of primary keys in a request body.
Fixed #2400
2018-11-28 06:14:45 +09:00
|
|
|
from rest_framework.relations import ManyRelatedField
|
2018-02-22 17:46:50 -05:00
|
|
|
|
2020-08-26 14:36:45 -04:00
|
|
|
from extras.api.customfields import CustomFieldsDataField
|
2020-10-13 15:54:23 -04:00
|
|
|
from netbox.api import ChoiceField, SerializedPKRelatedField, WritableNestedSerializer
|
2019-03-04 03:24:45 +02:00
|
|
|
|
|
|
|
|
Fix type mismatches in API view (#2429)
* Fix tags field to be shown as array in API view
`tags` field in serializers is defineded as `TagListSerializerField`.
It should be shown as an array value in API view but actually, it is a
simple string value.
This fixes it by introducing a new `FieldInspector` to handle
`TagListSerializerField` type field as an array. It doesn't affects any
other type fields.
* Fix SerializedPKRelatedField type API expression
A field definded as `SerializedPKRelatedField` should be shown as an
array of child serializer objects in a response value definition in API
view but it is shown as an array of primary key values (usually
`integer` type) of a child serializer.
This fixes it by introducing a new `FieldInspector` to handle the field.
It doesn't affect any other type fields.
* Fix request parameter representation in API view
In API view, representation of a parameter defined as a sub class of
`WritableNestedSerializer` should be vary between a request and a
response. For example, `tenant` field in `IPAddressSerializer` should be
shown like following as a request body:
```
tenant: integer ...
```
while it should be shown like following as a response body:
```
tenant: {
id: integer ...,
url: string ...,
name: string ...,
slug: string ...
}
```
But in both cases, it is shown as a response body type expression. This
causes an error at sending an API request with that type value.
It is only an API view issue, API can handle a request if a request
parameter is structured as an expected request body by ignoring the
wrong expression.
This fixes the issue by replacing an implicitly used default auto schema
generator class by its sub class and returning a pseudo serializer with
'Writable' prefix at generating a request body. The reason to introduce
a new generator class is that there is no other point which can
distinguish a request and a response. It is not enough to distinguish
POST, PUT, PATCH methods from GET because former cases may return a JSON
object as a response but it is also represented as same as a request
body, causes another mismatch.
This also fixes `SerializedPKRelatedField` type field representation. It
should be shown as an array of primary keys in a request body.
Fixed #2400
2018-11-28 06:14:45 +09:00
|
|
|
class NetBoxSwaggerAutoSchema(SwaggerAutoSchema):
|
2019-03-04 03:24:45 +02:00
|
|
|
writable_serializers = {}
|
|
|
|
|
2020-11-11 14:25:43 -05:00
|
|
|
def get_operation_id(self, operation_keys=None):
|
|
|
|
operation_keys = operation_keys or self.operation_keys
|
|
|
|
operation_id = self.overrides.get('operation_id', '')
|
|
|
|
if not operation_id:
|
|
|
|
# Overwrite the action for bulk update/bulk delete views to ensure they get an operation ID that's
|
|
|
|
# unique from their single-object counterparts (see #3436)
|
|
|
|
if operation_keys[-1] in ('delete', 'partial_update', 'update') and not self.view.detail:
|
|
|
|
operation_keys[-1] = f'bulk_{operation_keys[-1]}'
|
|
|
|
operation_id = '_'.join(operation_keys)
|
|
|
|
|
|
|
|
return operation_id
|
|
|
|
|
Fix type mismatches in API view (#2429)
* Fix tags field to be shown as array in API view
`tags` field in serializers is defineded as `TagListSerializerField`.
It should be shown as an array value in API view but actually, it is a
simple string value.
This fixes it by introducing a new `FieldInspector` to handle
`TagListSerializerField` type field as an array. It doesn't affects any
other type fields.
* Fix SerializedPKRelatedField type API expression
A field definded as `SerializedPKRelatedField` should be shown as an
array of child serializer objects in a response value definition in API
view but it is shown as an array of primary key values (usually
`integer` type) of a child serializer.
This fixes it by introducing a new `FieldInspector` to handle the field.
It doesn't affect any other type fields.
* Fix request parameter representation in API view
In API view, representation of a parameter defined as a sub class of
`WritableNestedSerializer` should be vary between a request and a
response. For example, `tenant` field in `IPAddressSerializer` should be
shown like following as a request body:
```
tenant: integer ...
```
while it should be shown like following as a response body:
```
tenant: {
id: integer ...,
url: string ...,
name: string ...,
slug: string ...
}
```
But in both cases, it is shown as a response body type expression. This
causes an error at sending an API request with that type value.
It is only an API view issue, API can handle a request if a request
parameter is structured as an expected request body by ignoring the
wrong expression.
This fixes the issue by replacing an implicitly used default auto schema
generator class by its sub class and returning a pseudo serializer with
'Writable' prefix at generating a request body. The reason to introduce
a new generator class is that there is no other point which can
distinguish a request and a response. It is not enough to distinguish
POST, PUT, PATCH methods from GET because former cases may return a JSON
object as a response but it is also represented as same as a request
body, causes another mismatch.
This also fixes `SerializedPKRelatedField` type field representation. It
should be shown as an array of primary keys in a request body.
Fixed #2400
2018-11-28 06:14:45 +09:00
|
|
|
def get_request_serializer(self):
|
|
|
|
serializer = super().get_request_serializer()
|
|
|
|
|
|
|
|
if serializer is not None and self.method in self.implicit_body_methods:
|
2021-01-26 14:03:46 -06:00
|
|
|
writable_class = self.get_writable_class(serializer)
|
|
|
|
if writable_class is not None:
|
|
|
|
if hasattr(serializer, 'child'):
|
|
|
|
child_serializer = self.get_writable_class(serializer.child)
|
|
|
|
serializer = writable_class(child=child_serializer)
|
|
|
|
else:
|
|
|
|
serializer = writable_class()
|
Fix type mismatches in API view (#2429)
* Fix tags field to be shown as array in API view
`tags` field in serializers is defineded as `TagListSerializerField`.
It should be shown as an array value in API view but actually, it is a
simple string value.
This fixes it by introducing a new `FieldInspector` to handle
`TagListSerializerField` type field as an array. It doesn't affects any
other type fields.
* Fix SerializedPKRelatedField type API expression
A field definded as `SerializedPKRelatedField` should be shown as an
array of child serializer objects in a response value definition in API
view but it is shown as an array of primary key values (usually
`integer` type) of a child serializer.
This fixes it by introducing a new `FieldInspector` to handle the field.
It doesn't affect any other type fields.
* Fix request parameter representation in API view
In API view, representation of a parameter defined as a sub class of
`WritableNestedSerializer` should be vary between a request and a
response. For example, `tenant` field in `IPAddressSerializer` should be
shown like following as a request body:
```
tenant: integer ...
```
while it should be shown like following as a response body:
```
tenant: {
id: integer ...,
url: string ...,
name: string ...,
slug: string ...
}
```
But in both cases, it is shown as a response body type expression. This
causes an error at sending an API request with that type value.
It is only an API view issue, API can handle a request if a request
parameter is structured as an expected request body by ignoring the
wrong expression.
This fixes the issue by replacing an implicitly used default auto schema
generator class by its sub class and returning a pseudo serializer with
'Writable' prefix at generating a request body. The reason to introduce
a new generator class is that there is no other point which can
distinguish a request and a response. It is not enough to distinguish
POST, PUT, PATCH methods from GET because former cases may return a JSON
object as a response but it is also represented as same as a request
body, causes another mismatch.
This also fixes `SerializedPKRelatedField` type field representation. It
should be shown as an array of primary keys in a request body.
Fixed #2400
2018-11-28 06:14:45 +09:00
|
|
|
return serializer
|
|
|
|
|
2021-01-26 14:03:46 -06:00
|
|
|
def get_writable_class(self, serializer):
|
|
|
|
properties = {}
|
|
|
|
fields = {} if hasattr(serializer, 'child') else serializer.fields
|
|
|
|
for child_name, child in fields.items():
|
|
|
|
if isinstance(child, (ChoiceField, WritableNestedSerializer)):
|
|
|
|
properties[child_name] = None
|
|
|
|
elif isinstance(child, ManyRelatedField) and isinstance(child.child_relation, SerializedPKRelatedField):
|
|
|
|
properties[child_name] = None
|
|
|
|
|
|
|
|
if properties:
|
|
|
|
if type(serializer) not in self.writable_serializers:
|
|
|
|
writable_name = 'Writable' + type(serializer).__name__
|
|
|
|
meta_class = getattr(type(serializer), 'Meta', None)
|
|
|
|
if meta_class:
|
|
|
|
ref_name = 'Writable' + get_serializer_ref_name(serializer)
|
|
|
|
writable_meta = type('Meta', (meta_class,), {'ref_name': ref_name})
|
|
|
|
properties['Meta'] = writable_meta
|
|
|
|
|
|
|
|
self.writable_serializers[type(serializer)] = type(writable_name, (type(serializer),), properties)
|
|
|
|
|
|
|
|
writable_class = self.writable_serializers[type(serializer)]
|
|
|
|
return writable_class
|
|
|
|
|
Fix type mismatches in API view (#2429)
* Fix tags field to be shown as array in API view
`tags` field in serializers is defineded as `TagListSerializerField`.
It should be shown as an array value in API view but actually, it is a
simple string value.
This fixes it by introducing a new `FieldInspector` to handle
`TagListSerializerField` type field as an array. It doesn't affects any
other type fields.
* Fix SerializedPKRelatedField type API expression
A field definded as `SerializedPKRelatedField` should be shown as an
array of child serializer objects in a response value definition in API
view but it is shown as an array of primary key values (usually
`integer` type) of a child serializer.
This fixes it by introducing a new `FieldInspector` to handle the field.
It doesn't affect any other type fields.
* Fix request parameter representation in API view
In API view, representation of a parameter defined as a sub class of
`WritableNestedSerializer` should be vary between a request and a
response. For example, `tenant` field in `IPAddressSerializer` should be
shown like following as a request body:
```
tenant: integer ...
```
while it should be shown like following as a response body:
```
tenant: {
id: integer ...,
url: string ...,
name: string ...,
slug: string ...
}
```
But in both cases, it is shown as a response body type expression. This
causes an error at sending an API request with that type value.
It is only an API view issue, API can handle a request if a request
parameter is structured as an expected request body by ignoring the
wrong expression.
This fixes the issue by replacing an implicitly used default auto schema
generator class by its sub class and returning a pseudo serializer with
'Writable' prefix at generating a request body. The reason to introduce
a new generator class is that there is no other point which can
distinguish a request and a response. It is not enough to distinguish
POST, PUT, PATCH methods from GET because former cases may return a JSON
object as a response but it is also represented as same as a request
body, causes another mismatch.
This also fixes `SerializedPKRelatedField` type field representation. It
should be shown as an array of primary keys in a request body.
Fixed #2400
2018-11-28 06:14:45 +09:00
|
|
|
|
|
|
|
class SerializedPKRelatedFieldInspector(FieldInspector):
|
|
|
|
def field_to_swagger_object(self, field, swagger_object_type, use_references, **kwargs):
|
|
|
|
SwaggerType, ChildSwaggerType = self._get_partial_types(field, swagger_object_type, use_references, **kwargs)
|
|
|
|
if isinstance(field, SerializedPKRelatedField):
|
|
|
|
return self.probe_field_inspectors(field.serializer(), ChildSwaggerType, use_references)
|
|
|
|
|
|
|
|
return NotHandled
|
|
|
|
|
|
|
|
|
2020-08-26 15:04:22 -04:00
|
|
|
class ChoiceFieldInspector(FieldInspector):
|
|
|
|
def field_to_swagger_object(self, field, swagger_object_type, use_references, **kwargs):
|
|
|
|
# this returns a callable which extracts title, description and other stuff
|
|
|
|
# https://drf-yasg.readthedocs.io/en/stable/_modules/drf_yasg/inspectors/base.html#FieldInspector._get_partial_types
|
|
|
|
SwaggerType, _ = self._get_partial_types(field, swagger_object_type, use_references, **kwargs)
|
|
|
|
|
|
|
|
if isinstance(field, ChoiceField):
|
|
|
|
choices = field._choices
|
|
|
|
choice_value = list(choices.keys())
|
|
|
|
choice_label = list(choices.values())
|
|
|
|
value_schema = openapi.Schema(type=openapi.TYPE_STRING, enum=choice_value)
|
|
|
|
|
|
|
|
if set([None] + choice_value) == {None, True, False}:
|
2020-10-05 11:32:39 -04:00
|
|
|
# DeviceType.subdevice_role and Device.face need to be differentiated since they each have
|
|
|
|
# subtly different values in their choice keys.
|
2020-08-26 15:04:22 -04:00
|
|
|
# - subdevice_role and connection_status are booleans, although subdevice_role includes None
|
|
|
|
# - face is an integer set {0, 1} which is easily confused with {False, True}
|
|
|
|
schema_type = openapi.TYPE_STRING
|
|
|
|
if all(type(x) == bool for x in [c for c in choice_value if c is not None]):
|
|
|
|
schema_type = openapi.TYPE_BOOLEAN
|
|
|
|
value_schema = openapi.Schema(type=schema_type, enum=choice_value)
|
|
|
|
value_schema['x-nullable'] = True
|
|
|
|
|
|
|
|
if all(type(x) == int for x in [c for c in choice_value if c is not None]):
|
|
|
|
# Change value_schema for IPAddressFamilyChoices, RackWidthChoices
|
|
|
|
value_schema = openapi.Schema(type=openapi.TYPE_INTEGER, enum=choice_value)
|
|
|
|
|
|
|
|
schema = SwaggerType(type=openapi.TYPE_OBJECT, required=["label", "value"], properties={
|
|
|
|
"label": openapi.Schema(type=openapi.TYPE_STRING, enum=choice_label),
|
|
|
|
"value": value_schema
|
|
|
|
})
|
|
|
|
|
|
|
|
return schema
|
|
|
|
|
|
|
|
return NotHandled
|
|
|
|
|
|
|
|
|
2018-02-22 17:46:50 -05:00
|
|
|
class NullableBooleanFieldInspector(FieldInspector):
|
|
|
|
def process_result(self, result, method_name, obj, **kwargs):
|
|
|
|
|
|
|
|
if isinstance(result, openapi.Schema) and isinstance(obj, ChoiceField) and result.type == 'boolean':
|
|
|
|
keys = obj.choices.keys()
|
|
|
|
if set(keys) == {None, True, False}:
|
|
|
|
result['x-nullable'] = True
|
|
|
|
result.type = 'boolean'
|
|
|
|
|
|
|
|
return result
|
|
|
|
|
|
|
|
|
2020-08-26 14:36:45 -04:00
|
|
|
class CustomFieldsDataFieldInspector(FieldInspector):
|
|
|
|
|
|
|
|
def field_to_swagger_object(self, field, swagger_object_type, use_references, **kwargs):
|
|
|
|
SwaggerType, ChildSwaggerType = self._get_partial_types(field, swagger_object_type, use_references, **kwargs)
|
|
|
|
|
|
|
|
if isinstance(field, CustomFieldsDataField) and swagger_object_type == openapi.Schema:
|
|
|
|
return SwaggerType(type=openapi.TYPE_OBJECT)
|
|
|
|
|
|
|
|
return NotHandled
|
|
|
|
|
|
|
|
|
2020-03-03 12:04:46 -05:00
|
|
|
class JSONFieldInspector(FieldInspector):
|
|
|
|
"""Required because by default, Swagger sees a JSONField as a string and not dict
|
|
|
|
"""
|
|
|
|
def process_result(self, result, method_name, obj, **kwargs):
|
|
|
|
if isinstance(result, openapi.Schema) and isinstance(obj, JSONField):
|
|
|
|
result.type = 'dict'
|
|
|
|
return result
|
|
|
|
|
|
|
|
|
2018-02-22 17:46:50 -05:00
|
|
|
class NullablePaginatorInspector(PaginatorInspector):
|
|
|
|
def process_result(self, result, method_name, obj, **kwargs):
|
|
|
|
if method_name == 'get_paginated_response' and isinstance(result, openapi.Schema):
|
|
|
|
next = result.properties['next']
|
|
|
|
if isinstance(next, openapi.Schema):
|
|
|
|
next['x-nullable'] = True
|
|
|
|
previous = result.properties['previous']
|
|
|
|
if isinstance(previous, openapi.Schema):
|
|
|
|
previous['x-nullable'] = True
|
|
|
|
|
|
|
|
return result
|