mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Only attempt to process session key if user is authenticated

Browse Source
This commit is contained in:
Jeremy Stretch
2017-03-22 17:43:29 -04:00
parent 007fe6a030
commit 0899a1052e
1 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
netbox/secrets/api/views.py
View File

@ -64,8 +64,10 @@ class SecretViewSet(WritableSerializerMixin, ModelViewSet):
super(SecretViewSet, self).initial(request, *args, **kwargs) super(SecretViewSet, self).initial(request, *args, **kwargs)
# Read session key from HTTP cookie or header if it has been provided. The session key must be provided in order if request.user.is_authenticated():
# to encrypt/decrypt secrets.
# Read session key from HTTP cookie or header if it has been provided. The session key must be provided in
# order to encrypt/decrypt secrets.
if 'session_key' in request.COOKIES: if 'session_key' in request.COOKIES:
session_key = base64.b64decode(request.COOKIES['session_key']) session_key = base64.b64decode(request.COOKIES['session_key'])
elif 'HTTP_X_SESSION_KEY' in request.META: elif 'HTTP_X_SESSION_KEY' in request.META:
@ -74,7 +76,6 @@ class SecretViewSet(WritableSerializerMixin, ModelViewSet):
session_key = None session_key = None
# We can't encrypt secret plaintext without a session key. # We can't encrypt secret plaintext without a session key.
# assert False, self.action
if self.action in ['create', 'update'] and session_key is None: if self.action in ['create', 'update'] and session_key is None:
raise ValidationError("A session key must be provided when creating or updating secrets.") raise ValidationError("A session key must be provided when creating or updating secrets.")