mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Fixes #1717: Fixed inteface validation for virtual machines

Browse Source
This commit is contained in:
Jeremy Stretch
2017-11-15 12:37:08 -05:00
parent 8ff10d5995
commit 0cb3e1749b
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
netbox/dcim/models.py
View File

@ -1120,6 +1120,8 @@ class ConsoleServerPort(models.Model):
def clean(self): def clean(self):
# Check that the parent device's DeviceType is a console server # Check that the parent device's DeviceType is a console server
if self.device is None:
raise ValidationError("Console server ports must be assigned to devices.")
device_type = self.device.device_type device_type = self.device.device_type
if not device_type.is_console_server: if not device_type.is_console_server:
raise ValidationError("The {} {} device type not support assignment of console server ports.".format( raise ValidationError("The {} {} device type not support assignment of console server ports.".format(
@ -1194,6 +1196,8 @@ class PowerOutlet(models.Model):
def clean(self): def clean(self):
# Check that the parent device's DeviceType is a PDU # Check that the parent device's DeviceType is a PDU
if self.device is None:
raise ValidationError("Power outlets must be assigned to devices.")
device_type = self.device.device_type device_type = self.device.device_type
if not device_type.is_pdu: if not device_type.is_pdu:
raise ValidationError("The {} {} device type not support assignment of power outlets.".format( raise ValidationError("The {} {} device type not support assignment of power outlets.".format(
@ -1257,11 +1261,12 @@ class Interface(models.Model):
def clean(self): def clean(self):
# Check that the parent device's DeviceType is a network device # Check that the parent device's DeviceType is a network device
device_type = self.device.device_type if self.device is not None:
if not device_type.is_network_device: device_type = self.device.device_type
raise ValidationError("The {} {} device type not support assignment of network interfaces.".format( if not device_type.is_network_device:
device_type.manufacturer, device_type raise ValidationError("The {} {} device type not support assignment of network interfaces.".format(
)) device_type.manufacturer, device_type
))
# An Interface must belong to a Device *or* to a VirtualMachine # An Interface must belong to a Device *or* to a VirtualMachine
if self.device and self.virtual_machine: if self.device and self.virtual_machine: