mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Optimize addition/removal of default custom field values

Browse Source
This commit is contained in:
jeremystretch
2021-08-16 14:48:56 -04:00
parent 9b0258fef4
commit 10847e2956
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
netbox/extras/models/customfields.py
View File

@ -127,9 +127,10 @@ class CustomField(BigIDModel):
""" """
for ct in content_types: for ct in content_types:
model = ct.model_class() model = ct.model_class()
for obj in model.objects.exclude(**{f'custom_field_data__contains': self.name}): instances = model.objects.exclude(**{f'custom_field_data__contains': self.name})
obj.custom_field_data[self.name] = self.default for instance in instances:
obj.save() instance.custom_field_data[self.name] = self.default
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)
def remove_stale_data(self, content_types): def remove_stale_data(self, content_types):
""" """
@ -138,9 +139,10 @@ class CustomField(BigIDModel):
""" """
for ct in content_types: for ct in content_types:
model = ct.model_class() model = ct.model_class()
for obj in model.objects.filter(**{f'custom_field_data__{self.name}__isnull': False}): instances = model.objects.filter(**{f'custom_field_data__{self.name}__isnull': False})
del(obj.custom_field_data[self.name]) for instance in instances:
obj.save() del(instance.custom_field_data[self.name])
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)
def rename_object_data(self, old_name, new_name): def rename_object_data(self, old_name, new_name):
""" """