From 15e1f62919c66f14b18a0e22a93562c0cd13ac44 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Thu, 9 Jan 2020 20:38:59 -0500 Subject: [PATCH] Renamed secrets FilterSets --- netbox/netbox/views.py | 4 ++-- netbox/secrets/api/views.py | 4 ++-- netbox/secrets/filters.py | 8 ++++---- netbox/secrets/tests/test_filters.py | 4 ++-- netbox/secrets/views.py | 6 +++--- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/netbox/netbox/views.py b/netbox/netbox/views.py index a27569950..aef3bc06b 100644 --- a/netbox/netbox/views.py +++ b/netbox/netbox/views.py @@ -25,7 +25,7 @@ from extras.models import ObjectChange, ReportResult from ipam.filters import AggregateFilterSet, IPAddressFilterSet, PrefixFilterSet, VLANFilterSet, VRFFilterSet from ipam.models import Aggregate, IPAddress, Prefix, VLAN, VRF from ipam.tables import AggregateTable, IPAddressTable, PrefixTable, VLANTable, VRFTable -from secrets.filters import SecretFilter +from secrets.filters import SecretFilterSet from secrets.models import Secret from secrets.tables import SecretTable from tenancy.filters import TenantFilter @@ -179,7 +179,7 @@ SEARCH_TYPES = OrderedDict(( ('secret', { 'permission': 'secrets.view_secret', 'queryset': Secret.objects.prefetch_related('role', 'device'), - 'filter': SecretFilter, + 'filter': SecretFilterSet, 'table': SecretTable, 'url': 'secrets:secret_list', }), diff --git a/netbox/secrets/api/views.py b/netbox/secrets/api/views.py index ee2b87a1f..873679775 100644 --- a/netbox/secrets/api/views.py +++ b/netbox/secrets/api/views.py @@ -38,7 +38,7 @@ class SecretRoleViewSet(ModelViewSet): ) serializer_class = serializers.SecretRoleSerializer permission_classes = [IsAuthenticated] - filterset_class = filters.SecretRoleFilter + filterset_class = filters.SecretRoleFilterSet # @@ -50,7 +50,7 @@ class SecretViewSet(ModelViewSet): 'device__primary_ip4', 'device__primary_ip6', 'role', 'role__users', 'role__groups', 'tags', ) serializer_class = serializers.SecretSerializer - filterset_class = filters.SecretFilter + filterset_class = filters.SecretFilterSet master_key = None diff --git a/netbox/secrets/filters.py b/netbox/secrets/filters.py index 2998b9c18..0c2b01f4d 100644 --- a/netbox/secrets/filters.py +++ b/netbox/secrets/filters.py @@ -8,19 +8,19 @@ from .models import Secret, SecretRole __all__ = ( - 'SecretFilter', - 'SecretRoleFilter', + 'SecretFilterSet', + 'SecretRoleFilterSet', ) -class SecretRoleFilter(NameSlugSearchFilterSet): +class SecretRoleFilterSet(NameSlugSearchFilterSet): class Meta: model = SecretRole fields = ['id', 'name', 'slug'] -class SecretFilter(CustomFieldFilterSet, CreatedUpdatedFilterSet): +class SecretFilterSet(CustomFieldFilterSet, CreatedUpdatedFilterSet): id__in = NumericInFilter( field_name='id', lookup_expr='in' diff --git a/netbox/secrets/tests/test_filters.py b/netbox/secrets/tests/test_filters.py index c378147ff..16ac3ff45 100644 --- a/netbox/secrets/tests/test_filters.py +++ b/netbox/secrets/tests/test_filters.py @@ -7,7 +7,7 @@ from secrets.models import Secret, SecretRole class SecretRoleTestCase(TestCase): queryset = SecretRole.objects.all() - filterset = SecretRoleFilter + filterset = SecretRoleFilterSet @classmethod def setUpTestData(cls): @@ -35,7 +35,7 @@ class SecretRoleTestCase(TestCase): class SecretTestCase(TestCase): queryset = Secret.objects.all() - filterset = SecretFilter + filterset = SecretFilterSet @classmethod def setUpTestData(cls): diff --git a/netbox/secrets/views.py b/netbox/secrets/views.py index 001a09696..e3267f647 100644 --- a/netbox/secrets/views.py +++ b/netbox/secrets/views.py @@ -70,7 +70,7 @@ class SecretRoleBulkDeleteView(PermissionRequiredMixin, BulkDeleteView): class SecretListView(PermissionRequiredMixin, ObjectListView): permission_required = 'secrets.view_secret' queryset = Secret.objects.prefetch_related('role', 'device') - filter = filters.SecretFilter + filter = filters.SecretFilterSet filter_form = forms.SecretFilterForm table = tables.SecretTable template_name = 'secrets/secret_list.html' @@ -248,7 +248,7 @@ class SecretBulkImportView(BulkImportView): class SecretBulkEditView(PermissionRequiredMixin, BulkEditView): permission_required = 'secrets.change_secret' queryset = Secret.objects.prefetch_related('role', 'device') - filter = filters.SecretFilter + filter = filters.SecretFilterSet table = tables.SecretTable form = forms.SecretBulkEditForm default_return_url = 'secrets:secret_list' @@ -257,6 +257,6 @@ class SecretBulkEditView(PermissionRequiredMixin, BulkEditView): class SecretBulkDeleteView(PermissionRequiredMixin, BulkDeleteView): permission_required = 'secrets.delete_secret' queryset = Secret.objects.prefetch_related('role', 'device') - filter = filters.SecretFilter + filter = filters.SecretFilterSet table = tables.SecretTable default_return_url = 'secrets:secret_list'