mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

#10170 changes from code review

Browse Source
This commit is contained in:
Arthur
2022-08-29 12:20:51 -07:00
parent 23fafe1996
commit 249b8b0363
3 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
netbox/extras/tables/tables.py
View File

@ -183,6 +183,7 @@ class ObjectChangeTable(NetBoxTable):
verbose_name='Username'
)
full_name = tables.TemplateColumn(
accessor=tables.A('user'),
template_code=OBJECTCHANGE_FULL_NAME,
verbose_name='Full Name',
orderable=False
@ -192,6 +193,7 @@ class ObjectChangeTable(NetBoxTable):
verbose_name='Type'
)
object_repr = tables.TemplateColumn(
accessor=tables.A('object_repr'),
template_code=OBJECTCHANGE_OBJECT,
verbose_name='Object'
)

4
netbox/extras/tables/template_code.py
View File

@ -13,8 +13,8 @@ OBJECTCHANGE_FULL_NAME = """
"""
OBJECTCHANGE_OBJECT = """
{% if record.changed_object and record.changed_object.get_absolute_url %}
<a href="{{ record.changed_object.get_absolute_url }}">{{ record.object_repr }}</a>
{% if value.changed_object and value.changed_object.get_absolute_url %}
<a href="{{ value.changed_object.get_absolute_url }}">{{ record.object_repr }}</a>
{% else %}
{{ record.object_repr }}
{% endif %}

2
netbox/extras/views.py
View File

@ -361,7 +361,7 @@ class ObjectConfigContextView(generic.ObjectView):
#
class ObjectChangeListView(generic.ObjectListView):
queryset = ObjectChange.objects.all().select_related("user").prefetch_related("changed_object")
queryset = ObjectChange.objects.all()
filterset = filtersets.ObjectChangeFilterSet
filterset_form = forms.ObjectChangeFilterForm
table = tables.ObjectChangeTable